[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan marked an inline comment as done. skan added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249558. shiva0217 added a comment. Update patch to address @jrtc27's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLineRefe

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \ + __d = 1;

[clang] 37fa9d6 - [CodeGen][ObjC] Don't extend lifetime of ObjC pointers passed to calls

Author: Akira Hatanaka Date: 2020-03-10T22:10:32-07:00 New Revision: 37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5 URL: https://github.com/llvm/llvm-project/commit/37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5 DIFF: https://github.com/llvm/llvm-project/commit/37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5.diff

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan updated this revision to Diff 249550. skan marked an inline comment as done. skan added a comment. Make the variale name in macro start with 2 underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:456 + __extension__({ \ +long long c = (long long)(b); \ +unsigned char d;

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:417 +#define _BitScanForward(a, b) \ + __extension__({ \ +int c = (int)(b);

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

jrtc27 added a comment. I believe my previous comments have indeed been addressed. Comment at: clang/docs/ClangCommandLineReference.rst:2958 + +Put global and static data smaller than the limitation into a special section (RISCV only) + lenary wrote: > "(RISC-

[PATCH] D75971: Should not need the second predicate.If `II->hasMacroDefinition()` is true, then the whole expr is always true.

oontvoo created this revision. oontvoo added a reviewer: jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. remove redundant pred Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75971 Files: clang/include/clang/Lex/Preprocessor.h Index: clang/i

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75896 ___

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:417 +#define _BitScanForward(a, b) \ + __extension__({ \ +int c = (int)(b);

[PATCH] D75894: [X86] Support intrinsics _bextr2*

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894 ___

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:456 + __extension__({ \ +long long c = (long long)(b); \ +unsigned char d;

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

skan updated this revision to Diff 249548. skan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75896 Files: clang/lib/Headers/cldemoteintrin.h clang/test/CodeGen/cldemote.c Index:

[PATCH] D75894: [X86] Support intrinsics _bextr2*

skan updated this revision to Diff 249547. skan added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894 Files: clang/lib/Headers/bmiintrin.h clang/test/CodeGen/bmi-builti

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan updated this revision to Diff 249546. skan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723 Files: clang/lib/Headers/ia32intrin.h clang/test/CodeGen/bitscan-

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249545. shiva0217 added a comment. Update patch to address @evandro's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLineRe

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. The commit summary needs improvement. The syntax is not really necessary there, but instead this needs a better explanation of how this builtin fits in with the overall scheme of language-specific and target-specific details of an atomic operation. For example, is this

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249544. PaulkaToast added a comment. Addressed @Eugene.Zelenko comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMake

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @njames93 @MaskRay Thanks for helping me with testing. I'll remember this for next time. I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in some other checks (`RedundantExpressionCheck` and `Static

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c70dec18c7e: [libunwind] Remove __FILE__ and __LINE__ from error reporting (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/ne

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp updated this revision to Diff 249538. tetsuo-cpp added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75901/new/ https://reviews.llvm.org/D75901 Files: clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp clang-tools

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Finds includes of sytem libc headers in llvm-libc implementation. + Please synchronize with first statement in documentation. Repository: rG LLVM Github Monorep

[libunwind] 1c70dec - [libunwind] Remove __FILE__ and __LINE__ from error reporting

Author: Leonard Chan Date: 2020-03-10T18:58:41-07:00 New Revision: 1c70dec18c7e530264cc70841cc60f385259b9e0 URL: https://github.com/llvm/llvm-project/commit/1c70dec18c7e530264cc70841cc60f385259b9e0 DIFF: https://github.com/llvm/llvm-project/commit/1c70dec18c7e530264cc70841cc60f385259b9e0.diff

[PATCH] D75969: [clangd] Link libClangDaemonTweaks to libClangFormat

hubert.reinterpretcast added a comment. Thanks for the prompt response. It seems our fix attempts happened "concurrently" and we ended up with pretty much the same fix. I had committed rG48121a5743b684def33d158391c5424626de28e2

[PATCH] D75969: [clangd] Link libClangDaemonTweaks to libClangFormat

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG48121a5743b6 (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D75969: [clangd] Link libClangDaemonTweaks to libClangFormat

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. hubert.reinterpretcast added a comment. Thanks for the prompt response. It seems our fix attempts happened "concurrently" an

[PATCH] D75716: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

hubert.reinterpretcast added a comment. In D75716#1916032 , @hubert.reinterpretcast wrote: > It looks like this is causing bot failures > (http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1881/steps/build%20stage%201/logs/stdio): Fix attempt

[PATCH] D75716: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

nridge added a comment. In D75716#1916032 , @hubert.reinterpretcast wrote: > It looks like this is causing bot failures > (http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1881/steps/build%20stage%201/logs/stdio): Sorry about that. Fix here:

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:66-67 +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + SmallString<128> CompilerIncudeDir = + StringRef(PP->getHeader

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249530. PaulkaToast marked 4 inline comments as done. PaulkaToast added a comment. Addressed @aaron.ballman comments (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D753

[clang-tools-extra] 48121a5 - [cmake] Link libclangDaemonTweaks with clangFormat

Author: Hubert Tong Date: 2020-03-10T21:31:10-04:00 New Revision: 48121a5743b684def33d158391c5424626de28e2 URL: https://github.com/llvm/llvm-project/commit/48121a5743b684def33d158391c5424626de28e2 DIFF: https://github.com/llvm/llvm-project/commit/48121a5743b684def33d158391c5424626de28e2.diff L

[PATCH] D75716: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

hubert.reinterpretcast added a comment. It looks like this is causing bot failures (http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1881/steps/build%20stage%201/logs/stdio): : && /home/buildbots/clang.9.0.0/bin/clang++ --gcc-toolchain=/opt/rh/devtoolset-7/root/usr -fPIC -fPIC -fv

Re: [clang] d052a57 - [c++2a] Allow comparison functions to be explicitly defaulted.

On Tue, Mar 10, 2020 at 7:35 PM Richard Smith wrote: > Should be fixed in llvmorg-11-init-5426-g4cba668ac13. > Thanks. We're also seeing a failure on valid code where a template class explicitly deletes a function that is an override of an explicitly deleted virtual function in a (non-templated)

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:418 + __extension__({ \ +*(a) = (unsigned)__bsfd((int)(b)); \ +(unsigned char)((b) != 0);

[PATCH] D75911: [clang-tidy] Added hasAnyListedName matcher

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.cpp:17 + +Matcher hasAnyListedName(std::vector Names) { + return Matcher(new HasNameMatcher(std::move(Names))); gribozavr2 wrote: >

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

rnk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay abandoned this revision. MaskRay added a comment. Thanks for review! However, I am abandoning this change because rL364160 deleted these traits. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45805/new/ https://revie

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75171/new/ https://reviews.llvm.org/D75171 ___ cfe-commits mailing list cfe-com

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. In D75784#1910688 , @aprantl wrote: > This will no doubt also need some patches to the Swift compiler, but given > the NFC-ness this hopefully should be fine. True. I could leave behind a typedef for the ASTSourceDescriptor if it ma

[clang-tools-extra] 54928ba - [clang-tidy] Use more widely available headers for protability-restrict-system-includes-check's test

Author: Paula Toth Date: 2020-03-10T16:54:11-07:00 New Revision: 54928ba0ec8355edbbdb31c7b01bb45eb2d384b6 URL: https://github.com/llvm/llvm-project/commit/54928ba0ec8355edbbdb31c7b01bb45eb2d384b6 DIFF: https://github.com/llvm/llvm-project/commit/54928ba0ec8355edbbdb31c7b01bb45eb2d384b6.diff LO

Re: [clang] d052a57 - [c++2a] Allow comparison functions to be explicitly defaulted.

Should be fixed in llvmorg-11-init-5426-g4cba668ac13. On Sat, 7 Mar 2020 at 08:05, Hubert Tong via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Following this commit, the error recovery for invalid cases that > explicitly define (out-of-line) a member function template as deleted and > atte

[clang] 4cba668 - Fix crash-on-invalid when trying to recover from a function template

Author: Richard Smith Date: 2020-03-10T16:34:27-07:00 New Revision: 4cba668ac13433ce295ee101a920365fba6f20de URL: https://github.com/llvm/llvm-project/commit/4cba668ac13433ce295ee101a920365fba6f20de DIFF: https://github.com/llvm/llvm-project/commit/4cba668ac13433ce295ee101a920365fba6f20de.diff

[PATCH] D75922: [ASTImporter] Compare the DC of the underlying type of a FriendDecl

shafik added a subscriber: rsmith. shafik added a comment. I believe that your main example violates basic.scope.class p2 : > A name N used in a class S shall refer to the same declaration in its context > and when re-evaluated in the completed scope

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added subscribers: libcxx-commits, dexonsmith. LGTM, but you'll need to rebase this Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45805/new/ https:

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge added a comment. I've started to update the patch to be in line with the direction discussed in the issue. @sammccall, how would you like to proceed logistically: - Do you plan to land (a possibly modified version of) D75479 ? - Or should I combine that

[clang] 218dd33 - Add triple for non-x86 environments.

Author: Bill Wendling Date: 2020-03-10T15:26:03-07:00 New Revision: 218dd339541f574f76d7310f6c3269bfe3262d08 URL: https://github.com/llvm/llvm-project/commit/218dd339541f574f76d7310f6c3269bfe3262d08 DIFF: https://github.com/llvm/llvm-project/commit/218dd339541f574f76d7310f6c3269bfe3262d08.diff

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. You've sold me on `AnyError`, we should have something like that with the addition of `NoteTags`. With that said, I feel uneasy about adding it in this patch and not testing it properly. I can also sympathize with your anxiety against bloating the `fseek` patch furthe

RE: [clang-tools-extra] ebdb98f - [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Hi Paula, The tests in this commit are failing on the PS4 Windows bot and our internal CI. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast Thanks, Matthew > -Original Message- > From: cfe-commits On Behalf Of Paula > Toth via c

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). Yes, bu

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI)

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:2295 Group, Flags<[CoreOption]>; +def mlvi_cfi : Flag<["-"], "mlvi-cfi">, Group, Flags<[CoreOption,DriverOption]>; +def mno_lvi_cfi : Flag<["-"], "mno-lvi-cfi">, Group, Flags<[CoreOption,Dr

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). > >

[clang] 5c845c1 - PR45083: Mark statement expressions as being dependent if they appear in

Author: Richard Smith Date: 2020-03-10T14:45:04-07:00 New Revision: 5c845c1c50ac89a6f12557d1571678f3d1432478 URL: https://github.com/llvm/llvm-project/commit/5c845c1c50ac89a6f12557d1571678f3d1432478 DIFF: https://github.com/llvm/llvm-project/commit/5c845c1c50ac89a6f12557d1571678f3d1432478.diff

[clang] 75af694 - [CodeGenObjC] Place property names in __objc_methname

Author: Erik Pilkington Date: 2020-03-10T14:31:00-07:00 New Revision: 75af694a6da5157cc6a688c2fa77ff5200f46e11 URL: https://github.com/llvm/llvm-project/commit/75af694a6da5157cc6a688c2fa77ff5200f46e11 DIFF: https://github.com/llvm/llvm-project/commit/75af694a6da5157cc6a688c2fa77ff5200f46e11.dif

[clang] 9769e1e - [Concepts] Fix incorrect DeclContext for transformed RequiresExprBodyDecl

Author: Saar Raz Date: 2020-03-10T23:17:00+02:00 New Revision: 9769e1ee9acc33638449b50ac394b5ee2d4efb60 URL: https://github.com/llvm/llvm-project/commit/9769e1ee9acc33638449b50ac394b5ee2d4efb60 DIFF: https://github.com/llvm/llvm-project/commit/9769e1ee9acc33638449b50ac394b5ee2d4efb60.diff LOG:

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rG40568fec7e3e: [CodeGen] Emit destructor calls to destruct compound literals (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D64464?vs

[PATCH] D75959: [clangd] Run clang-format on CodeComplete.cpp and SourceCodeTests.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG484402abaca2: [clangd] Run clang-format on CodeComplete.cpp and SourceCodeTests.cpp (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75959

[PATCH] D71314: Warn of uninitialized variables on asm goto's indirect branch

This revision was automatically updated to reflect the committed changes. Closed by commit rG72aa619a7fe0: Warn of uninitialized variables on asm goto's indirect branch (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ htt

[PATCH] D75716: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

This revision was automatically updated to reflect the committed changes. Closed by commit rG445195ba6cee: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75716: [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

nridge updated this revision to Diff 249495. nridge marked 6 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75716/new/ https://reviews.llvm.org/D75716 Files: clang-tools-ext

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked 3 inline comments as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:17 + "expected 'volatile', 'inline', 'goto', or '('">, CatInlineAsm; +def err_global_asm_qualifier_ignored : Error< + "meaningless '%0' on asm outside function">, CatInlineAsm; --

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

aaron.ballman added a comment. LGTM with the changes for #import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D75959: [clangd] Run clang-format on CodeComplete.cpp and SourceCodeTests.cpp

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. I assume I can self-approve t

[PATCH] D75959: [clangd] Run clang-format on CodeComplete.cpp and SourceCodeTests.cpp

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. I assume I can self-approve this kind of change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75959/new/ https://reviews.llvm.org/D75959 ___

[clang] 40568fe - [CodeGen] Emit destructor calls to destruct compound literals

Author: Akira Hatanaka Date: 2020-03-10T14:08:28-07:00 New Revision: 40568fec7e3eb51554cbdaf63a8044830be93fa4 URL: https://github.com/llvm/llvm-project/commit/40568fec7e3eb51554cbdaf63a8044830be93fa4 DIFF: https://github.com/llvm/llvm-project/commit/40568fec7e3eb51554cbdaf63a8044830be93fa4.diff

[clang-tools-extra] ddfcda0 - [clang-tidy] Fix warning from my previous patch in ReleaseNotes.txt

Author: Paula Toth Date: 2020-03-10T14:01:23-07:00 New Revision: ddfcda0256ca231499614742cce1b66db056dc2a URL: https://github.com/llvm/llvm-project/commit/ddfcda0256ca231499614742cce1b66db056dc2a DIFF: https://github.com/llvm/llvm-project/commit/ddfcda0256ca231499614742cce1b66db056dc2a.diff LO

[clang] 72aa619 - Warn of uninitialized variables on asm goto's indirect branch

Author: Bill Wendling Date: 2020-03-10T13:48:48-07:00 New Revision: 72aa619a7fe0e2f90959b0614f6388c09aba8913 URL: https://github.com/llvm/llvm-project/commit/72aa619a7fe0e2f90959b0614f6388c09aba8913 DIFF: https://github.com/llvm/llvm-project/commit/72aa619a7fe0e2f90959b0614f6388c09aba8913.diff

[clang-tools-extra] 445195b - [clangd] Have visibleNamespaces() and getEligiblePoints() take a LangOptions rather than a FormatStyle

Author: Nathan Ridge Date: 2020-03-10T16:45:41-04:00 New Revision: 445195ba6cee029852193e3f2a12cf9356fac308 URL: https://github.com/llvm/llvm-project/commit/445195ba6cee029852193e3f2a12cf9356fac308 DIFF: https://github.com/llvm/llvm-project/commit/445195ba6cee029852193e3f2a12cf9356fac308.diff

[clang-tools-extra] 484402a - [clangd] Run clang-format on CodeComplete.cpp and SourceCodeTests.cpp

Author: Nathan Ridge Date: 2020-03-10T16:45:14-04:00 New Revision: 484402abaca2b2523487b564c7d5173404b448af URL: https://github.com/llvm/llvm-project/commit/484402abaca2b2523487b564c7d5173404b448af DIFF: https://github.com/llvm/llvm-project/commit/484402abaca2b2523487b564c7d5173404b448af.diff

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

This revision was automatically updated to reflect the committed changes. PaulkaToast marked an inline comment as done. Closed by commit rGebdb98f254f6: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for… (authored by PaulkaToast). Changed prior to commit: https://rev

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast marked 2 inline comments as done. PaulkaToast added a comment. Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/Attr.td:362 +def TargetAArch64 : TargetArch<["aarch64"]>; +def TargetARM_AArch64 : TargetArch; def TargetAVR : TargetArch<["avr"]>; nit: don't thin we use underscores in names, and looking

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:55-71 + if (const auto *Reference = + Result.Nodes.getNodeAs("reference_to_non-const")) { +diag(Reference->getLocation(), +

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:52 +if (!SM.isInMainFile(HashLoc)) { + DiagnosticBuilder D = Check.diag( + HashLoc, No need for the local DiagnosticBuilde

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -c

[clang-tools-extra] ebdb98f - [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Author: Paula Toth Date: 2020-03-10T13:33:06-07:00 New Revision: ebdb98f254f632b506109b9d20c6e8e19697765f URL: https://github.com/llvm/llvm-project/commit/ebdb98f254f632b506109b9d20c6e8e19697765f DIFF: https://github.com/llvm/llvm-project/commit/ebdb98f254f632b506109b9d20c6e8e19697765f.diff LO

[clang] 7fb562c - [Concepts] Add constraints checks to isSameEntity

Author: Saar Raz Date: 2020-03-10T22:05:36+02:00 New Revision: 7fb562c1ab373a3d4e14003e40556791ec032bab URL: https://github.com/llvm/llvm-project/commit/7fb562c1ab373a3d4e14003e40556791ec032bab DIFF: https://github.com/llvm/llvm-project/commit/7fb562c1ab373a3d4e14003e40556791ec032bab.diff LOG:

[clang] f9e6389 - [Concepts] Add FoundDecl to ConceptSpecializationExpr serialization

Author: Saar Raz Date: 2020-03-10T22:04:11+02:00 New Revision: f9e63891597630405a4655298f06b193e4ceb384 URL: https://github.com/llvm/llvm-project/commit/f9e63891597630405a4655298f06b193e4ceb384 DIFF: https://github.com/llvm/llvm-project/commit/f9e63891597630405a4655298f06b193e4ceb384.diff LOG:

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

nickdesaulniers added a comment. In D75850#1915198 , @miyuki wrote: > Should compile without warnings now. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D7

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

saugustine accepted this revision. saugustine added a comment. This looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 ___ cfe-commits mailing li

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

thakis added a comment. `__FILE__` only expands to an absolute path if you pass an absolute path to clang (ctrl-f "__FILE__" on http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). It feels like this is working around a deficiency in the compiler. Maybe fixing whatever's

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

evandro added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2958 + +Put global and static data smaller than the limitation into a special section (RISC-V only) + ``` s/arg/limit/ s/limitation/limit/ ``` Comment at: clan

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you might want to wait a few more hours for other reviewers to see if anyone has objections. Comment at: libunwind/src/config.h:125 do {

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. In D72635#1912501 , @aaron.ballman wrote: > In D72635#1911844 , @aaronpuchert > wrote: > > > In D72635#1911671 , @aaron.ballman > > wrote: >

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan updated this revision to Diff 249468. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 Files: libunwind/src/config.h Index: libunwind/src/config.h ==

[PATCH] D75951: draft

oontvoo created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. oontvoo retitled this revision from "Make a distinction between import and pragma-once, and keep tracked of already-included pragma-once files." to "draft ". oontvoo edited the summary of this re

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

Szelethus added a comment. In D75851#1915014 , @Szelethus wrote: > In D75851#1914874 , @balazske wrote: > > > After a failed file operation we do not know if it was feof or ferror kind > > of error. > > > Is this t

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1915311 , @jeroen.dobbelaere wrote: > In D74935#1909909 , @jdoerfert wrote: > > > I would say that once we get modeling for indirect restrict we can adapt > > the lang ref acco

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal marked an inline comment as done. vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:55-71 + if (const auto *Reference = + Result.Nodes.getNodeAs("reference_to_non-const")) { +

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jeroen.dobbelaere added a comment. In D74935#1909909 , @jdoerfert wrote: > I would say that once we get modeling for indirect restrict we can adapt the > lang ref accordingly. For now there is only have outer level restrict/noalias. Why not try to get r

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:34 +// Matches Objective-C methods that are not overriding a superclass method. +AST_MATCHER(ObjCMethodDecl, isNotOverriding) { return !Node.isOverriding(); } + --

[clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Author: Aaron Ballman Date: 2020-03-10T14:22:21-04:00 New Revision: 4a0267e3ad8c4d47f267d7d960f127e099fb4818 URL: https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818 DIFF: https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818.diff

[clang] 9624beb - [docs] Regenerate ClangCommandLineReference.rst

Author: Craig Topper Date: 2020-03-10T11:10:18-07:00 New Revision: 9624beb38a46037f69362650a52e06d8be4fd006 URL: https://github.com/llvm/llvm-project/commit/9624beb38a46037f69362650a52e06d8be4fd006 DIFF: https://github.com/llvm/llvm-project/commit/9624beb38a46037f69362650a52e06d8be4fd006.diff

[clang] 57a2eaf - Revert "[modules] Do not cache invalid state for modules that we attempted to load."

Author: Rumeet Dhindsa Date: 2020-03-10T10:59:26-07:00 New Revision: 57a2eaf3c1aa1a08e9b474b873064e075c52daef URL: https://github.com/llvm/llvm-project/commit/57a2eaf3c1aa1a08e9b474b873064e075c52daef DIFF: https://github.com/llvm/llvm-project/commit/57a2eaf3c1aa1a08e9b474b873064e075c52daef.diff

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

craig.topper added inline comments. Comment at: clang/lib/Headers/cldemoteintrin.h:27 +/// +/// This intrinsic corresponds to the CLDRMOTE instruction. static __inline__ void __DEFAULT_FN_ATTRS CLDRMOTE->CLDEMOTE Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D75897: [X86] Support intrinsic _mm_broadcastsi128_si256

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75897/new/ https://reviews.llvm.org/D75897 ___

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

This revision was automatically updated to reflect the committed changes. Closed by commit rG66945b62f42f: Add Optional overload to DiagnosticBuilder operator << (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75714/new/ https:

[PATCH] D75927: [clangd] Use a separate RunningTask flag instead of leaving a broken request on top of the queue

This revision was automatically updated to reflect the committed changes. Closed by commit rG39eebe68b599: [clangd] Use a separate RunningTask flag instead of leaving a broken request on… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

njames93 added a comment. If you need help for the test case. Create a file in the `clang-tools-extra/test/clang-tidy/checkers`. Name it something like `misc-unconventional-assign-operator-pre11.cpp` and paste this in // RUN: %check_clang_tidy -std=c++98,c++03 %s misc-unconventional-assign-

  1   2   3   >