aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM!
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -checks glob list for running clang-tidy itself, ---------------- This is not something you have to fix (and certainly not as part of this patch), but is a note of a bug... we typically use semicolon-delimited lists, and I think that may be especially important here as comma can be a valid character in a file name on many file systems. I notice that we're using `GlobList` which still seems to use comma-separated values. We may want to consider allowing both semi-colon and commas in `GlobList` and then updating the docs to suggest semicolons instead of commas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75786/new/ https://reviews.llvm.org/D75786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
