[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert updated this revision to Diff 245795. jdoerfert added a comment. Remove leftover word Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935 Files: llvm/docs/LangRef.rst Index: llvm/docs/LangRef.rst

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1738 +// ++-+--

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked 7 inline comments as done. zoecarver added a comment. To address the question, what will this be used for: this could be used for several things in the library and compiler, but the primary use will be to create a builtin that can be used to implement P0154

[libclc] efeafa1 - libclc: Use acos implementation from amd_builtins

Author: Jan Vesely Date: 2020-02-20T23:36:14-05:00 New Revision: efeafa1bdaa715733fc100bcd9d21f93c7272368 URL: https://github.com/llvm/llvm-project/commit/efeafa1bdaa715733fc100bcd9d21f93c7272368 DIFF: https://github.com/llvm/llvm-project/commit/efeafa1bdaa715733fc100bcd9d21f93c7272368.diff LO

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

aqjune added a comment. Never mind, I see that the keyword object comes from the alias analysis document. The alias analysis document is using the term object consistently. I was confused because the term is used at llvm.objectsize intrinsic's LangRef documentation, which seems to refer an alloc

[clang] 4b540fa - [OpenMP][NFC] Remove leftover debug messages

Author: Johannes Doerfert Date: 2020-02-20T20:28:42-06:00 New Revision: 4b540fa8a1c1077468cf8eb7c32fd2481cdbc520 URL: https://github.com/llvm/llvm-project/commit/4b540fa8a1c1077468cf8eb7c32fd2481cdbc520 DIFF: https://github.com/llvm/llvm-project/commit/4b540fa8a1c1077468cf8eb7c32fd2481cdbc520.d

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Don't know how I missed that API... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74939/new/ https://reviews.llvm.org/D7

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added subscribers: llvm-commits, guansong, bollu, jholewinski. Herald added projects: clang, LLVM. This is the first pa

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert updated this revision to Diff 245774. jdoerfert added a comment. Tried to simplify the wording by making it two sentences. @efriedma's wording is another option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.ll

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

vsapsai created this revision. vsapsai added reviewers: dexonsmith, bruno, Bigcheese. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Follow-up to 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d , rename th

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

aqjune added a comment. Hi, The term 'object' seems ambiguous to me. For example, void f(i32* noalias x, i32* noalias y) { *x = 1; *y = 2; } int x[2]; f(&x[0], &x[1]); If object means an allocation, this should be UB, because x and y are pointing to the same object. Memory lo

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1885514 , @scott.linder wrote: > Multiple build bots were failing with the patch applied, see e.g. > http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4890/steps/test-check-clang/logs/FAIL%3A%20C

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

efriedma added a comment. I'm not sure I like the wording; it's a complicated sentence to understand. Can we make it sort of list-like? "for each memory location accessed through a noalias pointer, either: 1. the location is not modified during the execution of the function. 2. all accesses t

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + I think Lakemont is 16 bytes. Assuming I'm interpretting the CLFLUSH line size from this CPUID dump correctly https://github.co

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1738 +// ++-+--

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk accepted this revision. rnk added a comment. Sounds like a plan, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, nlopes, regehr, efriedma. Herald added a subscriber: bollu. Herald added a reviewer: sstefan1. Herald added a reviewer: uenoku. Herald added a project: LLVM. We already mention that `noalias` is modeled after the C99 `restrict` q

[libunwind] d4ded05 - [libunwind][CMake] Treat S files as C to work around CMake bug.

Author: Michael Spencer Date: 2020-02-20T15:26:09-08:00 New Revision: d4ded05ba851304b26a437896bc3962ef56f62cb URL: https://github.com/llvm/llvm-project/commit/d4ded05ba851304b26a437896bc3962ef56f62cb DIFF: https://github.com/llvm/llvm-project/commit/d4ded05ba851304b26a437896bc3962ef56f62cb.dif

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 245756. vsk added a comment. This revision is now accepted and ready to land. Get rid of multiple inheritance in the coverage::accessors namespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files: clang/

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}

MaskRay updated this revision to Diff 245755. MaskRay added a comment. Fix a file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74934/new/ https://reviews.llvm.org/D74934 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Allocate

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}

MaskRay created this revision. MaskRay added reviewers: jfb, gribozavr, nand, RKSimon. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. The Blocks runtime provide a header named Block.h. It is generally preferable to avoid name collision

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder added a comment. Multiple build bots were failing with the patch applied, see e.g. http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4890/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Aclang_f_opts.c Seems like on platforms with a backslash for a directory separato

[clang] 577d9ce - Revert "[Driver] Escape the program path for -frecord-command-line"

Author: Scott Linder Date: 2020-02-20T17:36:56-05:00 New Revision: 577d9ce35532439203411c999deefc9c80e04c69 URL: https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69 DIFF: https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69.diff

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk planned changes to this revision. vsk added a comment. @rnk Thanks for chasing this down. I'll update the function record structs to use free functions instead of multiple inheritance. I don't plan on getting rid of the awkward method calls at this point. The coverage reader is still templa

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245747. hliao added a comment. Revise following reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Pa

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. In D69471#1884043 , @dexonsmith wrote: > In D69471#1883912 , @rnk wrote: > > > Everything is off-by-one because the empty bases are not zero sized. The > > MSVC record layout algorithm is just

RE: [PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

No need to revert, I can wait. Thanks! De : Teresa Johnson Envoyé : February 20, 2020 5:07 PM À : reviews+d73242+public+5822844df8563...@reviews.llvm.org Cc : Peter Collingbourne ; Evgeny Leviant ; Alexandre Ganea ; joker@gmail.com; piotr.padlew...@gmail.com; hiradi...@msn.com; steve...@ap

Re: [PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

I'm currently traveling but will take a look tomorrow. If necessary go ahead and revert, I will not be able to do so myself until tomorrow. Teresa On Tue, Feb 18, 2020, 8:48 PM Alexandre Ganea via Phabricator < revi...@reviews.llvm.org> wrote: > aganea added a comment. > > There seems to be still

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added a comment. Herald added subscribers: martong, steakhal. Hmm, has this patch not landed yet? I was so excited to finally have https://bugs.llvm.org/show_bug.cgi?id=28450 fixed :) Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:767 + DefinedOrUnknownSV

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

jfb added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1193 + // the given cpu and returns `0` if the CPU is not found. + virtual unsigned getCPUCacheLineSize() const { return 0; } + Return an optional instead of using zero to mean "unkno

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245735. hliao marked an inline comment as done. hliao added a comment. Rebase the code to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

jkorous added a comment. @vsapsai Sorry! I read your comment only after landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74746/new/ https://reviews.llvm.org/D74746 ___ cfe-commits mailing li

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11444 + return nullptr; +const Decl *ContextDecl = dyn_cast(CurContext); +if (!ContextDecl) You really want this to match whenever we're in a local context, right? How abou

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

jyknight added a comment. As I've mentioned before, depending on what this will be used for, "64" is not a _useful_ answer if you want to know how your memory accesses will behave on modern intel x86 CPUs, despite being the "correct" answer for cache-line size. But, modern intel CPUs fetch alig

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

This revision was automatically updated to reflect the committed changes. Closed by commit rG6123074d0c0d: [Driver] Escape the program path for -frecord-command-line (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/

[clang] 6123074 - [Driver] Escape the program path for -frecord-command-line

Author: Scott Linder Date: 2020-02-20T16:31:17-05:00 New Revision: 6123074d0c0de3614f1552f2f2d6b9db7b32cebe URL: https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe DIFF: https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe.diff

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

efriedma added a comment. Where are you planning to use this? Comment at: clang/lib/Sema/SemaStmt.cpp:2817 + + unsigned targetCacheLineSize = Ctx.getTargetInfo().getCPUCacheLineSize(); + if (!targetCacheLineSize) "64" here is arbitrary; it's not actually supp

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3f427ba239: [ASTImporter] Add linkage check to ASTNodeImporter::hasSameVisibilityContext… (authored by shafik). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D74639?

[clang] bf3f427 - [ASTImporter] Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

Author: shafik Date: 2020-02-20T12:49:14-08:00 New Revision: bf3f427ba239bd2942bfaa350d06ed072935f048 URL: https://github.com/llvm/llvm-project/commit/bf3f427ba239bd2942bfaa350d06ed072935f048 DIFF: https://github.com/llvm/llvm-project/commit/bf3f427ba239bd2942bfaa350d06ed072935f048.diff LOG: [

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:51 +/// Represents a single source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRange { + DiagnosticAssociatedRange() = default; alexfh wrote: >

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 245717. compositeprimes marked an inline comment as done. compositeprimes added a comment. Added tests for Yaml serialization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 Files: include/clang/To

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. Looks like things are still broken in several ways even with this in: [2600/2950] Linking CXX executable bin\c-index-test.exe FAILED: bin/c-index-test.exe cmd.exe /C "cd . && C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\cmake-3.12.1-win32-x86\bin\cm

[clang] e844447 - Revert "libclang: Add static build support for Windows" and

Author: Nico Weber Date: 2020-02-20T15:17:51-05:00 New Revision: e8781aad23ed66d46d23637df4768677e76e URL: https://github.com/llvm/llvm-project/commit/e8781aad23ed66d46d23637df4768677e76e DIFF: https://github.com/llvm/llvm-project/commit/e8781aad23ed66d46d23637df4768677e76e.diff LO

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added a comment. Running this over llvm with only clang and clang-tools-extra enabled this was the output. ninja check-all ran successfully with no errors. Didn't try transform `TransformCxxOpCalls` or `TransformDepend

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245708. zoecarver added a comment. - Add AMD cache line sizes based on @lebedev.ri's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files: clang/include/c

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @lebedev.ri thanks! I'll add those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

mehdi_amini added a comment. > It seems to me that we are not dropping the flag of -fdiscard-value-names. I also reads this as overriding a cc1 flag / ignoring the flag, I don't know if we consistently warn in such cases though. Overall LGTM for the fix, pending resolution for the warning, than

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. No proofs, but for completeness, some amd numbers Comment at: clang/lib/Basic/Targets/X86.cpp:1811-1814 +// K6 +case CK_K6: +case CK_K6_2: +case CK_K6_3: K6 should have 32B cache line size Comment a

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. Thank you! A build with `-DLIBCLANG_BUILD_STATIC=ON` and `-DLLVM_ENABLE_PIC=OFF` is green at: https://github.com/cristianadam/llvm-project/actions/runs/42545217 The default build with `-DLIBCLANG_BUILD_STATIC=OFF` and `-DLLVM_ENABLE_PIC=ON` is green at: https:/

[clang] 6d34a87 - [cxx_status] Update -std= instructions for C++20.

Author: Richard Smith Date: 2020-02-20T11:40:09-08:00 New Revision: 6d34a87bae6ea211076c25faef7da5d29cb8e46d URL: https://github.com/llvm/llvm-project/commit/6d34a87bae6ea211076c25faef7da5d29cb8e46d DIFF: https://github.com/llvm/llvm-project/commit/6d34a87bae6ea211076c25faef7da5d29cb8e46d.diff

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f56789c8fe8: [clang][doxygen] Fix false -Wdocumentation warning for tag typedefs (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: h

[PATCH] D74907: libclang: Make shared object symbol exporting by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7c753b0cca: libclang: Make shared object symbol exporting by default (authored by cristian.adam, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. In D66822#1656476 , @jfb wrote: > 1. Add to target infrastructure Refs D74918 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66822/new/ https:/

[clang] 2f56789 - [clang][doxygen] Fix false -Wdocumentation warning for tag typedefs

Author: Jan Korous Date: 2020-02-20T11:32:30-08:00 New Revision: 2f56789c8fe8edb57bc7a193592ecd35a393fe4a URL: https://github.com/llvm/llvm-project/commit/2f56789c8fe8edb57bc7a193592ecd35a393fe4a DIFF: https://github.com/llvm/llvm-project/commit/2f56789c8fe8edb57bc7a193592ecd35a393fe4a.diff LO

[clang] 7a7c753 - libclang: Make shared object symbol exporting by default

Author: Cristian Adam Date: 2020-02-20T14:26:25-05:00 New Revision: 7a7c753b0cca6abb61f054842fb087dfc30dc563 URL: https://github.com/llvm/llvm-project/commit/7a7c753b0cca6abb61f054842fb087dfc30dc563 DIFF: https://github.com/llvm/llvm-project/commit/7a7c753b0cca6abb61f054842fb087dfc30dc563.diff

[PATCH] D74894: [clang-format] Merge name and colon into a single token for C# named arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11ff39ba2ad: [clang-format] Merge name and colon into a single token for C# named arguments (authored by Jonathan Coe ). Herald added a project: clang. Herald added a subscriber: cfe-co

[clang] a11ff39 - [clang-format] Merge name and colon into a single token for C# named arguments

Author: Jonathan Coe Date: 2020-02-20T19:23:38Z New Revision: a11ff39ba2ad3975a40e2684948a4dd2ada89bd3 URL: https://github.com/llvm/llvm-project/commit/a11ff39ba2ad3975a40e2684948a4dd2ada89bd3 DIFF: https://github.com/llvm/llvm-project/commit/a11ff39ba2ad3975a40e2684948a4dd2ada89bd3.diff LOG:

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch adds a virtual method `getCPUCacheLineSize()` to `TargetInfo`. Currently, I've only (partially) implemented the method in `X86TargetInfo`. It's extremely important tha

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. Thanks! Let me try landing this and see what happens :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 _

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. For the record: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Ariscv64-toolchain.c fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. Yes, makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { jroelofs wrote: > This feels very fragile, and I kn

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

b-sumner added a comment. I recall we agreed that conformance tests using mixed types were broken, so this change should be OK. Hopefully this will not affect users. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 ___

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam updated this revision to Diff 245683. cristian.adam added a comment. `-DLLVM_ENABLE_PIC=OFF` on Windows if `LIBCLANG_BUILD_STATIC` is not set to `ON` will generate a SHARED libclang.dll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao marked 2 inline comments as done. hliao added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11442 + ContextDecl = getCUDACurrentNonLocalVariable(); +return ContextDecl; + } rjmccall wrote: > This is tricky because we could be in a n

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245682. hliao added a comment. Skip non-function or non-TU context so far as more cases need considering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/i

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

rsmith added a comment. In D71920#1870195 , @sammccall wrote: > If you'd like to have `concept::Requirement` use a similar bitfield, I'd just > like to confirm my understanding of the current code before refactoring it: > > - there's just one `Dependent`

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa3894c4e77: [clang] Fix search path logic for C_INCLUDE_DIRS (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://revie

[clang] 6fa3894 - [clang] Fix search path logic for C_INCLUDE_DIRS

Author: Louis Dionne Date: 2020-02-20T12:35:15-05:00 New Revision: 6fa3894c4e771c773712b1ae777f78c1c922a908 URL: https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908 DIFF: https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908.diff

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. In D74907#1884842 , @cristian.adam wrote: > In D74907#1884795 , @thakis wrote: > > > Thanks! Does this make it so that libclang.dll is built again with > > -DLLVM_ENABLE_PIC=NO on Window? F

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, dancgr, cameron.mcinally, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsic

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

yaxunl added a comment. Are you sure this change will not break OpenCL conformance tests? I remember they are there for some reason. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 _

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

rsmith added a comment. In D71920#1884740 , @sammccall wrote: > @rsmith Friendly ping. Do you want to review this/other patches in this > sequence, or should we be a bit bolder and pull you in when we're uncertain > in principle what to do? I'm fine wi

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

njames93 added a comment. In D73580#1884042 , @Eugene.Zelenko wrote: > In D73580#1883861 , @njames93 wrote: > > > LGTM, For what this is trying to achieve I have no issue, follow up patches > > can be submitted fo

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb8911aad726: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks… (authored by Eugene.Zelenko, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, kristina, jfb. Herald added a project: clang. These declarations use a mix of unsigned and signed argument and return types. This is not defined in OpenCL v2.0 s6.13.11. Repository:

[clang-tools-extra] db8911a - [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Author: Eugene Zelenko Date: 2020-02-20T17:31:08Z New Revision: db8911aad726d050fb36f17f2978bd35f69165cc URL: https://github.com/llvm/llvm-project/commit/db8911aad726d050fb36f17f2978bd35f69165cc DIFF: https://github.com/llvm/llvm-project/commit/db8911aad726d050fb36f17f2978bd35f69165cc.diff LOG

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 ___ cfe-commits ma

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. In D74907#1884795 , @thakis wrote: > Thanks! Does this make it so that libclang.dll is built again with > -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that > correct? If so, could you reinstantiate

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:33 #endif -#elif defined(CINDEX_EXPORTS) +#elif defined(CINDEX_EXPORTS) && defined(__GNUC__) #define CINDEX_LINKAGE __attribute__((visibility("d

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur added a comment. In D74878#1884769 , @serge-sans-paille wrote: > @lebedev.ri maybe we should at least warn the user if there was a flag at > clang level to force discarding? That's what I've been doing in > https://reviews.llvm.org/D74871?id=245594

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

bader added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { yaxunl wrote: > rjmccall wrote: > > yaxunl wrote: > > > rjmccall wr

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam created this revision. cristian.adam added reviewers: yvvan, mstorsjo, thakis. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. https://reviews.llvm.org/D74564 enabled static building for libclang, and for non CMake consumers they had to set the `CMAKE_E

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > I'll submit it today. Done, see: https://reviews.llvm.org/D74907 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commi

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > yaxunl

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. @lebedev.ri maybe we should at least warn the user if there was a flag at clang level to force discarding? That's what I've been doing in https://reviews.llvm.org/D74871?id=245594 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://revie

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall added a comment. @rsmith Friendly ping. Do you want to review this/other patches in this sequence, or should we be a bit bolder and pull you in when we're uncertain in principle what to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb54c13c217b: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] cb54c13 - [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

Author: Utkarsh Saxena Date: 2020-02-20T17:17:36+01:00 New Revision: cb54c13c217b3e5fcda5c97bab229c1f9c3934b7 URL: https://github.com/llvm/llvm-project/commit/cb54c13c217b3e5fcda5c97bab229c1f9c3934b7 DIFF: https://github.com/llvm/llvm-project/commit/cb54c13c217b3e5fcda5c97bab229c1f9c3934b7.diff

[PATCH] D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. PutenvWithAutoChecker.cpp used to inclu

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. @ostannard Thanks for reporting that! Please share the case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. Reproducer for that crash: P8198 P8199 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits ma

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Nice! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. There's a failure on an ARM 2-stage buildbot which looks related to this: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/3920/steps/build%20stage%202/logs/stdio I can reproduce the crash on the buildbot machine, so hopefully I'll have a standalon

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted again with rG2f215cf36adc . The investigation is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 245656. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques added a comment. In D74847#1883028 , @efriedma wrote: > I'm not really a big fan of running tests with the host target triple, > anyway; it seems to create work with almost no benefit. I'd be happy to just > run the test with one target that

  1   2   >