NoQ added a comment. Herald added subscribers: martong, steakhal. Hmm, has this patch not landed yet? I was so excited to finally have https://bugs.llvm.org/show_bug.cgi?id=28450 fixed :)
================ Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:767 + DefinedOrUnknownSVal Size = UnknownVal(); + if (const Expr *SizeExpr = CNE->getArraySize().getValueOr(nullptr)) + Size = State->getSVal(SizeExpr, LCtx).castAs<DefinedOrUnknownSVal>(); ---------------- This looks like an object count, we'll need to convert it to size in bytes because that's what extent is. ================ Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:698 + DefinedOrUnknownSVal Size = UnknownVal(); + if (const Expr *SizeExpr = CNE->getArraySize().getValueOr(nullptr)) + Size = State->getSVal(SizeExpr, LCtx).castAs<DefinedOrUnknownSVal>(); ---------------- Same. I guess we should add a test for both cases, given that nothing failed when we screwed up the extent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
