[clang] c42116c - Fix up ms-pch-macro.c test to pass on non-Windows

Author: Reid Kleckner Date: 2020-01-14T22:19:30-08:00 New Revision: c42116cc653ae1618cc49dab367d9f6addd8cfd9 URL: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9 DIFF: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9.diff

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rtrieu added a comment. Heads up in case it affects you refactoring work: While looking through this code, I found a bug I previously made. I fixed it with a small change, but that lies in the middle of your refactoring during FieldDecl handling. The change is here: https://reviews.llvm.org/r

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ca24d09aefa: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D72463?vs=238120&id=238167#toc Repository:

[clang] 5ca24d0 - [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries

Author: Fangrui Song Date: 2020-01-14T21:57:06-08:00 New Revision: 5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a URL: https://github.com/llvm/llvm-project/commit/5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a DIFF: https://github.com/llvm/llvm-project/commit/5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a.diff

[PATCH] D72227: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

skan abandoned this revision. skan added a comment. The override principle of driver should keep same with MC (D72738 ). D72463 is better, so I prefer to abandon this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM The principle of override here is consistent with MC (D72738 ). So I think this patch is better than D72227 . Repository:

[clang] a60e892 - [ODRHash] Fix wrong error message with bitfields and mutable.

Author: Weverything Date: 2020-01-14T21:12:15-08:00 New Revision: a60e8927297005898b10a46300d929ba5cf7833c URL: https://github.com/llvm/llvm-project/commit/a60e8927297005898b10a46300d929ba5cf7833c DIFF: https://github.com/llvm/llvm-project/commit/a60e8927297005898b10a46300d929ba5cf7833c.diff L

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder created this revision. MadCoder added reviewers: ahatanak, arphaman, dexonsmith, erik.pilkington. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. Sending a message to `self` when it is const and within a class method is safe because we know that `self` is the Cla

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd18fbfc09720: Relax the rules around objc_alloc and objc_alloc_init optimizations. (authored by MadCoder). Changed prior to commit: https://reviews.llvm.org/D71682?vs=234644&id=238161#toc Repository:

[clang] d18fbfc - Relax the rules around objc_alloc and objc_alloc_init optimizations.

Author: Pierre Habouzit Date: 2020-01-14T19:48:33-08:00 New Revision: d18fbfc09720009c0dc6a1ddf315402ee0a7751d URL: https://github.com/llvm/llvm-project/commit/d18fbfc09720009c0dc6a1ddf315402ee0a7751d DIFF: https://github.com/llvm/llvm-project/commit/d18fbfc09720009c0dc6a1ddf315402ee0a7751d.dif

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen added a comment. Wild guess is that `2> %t.err` should be removed from the `-verify` lines? That change passes in the single env I have access to. @rnk any idea what might be going on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72405/new

[clang] 1b5404a - PR44540: Prefer an inherited default constructor over an initializer

Author: Richard Smith Date: 2020-01-14T19:29:50-08:00 New Revision: 1b5404aff37953ce4c10191d04872ed7c2dc6548 URL: https://github.com/llvm/llvm-project/commit/1b5404aff37953ce4c10191d04872ed7c2dc6548 DIFF: https://github.com/llvm/llvm-project/commit/1b5404aff37953ce4c10191d04872ed7c2dc6548.diff

[clang] c6e6988 - Modify test to use -S instead of -c so that it works when an external assembler is used that is not present.

Author: Douglas Yung Date: 2020-01-14T18:58:18-08:00 New Revision: c6e69880ae4d9ce4d27bf046292a0a20c3ab3540 URL: https://github.com/llvm/llvm-project/commit/c6e69880ae4d9ce4d27bf046292a0a20c3ab3540 DIFF: https://github.com/llvm/llvm-project/commit/c6e69880ae4d9ce4d27bf046292a0a20c3ab3540.diff

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. From an LTO perspective, this seems fine for the reasons we discussed here. I looked through the patch and have a few comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:818 + if (TM) { +TM->initializeOptionsWithModuleMetadata(*TheModule);

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added a comment. The patch could be shorter and slightly less confusing if I preserved 1:1 `RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought we might want to keep `RefKind` being 1 byte so that we don't waste unnecessary memory. Also, since we might want to

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added a comment. Changed reviewer to @kadircet because Sam would be out until the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 ___

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

ormris added a comment. Hi Zach, The tests in this patch are failing on this PS4 windows bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/30273/steps/test-check-all/logs/stdio Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev added a subscriber: hokein. This patch allows the index does to provide a way to distinguish implicit referen

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61871 tests passed, 1 failed and 781 were skipped. failed: Clang.PCH/ms-pch-macro.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your ch

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e780252a728: [X86] ABI compat bugfix for MSVC vectorcall (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72110/new/ https://reviews.llvm.o

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk updated this revision to Diff 238152. rnk marked 2 inline comments as done. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://reviews.llvm.org/D72114 Files: clang/include/clang/CodeGen/CGFunctionI

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:6 + + Flags use of the `C` standard library functions 'memset', 'memcpy' and + 'memcmp' and similar derivatives on non-trivial type

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238153. njames93 marked an inline comment as done. njames93 added a comment. - double ticks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rjmccall wrote: > rnk wrote: > > rnk wrot

[clang] 8e78025 - [X86] ABI compat bugfix for MSVC vectorcall

Author: Reid Kleckner Date: 2020-01-14T17:49:13-08:00 New Revision: 8e780252a7284be45cf1ba224cabd884847e8e92 URL: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92 DIFF: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92.diff

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61859 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9cf42facaf: Allow /D flags absent during PCH creation under msvc-compat (authored by zahen, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D72405?vs=238147&id=238149#toc Reposit

[clang] 0f9cf42 - Allow /D flags absent during PCH creation under msvc-compat

Author: Zachary Henkel Date: 2020-01-14T17:26:01-08:00 New Revision: 0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b URL: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b DIFF: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b.diff

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D72405#1818237 , @zahen wrote: > I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` > because the errors were reported against "(

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 ___

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk updated this revision to Diff 238147. rnk added a comment. - use %clang_cc1 as possible in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72405/new/ https://reviews.llvm.org/D72405 Files: clang/lib/Lex/PPDirectives.cpp clang/test/PCH/

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. Okay. Please let me know if you want me to review anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71387/new/ https://reviews.llvm.org/D71387 ___ cfe-commits mailing l

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

tejohnson added a comment. Overall I like this approach. Comment at: llvm/lib/Passes/PassBuilder.cpp:246 -static bool isOptimizingForSize(PassBuilder::OptimizationLevel Level) { - switch (Level) { - case PassBuilder::O0: - case PassBuilder::O1: - case PassBuilder::O2: -

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238142. ychen edited the summary of this revision. ychen added a comment. - fix test when clang is the host compiler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238143. wristow retitled this revision from "ix -ffast-math/-ffp-contract interaction" to "Fix -ffast-math/-ffp-contract interaction". wristow added a comment. Addressed comments from @hfinkel . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/ne

[clang] c9ee5e9 - Fix windows bot failures in c410adb092c9cb51ddb0b55862b70f2aa8c5b16f

Author: Rong Xu Date: 2020-01-14T16:32:17-08:00 New Revision: c9ee5e996e3c89a751a35e8b771870e0ec24f3c0 URL: https://github.com/llvm/llvm-project/commit/c9ee5e996e3c89a751a35e8b771870e0ec24f3c0 DIFF: https://github.com/llvm/llvm-project/commit/c9ee5e996e3c89a751a35e8b771870e0ec24f3c0.diff LOG:

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FileUtilities.h:38 +#if defined(_AIX) + SmallString<128> getLoadModuleFilenameForFunctionAIX(void (*Func)(void)); +#endif This should be an internal function in the `.cpp` file i

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

rnk added a comment. I think I liked the first version of this patch better. I would say, if the AST after instantiation remains the same as it was before D69950 , then the first one seems like the right fix. The pattern AST will just be missing a node to repres

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio created this revision. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Sign-extension is not guaranteed by the ABI, and thus the callee cannot assume it. This fixes PR44228 and PR12207. With these changes, there

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

This revision was automatically updated to reflect the committed changes. Closed by commit rG60d39479221d: [remark][diagnostics] Using clang diagnostic handler for IR input files (authored by xur). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D72523?vs=237810

[clang] 60d3947 - [remark][diagnostics] Using clang diagnostic handler for IR input files

Author: Rong Xu Date: 2020-01-14T15:44:57-08:00 New Revision: 60d39479221d6bc09060f7816bcd7c54eb286603 URL: https://github.com/llvm/llvm-project/commit/60d39479221d6bc09060f7816bcd7c54eb286603 DIFF: https://github.com/llvm/llvm-project/commit/60d39479221d6bc09060f7816bcd7c54eb286603.diff LOG:

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. I don't see any crashes in OpenMP tests, other tests just must be updated by the author, if this patch will ever going to be landed. I don't think it is a good idea to have a not fully functional implementation, even guarded by the option. CHANGES SINCE LAST ACTION

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61862 tests passed, 1 failed and 781 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon que

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

jyknight added a comment. Since this change is not android-only, please update change description, and update some non-android tests. E.g. maybe the tests in clang/test/Driver/linux-ld.c for ubuntu_14.04_multiarch_tree should check the path at which ld is found. While the existing Inputs/ubunt

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

njames93 added a comment. In D72121#1817733 , @Eugene.Zelenko wrote: > Please also close PRs. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72121/new/ https://reviews.llvm.org/D72121 ___ cfe

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FileUtilities.h:44 +if (!FuncAddr) { + return ""; +} I'm not sure that this function should handle failure by returning an empty string. The error condition can be m

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Lewis, your latest patch looks good, we just had another run with no new failures. But we know it will have issues with -g. So I think we should not merge it yet. Do you have a version of the patch that creates the labels for the compiler-generated save/restore lib calls

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay updated this revision to Diff 238120. MaskRay marked 2 inline comments as done. MaskRay added a comment. Make driver a thin wrapper since we are going to add a master option in MC (D72738 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

Author: Alexey Bataev Date: 2020-01-14T18:12:06-05:00 New Revision: 23058f9dd4d7e18239fd63b6da52549514b45fda URL: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda DIFF: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda.diff

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary added a comment. One thing to note about my patch, above: I have not made the TargetMachine DataLayout non-const, but I wanted to ensure that this might be possible in future, which is why calling `initializeOptionsWithModuleMetadata` must be done before the first call to `createDataLayo

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61849 tests passed, 1 failed and 781 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp {icon question-circle col

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc9d22e49b4: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=227634&id=238115#toc Repository: rG

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

lenary added a comment. @efriedma To keep you in the loop, D72624 is the patch to add a target hook for setting the TargetMachine options based on module metadata. That patch does not add any RISC-V specific functionality, it only lays the groundwork for it.

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:112 + + Flags use of the `C` standard library functions 'memset', 'memcpy' and + 'memcmp' and similar derivatives on non-trivial types. Please use double back-ticks to h

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238114. njames93 added a comment. - remove `This check` from docs... again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/cert/C

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya marked 4 inline comments as done. ilya added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; rsmith wrote: > ilya wrote: > > rsmith wrote: > > > Hm

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm added a comment. LGTM Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:487 +def FeatureMfma1Insts : SubtargetFeature<"mfma1-insts", + "HasMfma1Insts", We already have the HasMAIInsts feature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya updated this revision to Diff 238106. ilya added a comment. Address rsmith's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChec

[PATCH] D69779: -fmodules-codegen should not emit extern templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG729530f68fe1: -fmodules-codegen should not emit extern templates (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://revi

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin updated this revision to Diff 238107. mtrofin marked 2 inline comments as done. mtrofin added a comment. Alternative: expose speedup/size components to more closely align with legacy PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72547/new

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

lebedev.ri added a comment. In D72553#1820692 , @njames93 wrote: > - moved check from llvm module to performance Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.or

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

wristow marked 3 inline comments as done. wristow added a comment. Thanks for the quick feedback @hfinkel Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2721 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

Jonathan.Crowther created this revision. Jonathan.Crowther added reviewers: hubert.reinterpretcast, xingxue. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya. Herald added projects: clang, LLVM. Implemented (for AIX) a function to take any function and return the path of t

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 238104. njames93 added a comment. - moved check from llvm module to performance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/l

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen added a comment. In D72404#1820628 , @tycho wrote: > In D72404#1820461 , > @merge_guards_bot wrote: > > > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 > > failed and 781 were skipped

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. Herald added a subscriber: wuzish. Ping, I don't think I have any actionable feedback here and I'd like to get this landed before Clang 10 branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.l

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 238099. rsmith added a comment. Herald added subscribers: kbarton, nemanjai. Rebase and slightly expand release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Fi

[PATCH] D44352: [Concepts] Type Constraints

rsmith accepted this revision. rsmith added a comment. Some cleanups (mainly parameters that are no longer necessary), then this is good to go. Thanks! Comment at: clang/include/clang/Basic/LangOptions.def:146 LANGOPT(DllExportInlines , 1, 1, "dllexported classes dllexport i

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61848 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] a48600c - [OPENMP]Do not emit special virtual function for NVPTX target.

Author: Alexey Bataev Date: 2020-01-14T16:59:22-05:00 New Revision: a48600c0a653d34f4af760f117755ed1776adf9d URL: https://github.com/llvm/llvm-project/commit/a48600c0a653d34f4af760f117755ed1776adf9d DIFF: https://github.com/llvm/llvm-project/commit/a48600c0a653d34f4af760f117755ed1776adf9d.diff

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

tycho added a subscriber: merge_guards_bot. tycho added a comment. In D72404#1820461 , @merge_guards_bot wrote: > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed > and 781 were skipped. > > failed: Clang.CodeGen/thinlto-deb

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1820579 , @aaron.ballman wrote: > In D68115#1820462 , @vitalybuka > wrote: > > > I would be happy to finish this patch if we agree on something. > > > > So if I understand thi

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge updated this revision to Diff 238094. nridge added a comment. Revise the approach to treat non-first expansions as not-selected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72041/new/ https://reviews.llvm.org/D72041 Files: clang-tools-ex

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820598 , @dblaikie wrote: > (just a general comment that this code review should be only in service of > the design discussion happening on llvm-dev - please don't approve/commit > this without closing out the design

[clang] a3490e3 - Remove trailing `;`. NFC.

Author: Michael Liao Date: 2020-01-14T16:52:20-05:00 New Revision: a3490e3e3d38d502179329f76138d96c5b2bab88 URL: https://github.com/llvm/llvm-project/commit/a3490e3e3d38d502179329f76138d96c5b2bab88 DIFF: https://github.com/llvm/llvm-project/commit/a3490e3e3d38d502179329f76138d96c5b2bab88.diff

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. njames93 wrote: > lebedev.ri wrote: > > Are we **really**

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

dblaikie added a comment. (just a general comment that this code review should be only in service of the design discussion happening on llvm-dev - please don't approve/commit this without closing out the design discussion there if there are actionable conclusions from this review) Repository:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. lebedev.ri wrote:

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. > Well, just like for all the other FP builder methods, you can use the > setIsFPConstrained method on the builder object to switch between strict and > non-strict mode. Does this not suffice, or is there anything particular about > the comparisons that would require a

[PATCH] D69779: -fmodules-codegen should not emit extern templates

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks for your patience! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 ___

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak updated this revision to Diff 238089. llunak added a comment. This version uses a module based on the code posted above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 Files: clang/lib/Serialization/ASTWriterDecl.cpp clang/test/Modul

[PATCH] D68115: Zero initialize padding in unions

aaron.ballman added a comment. In D68115#1820462 , @vitalybuka wrote: > I would be happy to finish this patch if we agree on something. > > So if I understand this the proposal is to have something like > -fzero-union-padding which is off by default. > W

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820281 , @lenary wrote: > In D72624#1817464 , @tejohnson wrote: > > > > > > Thank you for your feedback! It has been very helpful. > > > I'm not sure if ThinLTOCodeGenerator.cpp

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1820462 , @vitalybuka wrote: > So if I understand this the proposal is to have something like > -fzero-union-padding which is off by default. > When it's OFF compiler will continue to do whatever it does

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge added a comment. In D72041#1800189 , @sammccall wrote: > - the allSelectedNodes API on SelectionTree feels non-orthogonal: it's only > meaningful here because the input happened to be a point and thus touches a > single token and therefore node. I

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added a comment. Happy to see this check! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. Are we **really** **really** sure thi

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak updated this revision to Diff 238086. llunak added a comment. I've updated the test as requested. However I've noticed that a PCH-based test for this relies on https://reviews.llvm.org/D69585 . The fix works (of course), but it requires a PCH/module with the instantiation. CHANGES SINC

[PATCH] D72668: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca51c06729d: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for… (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D72668?vs=237816&id=238085#toc Repository: rG LLVM Github

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 238082. njames93 added a comment. - fix spelling mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt cl

[clang] 1ca51c0 - [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

Author: Fangrui Song Date: 2020-01-14T13:18:23-08:00 New Revision: 1ca51c06729d7f7326fcc2a826e07d1c92158dfd URL: https://github.com/llvm/llvm-project/commit/1ca51c06729d7f7326fcc2a826e07d1c92158dfd DIFF: https://github.com/llvm/llvm-project/commit/1ca51c06729d7f7326fcc2a826e07d1c92158dfd.diff

[PATCH] D72730: [clang-tools-extra] run-clang-tidy -export-fixes exports only fixes, not all warnings

AlexanderLanin created this revision. AlexanderLanin added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. AlexanderLanin added a comment. Important: I'm not a python expert. It works fine as far as I can tell. I would feel better if someone wi

[PATCH] D72730: [clang-tools-extra] run-clang-tidy -export-fixes exports only fixes, not all warnings

AlexanderLanin added a comment. Important: I'm not a python expert. It works fine as far as I can tell. I would feel better if someone with more than a day python experience would say that it is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1819418 , @aaron.ballman wrote: > In D68115#1811091 , @lebedev.ri > wrote: > > > In D68115#1811089 , > > @hubert.reinterpretcast wrot

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed and 781 were skipped. failed: Clang.CodeGen/thinlto-debug-pm.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format

[clang] 986202f - [clang][test][NFC] Use more widely supported sanitizer for file dependency tests

Author: Jan Korous Date: 2020-01-14T12:55:11-08:00 New Revision: 986202fad41529af8288aca54f2ff62d4c501d71 URL: https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71 DIFF: https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71.diff LO

  1   2   3   >