[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added a comment. It'll be reasonable to submit patches generated by check into trunk. May be after branching release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 __

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-prefer-preincrement.rst:30 + both the prefix and postfix operator ``++`` or ``--``. + Default value is 1. + Please highlight default value with single back-ticks.

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, hokein. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a new clang-tidy check that detects postfix increments and decrements that can be swapped for their prefix

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61771 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. > what do you think about unwrapping decltype only when it's a return value > (optional: of a function whose leading return type is auto) to narrowly catch > this idiom? I think it's worth fixing in the declarations too. int &bar(int a, int b); template auto ca

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 ___ cfe-

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Here is a minimal example that shows the problem: #include template struct DoGooder { DoGooder(void* accessor, SomeValue value) { } }; struct Bingus { static constexpr auto someRandomConstant = 99; }; template s

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay updated this revision to Diff 237476. MaskRay edited the summary of this revision. MaskRay added a comment. Delete -mno-branches-within-32B-boundaries (GNU as does not support it) Use comma joined list instead of +. CommaJoined is more conventional. For example, `-mrecip=` and `-fsanitize

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:254 +def err_drv_invalid_malign_branch_EQ : Error< + "invalid argument '%0' to -malign-branch=; must be one of: %1">; + skan w

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a simple cache for constraint satisfaction results. This results in a major speedup (cjdb measured x2 faster than gcc with this caching, compared to being '

[PATCH] D72551: Warn when a string literal is used in a range-based for-loop

rtrieu created this revision. String literals used in ranged-based for-loops will actually process the terminating null character as part of the loop, which may be unexpected. // This runs three times, once for c = 'h', then c = 'i', and finally as c = '\0' for (char c : "hi") This patch

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

tejohnson added a comment. Thanks for fixing this missing -Rpass support! Comment at: clang/lib/CodeGen/CodeGenAction.cpp:594 + // SourceLoc. + if (Context == nullptr) { +return FullSourceLoc(); Does this only happen with IR input? Does it always happen w

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237471. sorenj added a comment. - Remove double space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rtrieu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:11007 + // Issue any pending ODR-failure diagnostics. + for (auto &Merge : RecordOdrMergeFailures) { bruno wrote: > rtrieu wrote: > > Is this just a copy of the other loop? That'

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unsigned-subtraction.rst:17 +constants, thus making the implict cast explicit and signals that +the the code was intended. In cases where the second argument is +not a constant,

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGde0a22471157: Remove umask tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D70854?vs=23340

[clang] de0a224 - Remove umask tests

Author: Alexandre Ganea Date: 2020-01-10T21:05:59-05:00 New Revision: de0a2247115729eade8249267a47f96f070a7666 URL: https://github.com/llvm/llvm-project/commit/de0a2247115729eade8249267a47f96f070a7666 DIFF: https://github.com/llvm/llvm-project/commit/de0a2247115729eade8249267a47f96f070a7666.dif

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237466. sorenj added a comment. - Address documentation comments. - Address documentation comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files: clang-tools-

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea updated this revision to Diff 237465. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/include/clang/Driver/Driver.h

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:267 + + StringRef SpawnCC1Str = ::getenv("CLANG_SPAWN_CC1"); + if (!SpawnCC1Str.empty()) { hans wrote: > aganea wrote: > > hans wrote: > > > Maybe just do the "!!" thing like for the enviro

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

tejohnson added a comment. I just have a few high level comments from looking through it just now. The summary needs a fix since Os/Oz are in fact O2 so OptLevel > 1 was not doing the wrong thing. Comment at: llvm/include/llvm/Pas

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin updated this revision to Diff 237464. mtrofin added a comment. Speedup level is actually '2' for Os and Oz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72547/new/ https://reviews.llvm.org/D72547 Files: clang/lib/CodeGen/BackendUtil.cpp

[clang] 9b23407 - [Concepts] Fix MarkUsedTemplateParameters for exprs

Author: Saar Raz Date: 2020-01-11T03:16:57+02:00 New Revision: 9b23407063ca41901e9e272bacf8b33eee8251c4 URL: https://github.com/llvm/llvm-project/commit/9b23407063ca41901e9e272bacf8b33eee8251c4 DIFF: https://github.com/llvm/llvm-project/commit/9b23407063ca41901e9e272bacf8b33eee8251c4.diff LOG:

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237463. efriedma added a comment. Figured out the changes necessary to get bitcode reading/writing working. ninja check now passes. Not sure what parts I should split off to get reviewed separately. Probably the GlobalISel changes could be split off with

[clang] 1d2cd2c - [Driver] Fix OptionClass of -fconvergent-functions and -fms-volatile (Joined -> Flag)

Author: Fangrui Song Date: 2020-01-10T17:06:40-08:00 New Revision: 1d2cd2c0b7d978e22a50e918af708ba67e87c2c1 URL: https://github.com/llvm/llvm-project/commit/1d2cd2c0b7d978e22a50e918af708ba67e87c2c1 DIFF: https://github.com/llvm/llvm-project/commit/1d2cd2c0b7d978e22a50e918af708ba67e87c2c1.diff

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma marked an inline comment as done. efriedma added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) r

Buildbot numbers for the last week of 12/29/2019 - 01/04/2020

Hello everyone, Below are some buildbot numbers for the last week of 12/29/2019 - 01/04/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 12/15/2019 - 12/21/2019

Hello everyone, Below are some buildbot numbers for the week of 12/15/2019 - 12/21/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 12/22/2019 - 12/28/2019

Hello everyone, Below are some buildbot numbers for the week of 12/22/2019 - 12/28/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 12/8/2019 - 12/14/2019

Hello everyone, Below are some buildbot numbers for the week of 12/8/2019 - 12/14/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson marked 2 inline comments as done. tejohnson added a comment. In D72538#1815074 , @wmi wrote: > The additional pipeline testing will catch any future pass change to the > pipeline. A related but separate question is do we have a way to check > w

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin added a comment. Another example where there is a discrepancy with the old pass manager: in the old pass manager (PassManagerBuilder::addFunctionSimplificationPasses): if (OptLevel > 1) { if (EnableGVNHoist) MPM.add(createGVNHoistPass()); (before this change, new pass ma

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237462. tejohnson marked an inline comment as done. tejohnson added a comment. Implement suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files: clang/te

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. mtrofin added reviewers: tejohnson, davidxl. mtrofin added a comment. Another example where there is a discrepancy with the

[clang] 44e0daf - driver: Allow -fdebug-compilation-dir=foo in joined form.

Author: Nico Weber Date: 2020-01-10T19:20:51-05:00 New Revision: 44e0daf16e6985eb44ea9a629402852dbff9cb0b URL: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b DIFF: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b.diff LO

[clang] fbf915f - Add a FIXME and corresponding test coverage for some suspicious behavior

Author: Richard Smith Date: 2020-01-10T16:12:00-08:00 New Revision: fbf915f01d46e005146f01553a5d7c6619d19597 URL: https://github.com/llvm/llvm-project/commit/fbf915f01d46e005146f01553a5d7c6619d19597 DIFF: https://github.com/llvm/llvm-project/commit/fbf915f01d46e005146f01553a5d7c6619d19597.diff

[clang] f4df7f4 - Remove redundant implicit cast creation.

Author: Richard Smith Date: 2020-01-10T16:12:00-08:00 New Revision: f4df7f4701d80ce6a2f5674db50f87fbd2dad82f URL: https://github.com/llvm/llvm-project/commit/f4df7f4701d80ce6a2f5674db50f87fbd2dad82f DIFF: https://github.com/llvm/llvm-project/commit/f4df7f4701d80ce6a2f5674db50f87fbd2dad82f.diff

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

xbolva00 added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) return UndefValue::get(RetTy); -

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237453. efriedma added a comment. Herald added subscribers: cfe-commits, Petar.Avramovic, dexonsmith, nhaehnle, jvesely, arsenm. Herald added a project: clang. Add more comments, fixed the GlobalISel representation of shuffles, misc other cleanups. Still h

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1815121 , @JonasToth wrote: > In D54943#1815073 , @0x8000- > wrote: > > > Applied the fix-it on one of our smaller (but C++ code bases) and it builds > > and passes the t

[clang] 1b8c84b - Improve precision of documentation comment.

Author: Richard Smith Date: 2020-01-10T15:49:17-08:00 New Revision: 1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27 URL: https://github.com/llvm/llvm-project/commit/1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27 DIFF: https://github.com/llvm/llvm-project/commit/1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27.diff

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added a comment. I see the following .cfi_offset directives generated using @shiva0217's test case. Any idea why the offset for ra is 536870908? callt0, __riscv_save_0 .cfi_def_cfa_offset 16 .cfi_offset ra, 536870908 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that the block legitimately ends with a

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor. W

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1815073 , @0x8000- wrote: > Applied the fix-it on one of our smaller (but C++ code bases) and it builds > and passes the tests. Comments: > > 1. I'm still seeing some false positives, where some locals that are con

[clang] 7a38468 - Only destroy static locals if they have non-trivial destructors.

Author: Richard Smith Date: 2020-01-10T15:18:36-08:00 New Revision: 7a38468e34eeeb59e80b176b97213d205d8d9b41 URL: https://github.com/llvm/llvm-project/commit/7a38468e34eeeb59e80b176b97213d205d8d9b41 DIFF: https://github.com/llvm/llvm-project/commit/7a38468e34eeeb59e80b176b97213d205d8d9b41.diff

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor.

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. First time so trying to follow similar recent submits. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailing lis

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor. W

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 + + Finds cases where a signed value is subtracted from an unsigned value, + a likely cause of unexpected underflow. Please synchronize with first statement in documen

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237440. sorenj added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project - Add documentation and release notes, fix spelling error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Applied the fix-it on one of our smaller (but C++ code bases) and it builds and passes the tests. Comments: 1. I'm still seeing some false positives, where some locals that are const are flagged as could be made const - I'm working to create a minimal reproduction

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi added a comment. The additional pipeline testing will catch any future pass change to the pipeline. A related but separate question is do we have a way to check whether there is any other missing pass in thinlto newpm similar as that in D72386 ? =

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constan

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 237433. logan-5 marked 4 inline comments as done. logan-5 added a comment. Added a TODO comment for catching more reserved names. Added links in documentation to CERT guidelines covered by the check. Pulled strings into named constants and made that logic ea

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added a comment. Documentation and Release Notes entry are still missing.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailin

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. Friendly ping - anything further I need to do here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailing list cfe-com

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237427. tejohnson added a comment. Remove some cruft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll llvm/t

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson created this revision. tejohnson added a reviewer: wmi. Herald added subscribers: jfb, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. I've added some more extensive ThinLTO pipeline testing with the new PM, motivated by the bug fixed in D72

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd added a comment. In D65761#1811097 , @hubert.reinterpretcast wrote: > In D65761#1804302 , > @hubert.reinterpretcast wrote: > > > I have confirmed that the case I mentioned fails with rGd157a9b > >

[clang-tools-extra] 68cd283 - clang-tidy doc: unbreak the CI

Author: Sylvestre Ledru Date: 2020-01-10T22:25:01+01:00 New Revision: 68cd283f3b074e3b64b9f65e93ceb2de6807c72d URL: https://github.com/llvm/llvm-project/commit/68cd283f3b074e3b64b9f65e93ceb2de6807c72d DIFF: https://github.com/llvm/llvm-project/commit/68cd283f3b074e3b64b9f65e93ceb2de6807c72d.dif

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:14 + + Specify extra functions to flag that act similarily to memset. + Default is an empty string. Somehow memset is still not in double back-ticks.

[clang-tools-extra] faeeb71 - clang-tidy doc: Refresh the list of checkers and polish the script

Author: Sylvestre Ledru Date: 2020-01-10T22:07:47+01:00 New Revision: faeeb71a17344171f814144213ac4fbc93be28fd URL: https://github.com/llvm/llvm-project/commit/faeeb71a17344171f814144213ac4fbc93be28fd DIFF: https://github.com/llvm/llvm-project/commit/faeeb71a17344171f814144213ac4fbc93be28fd.dif

[clang-tools-extra] f3db1aa - MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker

Author: Sylvestre Ledru Date: 2020-01-10T22:06:03+01:00 New Revision: f3db1aad2796c62f0d188a74f2901c18e51843c2 URL: https://github.com/llvm/llvm-project/commit/f3db1aad2796c62f0d188a74f2901c18e51843c2 DIFF: https://github.com/llvm/llvm-project/commit/f3db1aad2796c62f0d188a74f2901c18e51843c2.dif

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237422. njames93 added a comment. - Reworked options documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/cert/CERTTidyM

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you! I have commit on your behalf in 4ffcec40acebae7161ac7426edc68290bbaca2b8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 4ffcec4 - Implement new AST matcher hasAnyCapture to match on LambdaExpr captures.

Author: Reid Date: 2020-01-10T15:49:43-05:00 New Revision: 4ffcec40acebae7161ac7426edc68290bbaca2b8 URL: https://github.com/llvm/llvm-project/commit/4ffcec40acebae7161ac7426edc68290bbaca2b8 DIFF: https://github.com/llvm/llvm-project/commit/4ffcec40acebae7161ac7426edc68290bbaca2b8.diff LOG: Imp

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 237418. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/Sourc

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire updated this revision to Diff 237417. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp cla

[PATCH] D72233: Add a new AST matcher 'optionally'.

steveire added a comment. LGTM too. I described a more ad-hoc implementation previously: https://steveire.wordpress.com/2018/11/20/composing-ast-matchers-in-clang-tidy/ but I prefer this implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/new/ https://reviews.llvm.org/

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro added a comment. In D72414#1814831 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://review

[PATCH] D69868: Allow "callbr" to return non-void values

void marked an inline comment as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that the block legitimately ends with a

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237411. akhuang added a comment. Address comments - Removed driver option - Simplified test cases - Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe slightly less misleading Repository: rG LLVM Github Monorepo

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://reviews.llvm.

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72532 Files: clang/lib/

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/Duration

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72534 Files: clang/include/clang/AST/ASTContext.h Index: clang/include/clang/AST/AS

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + arsenm wrote: > andrew.w.kaylor wrote: > > cameron.

[clang] 55d7b22 - [ASTMatchers] Make test more clear about what it is verifying

Author: Stephen Kelly Date: 2020-01-10T19:47:12Z New Revision: 55d7b22277e1c5e710bac7d4d4dc09db3a22dad8 URL: https://github.com/llvm/llvm-project/commit/55d7b22277e1c5e710bac7d4d4dc09db3a22dad8 DIFF: https://github.com/llvm/llvm-project/commit/55d7b22277e1c5e710bac7d4d4dc09db3a22dad8.diff LOG:

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Fine with me. I just wanted -target powerpcspe-... to work with D72014 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGba91dffafe4d: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72433/new/ htt

[clang] ba91dff - [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

Author: Fangrui Song Date: 2020-01-10T11:43:17-08:00 New Revision: ba91dffafe4d348b469d8ae2b7b1cd00754f72f1 URL: https://github.com/llvm/llvm-project/commit/ba91dffafe4d348b469d8ae2b7b1cd00754f72f1 DIFF: https://github.com/llvm/llvm-project/commit/ba91dffafe4d348b469d8ae2b7b1cd00754f72f1.diff

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + andrew.w.kaylor wrot

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 5 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: aaron.ballman, alexfh, hokein. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. I added subsubsections for typical Clang-tidy entries in Release Notes, so no

[PATCH] D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf28972facc1f: [clang] Fix out-of-bounds memory access in ComputeLineNumbers (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https:/

[clang] f28972f - [clang] Fix out-of-bounds memory access in ComputeLineNumbers

Author: Jan Korous Date: 2020-01-10T11:22:41-08:00 New Revision: f28972facc1fce9589feab9803e3e8cfad01891c URL: https://github.com/llvm/llvm-project/commit/f28972facc1fce9589feab9803e3e8cfad01891c DIFF: https://github.com/llvm/llvm-project/commit/f28972facc1fce9589feab9803e3e8cfad01891c.diff LO

[PATCH] D71124: [RISCV] support clang driver to select cpu

evandro added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; Strange formatting...

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + cameron.mcinally wrote: > andrew.w.kaylor wrote: > >

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:16 + Default is an empty string. + The check will detect the following memory setting function: + ``memset`` This repeats first sentence in docume

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237393. njames93 marked 3 inline comments as done. njames93 added a comment. - Fixed more documentation nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: c

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + andrew.w.kaylor wrote: > arsenm wrote: > > andrew.w

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:14 + + Specify extra functions to flag on that act similarily to memset. + Default is an empty string Please enclose memset in double back-ticks. Sam

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. Related commit that moves to alpha: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 __

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro marked 2 inline comments as done. rhiro added a comment. I addressed the inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://reviews.llvm.org/D72414 ___ cfe-commits

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237390. njames93 marked 3 inline comments as done. njames93 added a comment. - Fix format of options docs and remove unnecessary empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://revi

[clang] 13ec473 - [analyzer] Move PlacementNewChecker to alpha

Author: Gabor Marton Date: 2020-01-10T19:35:25+01:00 New Revision: 13ec473b9d4bd4f7a558272932b7c0806171c666 URL: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666 DIFF: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666.diff

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro updated this revision to Diff 237389. rhiro added a comment. Fixed the condition for the varDecl case and made the cxxThisExpr more concise. - Condition on `capturesVariable` instead of `capturesThis` and switch the loop in the cxxThisExpr overload to use llvm::any_of instead of an explici

  1   2   3   >