[PATCH] D67897: Fix __is_signed builtin

rsmith added a comment. Thanks! Comment at: clang/docs/LanguageExtensions.rst:1165 Note that this currently returns true for enumeration types if the underlying - type is signed, and returns false for floating-point types, in violation of - the requirements for ``std::is_s

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

owenpan added a comment. I suppose the .clang-format file you used only had `BasedOnStyle: LLVM` in it. Did you run clang-format the second time to ensure that the formatted file was stable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 __

r372541 - For P0784R7: add further testing of requirements on constexpr

Author: rsmith Date: Sun Sep 22 22:08:55 2019 New Revision: 372541 URL: http://llvm.org/viewvc/llvm-project?rev=372541&view=rev Log: For P0784R7: add further testing of requirements on constexpr destructors. Added: cfe/trunk/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/dtor.cpp Added: cfe/trunk/t

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67901 Files: clang-tools-extra/c

[PATCH] D67897: Fix __is_signed builtin

zoecarver updated this revision to Diff 221253. zoecarver added a comment. - fix behavior when passed an enumeration type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ https://reviews.llvm.org/D67897 Files: clang/docs/LanguageExtensio

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221252. plotfi added a comment. Adding back -c. Fixing driver for .ifs files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h

r372538 - For P0784R7: add support for constexpr destructors, and call them as

Author: rsmith Date: Sun Sep 22 20:48:44 2019 New Revision: 372538 URL: http://llvm.org/viewvc/llvm-project?rev=372538&view=rev Log: For P0784R7: add support for constexpr destructors, and call them as appropriate during constant evaluation. Note that the evaluator is sometimes invoked on incompl

[PATCH] D67897: Fix __is_signed builtin

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D67897#1678420 , @zoecarver wrote: > > (Can I interest you in fixing the misbehaviour for enumeration types too?) > > Certainly. You mean that `__is_

[PATCH] D67897: Fix __is_signed builtin

zoecarver updated this revision to Diff 221247. zoecarver added a comment. - fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ https://reviews.llvm.org/D67897 Files: clang/docs/LanguageExtensions.rst clang/lib/Sema/SemaExprCXX.

[PATCH] D67897: Fix __is_signed builtin

zoecarver added a comment. > (Can I interest you in fixing the misbehaviour for enumeration types too?) Certainly. You mean that `__is_signed` should return false for enumeration types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ htt

[PATCH] D67899: Fix __is_fundamental to accept nullptr_t

zoecarver created this revision. zoecarver added reviewers: rsmith, EricWF, efriedma, craig.topper, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates the __is_fundamental builtin type trait to return true for nullptr_t. Repository: rG LLVM G

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl added a comment. In D67509#1677722 , @yaxunl wrote: > In D67509#1677586 , @yaxunl wrote: > > > In D67509#1677528 , @tra wrote: > > > > > Looks like CUDA test-suite is

[PATCH] D67897: Fix __is_signed builtin

Quuxplusone added a comment. In D67897#1678392 , @rsmith wrote: > In D67897#1678388 , @Quuxplusone > wrote: > > > But `std::is_signed_v` needs to yield `false`. > > > It should yield `true`; the spec says "If is_­a

[PATCH] D67897: Fix __is_signed builtin

rsmith added a comment. In D67897#1678388 , @Quuxplusone wrote: > But `std::is_signed_v` needs to yield `false`. It should yield `true`; the spec says "If is_­arithmetic_­v is true, the same result as T(-1) < T(0); otherwise, false". Repository: rG

[PATCH] D67897: Fix __is_signed builtin

zoecarver added a comment. In D67897#1678388 , @Quuxplusone wrote: > But `std::is_signed_v` needs to yield `false`. Isn't it cleaner to > leave the compiler builtin matching the library type-trait, so that the > library doesn't have to check for integral

[PATCH] D67897: Fix __is_signed builtin

rsmith added a comment. Looks good, but please also update http://clang.llvm.org/docs/LanguageExtensions.html#type-trait-primitives (Can I interest you in fixing the misbehaviour for enumeration types too?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D67897: Fix __is_signed builtin

Quuxplusone added a comment. But `std::is_signed_v` needs to yield `false`. Isn't it cleaner to leave the compiler builtin matching the library type-trait, so that the library doesn't have to check for integral types separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r372534 - [X86] Require last argument to LWPINS/LWPVAL builtins to be an ICE. Add ImmArg to the llvm intrinsics.

Author: ctopper Date: Sun Sep 22 16:48:50 2019 New Revision: 372534 URL: http://llvm.org/viewvc/llvm-project?rev=372534&view=rev Log: [X86] Require last argument to LWPINS/LWPVAL builtins to be an ICE. Add ImmArg to the llvm intrinsics. Update the isel patterns to use timm instead of imm. Modif

[PATCH] D67897: Fix __is_signed builtin

zoecarver created this revision. zoecarver added reviewers: EricWF, rsmith, erichkeane, craig.topper, efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the __is_signed builtin type trait to work with floating point types. Now, the builtin will retur

r372533 - [NFC] Fixed failed test

Author: xbolva00 Date: Sun Sep 22 15:15:11 2019 New Revision: 372533 URL: http://llvm.org/viewvc/llvm-project?rev=372533&view=rev Log: [NFC] Fixed failed test Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.cpp Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.cpp URL:

[PATCH] D67889: [clang] fixing conditional explicit for out-of-line definition PR42980

This revision was automatically updated to reflect the committed changes. Closed by commit rL372530: [clang] fixing conditional explicit for out-of-line definition PR42980 (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r372531 - [Diagnostics] Warn if ?: with integer constants always evaluates to true

Author: xbolva00 Date: Sun Sep 22 15:00:48 2019 New Revision: 372531 URL: http://llvm.org/viewvc/llvm-project?rev=372531&view=rev Log: [Diagnostics] Warn if ?: with integer constants always evaluates to true Extracted from D63082. GCC has this warning under -Wint-in-bool-context, but as noted in

r372530 - [clang] fixing conditional explicit for out-of-line definition PR42980

Author: tyker Date: Sun Sep 22 14:59:10 2019 New Revision: 372530 URL: http://llvm.org/viewvc/llvm-project?rev=372530&view=rev Log: [clang] fixing conditional explicit for out-of-line definition PR42980 Summary: not every read in CXXConstructorDecl::getExplicitSpecifierInternal() was made on the

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

This revision was automatically updated to reflect the committed changes. Closed by commit rL372527: [clang] [Basic] Enable __has_feature(leak_sanitizer) (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r372527 - [clang] [Basic] Enable __has_feature(leak_sanitizer)

Author: mgorny Date: Sun Sep 22 13:55:01 2019 New Revision: 372527 URL: http://llvm.org/viewvc/llvm-project?rev=372527&view=rev Log: [clang] [Basic] Enable __has_feature(leak_sanitizer) Add a 'leak_sanitizer' feature akin to existing '*_sanitizer' features to let programmers switch code paths acc

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

RKSimon added a comment. @erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67854/ne

[PATCH] D67883: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index()

This revision was automatically updated to reflect the committed changes. Closed by commit rL372516: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index() (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

r372516 - [CLANG][BPF] permit any argument type for __builtin_preserve_access_index()

Author: yhs Date: Sun Sep 22 10:33:48 2019 New Revision: 372516 URL: http://llvm.org/viewvc/llvm-project?rev=372516&view=rev Log: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index() Commit c15aa241f821 ("[CLANG][BPF] change __builtin_preserve_access_index() signature") cha

[PATCH] D67883: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index()

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. I tested few different examples. Generated code and relocations look good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67883/new/ https://reviews.ll

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67385/new/ https://reviews.llvm.org/D67385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67889: [clang] fixing conditional explicit for out-of-line definition PR42980

Tyker created this revision. Tyker added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. not every read in CXXConstructorDecl::getExplicitSpecifierInternal() was made on the canonical declaration. Repository: rC Clang https://reviews.l

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay updated this revision to Diff 221214. MyDeveloperDay added a comment. wrong patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp ==

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. It is annoying that the clang-format tests aren't themselves clang-formatted, if you use a format on save option in VS o

r372497 - Clang-format: Add Whitesmiths indentation style

Author: paulhoad Date: Sun Sep 22 05:00:34 2019 New Revision: 372497 URL: http://llvm.org/viewvc/llvm-project?rev=372497&view=rev Log: Clang-format: Add Whitesmiths indentation style Summary: This patch adds support for the Whitesmiths indentation style to clang-format. It’s an update to a patch

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

This revision was automatically updated to reflect the committed changes. Closed by commit rL372497: Clang-format: Add Whitesmiths indentation style (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r372495 - Move classes into anonymous namespaces. NFC.

Author: d0k Date: Sun Sep 22 02:28:47 2019 New Revision: 372495 URL: http://llvm.org/viewvc/llvm-project?rev=372495&view=rev Log: Move classes into anonymous namespaces. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/Mal

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:15 + +void tools::ifstool::Merger::ConstructJob(Compilation &C, const JobAction &JA, + const InputInfo &Outpu

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221210. plotfi marked an inline comment as done. plotfi added a comment. fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driv

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 7 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +