zoecarver added a comment. In D67897#1678388 <https://reviews.llvm.org/D67897#1678388>, @Quuxplusone wrote:
> But `std::is_signed_v<float>` needs to yield `false`. Isn't it cleaner to > leave the compiler builtin matching the library type-trait, so that the > library doesn't have to check for integral types separately? The idea is that these will match the standard. I don't see anywhere where the standard says that floating-point types yield `false`. The currently libc++ implementation also yields true for your example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ https://reviews.llvm.org/D67897 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
