[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added reviewers: lebedev.ri, vsk. lebedev.ri added a comment. This is marked as child revision of D65300 but it seems like they both add the same logic, just into different components, D65300 to clang, this to llvm. I

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff added a comment. > The thing that makes the IR semantically incomplete is that there is nothing > there to prevent incorrect code motion of the non-constrained operations. > Consider this case: > > if (someCondition) { > #pragma clang fp rounding(downward) > fesetround(FE_DO

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan created this revision. owenpan added reviewers: sammccall, MyDeveloperDay, klimek, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fixes a buggy test case. See PR42404 Repository: rC Clang https://reviews.llvm.org/D66332 Files: clang/lib/Format

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran updated this revision to Diff 215537. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix tests that were going to fail in Windows. Fix tests broken after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66298/new/ https://review

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

This revision was automatically updated to reflect the committed changes. Closed by commit rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛 (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea created this revision. aganea added reviewers: rnk, aprantl. aganea added a project: clang. Previously, when clang was compiled with -DLLVM_ENABLE_ASSERTIONS=ON, the attached test was yielding: inlinable function call in a function with debug info must have a !dbg location call voi

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso updated this revision to Diff 215525. Charusso marked an inline comment as done. Charusso added a comment. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://reviews.llvm.org/D66267 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang

r369078 - [analyzer] Analysis: Silence checkers

Author: charusso Date: Thu Aug 15 18:53:14 2019 New Revision: 369078 URL: http://llvm.org/viewvc/llvm-project?rev=369078&view=rev Log: [analyzer] Analysis: Silence checkers Summary: This patch introduces a new `analyzer-config` configuration: `-analyzer-config silence-checkers` which could be use

[PATCH] D66042: [analyzer] Analysis: Silence checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL369078: [analyzer] Analysis: Silence checkers (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[clang-tools-extra] r369078 - [analyzer] Analysis: Silence checkers

Author: charusso Date: Thu Aug 15 18:53:14 2019 New Revision: 369078 URL: http://llvm.org/viewvc/llvm-project?rev=369078&view=rev Log: [analyzer] Analysis: Silence checkers Summary: This patch introduces a new `analyzer-config` configuration: `-analyzer-config silence-checkers` which could be use

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

This revision was automatically updated to reflect the committed changes. Closed by commit rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛 (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added a comment. Thanks for the reviews! Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::ve

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215518. Charusso marked 10 inline comments as done. Charusso added a comment. - Rebased. - Added the remaining FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/Cl

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types in DynamicTypeMap

Charusso added a comment. @xazax.hun It is somehow performance critical code as we have too many casts in the LLVM. I would really appreciate it if you could review it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 _

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types in DynamicTypeMap

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Charusso added a comment. Charusso added a parent revis

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. You seem to have diffed against your latest local commit, rather than against trunk (or master, if you use the monorepo). Phabricator isn't smart enough to put two and two together, and only displays the uploaded diff (though one has to admit, its doing a damn good jo

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL369075: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r369075 - [clang-doc] Serialize inherited attributes and methods

Author: diegoastiazaran Date: Thu Aug 15 17:10:49 2019 New Revision: 369075 URL: http://llvm.org/viewvc/llvm-project?rev=369075&view=rev Log: [clang-doc] Serialize inherited attributes and methods clang-doc now serializes the inherited attributes and methods, not only the name of the base class.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth created this revision. paulkirth added reviewers: phosek, leonardchan, jakehehrlich, mcgrathr. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. paulkirth added a parent revision: D65300: [clang] [CodeGen] clang-misexpect prototyp

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry added a comment. As far as I can tell this case was just overlooked. The original commit adding this change https://reviews.llvm.org/rG0208793e41018ac168412a3da8b2fba70aba9716 only allows chars to int and chars to chars. Another commit ignores typing of chars https://reviews.

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215506. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66238/new/ https://reviews.llvm.org/D66238 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1898-1900 + // If the contents are symbolic and null, find out when they became null. + if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true)) +if (LVState->isNull(V).

[PATCH] D63889: Check possible warnings on global initializers for reachability

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1684-1686 + void pushDeclForInitializer(Decl *D) { DeclForInitializer.push_back(D); } + + void popDeclForInitializer() { DeclForInitializer.pop_back(); } I don't think a simple list of th

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215504. jdoerfert added a comment. Extracted CaptureTracking changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attribu

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rL369068: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[clang-tools-extra] r369068 - [clang-doc] Sort index elements case insensitive

Author: diegoastiazaran Date: Thu Aug 15 16:32:12 2019 New Revision: 369068 URL: http://llvm.org/viewvc/llvm-project?rev=369068&view=rev Log: [clang-doc] Sort index elements case insensitive Implement logic to compare the references of the index case insensitive. Differential revision: https://r

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215498. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h llvm/lib/Analysis/C

[clang-tools-extra] r369065 - [clang-doc] Fix use of source-root flag

Author: diegoastiazaran Date: Thu Aug 15 16:20:42 2019 New Revision: 369065 URL: http://llvm.org/viewvc/llvm-project?rev=369065&view=rev Log: [clang-doc] Fix use of source-root flag The value, if any, of --source-root flag was not being used. This has been fixed and the logic was moved to the Cla

[PATCH] D66268: [clang-doc] Fix use of source-root flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL369065: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso marked an inline comment as done. Charusso added a comment. @Szelethus pointed out well. My patch is about nullability, and it is perfect. The bug report you made is about deduplication rather than nullability. The fact is we fail to call the deduplication function: `eventsDescribeSame

[PATCH] D66151: [clang-doc] Fix bitcode writer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r369063 - [clang-doc] Fix bitcode writer for access specifiers

Author: diegoastiazaran Date: Thu Aug 15 16:04:27 2019 New Revision: 369063 URL: http://llvm.org/viewvc/llvm-project?rev=369063&view=rev Log: [clang-doc] Fix bitcode writer for access specifiers Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo.

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

Bigcheese requested changes to this revision. Bigcheese added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/SourceManager.h:1024 + Optional getFileEntryRefForID(FileID FID) const { +bool MyInvalid = false; +const Sr

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. In D66267#1632164 , @NoQ wrote: > In D66267#1630728 , @Szelethus wrote: > > > Shouldn't we just delete this entire visitor altogether and merge it into > > ConditionBRVisitor (like, event

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. Thanks! This looks very useful. Comment at: clang/lib/Analysis/CallGraph.cpp:97-102 +const auto *ConstructedType = Ctor->getParent(); +if (ConstructedType->hasUserDeclaredDestructor()) { + CXXDestructorDecl *Dtor = ConstructedType->getDestructo

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

andrew.w.kaylor added a comment. In D66092#1630997 , @sepavloff wrote: > Replacement of floating point operations with constrained intrinsics seems > more an optimization helper then a semantic requirement. IR where constrained > operations are mixed wit

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ added a comment. In D66267#1630728 , @Szelethus wrote: > Shouldn't we just delete this entire visitor altogether and merge it into > ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic > of the past. I'm actually curious ab

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This code is super messy. It'd be great to actually test this change on something to see if it has any unwanted side effects. Could you see if it also fixes https://bugs.llvm.org/show_bug.cgi?id=429

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL369049: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369049 - [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

Author: jdenny Date: Thu Aug 15 14:17:48 2019 New Revision: 369049 URL: http://llvm.org/viewvc/llvm-project?rev=369049&view=rev Log: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug I'd like to add these comments to warn others of problems I encountered when trying to use `RemoveLine

[PATCH] D59692: [ASTImporter] Fix name conflict handling

shafik added a comment. Just wanted to see if you were planning on landing this soon, the fix `Name` -> `SearchName` is probably an important one since we have seen several issues w/ bugs like that but I really would like to see more tests. Are you having issues coming up w/ tests? Repository

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6622 +return false; + const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl(); + if (!FD->isInStdNamespace() || !RD || !RD->isInStdNamespace()) Maybe move the `Callee->

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3758 +static QualType +getFixedEnumUnderlayingType(const StandardConversionSequence &SCS) { + Underlaying -> Underlying (here and below) Comment at: clang/lib/Sema/SemaOv

[PATCH] D65997: Add options rounding and exceptions to pragma fp

andrew.w.kaylor added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3127 The pragma can take three values: ``on``, ``fast`` and ``off``. The ``on`` option is identical to using ``#pragma STDC FP_CONTRACT(ON)`` and it allows This part of the

r369044 - Mark the test as unsupported on darwin, NFC.

Author: abataev Date: Thu Aug 15 13:31:47 2019 New Revision: 369044 URL: http://llvm.org/viewvc/llvm-project?rev=369044&view=rev Log: Mark the test as unsupported on darwin, NFC. The bundler may fail on darwin, mark the test as not compatible. Modified: cfe/trunk/test/Driver/clang-offload-bu

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel updated this revision to Diff 215462. jcranmer-intel added a comment. I've rolled the relevant call graph analysis changes from the prior commit into this updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 Files: cl

Re: [PATCH] D66296: [BUNDLER]Improve the test, NFC.

Will fix this shortly. - Best regards, Alexey Bataev 15.08.2019 16:23, Azhar Mohammed пишет: > Seeing this now: > > fatal error: error in backend: Global variable '' has an invalid > section specifier > '__CLANG_OFFLOAD_BUNDLE__host-x86_64-apple-darwin17.6.0': mach-o > section specifi

Re: [PATCH] D66296: [BUNDLER]Improve the test, NFC.

Seeing this now: fatal error: error in backend: Global variable '' has an invalid section specifier '__CLANG_OFFLOAD_BUNDLE__host-x86_64-apple-darwin17.6.0': mach-o section specifier requires a segment whose length is between 1 and 16 characters. <>clang-10: error: clang frontend command faile

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I was hoping to be able reproduce this in LLDB via an expression like this: expr testImportOfDelegateConstructor(10) == 10 but it does not. I am assuming the test ctu test case invokes the i

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; kpn wrote: > Wait, so "fast" and "precise" are the same thi

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 215457. Mordante added a comment. Add the proper markers in the unit test to update `cxx_dr_status.html`. As discussed on IRC; the up to date `cwg_index.html` is not public, so I only updated the unit test and removed the changes to `cxx_dr_status.html`.

r369043 - [Sema] Implement DR2386 for C++17 structured binding

Author: rnk Date: Thu Aug 15 12:45:28 2019 New Revision: 369043 URL: http://llvm.org/viewvc/llvm-project?rev=369043&view=rev Log: [Sema] Implement DR2386 for C++17 structured binding Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

This revision was automatically updated to reflect the committed changes. Closed by commit rL369043: [Sema] Implement DR2386 for C++17 structured binding (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng abandoned this revision. pzheng added a comment. Hi Sam, Thanks for pointing me to the patch. I can abandon this one now. Pengxuan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66266/new/ https://reviews.llvm.org/D66266

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

This revision was automatically updated to reflect the committed changes. Closed by commit rL369042: [WebAssembly] Correctly handle va_arg of zero-sized structures (authored by quantum, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369042 - [WebAssembly] Correctly handle va_arg of zero-sized structures

Author: quantum Date: Thu Aug 15 12:33:36 2019 New Revision: 369042 URL: http://llvm.org/viewvc/llvm-project?rev=369042&view=rev Log: [WebAssembly] Correctly handle va_arg of zero-sized structures Summary: D66168 passes size 0 structs indirectly, while the wasm backend expects it to be passed dir

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with minor adjustments to the test. Comment at: clang/test/CXX/drs/dr23xx.cpp:43-57 +#if __cplusplus >= 201707L +// Otherwise, if the qualified-id std::tuple_size names

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. (just want to mark it as "unanswered questions") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev added a comment. In D66296#1632003 , @azharudd wrote: > Looks like this is failing on Darwin: > > http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404 > > > /Users/

RE: QualType

Usually the cfe-dev mailing list is better for questions like this. The type “int” is ASTContext::IntTy. You can use QualType::withConst to add a “const” qualifier, and ASTContext::getPointerType to construct a pointer type. Putting that together, you can construct a “const int*” with somethin

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

azharudd added a comment. Looks like this is failing on Darwin: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404 /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/t

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added inline comments. Comment at: clang/docs/UsersManual.rst:1307 + + ``precise `` Disables optimizations that are not value-safe on + floating-point data, although FP contraction (FMA) is enabled. Extra spaces? Comment at: clang/li

r369035 - Rename this file from cx2.c to c2x.c; NFC.

Author: aaronballman Date: Thu Aug 15 11:37:30 2019 New Revision: 369035 URL: http://llvm.org/viewvc/llvm-project?rev=369035&view=rev Log: Rename this file from cx2.c to c2x.c; NFC. Added: cfe/trunk/test/Sema/attr-c2x.c - copied unchanged from r369034, cfe/trunk/test/Sema/attr-cx2.c Rem

r369033 - Allow standards-based attributes to have leading and trailing underscores.

Author: aaronballman Date: Thu Aug 15 11:35:44 2019 New Revision: 369033 URL: http://llvm.org/viewvc/llvm-project?rev=369033&view=rev Log: Allow standards-based attributes to have leading and trailing underscores. This gives library implementers a way to use standards-based attributes that do no

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante updated this revision to Diff 215448. Mordante added a comment. Updated the unit tests as requested. This required the `Sema::ActOnParamDefaultArgument` to delay a part of the ODR validation until the default argument has been 'instantiated'. As discussed on IRC; the up to date `cwg_ind

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61466/new/ https://reviews.llvm.org/D61466 ___ cfe-commits mailing list cf

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

aaron.ballman added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > > thi

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > > this b

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

kees added a comment. For latest version see https://reviews.llvm.org/D64838 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry added a comment. In D66186#1630427 , @aaron.ballman wrote: > There was a request in the linked bug for some code archaeology to see why > this behavior exists in the first place. What were the results of that? I'm > not opposed to the

r369028 - Fix the test, NFC.

Author: abataev Date: Thu Aug 15 10:53:49 2019 New Revision: 369028 URL: http://llvm.org/viewvc/llvm-project?rev=369028&view=rev Log: Fix the test, NFC. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-bundler.c URL: http://llvm.org/viewv

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk updated this revision to Diff 215442. rnk added a comment. - add DR test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.decl/dcl.decomp

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx updated this revision to Diff 215433. chrish_ericsson_atx added a comment. Follow-up on reviewer feedback. Changed from blacklisting LValueToRValue to whitelisting IntegralCast. This was a good call -- additional testing with different cast kinds showed that the assertion t

[PATCH] D64811: Warn when NumParams overflows

Mordante updated this revision to Diff 215425. Mordante added a comment. Moved the testing from Parse to Sema. Added additional safeguards for template instantiation. Added more unit tests. The comments may be a bit noisy, but they explain why the templates need to be tested at two locations. C

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369019: [Driver][Bundler] Improve bundling of object files. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

r369020 - Test commit #2.

Author: george.karpenkov Date: Thu Aug 15 10:17:21 2019 New Revision: 369020 URL: http://llvm.org/viewvc/llvm-project?rev=369020&view=rev Log: Test commit #2. Modified: cfe/trunk/www/index.html Modified: cfe/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/index.h

r369019 - [Driver][Bundler] Improve bundling of object files.

Author: abataev Date: Thu Aug 15 10:15:35 2019 New Revision: 369019 URL: http://llvm.org/viewvc/llvm-project?rev=369019&view=rev Log: [Driver][Bundler] Improve bundling of object files. Summary: Previously, object files were bundled using partial linking. It resulted in the following structure of

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG, thanks for the changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 ___

Re: r368874 - Document clang-cpp in the release notes for clang

It actually does not. Getting the MSVC export list is a much harder problem. I'll update the release note. -Chris > On Aug 14, 2019, at 10:32 PM, Kim Gräsman wrote: > > On Wed, Aug 14, 2019 at 6:48 PM Chris Bieneman via cfe-commits > wrote: >> >> Author: cbieneman >> Date: Wed Aug 14 09:49:5

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. Oh, there is no need for a new differential, you can update this one by clicking on 'update diff' in the right panel. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014 _

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215421. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c tools/clang-offload-bundler/ClangOffloadBundler.

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. Yup, you can upload it and the green checkmark will stay. If it doesn't, I'll accept again. I think there was one case when I added like 800 extra LOCs to a patch and phabricator automatically marked it as "needs reviews", but I never came across this after that, eve

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369015: [BUNDLER]Improve the test, NFC. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx marked 5 inline comments as done. chrish_ericsson_atx added a comment. In D66014#1627858 , @Szelethus wrote: > LGTM, thanks! Do you need someone to commit this on your behalf? Also, could > you please make the comments capitalized, ter

r369015 - [BUNDLER]Improve the test, NFC.

Author: abataev Date: Thu Aug 15 09:28:24 2019 New Revision: 369015 URL: http://llvm.org/viewvc/llvm-project?rev=369015&view=rev Log: [BUNDLER]Improve the test, NFC. Summary: Make the test more portable and do not rely on the pre-bundled object file. Reviewers: Hahnfeld, hfinkel, jdoerfert Subs

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66003/new/ https://reviews.llvm.org/D66003

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

xazax.hun created this revision. xazax.hun added reviewers: mgehre, gribozavr. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. This patch adds support to the idiom when people using the free version of `begin`, `end` and the like inste

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk marked an inline comment as done. rnk added a comment. In D66040#1631658 , @thakis wrote: > rnk, what's the status here? I think I can get this in today, things just got busy here and I forgot about this. I have to add that test.

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

thakis added a comment. rnk, what's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Ok, makes sense, thanks for explaining. Please add a summary of that discussion to the patch description / commit message :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 _

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin created this revision. kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov. Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following inline asm constraints for SVE: -

[PATCH] D66298: [clang-doc] Fix records in global namespace

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299 RecordInfo *G = InfoAsRecord(Infos[2].get()); - RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E"); + RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"Gl

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } luismarques wrote: > When I compile a bare metal GNU toolchain (using >

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

svenvh added inline comments. Comment at: docs/ReleaseNotes.rst:173 + +- Added initial support for implicitly including OpenCL BIFs using + efficient trie lookup generated by TableGen. A corresponding mantognini wrote: > If the BIF acronym wasn't introduced befo

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } When I compile a bare metal GNU toolchain (using

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini requested changes to this revision. mantognini added a comment. This revision now requires changes to proceed. The overall structure seems alright. I'll let people more familiar with the code-base judge whether other important features should be added there as well.

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66296/new/ https://reviews.llvm.org/D66296 ___ cfe-commits

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. Implement logic to compare the references of the index case insensitive. https://reviews.llvm.org/D66299 F

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now one

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev created this revision. ABataev added reviewers: Hahnfeld, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make the test more portable and do not rely on the pre-bundled object file. Repository: rC Clang https://reviews.llvm.org/D66296 Files: test/Driver/

  1   2   >