[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

MaskRay added a comment. In D64666#1600445 , @ziangwan wrote: > Update diff. > > 1. Fix 2 failing test cases. I omitted these two. My mistake. > 2. Fix trailing whitespaces. > > Okay? error: constant expression evaluates to 123456789 which cannot b

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 211666. ziangwan added a comment. Update diff. 1. Fix 2 failing test cases. I omitted these two. My mistake. 2. Fix trailing whitespaces. Okay? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: cla

r366979 - Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss"

Author: phosek Date: Wed Jul 24 20:11:49 2019 New Revision: 366979 URL: http://llvm.org/viewvc/llvm-project?rev=366979&view=rev Log: Revert "[Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss" This reverts commit r366972 which broke the following tests: Cl

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. Reverted in r366979. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak updated this revision to Diff 211663. ahatanak marked an inline comment as done. ahatanak added a comment. Check that the attributed type is an ObjC qualified type. Do not diagnose fields that are unavailable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1600354 , @phosek wrote: > I'm seeing some test failures which appear to have been introduced by this > change: > > TEST 'Clang :: > CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp' FAILED

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song abandoned this revision. yonghong-song added a comment. abandon this one. A revised version with most tests has been merged. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 _

[PATCH] D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

yonghong-song closed this revision. yonghong-song added a comment. The commit has been merged. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64598/new/ https://reviews.llvm.org/D64598 ___ cfe-commits mailing list cfe

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16379 + !getLangOpts().CPlusPlus && !FD->hasAttr() && + !FD->getType()->getAs()) { + // For backward compatibility, fields of C unions dec

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

phosek added a comment. I'm seeing some test failures which appear to have been introduced by this change: TEST 'Clang :: CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/ir/k/recipe_cleanup/clango5z

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +//

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi updated this revision to Diff 211652. plotfi added a comment. Removing 'A' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65176/new/ https://reviews.llvm.org/D65176 Files: clang/include/clang/Driver/Types.def clang/lib/Driver/Types.cpp

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 211651. plotfi marked an inline comment as done. plotfi added a comment. Removing 'A' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added a comment. This was a mistake. Updated the Wrong diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16379 + !getLangOpts().CPlusPlus && !FD->hasAttr() && + !FD->getType()->getAs()) { + // For backward compatibility, fields of C unions declared in system This ch

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

This revision was automatically updated to reflect the committed changes. Closed by commit rL366972: [Sema] Enable -Wimplicit-float-conversion for integral to floating point… (authored by ziangwan725, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r366972 - [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Author: ziangwan725 Date: Wed Jul 24 17:32:50 2019 New Revision: 366972 URL: http://llvm.org/viewvc/llvm-project?rev=366972&view=rev Log: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss Issue an warning when the code tries to do an implicit int -> float co

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai marked an inline comment as done. smeenai added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args, Cmd

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ updated this revision to Diff 211640. NoQ added a comment. Polish wording a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65250/new/ https://reviews.llvm.org/D65250 Files: clang/test/Analysis/exploded-graph-rewriter/lit.local.cfg clang/utils/analyzer/exploded-graph-rewrite

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ updated this revision to Diff 211639. NoQ added a comment. Make it a soft failure when graphviz is not installed. Display a friendly warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65250/new/ https://reviews.llvm.org/D65250 Files: clang/test/Analysis/exploded-graph-rewrit

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak created this revision. ahatanak added reviewers: rjmccall, jordan_rose. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous, mehdi_amini. r365985 stopped marking those fields as unavailable, which caused the union's NonTrivialToPrimitive* bits to be set to true

[PATCH] D65196: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Oof. Someone had to do it. Comment at: clang/include/clang/Analysis/CFG.h:617 + template + class ElementRef { + Yeah, kinda shocking that you needed to go that

[PATCH] D65254: Allow prefetching from non-zero address spaces

jfb created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jkorous, kbarton, hiraditya, javed.absar, nemanjai. Herald added projects: clang, LLVM. This is useful for targets which have prefetch instructions for non-default address spaces. rdar://problem/42662136

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Change the default behavior: the tool

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change-IWk6CtRl45h6 The rest is side-show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb created this revision. jfb added a reviewer: chandlerc. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, jkorous, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please remove the changes to `Conversion` if they're not needed before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

jfb accepted this revision. jfb added a comment. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 accepted this revision. xbolva00 added a comment. Looks ok Comment at: clang/include/clang/Basic/DiagnosticGroups.td:739 ImplicitFloatConversion, +ImplicitIntFloatConversion, LiteralC

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 211617. ziangwan added a comment. Update diff. 1. Make the two warnings controlled by `-Wimplicit-int-float-conversion`, which is a subset of `-Wimplicit-float-conversion`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.

r366953 - Revert "NFC: utils/perf-training: Python 3 compatibility for lit.cfg"

Author: azhar Date: Wed Jul 24 15:42:50 2019 New Revision: 366953 URL: http://llvm.org/viewvc/llvm-project?rev=366953&view=rev Log: Revert "NFC: utils/perf-training: Python 3 compatibility for lit.cfg" This reverts commit 9178b10163f758cbf8a5290ea6a827990427ddc0 (r365969). We are back to using P

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

joerg added a comment. You lost the changes to lib/Sema/SemaStmtAsm.cpp to actually do the delaying for immediate operands? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 __

[PATCH] D63954: Add lifetime categories attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor formatting nit. Thank you for working on these attributes! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2517 +def err_a

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. In D59963#195 , @dvyukov wrote: > Re more checks. I guess we can borrow some from the existing checkers: > https://www.kernel.org

[PATCH] D63954: Add lifetime categories attributes

mgehre marked 9 inline comments as done. mgehre added inline comments. Comment at: clang/test/SemaCXX/attr-gsl-owner-pointer-parsing.cpp:2 +// RUN: %clang_cc1 -fsyntax-only -verify %s + +int [[gsl::Owner]] i; aaron.ballman wrote: > This file tests part of parsing

[PATCH] D63954: Add lifetime categories attributes

mgehre updated this revision to Diff 211600. mgehre marked an inline comment as done. mgehre added a comment. - Fix all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 Files: clang/include/clang/

[PATCH] D64914: Implement P1771

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:296-301 + if (A) { +StringRef Msg = A->getMessage(); +if (!Msg.empty()) + Diag(Loc, diag::warn_unused_constructor_msg) << A << Msg << R1 << R2; +else + Diag

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thank you for adding the Bye pass. It is really useful! Is there a specific reason to not modify the Hello pass? --- If I enable both passes statically (`LLVM_BYE_LINK_INTO_

[PATCH] D65182: [analyzer] WIP: Add fix-it hint support.

NoQ updated this revision to Diff 211595. NoQ added a comment. Unforget a `FileCheck`-based test file for the virtual call checker that i already had. In D65182#1598614 , @Szelethus wrote: > How does an `-analyzer-config fixits-as-warnings` option sound

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

NoQ added a comment. Aha, great, the overall structure of the code is correct! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:477 + + // For all of the bitwise operations, + // if they remain in that 'SymIntExpr' form that means we cannot evaluate the --

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in r366941, thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 _

r366941 - Fix exporting SARIF files from scan-build on Windows.

Author: aaronballman Date: Wed Jul 24 13:03:27 2019 New Revision: 366941 URL: http://llvm.org/viewvc/llvm-project?rev=366941&view=rev Log: Fix exporting SARIF files from scan-build on Windows. In Perl, -z is defined as checking if a "file has zero size" and makes no mention what it does when giv

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, + CodeGenFunction *CGF = nullptr) override; -

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech added a comment. In D65212#1599841 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

Charusso accepted this revision. Charusso added a comment. When I started programming I read that the programming is British English, but LLVM project has more 'behavior' than 'behaviour', so as being democratic it should be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 211589. lildmh added a comment. Get rid of MSVC requirement of this, and a virtual function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp l

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 211587. NoQ added a comment. One more thing: explain the consequences of the bug, so that it was obvious what the problem is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 ___

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. We do not support evaluating bitwise operations, so that when w

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun updated this revision to Diff 211583. xazax.hun added a comment. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65127/new/ https://reviews.llvm.org/D65127 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/warn-lifetime-analysis-nocfg.cpp Index: clang/test/Sema/w

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211581. xazax.hun added a comment. - Remove unused parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65120/new/ https://reviews.llvm.org/D65120 Files: clang/lib/Sema/SemaInit.cpp clang/test/Analysis/inner-pointer.cpp clang/test/Sema/

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211580. xazax.hun added a comment. - Fix a false positive case found by running over ~200 open source projects CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticS

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 ___ c

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman added a comment. In D64666#1599544 , @jfb wrote: > In D64666#1599524 , @ziangwan wrote: > > > In D64666#1598194 , @jfb wrote: > > > > > Thanks, the update looks

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech updated this revision to Diff 211578. jranieri-grammatech added a comment. Update an additional place that used -z. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 Files: clang/tools/s

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

leonardchan updated this revision to Diff 211572. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65110/new/ https://reviews.llvm.org/D65110 Files: clang/test/CodeGen/avx512-reduceMinMaxIntrin.c clang/

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. glider added reviewers: eli.friedman, jyknight. glider added a subscriber: vitalybuka. The "=r" output constraint for a structure variable passed to inline asm shouldn't be converted to "=*r", as t

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added a comment. In D65043#1599220 , @sammccall wrote: > Clang actually defaults to c++14 since clang 6. (CompilerInvocation.cpp near > `CLANG_DEFAULT_STD_CXX`) Today I learned. Thanks! :) > It's important that clang-format works sensibly w

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

thakis created this revision. thakis added a reviewer: klimek. This is like r305666 (which added support for `if constexpr`) except that it allows a macro name after the if. This is slightly tricky for two reasons: 1. r305666 didn't add test coverage for all cases where it added a kw_constexpr,

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jordan_rose added a comment. Oops. It looks like there's another place where this pattern shows up (see rC139382 ). The other one should probably be changed as well. (Thanks for diverging from test(1), perl…) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

jfb added a comment. In D64666#1599524 , @ziangwan wrote: > In D64666#1598194 , @jfb wrote: > > > Thanks, the update looks good. > > > > One thing I just noticed: if I have a codebase with > > `-Wimplicit-float-con

r366929 - clang-format: Add another test like r366926

Author: nico Date: Wed Jul 24 10:15:47 2019 New Revision: 366929 URL: http://llvm.org/viewvc/llvm-project?rev=366929&view=rev Log: clang-format: Add another test like r366926 Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unittests/Format/FormatTest.cpp URL: http://

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1598194 , @jfb wrote: > Thanks, the update looks good. > > One thing I just noticed: if I have a codebase with > `-Wimplicit-float-conversion` it seems like updating clang will automatically > turn the two new warnings

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry updated this revision to Diff 211545. Nathan-Huckleberry added a comment. - Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64678/new/ https://reviews.llvm.org/D64678 Files: clang/lib/Sema/SemaDecl.cpp clang/test/S

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache marked 3 inline comments as done. modocache added a comment. > It sounds like currently they're very different, and you're proposing to make > them basically the same. I think that's a good thing. I 100% agree with this statement, and thank you @sammccall for the suggestion to move in

r366926 - clang-format: Add a test that shows that some code I thought was dead is not dead.

Author: nico Date: Wed Jul 24 10:01:57 2019 New Revision: 366926 URL: http://llvm.org/viewvc/llvm-project?rev=366926&view=rev Log: clang-format: Add a test that shows that some code I thought was dead is not dead. Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unit

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun added a comment. I have run this successfully on ~192 open source projects. The results so far: 1. https://github.com/ANTsX/ANTs/blob/master/Examples/sccan.cxx#L2899 /home/tgahor/data/projects/ANTs/Examples/sccan.cxx:2899:34: warning: object backing the pointer will be destroyed

[PATCH] D65043: [Format] Add C++20 standard to style options

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:76 +IO.enumCase(Value, "C++20", FormatStyle::LS_Cpp20); IO.enumCase(Value, "Auto", FormatStyle::LS_Auto); } Prior to C++20 being confirmed and given the line 2373 being Lan

[PATCH] D64386: CodeGen: Use memset in initializers for non-zeros

hfinkel added inline comments. Comment at: clang/test/CodeGen/init-memset.c:29 char a[] = "aa"; - // CHECK: call void @llvm.memcpy.{{.*}} + // CHECK: call void @llvm.memset.{{.*}} use(a); I'd be

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall updated this revision to Diff 211521. sammccall marked an inline comment as done. sammccall added a comment. Address minor comments, but not tree-traversal simplification yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65139/new/ https

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:213 +//the purposes of calculating the insertion point. +namespace { + SureYeaah wrote: > Why do we need an a

[PATCH] D65149: [Format] Add test demonstrating PR42722

MyDeveloperDay added a comment. We don't normally commit a failing test alone, otherwise the build machines will be broken until it gets fixed.. just add this test with your fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65149/new/ https://rev

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

compnerd added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +// phases::Assemble but not phases::Compi

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211513. AntonBikineev marked an inline comment as not done. AntonBikineev added a comment. Missed that, thanks for the point! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Fil

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) AntonBikineev wrote: > aaron.ballman wrote:

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

This revision was automatically updated to reflect the committed changes. Closed by commit rL366911: [Support] Fix `-ftime-trace-granularity` option (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D65202?vs=211

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211508. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks for the comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files: clang/do

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) aaron.ballman wrote: > I don't think this a

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 211509. Szelethus added a comment. Use the correct sorting for the GEN, KILL, IN and OUT sets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64991/new/ https://reviews.llvm.org/D64991 Files: clang/include/clang/Analysis/Analyses/ReachingDefinit

r366911 - [Support] Fix `-ftime-trace-granularity` option

Author: anton-afanasyev Date: Wed Jul 24 07:55:40 2019 New Revision: 366911 URL: http://llvm.org/viewvc/llvm-project?rev=366911&view=rev Log: [Support] Fix `-ftime-trace-granularity` option Summary: Move `-ftime-trace-granularity` option to frontend options. Without patch this option is showed up

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @lebedev.ri, could you please lgtm this or elaborate on possible issue with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 _

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. In D65043#1599148 , @Quuxplusone wrote: > Peanut gallery says: A priori, I don't see any reason for clang-format's > `LanguageStandard` options to diverge from Clang's own `-std=` options. It > sounds like currently they're ver

[PATCH] D58531: [clang] Specify type of pthread_create builtin

probinson added a reviewer: jdoerfert. probinson added a comment. We've started running into this too in building the PS4 system. +jdoerfert who added pthread_create to the builtin list. Looking at the patch, it seems straightforward enough although clearly needs clang-format-diff run over it.

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211504. erichkeane added a comment. Casting implementation had to happen in SemaStmt, because other 'warn unused result' stuff depends on them being the way they are. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/ https://reviews.llvm.

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:31 InterestedDecl = N->ASTNode.get(); return InterestedDecl; } --

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, jordan_rose, dcoughlin, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald a

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + anton-afanasyev wrote: > sammccall wrote: >

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. After rL366893 , the annoate tweak is not activated when we select the whole file (the

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. jr

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added a comment. Peanut gallery says: A priori, I don't see any reason for clang-format's `LanguageStandard` options to diverge from Clang's own `-std=` options. It sounds like currently they're very different, and you're proposing to make them basically the same. I think that's a g

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. jr

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) I don't think this assertion is reasonable

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev updated this revision to Diff 211489. anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Remove default repeat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1772 Opts.TimeTrace = Args.hasArg(OPT_ftime_trace); + Opts.TimeTraceGranularity = + getLastArgIntValue(Args, OPT_ftime_trace_gra

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added a comment. So, I did like the more exhaustive doc, I thought you'd move it to the code so it also shows up in the generated doc page :) (sorry for not being clearer here) Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637 internal::Match

r366904 - Test commit. NFC.

Author: sjoerdmeijer Date: Wed Jul 24 06:30:36 2019 New Revision: 366904 URL: http://llvm.org/viewvc/llvm-project?rev=366904&view=rev Log: Test commit. NFC. Removed 2 trailing whitespaces in 2 files that used to be in different repos to test my new github monorepo workflow. Modified: cfe/tru

  1   2   >