sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:31
InterestedDecl = N->ASTNode.get<Decl>();
return InterestedDecl;
}
----------------
this is now always true. Just return true (maybe with a comment) and move the
InterestedDecl stuff to apply?
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:493
const char *Output = "void /* entity.name.function.cpp */f() {}";
checkTransform(ID, Input, Output);
}
----------------
check input/output for TUDecl since it's a different codepath?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65210/new/
https://reviews.llvm.org/D65210
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
