[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek added a comment. This is an alternative to D62154 . With just the change to `HandleLLVMOptions.cmake`, we're seeing errors in Analysis plugins due to undefined symbols: error: 'error' diagnostics seen but not expected: (frontend): unable to load plu

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek created this revision. phosek added reviewers: hintonda, vitalybuka, Szelethus. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Repository: rC Clang http

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. Should you also consider Windows path separators here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200401. yaqiji added a comment. Simplified method signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200399. yaqiji marked 2 inline comments as done. yaqiji added a comment. Herald added a subscriber: mgorny. Modified CMakeList to include tests, otherwise clangTidyGoogleModule wouldn't compile. Added k_Alpha test case back. Added Extern case so that if it i

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200393. plotfi added a comment. adding a nice inline test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200389. jkorous marked 4 inline comments as done. jkorous added a comment. Addressed comments. Changed semantics of one of std::atomic in linux implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 36 inline comments as done. jkorous added a comment. I addressed most of the comments. What is left: - rewrite test with gmock matchers - write test for metadata of a file in watched dir being changed Comment at: clang/include/clang/DirectoryWatcher/DirectoryWa

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added a comment. In D62050#1509400 , @vitalybuka wrote: > In D62050#1509384 , @vitalybuka > wrote: > > > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake > > in empty directory)

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 200388. george.burgess.iv added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inc

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Nice, thanks for r361208. As for support -- no, I didn't try that. I was following a pattern I saw elsewhere. Do you suggest that I make that change? If so, any particular way to test it? thanks On Mon, May 20, 2019 at 8:26 PM Nico Weber wrote: > + LLVMSupport > + LLVMTestingSupport > > cla

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. In D62050#1509384 , @vitalybuka wrote: > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in > empty directory) I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right appro

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory) http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21622/steps/check-cfi-and-supported%20in%20gcc%20build/logs/stdio 100%] Running the cfi regression tests

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked an inline comment as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); craig.topper wrote: > skan wrote

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

craig.topper added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); skan wrote: > lebedev.ri wrote: > > xiangzhangllvm wrote: > > >

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked 2 inline comments as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); lebedev.ri wrote: > xiangzhangll

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. Latest change addresses most of issues. Outstanding is adding a test when garbage GuardStyle value is fed into config. The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases. Looking for something similar in the ot

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200380. trixirt added a comment. Change the GuardStyle data type from a string to an enum. Add test cases for explicitly setting valid style. Document valid style values. Reduce llvm-header-guard doc to point to bugprone-header-guard. Repository: rCTE Clan

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

+ LLVMSupport + LLVMTestingSupport clang/unittests/Tooling/CMakeLists already has this at the top: set(LLVM_LINK_COMPONENTS ${LLVM_TARGETS_TO_BUILD} Support ) I think we link Support twice now. Did adding TestingSupport up there not work? I'd expect that your addition would break shared l

r361209 - Try to fix build with older gccs after r361152

Author: nico Date: Mon May 20 17:27:26 2019 New Revision: 361209 URL: http://llvm.org/viewvc/llvm-project?rev=361209&view=rev Log: Try to fix build with older gccs after r361152 Also merge the cmake change there to the gn build. Modified: cfe/trunk/unittests/Tooling/RangeSelectorTest.cpp Mo

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Add static data members to IR debug info's list of global variables so that they are emitted as S_CONSTANT records. Related to https://bu

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman updated this revision to Diff 200376. arphaman added a comment. Remove some outdated commented out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Driv

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

r361208 - Give 'fixit-cxx0x.cpp' a more modern name.

Author: rsmith Date: Mon May 20 16:37:18 2019 New Revision: 361208 URL: http://llvm.org/viewvc/llvm-project?rev=361208&view=rev Log: Give 'fixit-cxx0x.cpp' a more modern name. Added: cfe/trunk/test/FixIt/fixit-c++11.cpp - copied, changed from r361193, cfe/trunk/test/FixIt/fixit-cxx0x.cp

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. Interesting. I think all of the new warnings in the test cases here are undesirable (they duplicate errors produced by the constant evaluator), but the removed warnings all look like improvements. Generally, I think our goals should be: For code patterns that might lead

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. In D62157#1509289 , @juliehockett wrote: > @hintonda Aha so it is :) I don't think it's at all controversial, so I'll commit D61747 tomorrow unless someone raises an issue. Thanks... CHANG

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett abandoned this revision. juliehockett added a comment. @hintonda Aha so it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman added inline comments. Comment at: include/clang/Lex/DependencyDirectivesSourceMinimizer.h:36 + pp_import, + pp_at_import, + pp_pragma_import, Bigcheese wrote: > Is `@import` actually a preprocessor directive? For C++20 modules all the > modules bits

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman updated this revision to Diff 200371. arphaman marked 8 inline comments as done. arphaman added a comment. - Added diagnostic support. - Fixed the issue with C++14 number separators. - Other fixes requested by @Bigcheese . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. If no further comments, I'll commit it for you tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/ https://reviews.llvm

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. Great idea. Please see D61747 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Thanks for bringing this up! I submitted r361205 which should fix this. The problem seemed to be that stripOuterNullability() was missing checks for AttributedTypes that were wrapped in the MacroQualifiedType which this patch introduces, so I just added a check for that type also. The reason replac

r361205 - [Sema] Fix for build on some iOS programs.

Author: leonardchan Date: Mon May 20 15:42:19 2019 New Revision: 361205 URL: http://llvm.org/viewvc/llvm-project?rev=361205&view=rev Log: [Sema] Fix for build on some iOS programs. Nullability attributes weren't being stripped for AttributedTypes that were wrapped in a MacroQualifiedType. This fi

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. Yes, I think we can add something to the release note. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Thank you MaskRay! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. I changed the approach in the last revision. the information is now propagated using the expression evaluation context and then via booleans. I should have added a comment to make it clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews

[PATCH] D62160: [LibTooling] Update Stencil to use RangeSelector

ymandel created this revision. ymandel added a reviewer: sbenza. Herald added a project: clang. Replace Stencil's specialized operators `node` and `sNode` with general support for any RangeSelector. This change allows Stencil to support any RangeSelector and avoids redundancy between the two libr

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

andrew.w.kaylor added inline comments. Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used with constrained floating point + void setDefaultConstrainedExcept(MDNode *NewExcept) { +DefaultConstrainedExcept = NewExcept; I

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea added a comment. In D60568#1508909 , @ABataev wrote: > Looks good, in general. Just one more question: will __tgt_register_requires > be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, > this function should not be called,

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200355. gtbercea added a comment. - Avoid requires registration when no targets are specified. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/LangOption

[PATCH] D62056: Use ASTDumper to dump the AST from clang-query

aaron.ballman added a comment. If you wanted to expand test coverage for the changes covered in this, that would be a good thing. However, I'm not certain how testable the newly colorized output is, which is why this LG as-is. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION h

[PATCH] D62056: Use ASTDumper to dump the AST from clang-query

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62056/new/ https://reviews.llvm.org/D62056 __

[PATCH] D62065: Move dump method implementations to their respective class files

aaron.ballman added inline comments. Comment at: lib/AST/Comment.cpp:378-380 +LLVM_DUMP_METHOD void Comment::dump() const { + dump(llvm::errs(), nullptr, nullptr); +} If we're moving things around, is there a reason we should keep this in a source file as oppos

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. In D62009#1506415 , @Tyker wrote: > there are issues with using ConstantExpr to mark expressions as constant for > semantic checking: > > - #1 multpile Expr::Ignore* operation remove ConstantExpr from the expression. `Ignore*` is

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) { We want to catch `_

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 2 inline comments as done. jkorous added a comment. Thanks for taking a look @gribozavr! I briefly scanned the rest of your comments and I agree with you (or don't really have a strong opinion) in all cases. I'll work on that today. Comment at: clang/lib/Direct

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett created this revision. juliehockett added reviewers: alexfh, hokein. juliehockett added a project: clang-tools-extra. This removes the else clause that adds a default `-header-filter` flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any He

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Another comment: The new binary is called TokensTest but is in a directory "Syntax". For consistency with all other unit test binaries, please either rename the binary to SyntaxTests, or rename the directory to "Tokens". (From the patch description, the former seems more

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests binary while this adds a new binary TokensTest. Can you say why? (No change needed, just curious.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https:

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

efriedma added a comment. Please verify my understanding of the following is correct: 1. getTypeUnadjustedAlign() is currently only used to compute calling convention alignment for ARM and AArch64. 2. Without this patch, we use the unadjusted alignment to pass arguments, but the adjusted alignm

r361187 - [X86] Check the alignment argument for the masked.load/store for the _mm_mask_store_ss/sd and _mm_mask(z)_load_ss/sd intrinsics.

Author: ctopper Date: Mon May 20 11:48:31 2019 New Revision: 361187 URL: http://llvm.org/viewvc/llvm-project?rev=361187&view=rev Log: [X86] Check the alignment argument for the masked.load/store for the _mm_mask_store_ss/sd and _mm_mask(z)_load_ss/sd intrinsics. Modified: cfe/trunk/test/Code

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Hello, it seems this broke building some iOS programs. $ cat test.m # define UI_APPEARANCE_SELECTOR __attribute__((annotate("ui_appearance_selector"))) @class UIColor; @interface Test @property(null_resettable, nonatomic, strong) UIColor *onTintColor UI_APPEARANCE_SELECTOR; @end @implementatio

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attrib

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. Anastasia edited the summary of this revision. Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else { - // C++ [over.match.copy]p1: - // - When initializing a temporary to be bound to the first parameter - // of a constructor [for ty

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

smeenai added a comment. In D61974#1508097 , @ahatanak wrote: > Delete the entire code path that tries to work around a bug in gcc. Should something be added to the release notes for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

r361184 - [CMake] Update DistributionExample for mono repo

Author: cbieneman Date: Mon May 20 11:10:20 2019 New Revision: 361184 URL: http://llvm.org/viewvc/llvm-project?rev=361184&view=rev Log: [CMake] Update DistributionExample for mono repo This just updates the DistributionExamples from my 2016 Dev Meeting talk to work more seamlessly with the monor

r361182 - Rearrange and clean up how we disambiguate lambda-introducers from ObjC

Author: rsmith Date: Mon May 20 11:01:54 2019 New Revision: 361182 URL: http://llvm.org/viewvc/llvm-project?rev=361182&view=rev Log: Rearrange and clean up how we disambiguate lambda-introducers from ObjC message sends, designators, and attributes. Instead of having the tentative parsing phase so

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added a comment. Looks good, in general. Just one more question: will __tgt_register_requires be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, this function should not be called, I think, because we're not going to use offloading at all in this case and __tgt_re

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

This revision was automatically updated to reflect the committed changes. Closed by commit rL361178: [clangd] Make it possible to use VFS from parsing for getting tidy options (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200330. ilya-biryukov added a comment. - Fix another typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang-tools-extra/clangd/ClangdServer.cpp cla

[clang-tools-extra] r361178 - [clangd] Make it possible to use VFS from parsing for getting tidy options

Author: ibiryukov Date: Mon May 20 10:30:46 2019 New Revision: 361178 URL: http://llvm.org/viewvc/llvm-project?rev=361178&view=rev Log: [clangd] Make it possible to use VFS from parsing for getting tidy options Summary: To give an option for clangd embedders with snapshotted filesystem to read co

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200329. ilya-biryukov added a comment. - Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200328. ilya-biryukov added a comment. - Add a typedef for function - Make the provider thread-safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:186 +/// where a \c TextGenerator, \c RangeSelector are otherwise expected. +inline ASTEdit change(RangeSelector Target, std::string Replacem

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel updated this revision to Diff 200325. ymandel added a comment. Removed most `change` overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62149/new/ https://reviews.llvm.org/D62149 Files: clang/include/clang/Tooling/Refactoring/Trans

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn accepted this revision. Lekensteyn added a comment. Verified again! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() hintonda wrote: > This is a breaking patch. What's the rational for u

r361172 - Dump macro expansion information as needed when outputting the AST to JSON.

Author: aaronballman Date: Mon May 20 09:46:44 2019 New Revision: 361172 URL: http://llvm.org/viewvc/llvm-project?rev=361172&view=rev Log: Dump macro expansion information as needed when outputting the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-macro-json.c Modified: cfe/trunk/includ

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

john.brawn created this revision. john.brawn added reviewers: chill, efriedma, t.p.northover, rjmccall. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Overaligned and underaligned types (i.e. types where the alignment has been increased or decreased using the

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() This is a breaking patch. What's the rational for unilaterally disabl

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems fine: - please give this `function<>` type a name - maybe `ClangTidyOptionsBuilder` or so? - while we're defining this, we should make it threadsafe because that's what we re

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

ilya-biryukov added a comment. @ymandel, feel free to change the name to your liking if you don't like `select`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62150/new/ https://reviews.llvm.org/D62150 ___ cfe-commi

[PATCH] D62019: [clang] Handle lrint/llrint builtins

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 ___ cfe-commits mailing list c

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

This revision was automatically updated to reflect the committed changes. Closed by commit rC361170: Renamed `apply` to `select` to avoid ADL conflict with `std::apply` (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D62150?vs=200313&id=200316#toc Repo

r361170 - Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

Author: gribozavr Date: Mon May 20 09:30:49 2019 New Revision: 361170 URL: http://llvm.org/viewvc/llvm-project?rev=361170&view=rev Log: Renamed `apply` to `select` to avoid ADL conflict with `std::apply` Summary: `std::apply` in C++14 and above is defined with two unrestricted arguments, and it w

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Quick LGTM to unbreak our integrate! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62150/new/ https://reviews.llvm.org/D62150 _

[PATCH] D62151: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D62151 Files: clangd/refactor/tweaks/CM

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. `std::apply` in C++14 and above is defined with two unrestricted arguments, and it wins overload resolution in this case. Repository: rG LLVM Githu

r361169 - [Intrinsics] Merge lround.i32 and lround.i64 into a single intrinsic with overloaded result type. Make result type for llvm.llround overloaded instead of fixing to i64

Author: ctopper Date: Mon May 20 09:27:09 2019 New Revision: 361169 URL: http://llvm.org/viewvc/llvm-project?rev=361169&view=rev Log: [Intrinsics] Merge lround.i32 and lround.i64 into a single intrinsic with overloaded result type. Make result type for llvm.llround overloaded instead of fixing t

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ilya-biryukov added a comment. Looks neat! The only concern I have is about the growing number of overloads in `Transformer.h`, see the relevant comment. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:186 +/// where a \c TextGenerator, \c RangeSelector are o

[PATCH] D61963: [clang][Darwin] Refactor header search path logic into the driver

ldionne updated this revision to Diff 200311. ldionne added a comment. Fix test that fails on systems that don't have /usr/include/c++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61963/new/ https://reviews.llvm.org/D61963 Files: clang/include

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel updated this revision to Diff 200310. ymandel added a comment. reordered some declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62149/new/ https://reviews.llvm.org/D62149 Files: clang/include/clang/Tooling/Refactoring/Transform

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. ymandel updated this revision to Diff 200310. ymandel added a comment. reordered some declarations. Transformer provides an enum to indicate the range of source text to be edited. That support

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz updated this revision to Diff 200291. zatrazz added a comment. Updated patch based on D62026 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[clang-tools-extra] r361163 - Disable the modernize-use-trailing-return-type.cpp test in C++2a mode

Author: gribozavr Date: Mon May 20 08:12:12 2019 New Revision: 361163 URL: http://llvm.org/viewvc/llvm-project?rev=361163&view=rev Log: Disable the modernize-use-trailing-return-type.cpp test in C++2a mode It is performing a use-of-uninitialized-value, as detected by MSan. Modified: clang-t

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To give an option for clangd embedders with snapshotted filesystem to read config files from exact snapshots, possibly loos

r361161 - Fix test not to use UNSUPPORTED as a FileCheck prefix.

Author: probinson Date: Mon May 20 07:57:18 2019 New Revision: 361161 URL: http://llvm.org/viewvc/llvm-project?rev=361161&view=rev Log: Fix test not to use UNSUPPORTED as a FileCheck prefix. It was not causing a problem but it's not good practice. Modified: cfe/trunk/test/Driver/cl-cc-flags.c

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added inline comments. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:78 + /// The DirectoryWatcher that originated this event is no longer valid and + /// it's behavior is undefined. + /// The prime case is kernel signalling to OS-s

[PATCH] D37813: clang-format: better handle namespace macros

klimek added a comment. In D37813#1254891 , @Typz wrote: > In D37813#1254865 , @klimek wrote: > > > In D37813#1253813 , @Typz wrote: > > > > > In D37813#1184051

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel added a comment. Fixed with r361160. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

r361160 - [LibTooling] Fix build break in test after r361152.

Author: ymandel Date: Mon May 20 07:44:40 2019 New Revision: 361160 URL: http://llvm.org/viewvc/llvm-project?rev=361160&view=rev Log: [LibTooling] Fix build break in test after r361152. r361152 broke gcc builds. Modified: cfe/trunk/unittests/Tooling/RangeSelectorTest.cpp Modified: cfe/trunk

[PATCH] D62138: [Docs] Increase Doxygen cache size

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I'll give it a day for further comments, and barring any, commit it for you tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel added a comment. Test file broke gcc builds. Fix in progress... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji added subscribers: MaskRay, rjmccall, aaron.ballman, rnk, jyknight. jsji added a comment. Add more subscribers, reviews and comments are welcome and appreciated. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (with the typo fix). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61851/new/ https://reviews.llvm.org/D61851 ___ cfe

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-comm

  1   2   >