sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
This seems fine: - please give this `function<>` type a name - maybe `ClangTidyOptionsBuilder` or so? - while we're defining this, we should make it threadsafe because that's what we really want - document that it's threadsafe and approximately why we don't use ClangTidyOptionsProvider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits