[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay abandoned this revision. MaskRay added a comment. Abandon in favor of D62055 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 ___ cfe-

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

phosek added a comment. We (Fuchsia) would like to see this landed as well so we can start using this in our kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 ___ cfe-commits mailing list cfe-

[PATCH] D62094: [analyzer] Categorize checker/plugin options into 3 categories, same as for checkers

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, rnkovacs, xazax.hun, Charusso, a_sidorin, dkrupp, o.gyorgy. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperit

[PATCH] D61839: [analyzer] Hide developer-only checker/package options by default

Szelethus updated this revision to Diff 200127. Szelethus retitled this revision from "[analyzer][WIP] Hide developer-only checker/package options by default" to "[analyzer] Hide developer-only checker/package options by default". Szelethus added a comment. - Hide several more checkers - Rename

[PATCH] D62093: [analyzer] Divide checkers into 3 categories: released, alpha, developer

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, dkrupp, o.gyorgy, xazax.hun, rnkovacs, Charusso, a.sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Szelethu

[PATCH] D62092: [analyzer] Create the beta package that is more stable than alpha, move unix.cstring.OutOfBounds there

Szelethus created this revision. Szelethus added reviewers: NoQ, dkrupp, o.gyorgy, dcoughlin, Charusso, a.sidorin, xazax.hun, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. As per

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:45 + + auto NewName = (IsConst? "k": "g") + llvm::StringRef(std::string(1, FC)).upper()) + + Decl->getName().substr(1).str());

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200123. jkorous added a comment. fix link libraries in cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/cmake/modules/AddClang.cmake clang/include/clang/DirectoryWatcher/DirectoryWatche

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

yonghong-song updated this revision to Diff 200117. yonghong-song edited the summary of this revision. yonghong-song added a comment. array index may not be constant and remove inst_name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llv

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200113. yaqiji marked an inline comment as done. yaqiji added a comment. Added fixithint for const as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clan

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit. Comment at: clan

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61617/new/ https://reviews.llvm.org/D61617 ___ cfe-comm

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200102. yaqiji added a comment. Updated matching criteria to allow variable declarations for legacy code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-t

LLvm masrer and llvm lab unavailable tomorrow

Hello everyone, LLvm masrer and llvm lab will be unavailable tomorrow Saturday, May 18th, from 10:30 am to 2:00 pm PST due to works related to an infrastructure improvement project. Thank you for understanding. Thanks Galina ___ cfe-commits mailing lis

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200094. hctim added a comment. Merged in master after fixing up some buildbots with the previous patches. Also have pinged libcxx-dev :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.l

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200091. gtbercea added a comment. - Fix braces. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200089. gtbercea marked 3 inline comments as done. gtbercea added a comment. - Fix format. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200088. gtbercea added a comment. - Fix conditions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/Cod

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 200079. ymandel marked 2 inline comments as done. ymandel added a comment. fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 Files: clang/include/clan

r361067 - [c++20] P1327R1: Support for typeid applied to objects of polymorphic

Author: rsmith Date: Fri May 17 12:19:28 2019 New Revision: 361067 URL: http://llvm.org/viewvc/llvm-project?rev=361067&view=rev Log: [c++20] P1327R1: Support for typeid applied to objects of polymorphic class type in constant evaluation. This reinstates r360977, reverted in r360987, now that its

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361066: [OpenMP][bugfix] Add missing math functions variants for log and abs. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D62046?vs=200048&id=200076#toc Repo

r361066 - [OpenMP][bugfix] Add missing math functions variants for log and abs.

Author: gbercea Date: Fri May 17 12:15:53 2019 New Revision: 361066 URL: http://llvm.org/viewvc/llvm-project?rev=361066&view=rev Log: [OpenMP][bugfix] Add missing math functions variants for log and abs. Summary: When including the random header in C++, some of the math functions it relies on ar

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. @sylvestre.ledru, I’ve added you on D62040 , which is an attempt to document best practices for generating releases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1, FC)

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mstorsjo requested changes to this revision. mstorsjo added a comment. This revision now requires changes to proceed. No, I don't think this is a good idea. Like I said, the Windows SDK is not self-consistent, so you cannot use it on a case sensitive file system without other case insensitivity

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200072. ymandel added a comment. Updated to incorporate changes to Transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra/clang-tidy/ut

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. In D62034#1506879 , @mclow.lists wrote: > I have no objection to this; but I'm not really confident that this won't > break more than it solves. Actually, I think the existing VFS overlay would fix this without any changes. So I

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mclow.lists added a comment. I have no objection to this; but I'm not really confident that this won't break more than it solves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62034/new/ https://reviews.llvm.org/D62034 _

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. Herald added a subscriber: dexonsmith. In D62034#1506102 , @mstorsjo wrote: > Yes, MinGW headers are all lowercase. > > And the Windows SDK, where the file is spelled with a capital W, isn't > self-consistent (some headers include

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi updated this revision to Diff 200067. plotfi added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, cfe-commits, lebedev.ri, kadircet, arphaman, jkorous, christof, hiraditya, mgorny, ki.stfu, kubamracek. Herald added a reviewer: jfb. Herald added a reviewe

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

*From: *Stephen Kelly via cfe-commits *Date: *Fri, May 17, 2019 at 1:56 PM *To: *Yitzhak Mandelbaum *Cc: *cfe-commits Hmm, thanks for letting me know! > > Is that an old compiler? > > I'm not near a computer for the weekend. > > Can someone fix or revert? > Sure, reverted in 361059. > > Thanks

r361059 - Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser"

Author: nico Date: Fri May 17 11:31:24 2019 New Revision: 361059 URL: http://llvm.org/viewvc/llvm-project?rev=361059&view=rev Log: Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser" It fails to build on some bots. Also revert follow-up r361055. Removed: cfe/trunk/uni

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

srhines added a comment. This LGTM if Ryan is happy with it. Thanks for taking care of getting a workaround implemented until this can be fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 _

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. ok, it should probably be installed in that case (it is currently in usr/lib/llvm-9/lib/libclang_shared.so.9 ) by the way, the name of lib isn't super explicit :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://r

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. I would leave it out of any distribution (at least for now). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. @beanz @tstellar I am wondering what to do wrt apt.llvm.org should it be part of libclang or create a libclang++ package what do you think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 200068. jcai19 marked an inline comment as done. jcai19 added a comment. Update based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-e

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 200066. jcai19 added a comment. Update based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModule

Re: r360998 - Fix crash if, during evaluation of __builtin_object_size, we try to load

Looks good, thanks :) On Fri, 17 May 2019, 10:31 Nico Weber via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > I attempted to fix this in 361054. > > *From: *Nico Weber > *Date: *Fri, May 17, 2019 at 1:16 PM > *To: *Richard Smith > *Cc: *cfe-commits > > Also on the LLVM waterfall: >> http:/

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

i'll see if i can repro on my build and fix if so. On Fri, May 17, 2019 at 1:56 PM Stephen Kelly wrote: > Hmm, thanks for letting me know! > > Is that an old compiler? > > I'm not near a computer for the weekend. > > Can someone fix or revert? > > Thanks, > > Stephen. > > On Fri 17 May 2019, 17:

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

Hmm, thanks for letting me know! Is that an old compiler? I'm not near a computer for the weekend. Can someone fix or revert? Thanks, Stephen. On Fri 17 May 2019, 17:11 Yitzhak Mandelbaum, wrote: > Looks like this caused a breakage: > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-qu

Re: r360998 - Fix crash if, during evaluation of __builtin_object_size, we try to load

I attempted to fix this in 361054. *From: *Nico Weber *Date: *Fri, May 17, 2019 at 1:16 PM *To: *Richard Smith *Cc: *cfe-commits Also on the LLVM waterfall: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/6937/steps/s

r361054 - Attempt to fix test on Windows after r360998

Author: nico Date: Fri May 17 10:33:54 2019 New Revision: 361054 URL: http://llvm.org/viewvc/llvm-project?rev=361054&view=rev Log: Attempt to fix test on Windows after r360998 Modified: cfe/trunk/test/SemaCXX/builtin-object-size-cxx14.cpp Modified: cfe/trunk/test/SemaCXX/builtin-object-size-

Re: r360998 - Fix crash if, during evaluation of __builtin_object_size, we try to load

Also on the LLVM waterfall: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/6937/steps/stage%201%20check/logs/stdio (Same error.) *From: *Nico Weber *Date: *Fri, May 17, 2019 at 1:14 PM *To: *Richard Smith *Cc: *cfe-commits

r361050 - Added an assertion to constant evaluation enty points that prohibits dependent expressions

Author: gribozavr Date: Fri May 17 10:16:53 2019 New Revision: 361050 URL: http://llvm.org/viewvc/llvm-project?rev=361050&view=rev Log: Added an assertion to constant evaluation enty points that prohibits dependent expressions Summary: Constant evaluator does not work on value-dependent or type-

Re: r360998 - Fix crash if, during evaluation of __builtin_object_size, we try to load

-- Testing: 49966 tests, 32 threads -- Testing: 0 .. 10.. 20.. FAIL: Clang :: SemaCXX/builtin-object-size-cxx14.cpp (14324 of 49966) TEST 'Clang :: SemaCXX/builtin-object-size-cxx14.cpp' FAILED Script: -- : 'RUN: at line 1'; c:\b\s\w\ir\k\src\third_party\ll

Re: r360998 - Fix crash if, during evaluation of __builtin_object_size, we try to load

The test fails on Windows: *From: *Richard Smith via cfe-commits *Date: *Fri, May 17, 2019 at 3:58 AM *To: * Author: rsmith > Date: Fri May 17 01:01:34 2019 > New Revision: 360998 > > URL: http://llvm.org/viewvc/llvm-project?rev=360998&view=rev > Log: > Fix crash if, during evaluation of __bui

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL361050: Added an assertion to constant evaluation enty points that prohibits dependent… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:115 + /// expansion. + llvm::Optional range(const SourceManager &SM) const; + ilya-biryukov wrote: > sammccall wrote: > > I think this might need a more explicit name. It's

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto &SP : DeclCache) { + auto *D = SP.first; djtodoro wrote: > aprantl wrote: > > djtodoro wrote: > > > aprantl wrote: > > > > Just lo

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel marked 7 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/RangeSelector.h:29 + +namespace range_selector { +inline RangeSelector charRange(CharSourceRange R) { ilya-biryukov wrote: > ymandel wrote

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 200061. ymandel marked 4 inline comments as done. ymandel added a comment. Restructured tests to simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 Files: clan

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:115 + /// expansion. + llvm::Optional range(const SourceManager &SM) const; + sammccall wrote: > I think this might need a more explicit name. It's reasonably obvious t

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I'd add a comment with a brief explanation for the const variant and a TODO() to remove it. Looks OK to me otherwise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

Re: r361011 - [analyzer] Validate checker option names and values

Looks like your r361042 fixed the ppc64be bot nonetheless. Maybe it was related after all :) *From: *Kristof Umann *Date: *Fri, May 17, 2019 at 11:10 AM *To: *Nico Weber *Cc: *cfe-commits http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick seems to be > doing fine now, http://lab.llvm.or

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

Looks like this caused a breakage: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/18641/steps/ninja%20check%201/logs/stdio On Fri, May 17, 2019 at 9:52 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Fri May 17 06:55:28 2019 > N

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9291 + if (CGM.getLangOpts().OpenMPSimd || CGM.getLangOpts().OpenMPIsDevice || + (OffloadEntriesInfoManager.empty() && !HasEmittedDeclareTargetRegion)) +return nullptr; Missed ch

r361042 - [analyzer] Remove the default value arg from getChecker*Option

Author: szelethus Date: Fri May 17 08:52:13 2019 New Revision: 361042 URL: http://llvm.org/viewvc/llvm-project?rev=361042&view=rev Log: [analyzer] Remove the default value arg from getChecker*Option Since D57922, the config table contains every checker option, and it's default value, so having it

[PATCH] D59195: [analyzer] Remove the default value arg from getChecker*Option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361042: [analyzer] Remove the default value arg from getChecker*Option (authored by Szelethus, committed by ). Herald adde

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; --

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

gtbercea added a comment. @tra I eliminated the long double definition for log and only left the declaration. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62046/new/ https://reviews.llvm.org/D62046 ___ cfe-commits

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

gtbercea updated this revision to Diff 200048. gtbercea added a comment. - update patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62046/new/ https://reviews.llvm.org/D62046 Files: lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_math_forward_dec

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; gtbercea wrote: > ABataev wro

Re: r361011 - [analyzer] Validate checker option names and values

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick seems to be doing fine now, http://lab.llvm.org:8011/builders/clang-ppc64be-linux seems to crash on files totally unrelated to mine. From: Kristof Umann Sent: 17 May 2019 15:59:28 To: Nico Weber Cc: cfe-

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Could someone merge this and D61841 now that they're approved? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 __

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. Herald added a project: clang. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; --

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:240 + + assert(RestrictKind.isBaseOf(NodeKind)); + if (Implementation->dynMatches(N, Finder, Builder)) { aaron.ballman wrote: > stevei

[PATCH] D62066: [ASTImporter] Enable disabled but passing tests

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D62065: Move dump method implementations to their respective class files

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no need to group them together. Repository: rC Clang https://reviews.llvm.org/D62065 Files: lib/AST/ASTDumper.cpp lib/AST/Comment.cpp

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:49 + +/// A half-open range inside a particular file, the start offset is included and +/// the end offset is excluded from the range. nit:

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361037: [LibTooling] Add support to Transformer for composing rules as an ordered… (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D61335?vs=200042&id=200044#toc

r361037 - [LibTooling] Add support to Transformer for composing rules as an ordered choice.

Author: ymandel Date: Fri May 17 07:23:33 2019 New Revision: 361037 URL: http://llvm.org/viewvc/llvm-project?rev=361037&view=rev Log: [LibTooling] Add support to Transformer for composing rules as an ordered choice. This revision updates `RewriteRule` to support multiple subrules that are interp

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked 3 inline comments as done. djtodoro added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto &SP : DeclCache) { + auto *D = SP.first; aprantl wrote: > djtodoro wrote: > > aprantl

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. In most cases the FriendDecl contains the declarati

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel updated this revision to Diff 200042. ymandel marked an inline comment as done. ymandel added a comment. Synced to HEAD in preparation for committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added inline comments. Comment at: unittests/AST/ASTTraverserTest.cpp:75 + +template std::string dumpASTString(NodeType &&... N) { + std::string Buffer; steveire wrote: > aaron.ballman wrote: > > Did clang-format produce this formatting? (If not,

[PATCH] D61835: Extract ASTDumper to a header file

This revision was automatically updated to reflect the committed changes. Closed by commit rC361034: Extract ASTDumper to a header file (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D61835?vs=199179&id=200038#toc Repository: rC Clang CHANGES SINCE

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. Great, thanks. I'm going to investigate whether we can move the `dump` method implementations to their respective class files, and then look into a rename for this to `StreamNodeDumper` or so (name tbd). Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:50 + + } else { +if (OldGuard.size()) I think this should be an `else if` rather than an `else`. I'd like to see us diagnose unknown guard styles so that we only accep

Re: r361011 - [analyzer] Validate checker option names and values

I'll take a look. From: Nico Weber Sent: 17 May 2019 15:09:18 To: Kristof Umann Cc: cfe-commits Subject: Re: r361011 - [analyzer] Validate checker option names and values It looks like this change is making gcc-7 crash on these (and other http://lab.llvm.org:801

r361034 - Extract ASTDumper to a header file

Author: steveire Date: Fri May 17 06:59:15 2019 New Revision: 361034 URL: http://llvm.org/viewvc/llvm-project?rev=361034&view=rev Log: Extract ASTDumper to a header file Summary: This class has member APIs which are useful to clients. Make it possible to use those APIs without adding them to dum

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

This revision was automatically updated to reflect the committed changes. steveire marked an inline comment as done. Closed by commit rL361033: Add a Visit overload for DynTypedNode to ASTNodeTraverser (authored by steveire, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire marked 5 inline comments as done. steveire added inline comments. Comment at: unittests/AST/ASTTraverserTest.cpp:75 + +template std::string dumpASTString(NodeType &&... N) { + std::string Buffer; aaron.ballman wrote: > Did clang-format produce this for

r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

Author: steveire Date: Fri May 17 06:55:28 2019 New Revision: 361033 URL: http://llvm.org/viewvc/llvm-project?rev=361033&view=rev Log: Add a Visit overload for DynTypedNode to ASTNodeTraverser Reviewers: aaron.ballman Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:292 + // "LangOpts" bound. + string CustomCode = customCode; } If this is code, should it be using a `code` type rather than a `string` type? Comment at: clan

r361032 - Fix Wdocumentation warnings. NFCI.

Author: rksimon Date: Fri May 17 06:42:16 2019 New Revision: 361032 URL: http://llvm.org/viewvc/llvm-project?rev=361032&view=rev Log: Fix Wdocumentation warnings. NFCI. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/ll

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D61834#1505418 , @steveire wrote: > In D61834#1505124 , @aaron.ballman > wrote: > > > In D618

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc added a comment. @dexonsmith Can you take a look at this patch or recommend someone who can review it? Many thanks. --Melanie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ cfe-commits

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200033. martong added a comment. - se -> so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200031. martong added a comment. - Rebase to master - Rebase to D62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked an inline comment as done. martong added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922 + + Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST)); + if (log_ast) { shafik wrote: > I am going to sa

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

aaron.ballman added inline comments. Comment at: lib/AST/ASTContext.cpp:120 +ASTContext::TraverseIgnored(const ast_type_traits::DynTypedNode &N) { + if (auto E = N.get()) { +return ast_type_traits::DynTypedNode::create(*TraverseIgnored(E)); aaron.ballman wro

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 200030. ilya-biryukov added a comment. - Skip annotation tokens, some of them are reported by the preprocessor but we don't want them in the final expanded stream. - Add functions to compute FileRange of tokens, add tests for it. Repository: rG LLVM

Re: r361011 - [analyzer] Validate checker option names and values

It looks like this change is making gcc-7 crash on these (and other http://lab.llvm.org:8011/console) bots: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/18639 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/33837/ [100/212] Building CXX object tools/clang/unitte

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel updated this revision to Diff 200026. ymandel marked 2 inline comments as done. ymandel added a comment. updated comments; moved some decls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335 Files:

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:278 +/// Builds the matcher needed for registration. +ast_matchers::internal::DynTypedMatcher buildMatcher(const RewriteRule &Rule); + --

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D61835#1505388 , @steveire wrote: > In D61835#1505314 , @aaron.ballman > wrote: > > > In D618

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

jdoerfert added a comment. This LGTM me, @tra or @efriedma any objections? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62046/new/ https://reviews.llvm.org/D62046 ___ cfe-commits mailing list cfe-commits@lists.llvm.

  1   2   >