[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM. Requires making the llvm::MemoryBuffer* stored by SourceManager const, which in turn requires making the accessors for that return const llvm::MemoryBuffer*s

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar added a comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59987/new/ https://reviews.llvm.org/D59987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[libunwind] r357671 - [libunwind] Export the weak alias in Mach-O

Author: phosek Date: Wed Apr 3 20:36:35 2019 New Revision: 357671 URL: http://llvm.org/viewvc/llvm-project?rev=357671&view=rev Log: [libunwind] Export the weak alias in Mach-O This is not necessary for ELF since .globl and .weak are mutually exclusive, but is necessary for Mach-O otherwise the s

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers aaro

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<< FixItHint::CreateReplacement(SourceRange(Match

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Dear reviewers, any comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<< FixItHint::CreateReplacement(SourceRange(Match

r357667 - Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)'

Author: dlj Date: Wed Apr 3 19:27:57 2019 New Revision: 357667 URL: http://llvm.org/viewvc/llvm-project?rev=357667&view=rev Log: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)' This revision causes tests to fail under ASAN.

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238 __

[PATCH] D60018: [codeview] Remove Type member from CVRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD357658: [codeview] Remove Type member from CVRecord (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60018?vs=193526&id=193633#toc Repository: rLLD LLVM Linker

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357654: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60201?vs=1934

[clang-tools-extra] r357654 - Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

Author: nico Date: Wed Apr 3 17:05:53 2019 New Revision: 357654 URL: http://llvm.org/viewvc/llvm-project?rev=357654&view=rev Log: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.) D

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

srhines marked an inline comment as done. srhines added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" aprantl wrote: > What's th

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal); I don't have an issue with these cha

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

aprantl added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" What's that for? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

srhines created this revision. srhines added a reviewer: aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. srhines added subscribers: pirama, chh. In the future, Android releases will support DWARF 5, but we need to ensure that older targets only have DWARF 4 generate

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Emit !heapallocsite in the metadata for calls to functions marked with __declspec(allocator). Eventually this will be emitted as S_HEAPALLOCSITE debug info in co

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek added a subscriber: ldionne. phosek added a comment. In D60235#1454152 , @mcgrathr wrote: > IMHO the library code should use `#if !__has_feature(...)` to avoid the > definitions entirely when built with a sanitizer whose runtime provides them. > B

r357643 - add periods

Author: akhuang Date: Wed Apr 3 15:19:07 2019 New Revision: 357643 URL: http://llvm.org/viewvc/llvm-project?rev=357643&view=rev Log: add periods Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/

[PATCH] D60236: add periods

akhuang created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. emit metadata for __declspec(allocator) add tests for heapallocsite metadata Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60236 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. IMHO the library code should use `#if !__has_feature(...)` to avoid the definitions entirely when built with a sanitizer whose runtime provides them. But this is a fine way to achieve that

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. ASan provides its own operator new/delete to intercept all allocations and deallocations. Current

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda updated this revision to Diff 193604. hintonda added a comment. Herald added subscribers: arphaman, mgorny. - Rename llvm directory to llvm_project. - Change llvm- to llvm-project-. - Rename files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + rjmccall wrote: > Hmm. I think it might be better to just have t

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman added a comment. @Bigcheese Initial tool posted to https://reviews.llvm.org/D60233 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 ___ cfe-commits mailing list cfe

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman created this revision. arphaman added a reviewer: Bigcheese. Herald added subscribers: jfb, dexonsmith, jkorous, mgorny. Herald added a project: clang. This patch introduces an outline for the `clang-scan-deps` tool that will be used to implement fast dependency discovery phase using imp

[libunwind] r357640 - [libunwind] Export the unw_* symbols as weak symbols

Author: phosek Date: Wed Apr 3 14:50:03 2019 New Revision: 357640 URL: http://llvm.org/viewvc/llvm-project?rev=357640&view=rev Log: [libunwind] Export the unw_* symbols as weak symbols libunwind defines the _Unwind_* ABI used by libc++abi. This ABI is a stable quasi-standard common between multi

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + Hmm. I think it might be better to just have this return a funct

[PATCH] D59852: [IR] Create new method in the Function class (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC357638: [IR] Create new method in `Function` class (NFC) (authored by evandro, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

r357638 - [IR] Create new method in `Function` class (NFC)

Author: evandro Date: Wed Apr 3 14:27:03 2019 New Revision: 357638 URL: http://llvm.org/viewvc/llvm-project?rev=357638&view=rev Log: [IR] Create new method in `Function` class (NFC) Create method `optForNone()` testing for the function level equivalent of `-O0` and refactor appropriately. Diffe

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

Hui added inline comments. Comment at: test/CodeGenCXX/debug-info-composite-triviality.cpp:88 - -// CHECK-DAG: !DICompositeType({{.*}}, name: "NonTrivialE",{{.*}}flags: {{.*}}DIFlagNonTrivial -struct NonTrivialE : Trivial, NonTrivial { probinson wrote: > This on

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193584. ymandel added a subscriber: ABataev. ymandel added a comment. Sever dependency of clangToolingRefactor on clangTooling via FixIt. Transformer used FixIt, which causes a problematic dependency. This diff copies the (minimal) code from FixIt to Transfo

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. Ilya, this diff fixes the breakage. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: yaxunl wrote: > I don't think we should detect ROCm installati

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel reopened this revision. ymandel added a comment. This revision is now accepted and ready to land. Reopening to fix the breakage caused by previous attempt at commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376

r357629 - [OPENMP]Add codegen for reduction vars with allocate clause, NFC.

Author: abataev Date: Wed Apr 3 12:59:09 2019 New Revision: 357629 URL: http://llvm.org/viewvc/llvm-project?rev=357629&view=rev Log: [OPENMP]Add codegen for reduction vars with allocate clause, NFC. Added test for the reduction variables with the allocate clause. Modified: cfe/trunk/test/Op

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

erik.pilkington added a comment. In D24639#1453795 , @bgianfo wrote: > Is there a reason why this was never merged? > Has the functionality been folded in in some other revision? > > I saw a bug recently which would have been caught by exactly this, which

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

rnk added a comment. In D59797#1452440 , @MaskRay wrote: > > this reduces the sum of heap allocations ... These numbers exclude memory > > mapped files > > May I ask how you counted the memory usage minus memory mapped files? I'm using the Visual Studio

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked 3 inline comments as done. lewissbaker added inline comments. Comment at: include/experimental/task:160 +__get_allocator<_CharAlloc>(__pointer, __size); +_CharAlloc __allocatorOnStack = _VSTD::move(__allocatorInFrame); +__allocatorIn

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3177-3178 return false; // Don't split tagged template literal so there is a break between the tag // identifier and template st

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, djasper, JonasToth, russellmcc, reuk. MyDeveloperDay added a project: clang-tools-extra. Code::Blocks and Qt Creator code uses a style guide which recommends indenting the next line after the access modifier e.g. cla

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60201/new/ https://reviews.llvm.org/D60201 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

bgianfo added a comment. Herald added subscribers: dexonsmith, jkorous. Is there a reason why this was never merged? Has the functionality been folded in in some other revision? I saw a bug recently where this warning would have been great. How can we get this merged? CHANGES SINCE LAST ACTION

r357625 - [OPENMP]Add codegen for lastprivate vars with allocate clause, NFC.

Author: abataev Date: Wed Apr 3 12:12:47 2019 New Revision: 357625 URL: http://llvm.org/viewvc/llvm-project?rev=357625&view=rev Log: [OPENMP]Add codegen for lastprivate vars with allocate clause, NFC. Added test for the lastprivatized variables with the allocate clause. Modified: cfe/trunk/

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: I don't think we should detect ROCm installation here. We are compiling code for amdgpu not only on RO

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:81-90 +__DEVICE__ bool isinf(long double __x) { return ::__isinfl(__x); } __DEVICE__ bool isfinite(float __x) { return ::__finitef(__x); } // For inscrutable reasons, __finite(), the double-precision

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. Reverted D57230 in rC357620 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58121/new/ https://reviews.llvm.org/D58121 ___ cfe-commits mailing list c

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Thanks. Any idea why AtomicChange.cpp's inclusion of clang/Tooling/ReplacementsYaml.h doesn't cause the same problem? https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp On Wed, Apr 3, 2019 at 2:11 PM Alexey Bataev wrote: > The problem is that libTool

r357620 - Revert "[analyzer] Toning down invalidation a bit".

Author: dergachev Date: Wed Apr 3 11:21:16 2019 New Revision: 357620 URL: http://llvm.org/viewvc/llvm-project?rev=357620&view=rev Log: Revert "[analyzer] Toning down invalidation a bit". This reverts commit r352473. The overall idea is great, but it seems to cause unintented consequences when n

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Alexey, thanks for reverting the change. Can you expand on why a dependency from libToolingRefactor to libTooling causes a cycle in the dep graph? In particular, I can't find the reverse dependency libTooling -> libToolingRefactor. If you can expand on that (I presume its a chain rather than a dire

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov created this revision. emankov added a reviewer: tra. emankov added a project: clang. Herald added a subscriber: cfe-commits. Last fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". **[IMPORTANT]** With that last f

r357617 - [OPENMP]Add codegen for firstprivate vars with allocate clause.

Author: abataev Date: Wed Apr 3 10:57:06 2019 New Revision: 357617 URL: http://llvm.org/viewvc/llvm-project?rev=357617&view=rev Log: [OPENMP]Add codegen for firstprivate vars with allocate clause. Added codegen/test for the firstprivatized variables with the allocate clause. Modified: cfe/t

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

jyu2 closed this revision. jyu2 added a comment. Closed by commit rG0b28b8b09be7 : Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2). Repository: rL LLVM CHANGES SINCE LAS

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; alexfh wrote: > hintonda wrote: > > aaron.ballman wr

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Reverted in r357612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

Re: [PATCH] D60213: Add clangTooling dependency to fix the build.

That would be great, thank you. On Wed, Apr 3, 2019 at 1:28 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > I can revert it for you, if you want > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.

r357612 - Revert "[LibTooling] Add Transformer, a library for source-to-source transformations."

Author: abataev Date: Wed Apr 3 10:34:04 2019 New Revision: 357612 URL: http://llvm.org/viewvc/llvm-project?rev=357612&view=rev Log: Revert "[LibTooling] Add Transformer, a library for source-to-source transformations." This reverts commit r357576 to fix the problem with the cyclic dependencies

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

I'll revert the change. On Wed, Apr 3, 2019 at 1:00 PM Yitzhak Mandelbaum wrote: > https://reviews.llvm.org/D60213 for the record > > On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum > wrote: > >> Thanks. Do you have build command I can run before/after to verify my >> fix before I submit? >

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > hintonda wrote:

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. I can revert it for you, if you want Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel added a comment. In D60213#1453516 , @ABataev wrote: > Nope, it won't work. There is a cyclic dependency, unfortunately. > clangTooling depends on clangToolingRefactor already. You need to revert your > commit and refactor it to remove the cyclic

r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Author: jyu2 Date: Wed Apr 3 10:21:40 2019 New Revision: 357610 URL: http://llvm.org/viewvc/llvm-project?rev=357610&view=rev Log: Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main. Added: cfe/trunk/test/CodeG

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

alexfh added a comment. This looks like a more promising direction. Thanks for the readiness to experiment with this. See the comments inline. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:130 + + // If we have alternative fixes (attached via diagnostic::Notes),

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

https://reviews.llvm.org/D60213 for the record On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum wrote: > Thanks. Do you have build command I can run before/after to verify my fix > before I submit? > > On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < > revi...@reviews.llvm.org>

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. You need to provide -DBUILD_SHARED_LIBS=true to cmake. Unfortunately, there is a dependency from the libToolingRefactor to libTooling. I don't think it will be easy to fix this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ h

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Fixes https://reviews.llvm.org/D59371, which broke the build for shared libraries. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60213 Files: clang/lib/Tooling/Refa

[libunwind] r357606 - [libunwind] Do not share an object library to create the static/shared libraries

Author: phosek Date: Wed Apr 3 09:59:33 2019 New Revision: 357606 URL: http://llvm.org/viewvc/llvm-project?rev=357606&view=rev Log: [libunwind] Do not share an object library to create the static/shared libraries This change is similar to r356150, with the same motivation. Modified: libunwi

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Thanks. Do you have build command I can run before/after to verify my fix before I submit? On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > Patch breaks the build with the shared libraries, for example, > http://lab.l

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Note that with: 1. https://reviews.llvm.org/D60208 ("[X86] Extend boolean arguments to inline-asm according to getBooleanType") 2. https://reviews.llvm.org/D58260 ("[INLINER] allow inlining of blockaddresses if sole uses are callbrs") 3. https://reviews.llvm.o

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. Patch breaks the build with the shared libraries, for example, http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498. Seems to me, you need to add an extra dependency on clangTooling. clangToolingCore is not enough. Repository: rC Clang CHANG

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193526. rnk added a comment. - final updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordC

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk marked 2 inline comments as done. rnk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > I do not

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein added a comment. Running out of time today, the patch is not finished yet, but it should be good for another initial review/comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 __

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein updated this revision to Diff 193510. hokein added a comment. Emit the check fix description via diagnostic::note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 Files: clang-tools-extra/clang-app

[PATCH] D60203: Updating Chromium's Java import order

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! (Test?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___ cf

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. Alternative way to fix it is to use `isNullPointerConstant` like we do in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we can emit `ConstantPointerNull` directly, without `EmitScalarExpr` . Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

This revision was automatically updated to reflect the committed changes. Closed by commit rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D60199?vs=193500&id=19350

r357599 - [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

Author: krasimir Date: Wed Apr 3 08:16:04 2019 New Revision: 357599 URL: http://llvm.org/viewvc/llvm-project?rev=357599&view=rev Log: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK Summary: Currently clang-format would always emit a replacement for multi-block #i

[PATCH] D60203: Updating Chromium's Java import order

SamMaier created this revision. SamMaier added a reviewer: thakis. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Adding in androidx as another import group. Repository: rC Clang https://reviews.llvm.org/D60203 Files: lib/Format/Format.cpp Index: lib/Forma

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda added a comment. In D60151#1453099 , @alexfh wrote: > The change looks fine, but I don't understand the description of this > revision. Could you clarify which checkers you're talking about and which bug > you observe? Sorry for not being clea

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir updated this revision to Diff 193500. krasimir added a comment. - Address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp In

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193498. ymandel added a comment. Remove noisy default-defined constructors/operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Toolin

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

alexfh added a comment. In D59449#1449664 , @zinovy.nis wrote: > > Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a > > distinct and somewhat self-documenting name and a very specific purpose > > (find clang-tidy regressions in a

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193496. ymandel added a comment. Sever dependency on NodeId and some general cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Tooli

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall added a comment. Got here trying to understand how D60126 works. It seems there's two fairly independent changes here: - the one described, allow actions to run without a preamble - defer the blocking getCompileCommand() call until we're building the

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

ioeric added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:28 std::string sort(StringRef Code, std::vector Ranges, + llvm::Optional ExpectedNumRanges = llvm::None, StringRef FileName = "input.cc") { As

r357589 - Whitespace and formatting changes; NFC.

Author: aaronballman Date: Wed Apr 3 07:40:00 2019 New Revision: 357589 URL: http://llvm.org/viewvc/llvm-project?rev=357589&view=rev Log: Whitespace and formatting changes; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: htt

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1116 +def ObjCClassStubDocs : Documentation { +let Category = DocCatFunction; +let Content = [{ aaron.ballman wrote: > slavapestov wrote: > > aaron.ballman wrote: > > > This

r357585 - Add a new attribute documentation category for declarations.

Author: aaronballman Date: Wed Apr 3 07:26:32 2019 New Revision: 357585 URL: http://llvm.org/viewvc/llvm-project?rev=357585&view=rev Log: Add a new attribute documentation category for declarations. This moves documentation for some attributes into new categories that are hopefully a bit more c

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

thakis created this revision. thakis added a reviewer: bkramer. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.) https://reviews.llvm.org/D60201

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Thank you, I submitted a clang-formatted fix for the if statement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mailing list cfe-commi

[PATCH] D33841: [clang-tidy] redundant keyword check

alexfh added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8 + +`extern` is redundant in function declarations + koldaniel wrote: > alexfh wrote: > > xazax.hun wrote: > > > alexfh wrote: > > > > Could you explain, why you t

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-placement-new-target-size.rst:5 +== + + Eugene.Zelenko wrote: > Unnecessary empty line. Somehow empty line is still there. CHANGES SINCE LAST ACTION http

  1   2   >