arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: lib/Driver/ToolChains/AMDGPU.h:25
+/// TODO: Generalize to handle libclc.
+class RocmInstallationDetector {
+private:
----------------
yaxunl wrote:
> I don't think we should detect ROCm installation here. We are compiling code
> for amdgpu not only on ROCm, but also on amdgpu-pro and windows. Many cases,
> people want to compile code for amdgpu on systems without ROCm installed.
>
> Compiilng code for amdgpu does not really depend on ROCm. We only depend on
> device library.
>
> It makes more sense to have a AMDGPUDeviceLibDetector which works on ROCm,
> amdgpu-pro, and windows. Also we need an option -amdgpu-device-lib-path to
> override the default amdgpu device lib path.
Being able to cross compile without a rocm installation is one of my primary
goals here. I don't know what the install paths look like for those other
drivers. It would be best if everything could agree on a single default install
location for these to search, which is mostly a naming problem. In the patch
as-is, the rocm-path is serving as -amdgpu-device-lib-path, but this is a
naming question
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59321/new/
https://reviews.llvm.org/D59321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
