[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 191640. shiva0217 marked an inline comment as done. shiva0217 edited the summary of this revision. shiva0217 changed the repository for this revision from rL LLVM to rC Clang. shiva0217 removed a project: LLVM. shiva0217 removed a subscriber: llvm-commits. sh

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

philip.derrin created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Add an -mtpidr=el[0-3] option to select which of the AArch64 thread ID registers will be used for the TLS base pointer. This is a followup to D54685

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Basic/AttrDocs.td:1118 +let Content = [{ +This attribute specifies that the Objective-C class to which it applies has dynamic

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to TypeScript, "enum" is not a reserved word. Repository: rC Clang https://reviews.llvm.org/D59629 Files: lib/Format/UnwrappedLineParser.cpp unitt

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2976 + +return Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_None || + Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_Inline || klimek wrote: > If

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 191629. rdwampler marked 2 inline comments as done. rdwampler added a comment. Changes since last revision: -rebased -Fall through when SLS_All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: c

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. Ok, got it! Yeah, this sounds like a valid way of supporting non-base-region-based worklist items, i'm seeing no problems with it and i don't immediately see a solution that'd be better than gradually supporting non-base-regions in more and more places. Here's the slight m

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov created this revision. slavapestov added reviewers: rjmccall, dexonsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. dexonsmith edited reviewers, added: erik.pilkington, arphaman; removed: dexonsmith. dexonsmith added a comment. +Erik and Ale

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

dexonsmith edited reviewers, added: erik.pilkington, arphaman; removed: dexonsmith. dexonsmith added a comment. +Erik and Alex, can you take a look at this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 _

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

craig.topper added a comment. In D59567#1436035 , @RKSimon wrote: > IIRC we don't use libcalls for popcnt - we just expand Yeah we expand. gcc uses libcall. I think icc also expands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59567/new/ htt

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai created this revision. dchai added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Top-level "package" and "import" statements should generally be kept on one line, for all languages. Repository: rC Clang https://reviews.llvm.org/D59627 Fil

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

craig.topper updated this revision to Diff 191625. craig.topper added a comment. Update doxygen comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59567/new/ https://reviews.llvm.org/D59567 Files: lib/Headers/ia32intrin.h lib/Headers/popcntintrin.h test/CodeGen/popcnt-builtin

r356628 - Remove extra white spaces

Author: jyu2 Date: Wed Mar 20 16:05:18 2019 New Revision: 356628 URL: http://llvm.org/viewvc/llvm-project?rev=356628&view=rev Log: Remove extra white spaces Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp URL

[PATCH] D59440: add steps to preprocess file and reduce command line args

This revision was automatically updated to reflect the committed changes. Closed by commit rC356636: creduce-clang-crash.py: preprocess file + reduce commandline (authored by gbiv, committed by ). Changed prior to commit: https://reviews.llvm.org/D59440?vs=191598&id=191615#toc Repository: rC

r356636 - creduce-clang-crash.py: preprocess file + reduce commandline

Author: gbiv Date: Wed Mar 20 18:01:53 2019 New Revision: 356636 URL: http://llvm.org/viewvc/llvm-project?rev=356636&view=rev Log: creduce-clang-crash.py: preprocess file + reduce commandline This CL causes our creduce-clang-crash.py util to: - try to preprocess the file before reducing - try to

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

craig.topper created this revision. craig.topper added a reviewer: rnk. -malign-double is currently only implemented in the -cc1 interface. But its declared in Options.td so it is a driver option too. But you try to use it with the driver you'll get a message about the option being unused. This

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal added a comment. This broke all the build bots, so I reverted the SVN change. I thought the nodiscard-ness was tested elsewhere but I'm not sure about interaction between this and -faligned-allocation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/ https://reviews

[PATCH] D59573: [analyzer] C++17: PR41142: Ignore transparent InitListExprs when finding construction contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356634: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in constructors. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

r356634 - [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in constructors.

Author: dergachev Date: Wed Mar 20 17:15:07 2019 New Revision: 356634 URL: http://llvm.org/viewvc/llvm-project?rev=356634&view=rev Log: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in constructors. When searching for construction contexts, i.e. figuring out which statements def

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal added a comment. As an FYI, I committed this to subversion as r356632 since I haven't figured out the new git world order yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/ https://reviews.llvm.org/D59621 ___ cfe-

[PATCH] D59440: add steps to preprocess file and reduce command line args

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM; thanks again! Will land shortly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 __

[PATCH] D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision:

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists, ldionne. Herald added a subscriber: jdoerfert. Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]]. This allows these tests to pass when compiled by MSVC++. https://reviews.ll

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

cpplearner added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8166 +def err_multiple_likelihood : Error< + "there can only be one %0 attribue in any attribute list">; +def err_mutuably_exclusive_likelihood : Error< attribue => at

RE: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

Hi Zinovy, I have reverted this change in r356630 in order to get the build bots back to green. I was able to reproduce the issue locally on my machine, it appears that your use of “import yaml” is not part of the standard python distribution and so is not found. Douglas Yung From: cfe-commi

[PATCH] D59573: [analyzer] C++17: PR41142: Ignore transparent InitListExprs when finding construction contexts.

NoQ added a comment. Though it's kidna funny that even when we support all of C++, we wouldn't necessarily always have construction contexts for all objects in the analyzer sense (even if they would be there in the CFG). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] r356630 - Revert "Reland r356547 after fixing the tests for Linux."

Author: dyung Date: Wed Mar 20 16:21:43 2019 New Revision: 356630 URL: http://llvm.org/viewvc/llvm-project?rev=356630&view=rev Log: Revert "Reland r356547 after fixing the tests for Linux." This reverts commit 538fb72226cf6dff95af83fe12b8dbd061ea (r356565). This is still breaking a build bot

[PATCH] D59573: [analyzer] C++17: PR41142: Ignore transparent InitListExprs when finding construction contexts.

NoQ added a comment. Thx! > The problem here is that we inevitably hit the recursion limit, and then... > > 4. Well, something weird happens. I'll have to have a closer look, but one > weird thing i noticed is that the value for `{ boo() }` ends up being > `compoundVal{Unknown}`, as if `bindRe

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ping @aaron.ballman @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore marked an inline comment as done. stephanemoore added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 ___ cfe-co

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356627: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓 (authored by stephanemoore, committed by ). Changed prior to commit: https://reviews.llvm.org/D59336?vs=191219&id=191599#toc Reposit

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191598. akhuang added a comment. style nits, fixed thing in getting path to clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang

[clang-tools-extra] r356623 - Revert "[clangd] Print arguments in template specializations"

Author: rupprecht Date: Wed Mar 20 15:51:56 2019 New Revision: 356623 URL: http://llvm.org/viewvc/llvm-project?rev=356623&view=rev Log: Revert "[clangd] Print arguments in template specializations" This reverts commit 44a63f6a150dec72dea43730d2a89d292e58bd6f. It segfaults on an internal test cas

r356623 - Revert "[clangd] Print arguments in template specializations"

Author: rupprecht Date: Wed Mar 20 15:51:56 2019 New Revision: 356623 URL: http://llvm.org/viewvc/llvm-project?rev=356623&view=rev Log: Revert "[clangd] Print arguments in template specializations" This reverts commit 44a63f6a150dec72dea43730d2a89d292e58bd6f. It segfaults on an internal test cas

[PATCH] D59440: add steps to preprocess file and reduce command line args

george.burgess.iv added a comment. Just a few style nits for you, and this LGTM. I assume rnk and serge-sans-paille are content, so I'm happy to check this in for you once these are addressed. Thanks! Comment at: clang/utils/creduce-clang-crash.py:64 crash_output, _ = p.c

[PATCH] D59560: Permit redeclarations of a builtin to specify calling convention.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59560/new/ https://reviews.llvm.org/D59560 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson created this revision. aemerson added reviewers: kristof.beyls, t.p.northover, olista01. aemerson added a project: clang. Herald added subscribers: arphaman, javed.absar. Some intrinsics like saturating operations may set flags, so if the scalar arg is inserted into an undef vector, the

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb marked an inline comment as done. jfb added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + aaronpuchert wrote: > Test is fine for me, but I

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb updated this revision to Diff 191580. jfb marked 3 inline comments as done. jfb added a comment. - Simlify tests, share code Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 Files: lib/Analysis/ThreadSafetyCommon.cpp

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added inline comments. Herald added subscribers: benna, psnobl. Comment at: lib/Driver/ToolChains/Clang.cpp:1803 + + // Forward the -msmall-data-limit= option. + if (Arg *A = Args.getLastArg(options::OPT_G)) { Might be simpler to just set it to 0, and if

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

This revision was automatically updated to reflect the committed changes. Closed by commit rC356614: [clang][OpenMP] Fix build when using libgomp (authored by rupprecht, committed by ). Changed prior to commit: https://reviews.llvm.org/D59609?vs=191567&id=191577#toc Repository: rC Clang CHA

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added a reviewer: aaronpuchert. aaronpuchert added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:282-285 + const auto *Canonical = Ctx->AttrDecl->getCanonicalDecl(); + if (isa(D) + ? (cast(D)->getCanonicalDecl() == Canonical)

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

rupprecht added a comment. In D59609#1436975 , @lebedev.ri wrote: > Interesting. > What happens if libomp is not being built? > What happens if libomp is not present? I'm far from an omp expert (only running across this because some tests failed), but

Re: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

Hello Zinovy, This commit broke test on the next builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45557 . . . Failing Tests (1): Clang Tools :: clang-tidy/clang-tidy-diff.cpp Please have a look? Thanks Galina On Wed, Mar 20, 2019 at 8:49 AM Zino

r356615 - [clang-format][NFC] fix release notes build issue

Author: paulhoad Date: Wed Mar 20 14:02:12 2019 New Revision: 356615 URL: http://llvm.org/viewvc/llvm-project?rev=356615&view=rev Log: [clang-format][NFC] fix release notes build issue build issue from r356613 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.r

r356614 - [clang][OpenMP] Fix build when using libgomp

Author: rupprecht Date: Wed Mar 20 14:01:56 2019 New Revision: 356614 URL: http://llvm.org/viewvc/llvm-project?rev=356614&view=rev Log: [clang][OpenMP] Fix build when using libgomp Summary: rL356570 introduced a test which only passes with the default openmp library, libomp, and fails with other

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL356613: [clang-format] BeforeHash added to IndentPPDirectives (authored by paulhoad, committed by ). Herald added a projec

r356613 - [clang-format] BeforeHash added to IndentPPDirectives

Author: paulhoad Date: Wed Mar 20 13:49:43 2019 New Revision: 356613 URL: http://llvm.org/viewvc/llvm-project?rev=356613&view=rev Log: [clang-format] BeforeHash added to IndentPPDirectives Summary: The option BeforeHash added to IndentPPDirectives. Fixes Bug 36019. https://bugs.llvm.org/show_bug.

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59609/new/ https://reviews.llvm.org/D59609 ___

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

ABataev added a comment. If the compiler is built without OpenMP support -fopenmp is converted to -fopenmp=libgomp frontend option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59609/new/ https://reviews.llvm.org/D59609 ___

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

lebedev.ri added a reviewer: ABataev. lebedev.ri added a comment. Interesting. What happens if libomp is not being built? What happens if libomp is not present? Or more generally, why does it even matter whether there is runtime or not, this only does paring+sema, no codegen/execution. Reposit

[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356609: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc. (authored by ctopper, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM.

r356609 - [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

Author: ctopper Date: Wed Mar 20 13:25:28 2019 New Revision: 356609 URL: http://llvm.org/viewvc/llvm-project?rev=356609&view=rev Log: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc. gcc has these intrinsics in ia32intrin.h as well. And icc implements them though the

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

rupprecht created this revision. rupprecht added a reviewer: lebedev.ri. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. rL356570 introduced a test which only passes with the default openmp library, libomp, and fails w

r356607 - [OPENMP]Improve detection of omp_allocator_handle_t type and predefined

Author: abataev Date: Wed Mar 20 13:14:22 2019 New Revision: 356607 URL: http://llvm.org/viewvc/llvm-project?rev=356607&view=rev Log: [OPENMP]Improve detection of omp_allocator_handle_t type and predefined allocators. It is better to deduce omp_allocator_handle_t type from the predefined allocato

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

rupprecht added inline comments. Comment at: cfe/trunk/unittests/AST/OMPStructuredBlockTest.cpp:58 + std::vector Args = { + "-fopenmp", + }; Looks like this test fails when the default is not libomp, e.g. DCLANG_DEFAULT_OPENMP_RUNTIME=libgomp Using -fopen

r356605 - Fix implicit ios -> watchOS availability version mapping for

Author: arphaman Date: Wed Mar 20 13:02:00 2019 New Revision: 356605 URL: http://llvm.org/viewvc/llvm-project?rev=356605&view=rev Log: Fix implicit ios -> watchOS availability version mapping for versions that have the major number only rdar://48018651 Modified: cfe/trunk/lib/Sema/SemaDeclAt

[PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added a subscriber: xazax.hun. Herald added a reviewer: serge-sans-paille. Review process takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17482/new/ ht

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added subscribers: jdoerfert, mgorny. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 __

[PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added a reviewer: serge-sans-paille. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18509/new/ https://reviews.llvm.org/D18509 _

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk updated this revision to Diff 191560. reuk added a comment. Removed unnecessary parens. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55170/new/ https://reviews.llvm.org/D55170 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp lib/For

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. Herald added a subscriber: jdoerfert. In D56323#1350998 , @JonasToth wrote: > @LegalizeAdulthood your stuck on the commit right things right? If you want I > can commit for you (maybe even later) as you said you are limi

[PATCH] D59394: [Sema] De-duplicate some availability checking logic

This revision was automatically updated to reflect the committed changes. Closed by commit rL356599: [Sema] Deduplicate some availability checking logic (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

r356600 - Add a __has_extension check for '#pragma clang attribute' as an external-declaration

Author: epilk Date: Wed Mar 20 12:26:37 2019 New Revision: 356600 URL: http://llvm.org/viewvc/llvm-project?rev=356600&view=rev Log: Add a __has_extension check for '#pragma clang attribute' as an external-declaration This was added in r356075. Modified: cfe/trunk/include/clang/Basic/Feature

r356599 - [Sema] Deduplicate some availability checking logic

Author: epilk Date: Wed Mar 20 12:26:33 2019 New Revision: 356599 URL: http://llvm.org/viewvc/llvm-project?rev=356599&view=rev Log: [Sema] Deduplicate some availability checking logic Before this commit, we emit unavailable errors for calls to functions during overload resolution, and for referen

r356598 - Recommit "Support attribute used in member funcs of class templates"

Author: rafauler Date: Wed Mar 20 12:22:24 2019 New Revision: 356598 URL: http://llvm.org/viewvc/llvm-project?rev=356598&view=rev Log: Recommit "Support attribute used in member funcs of class templates" This diff previously exposed a bug in LLVM's IRLinker, breaking buildbots that tried to self-

RE: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

Hi Zinovy, The test you modified is still failing on the PS4 linux bot after your change: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45557 FAIL: Clang Tools :: clang-tidy/clang-tidy-diff.cpp (14410 of 47824) TEST 'Clang Tools :: clang

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL356592: Remove the unused return value in ASTImporter::Imported [NFC] (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

r356592 - Remove the unused return value in ASTImporter::Imported [NFC]

Author: teemperor Date: Wed Mar 20 12:00:25 2019 New Revision: 356592 URL: http://llvm.org/viewvc/llvm-project?rev=356592&view=rev Log: Remove the unused return value in ASTImporter::Imported [NFC] Summary: `ASTImporter::Imported` currently returns a Decl, but that return value is not used by th

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

keryell added a comment. I was a little bit worried about struct top_level { int i; }; private ::top_level a; but it should be fine because in that case we have a `tok::coloncolon` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 _

[clang-tools-extra] r356589 - [clang-tidy] Fix redundant check breaking the test on many platforms.

Author: zinovy.nis Date: Wed Mar 20 11:37:04 2019 New Revision: 356589 URL: http://llvm.org/viewvc/llvm-project?rev=356589&view=rev Log: [clang-tidy] Fix redundant check breaking the test on many platforms. Differential Revision: https://reviews.llvm.org/D57662 Modified: clang-tools-extra/t

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:397 +def ext_pp_opencl_variadic_macros : Extension< + "variadic macros not supported in OpenCL">; Maybe rephrase the message now to say it's an extension? The other similar wa

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz updated this revision to Diff 191540. to-miz added a comment. Made a new diff on the git repository, since the docs now recommend using git. Rebased and created a new diff with `git show HEAD -U99`. The patch applies cleanly on windows after `git reset --hard` so I hope there shouldn't

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > The cost is financial, as it's developer time, which costs real money to > companies. In the end, to support this, people like myself who are doing this > as part of their job spend time that they'd otherwise spend to make other > things better that might be mo

[PATCH] D59605: [clangd] Introduce background-indexer

jkorous added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:56 + // non-interactive tools like this one. + 24 * 60 * 60 * 1000); + llvm::SmallString<128> DummyFile(CompileCommandsDir); Nit: maybe we shou

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood marked 9 inline comments as done. LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:112 +process_output = e.output.decode() +print('%s failed:\n%s' % (' '.join(args), process_output)) +if raise_error: --

[PATCH] D59605: [clangd] Introduce background-indexer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:29 #include "llvm/Support/SHA1.h" #include Unnecessary empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. Ping for reviews please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:135 +// \endcode +class RewriteRule { +public: ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov wrote: > > > Maybe co

[PATCH] D59605: [clangd] Introduce background-indexer

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:13 + +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clangd/Context.h" +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-ex

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

Eugene.Zelenko added inline comments. Comment at: clangd/AST.cpp:86 else if (auto *Cls = llvm::dyn_cast(&ND)) { -if (auto STL = Cls->getTypeAsWritten() - ->getTypeLoc() - .getAs()) { - llvm::SmallVector ArgLocs; - ArgLo

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. Thanks for changes. A few more comments. Comment at: clangd/ClangdUnit.cpp:259 +// Generates a mapping from start of an include directive to its range. +std::map +positionToRangeMap(const std::vector &MainFileIncludes) { Could we

[PATCH] D59605: [clangd] Introduce background-indexer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:13 + +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clangd/Context.h" +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-e

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191536. MyDeveloperDay added a comment. Sorry for the spam: - write this a little better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.org/D59309 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests

[PATCH] D59605: [clangd] Introduce background-indexer

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, erik.pilkington, arphaman, jkorous, MaskRay, ioeric, mgorny. Herald added a project: clang. Sample output: I[18:37:50.083] BackgroundIndex: build symbol index periodically e

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191530. MyDeveloperDay added a comment. Addressing code review comment @klimek I think is what you meant, a much smaller and neater version of what I had before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llv

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. In D52150#1436423 , @to-miz wrote: > I checked out the git repository and applied the patch to head and reran all > tests. > The diff produced by git is basically the same, should I upload the new diff? I think you might

[PATCH] D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356580: [X86] Remove getCPUKindCanonicalName which is unused. (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SI

r356580 - [X86] Remove getCPUKindCanonicalName which is unused.

Author: ctopper Date: Wed Mar 20 10:26:51 2019 New Revision: 356580 URL: http://llvm.org/viewvc/llvm-project?rev=356580&view=rev Log: [X86] Remove getCPUKindCanonicalName which is unused. Differential Revision: https://reviews.llvm.org/D59578 Modified: cfe/trunk/lib/Basic/Targets/X86.cpp

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:135 +// \endcode +class RewriteRule { +public: ymandel wrote: > ilya-biryukov wrote: > > Maybe consider separating the fluent API to build the rewrite rule from

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

Anastasia added a comment. Herald added a subscriber: ebevhan. Herald added a project: clang. Btw, I have created a patch that allows non-underscore prefixed spelling for address spaces in C++ for OpenCL: https://reviews.llvm.org/D59603 I assume the error becomes less critical however it remains

r356578 - [NFC][ASTMatchers] Alphabetically sort REGISTER_MATCHER() macros in RegistryMaps::RegistryMaps()

Author: lebedevri Date: Wed Mar 20 10:15:47 2019 New Revision: 356578 URL: http://llvm.org/viewvc/llvm-project?rev=356578&view=rev Log: [NFC][ASTMatchers] Alphabetically sort REGISTER_MATCHER() macros in RegistryMaps::RegistryMaps() As noted in https://reviews.llvm.org/D59453#inline-526253 Modi

r356577 - [AST] Disable ast-dump-openmp-parallel-master-XFAIL.c test

Author: lebedevri Date: Wed Mar 20 10:14:49 2019 New Revision: 356577 URL: http://llvm.org/viewvc/llvm-project?rev=356577&view=rev Log: [AST] Disable ast-dump-openmp-parallel-master-XFAIL.c test Fails on MSVC buildbot (but not locally). Not important as it is 'testing' something that isn't suppor

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

Anastasia created this revision. Anastasia added reviewers: svenvh, rjmccall. Herald added subscribers: jdoerfert, ebevhan, yaxunl. For backwards compatibility we should allow alternative spelling of address spaces - `private`, `local`, `global`, `constant`, `generic`. Note that in order to acce

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

This revision was automatically updated to reflect the committed changes. Closed by commit rC356575: [clang-format] structured binding in range for detected as Objective C (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D59

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

tra added a comment. > This is, or is very similar to, the problem that the host/device overloading > addresses in CUDA. IIRC the difference was that OpenMP didn't have explicit notion of host/device functions which made it hard to apply host/device overloading in practice. > It is also the

r356575 - [clang-format] structured binding in range for detected as Objective C

Author: paulhoad Date: Wed Mar 20 10:10:23 2019 New Revision: 356575 URL: http://llvm.org/viewvc/llvm-project?rev=356575&view=rev Log: [clang-format] structured binding in range for detected as Objective C Summary: Sometime after 6.0.0 and the current trunk 9.0.0 the following code would be cons

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/AST.cpp:95 +} else { + // FIXME: Cls->getTypeAsWritten might return null in some cases, e.g. + // clang sees first sees a

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: include/clang/Basic/TokenKinds.h:80 K == tok::utf8_string_literal || K == tok::utf16_string_literal || - K == tok::utf32_string_literal; } klimek

  1   2   >