[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri added a comment. Thank you for working on this! Is there any way to model this more generically? I.e don't duplicate every naive matcher (ignoring possible presence of `,` op) with an variant that does not ignore `,`. E.g. will this handle `(a,b)+=1` ? What about `(a,b).callNonConstMe

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro created this revision. djtodoro added reviewers: shuaiwang, lebedev.ri. Herald added subscribers: Charusso, jdoerfert, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. We should track mutation of a variable within a comma operator expressi

[PATCH] D58891: Modules: Add -Rmodule-import

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/test/Modules/Rmodule-build.m:22-25 -// RUN: echo ' ' >> %t/C.h -// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fsyntax-only %s -I %t \ -// RUN:

[PATCH] D58893: Modules: Invalidate out-of-date PCMs as they're discovered

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, bruno, rsmith, vsapsai. Herald added a subscriber: jdoerfert. dexonsmith added parent revisions: D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache, D58891: Modules: Add -Rmodule-import. Leverage the InMemoryMo

[PATCH] D58891: Modules: Add -Rmodule-import

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, bruno, rsmith, vsapsai. Herald added a subscriber: jdoerfert. Add a remark for importing modules. Depending on whether this is a direct import (into the TU being built by this compiler instance) or transitive import (into an

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith created this revision. dexonsmith added reviewers: bruno, rsmith, vsapsai, Bigcheese. Herald added subscribers: jdoerfert, jsji, kbarton, mgorny, nemanjai. Change MemoryBufferCache to InMemoryModuleCache, moving it from Basic to Serialization. Another patch will start using it to manag

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 189114. nridge added a comment. Address a couple of outstanding TODOs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-tools-extra/clangd/ClangdLSPServer.c

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

MaskRay added a comment. I read your https://blog.netbsd.org/tnf/entry/the_first_report_on_lld :) The chapter "Handling of indirect shared library dependencies" summarizes the transitive DT_NEEDED problem well. But do we have a convincing list of applications that really need this option to li

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 189107. Szelethus added a comment. Herald added a reviewer: teemperor. Herald added a subscriber: Charusso. This revision now requires review to proceed. Remove the default value parameters from `getChecker*Option`, as they are no longer necessary. Note the

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 189105. Szelethus added a comment. Remembered that we can't use use `llvm::binary_search`, as we'll need the iterators in a later patch. Should've rebased all my branches before updating :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC355297: [analyzer] Enable subcheckers to possess checker options (authored by Szelethus, committed by ). Herald added a su

r355297 - [analyzer] Enable subcheckers to possess checker options

Author: szelethus Date: Sun Mar 3 16:28:16 2019 New Revision: 355297 URL: http://llvm.org/viewvc/llvm-project?rev=355297&view=rev Log: [analyzer] Enable subcheckers to possess checker options Under the term "subchecker", I mean checkers that do not have a checker class on their own, like unix.Ma

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

Szelethus added a comment. Herald added a subscriber: Charusso. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r355294 - Modules: Document that ReadASTCore exits its final loop via `return`, NFC

Author: dexonsmith Date: Sun Mar 3 12:17:53 2019 New Revision: 355294 URL: http://llvm.org/viewvc/llvm-project?rev=355294&view=rev Log: Modules: Document that ReadASTCore exits its final loop via `return`, NFC The final loop never breaks. Document that by following it with llvm_unreachable. Mo

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 189093. nridge added a comment. Rebased onto updated D56370 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge removed a reviewer: sammccall. nridge added a comment. Removing Sam as reviewer as he's on parental leave. Kadir, if you have other reviewers to suggest to provide feedback on the API changes here, please feel free to add them. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 189092. nridge marked 2 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-to

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked 19 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:830 +return false; + if (auto *Resolve = Params.getAsObject()->get("resolve")) { +if (!fromJSON(*Resolve, R.resolve)) { sammccall wr

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

JonasToth added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:90 + for (auto i = 0; i < 3; i++) { +m.lock(); +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use RAII lewmpk wrote: > JonasToth wrote: > > I got another one

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

krytarowski added a comment. Herald added a subscriber: MaskRay. Herald added a project: LLVM. @ruiu ping? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56647/new/ https://reviews.llvm.org/D56647 ___ cfe-comm

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, Thanks for the patch! It looks good to me except some stylish nits. Comment at: lib/AST/ASTImporter.cpp:5130 +Importer.MapImported(D, PrevDecl->getDef

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

a_sidorin added a comment. Hi Gabor, The patch looks almost good bu I have some comments inline. Comment at: lib/AST/ASTImporter.cpp:3002 + // Check if we have found an existing definition. Returns with that + // definition if yes, otherwise returns null.

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 189090. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/StaticAnalyzer/Checkers/CheckerBase.td include/clang/StaticAnalyzer/Checkers/Ch

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added a comment. Hi Nathan, Really sorry about the delay here. I'm actually out on leave at the moment, and didn't get things wrapped up before I went. (I'm 1 week into 4 week parental leave, and got sick the week I was supposed to be handing things off). @kadircet, can you finish the

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 189088. Szelethus added a comment. Herald added a subscriber: Charusso. - Capitalized some variable names - Added more comments - Preferring binary searches to linear searches wherever possible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/ne

[PATCH] D58885: Variable auto-init: split out small arrays

jfb updated this revision to Diff 189085. jfb marked an inline comment as done. jfb added a comment. - typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58885/new/ https://reviews.llvm.org/D58885 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/auto-var-init.c

[PATCH] D58885: Variable auto-init: split out small arrays

jfb added a comment. I'll do a few size diffs to double-check that this also pays off. @glider can you also check that it doesn't regress what you've been looking at? Comment at: test/CodeGenCXX/auto-var-init.cpp:1133 // PATTERN-O1: bitcast -// PATTERN-O1: call void @llvm.mem

[PATCH] D58885: Variable auto-init: split out small arrays

jfb created this revision. jfb added reviewers: glider, pcc, kcc, rjmccall. Herald added subscribers: cfe-commits, jdoerfert, dexonsmith, jkorous. Herald added a project: clang. Following up with r355181, initialize small arrays as well. Repository: rC Clang https://reviews.llvm.org/D58885 F

[PATCH] D48259: [clang-format] Fix bug with UT_Always when there is less than one full tab

guigu abandoned this revision. guigu added a comment. Herald added a project: clang. Forgot about this one. While merging, noticed that it's fixed by https://reviews.llvm.org/D57655. The integrated fix is better as it handle the unlikely but possible tabwidth of 1. Closing. Repo

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk marked an inline comment as done. lewmpk added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:90 + for (auto i = 0; i < 3; i++) { +m.lock(); +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use RAII JonasToth wrote:

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 189078. lewmpk marked an inline comment as done. lewmpk added a comment. added example in docs and explicitly specified types for some variables Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://re

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

This revision was automatically updated to reflect the committed changes. Closed by commit rL355282: [clang] [ToolChains/NetBSD] Support relative libc++ header path (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r355282 - [clang] [ToolChains/NetBSD] Support relative libc++ header path

Author: mgorny Date: Sun Mar 3 02:06:34 2019 New Revision: 355282 URL: http://llvm.org/viewvc/llvm-project?rev=355282&view=rev Log: [clang] [ToolChains/NetBSD] Support relative libc++ header path Support locating the libc++ header files relatively to the clang executable, in addition to the defa