[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4620 const TargetInfo &TI = Context.getTargetInfo(); - TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC); + auto *Aux = Context.getAuxTargetInfo(); + if (LangOpts.CUDA) { --

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, it won't have a guarantee that it won't see unused annotations, but alright, I'm fine with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.ll

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D56411#1410598 , @yaxunl wrote: > In D56411#1410153 , @rjmccall wrote: > > > In D56411#1406212

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 ___ c

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

rjmccall added a comment. A couple tweaks, but otherwise LGTM. Comment at: clang/include/clang/AST/OperationKinds.def:203 +/// CK_FixedPointToIntegral - Fixed point to an integral. +///(int) 2.0k This is super-picky, but please either just say "integral"

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1411657 , @tstellar wrote: > Use macros instead of functions. I mean "Use functions instead of macros." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https:/

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188500. tstellar added a comment. Use macros instead of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 Files: clang/lib/Headers/CMakeLists.txt Index: c

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354949: [clangd] Library dependencies in XPC (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D58089?vs=186369&id=188494#toc Repository: rCTE Clang Tools Extr

[clang-tools-extra] r354949 - [clangd] Library dependencies in XPC

Author: jkorous Date: Tue Feb 26 18:37:44 2019 New Revision: 354949 URL: http://llvm.org/viewvc/llvm-project?rev=354949&view=rev Log: [clangd] Library dependencies in XPC Patch by Nicholas Allegra Differential Revision: https://reviews.llvm.org/D58089 Modified: clang-tools-extra/trunk/clang

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Reconsidered - let's fix the build first and I can finish my patch tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://r

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

jkorous requested changes to this revision. jkorous added a comment. This revision now requires changes to proceed. Hi @comex, I totally missed this! Thanks for the patch. I am not entirely happy about this dependency though. I am trying to split off the only parts of clangDaemon that XpcTranspor

[PATCH] D58518: [HIP] change kernel stub name

This revision was automatically updated to reflect the committed changes. Closed by commit rL354948: [HIP] change kernel stub name (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58518

r354948 - [HIP] change kernel stub name

Author: yaxunl Date: Tue Feb 26 18:02:52 2019 New Revision: 354948 URL: http://llvm.org/viewvc/llvm-project?rev=354948&view=rev Log: [HIP] change kernel stub name Add .stub to kernel stub function name so that it is different from kernel name in device code. This is necessary to let debugger find

r354946 - [index] Fixup for r354942. Specify target in test to achieve stable mangling.

Author: vsapsai Date: Tue Feb 26 17:37:43 2019 New Revision: 354946 URL: http://llvm.org/viewvc/llvm-project?rev=354946&view=rev Log: [index] Fixup for r354942. Specify target in test to achieve stable mangling. Modified: cfe/trunk/test/Index/ms-property.cpp Modified: cfe/trunk/test/Index/ms

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Thanks for reviewing the change! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354942: [index] Improve indexing support for MSPropertyDecl. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r354942 - [index] Improve indexing support for MSPropertyDecl.

Author: vsapsai Date: Tue Feb 26 17:04:53 2019 New Revision: 354942 URL: http://llvm.org/viewvc/llvm-project?rev=354942&view=rev Log: [index] Improve indexing support for MSPropertyDecl. Currently the symbol for MSPropertyDecl has kind `SymbolKind::Unknown` which can trip up various indexing tool

[PATCH] D58649: Fix inline assembler constraint validation

This revision was automatically updated to reflect the committed changes. Closed by commit rL354937: Fix inline assembler constraint validation (authored by joerg, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r354937 - Fix inline assembler constraint validation

Author: joerg Date: Tue Feb 26 16:40:59 2019 New Revision: 354937 URL: http://llvm.org/viewvc/llvm-project?rev=354937&view=rev Log: Fix inline assembler constraint validation The current constraint logic is both too lax and too strict. It fails for input outside the [INT_MIN..INT_MAX] range, but

[PATCH] D58649: Fix inline assembler constraint validation

efriedma added inline comments. Comment at: include/clang/Basic/TargetInfo.h:860 + if (!ImmSet.empty()) +return ImmSet.count(Value.getZExtValue()) != 0; + return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) && Value.sle(ImmRange.Max)); I

[PATCH] D58649: Fix inline assembler constraint validation

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Nice find! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58649/new/ https://reviews.llvm.org/D58649 ___ cfe-commits mailing list cfe

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. I think this is ready to continue to be reviewed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 ___ cfe-commits mailing list cfe-com

r354899 - [X86] AMD znver2 enablement

Author: ggopala Date: Tue Feb 26 09:15:36 2019 New Revision: 354899 URL: http://llvm.org/viewvc/llvm-project?rev=354899&view=rev Log: [X86] AMD znver2 enablement This patch enables the following 1) AMD family 17h "znver2" tune flag (-march, -mcpu). 2) ISAs that are enabled for "znver2" architect

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak updated this revision to Diff 188472. ahatanak marked an inline comment as done. ahatanak added a comment. Call `IgnoreParens` on the LHS too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 Files: include/clan

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. In D58147#1398094 , @rjmccall wrote: > Okay. Is it acceptable for the annotation to simply disappear in this case? > I don't really understand the purposes of annotations well enough to judge. Looks like it is acceptable. The

[PATCH] D58600: [clangd] Emit source to Diagnostic.

jkorous added inline comments. Comment at: clangd/Diagnostics.cpp:381 LastDiag = Diag(); +LastDiag->ID = Info.getID(); FillDiagBase(*LastDiag); Nit - is this really intended to be part of this patch? Comment at: clangd/Diagnostics

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

jkorous added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:266 +auto *NewAttrTy = cast(T.getTypePtr()); +for (TypeAttrPair &A : AttrsForTypes) { + if (A.first == AttrTy) Do you think it would make sense to terminate the loop e

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Probably worth sending an email to llvmdev noting that the datalayout is changing before you merge this, so a wider audience can review the IR aspects of the change. Otherwise LGTM Repo

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for looking into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-c

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Maybe update at least some of the tests using these targets to additionally run with the new pass manager explicitly enabled via flag? Comment at: clang/lib/

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

This revision was automatically updated to reflect the committed changes. Closed by commit rC354929: [CUDA][HIP] Check calling convention based on function target (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

r354929 - [CUDA][HIP] Check calling convention based on function target

Author: yaxunl Date: Tue Feb 26 14:24:49 2019 New Revision: 354929 URL: http://llvm.org/viewvc/llvm-project?rev=354929&view=rev Log: [CUDA][HIP] Check calling convention based on function target MSVC header files using vectorcall to differentiate overloaded functions, which causes failure for AMD

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188461. jdoerfert added a comment. Remove unneeded changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntimeTRegion.cpp cla

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188462. jdoerfert added a comment. Remove more unneeded changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntimeTRegion.cpp

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188460. jdoerfert added a comment. Remove leftover debug msgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert added a comment. I updated the patch with one that has a clean clang and runtime integration. It passes all but one OpenMP V&V test suite test (developed as part of ECP by U Del and others). The LLVM optimization gives us 30% speedup on the rodinia3.1/nw (Needleman Wunsch) benchmark (

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188458. jdoerfert added a comment. Herald added projects: clang, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits. Cleaned up clang part and interface. LLVM part still needs work Repository: rG LLVM Github Monorepo CHANG

[PATCH] D58518: [HIP] change kernel stub name

tra accepted this revision. tra added subscribers: jyknight, bkramer. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CodeGenModule.cpp:1059 +FD->hasAttr()) + MangledName = MangledName + ".stub"; +

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks for the fixes! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 ___

[PATCH] D57590: [ASTImporter] Improve import of FileID.

a_sidorin added a comment. Hi Gabor, Sorry, missed the patch. It looks mostly good, but do we have any test for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-c

r354928 - [OPENMP][CUDA]Do not emit warnings for variables in late-reported asm

Author: abataev Date: Tue Feb 26 13:51:16 2019 New Revision: 354928 URL: http://llvm.org/viewvc/llvm-project?rev=354928&view=rev Log: [OPENMP][CUDA]Do not emit warnings for variables in late-reported asm statements. If the assembler instruction is not generated and the delayed diagnostic is emitt

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57716/new/ https://reviews.llvm.org/D57716 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D57590: [ASTImporter] Improve import of FileID.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM I don't see any LLDB test regressions but I would prefer another reviewer as well. I am going to be modifying this soon to fix some issues w/ handling built-ins. Repository: rC Clang

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. Herald added a subscriber: Charusso. In D46421#1382017 , @martong wrote: > > I think you should change back to getInit() > > I am not entirely sure about this because the initalizer may not be attached > to the canonical decl. `getIni

r354925 - [OPENMP]Delay emission for unsupported va_arg expression.

Author: abataev Date: Tue Feb 26 12:52:16 2019 New Revision: 354925 URL: http://llvm.org/viewvc/llvm-project?rev=354925&view=rev Log: [OPENMP]Delay emission for unsupported va_arg expression. If the OpenMP device is NVPTX and va_arg is used, delay emission of the error for va_arg unless it is use

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

This revision was automatically updated to reflect the committed changes. Closed by commit rL354924: [MS] Don't emit coverage for deleting dtors (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r354924 - [MS] Don't emit coverage for deleting dtors

Author: rnk Date: Tue Feb 26 12:42:52 2019 New Revision: 354924 URL: http://llvm.org/viewvc/llvm-project?rev=354924&view=rev Log: [MS] Don't emit coverage for deleting dtors Summary: The MS C++ ABI has no constructor variants, but it has destructor variants, so we should move the deleting destruc

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl added a comment. Please add changes to option documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. In D57590#1411055 , @efriedma wrote: > I don't know anything about this particular patch, but you aren't allowed to > set deadlines like that; the patch review process requires that the patch is > actually reviewed. If you aren'

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks! Lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58691/new/ https://reviews.llvm.org/D58691

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1411086 , @tra wrote: > >> E.g.: > >> > >> namespace { > >> __host__ __device__ a() { > >> int prev; > >> __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); > >> return prev; > >> } > >> > >> __hos

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. >> E.g.: >> >> namespace { >> __host__ __device__ a() { >> int prev; >> __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); >> return prev; >> } >> >> __host__ __device__ b() { >> int prev; >> return prev; >> } >> >> } //namespace >> >>

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk added inline comments. Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28 +// FIXME: Should we emit coverage info for deleting dtors? They do contain +// conditional branches. LLVM IR PGO will insrument them just fine, though. + vsk wrote: > Probably

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk updated this revision to Diff 188434. rnk marked 3 inline comments as done. rnk added a comment. - fix CHECK-NOT - FIXME that isn't needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58691/new/ https://reviews.llvm.org/D58691 Files: clang/

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

efriedma added a comment. I thought the plan was to fix whatever issue was causing the -O0 tests to fail, then rebase on top of that? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1411039 , @tra wrote: > > Hi Artem, I think we can just delay emission of this warning to solve this > > problem. > > I'm not sure we can always tell whether the warning is real or if it's the > consequence of failing t

[PATCH] D57590: [ASTImporter] Improve import of FileID.

efriedma added a comment. I don't know anything about this particular patch, but you aren't allowed to set deadlines like that; the patch review process requires that the patch is actually reviewed. If you aren't getting a response, ask on cfe-dev. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added a comment. @rjmccall @ebevhan @bjope *ping* any other comments on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 ___ cfe-commits mailing list cf

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

vsk added inline comments. Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28 +// FIXME: Should we emit coverage info for deleting dtors? They do contain +// conditional branches. LLVM IR PGO will insrument them just fine, though. + Probably not. IIUC th

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. > Hi Artem, I think we can just delay emission of this warning to solve this > problem. I'm not sure we can always tell whether the warning is real or if it's the consequence of failing to parse inline asm. E.g.: namespace { __host__ __device__ a() { int prev;

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Herald added a subscriber: jdoerfert. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

rnk added a comment. Sounds good, thanks for debugging this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

RE: r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

You're right. It was already there after Ganesh's patch this morning. I hadn't updated my clang tree so I thought it was missing. Sorry. -Original Message- From: Roman Lebedev [mailto:lebedev...@gmail.com] Sent: Tuesday, February 26, 2019 11:29 AM To: Topper, Craig Cc: cfe-commits@lists

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk created this revision. rnk added a reviewer: vsk. Herald added a subscriber: jdoerfert. Herald added a project: clang. The MS C++ ABI has no constructor variants, but it has destructor variants, so we should move the deleting destructor variant check outside the check for "does the ABI have co

Re: r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

Doesn't look like this patch added 'znver2'? On Tue, Feb 26, 2019 at 10:20 PM Craig Topper via cfe-commits wrote: > > Author: ctopper > Date: Tue Feb 26 11:20:04 2019 > New Revision: 354915 > > URL: http://llvm.org/viewvc/llvm-project?rev=354915&view=rev > Log: > [X86] Add 'znver2' and 'cascadela

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354916: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added

r354916 - [ASTImporter] Add support for importing ChooseExpr AST nodes.

Author: tmroeder Date: Tue Feb 26 11:26:41 2019 New Revision: 354916 URL: http://llvm.org/viewvc/llvm-project?rev=354916&view=rev Log: [ASTImporter] Add support for importing ChooseExpr AST nodes. Summary: This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr c

r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

Author: ctopper Date: Tue Feb 26 11:20:04 2019 New Revision: 354915 URL: http://llvm.org/viewvc/llvm-project?rev=354915&view=rev Log: [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test. These are supported by at least libgcc trunk so we can include them now. Modified: cfe/trun

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188423. jkorous marked 4 inline comments as done. jkorous added a comment. - Use RetryAfterSignal - Propagate events from inotify directly - Remove ModTime - Add assert for unknown event kinds CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. I'm going to submit this patch again, since that I believe I understand the problem, and I have tested this version on Win10 with the latest MSVC (other than the expectation that I just added, but that test wasn't a problem on the Windows builders, and the new expectat

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 18 inline comments as done. jkorous added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:116 + + DirectoryWatcher::EventKind K = DirectoryWatcher::EventKind::Added; + if (ievt->mask & IN_MODIFY) { jko

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1410900 , @tra wrote: > There's a new quirk we've ran into after this patch landed. Consider this > code: > > int foo() { > int prev; > __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); > return prev; >

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

NoQ added a comment. Hi, thanks!, i think this is correct. As in, `LocAsInteger` was clearly a mistake to begin with, but this change shouldn't make it worse. You should be able to get away with not supporting comparisons between regions without symbolic base [as integers] and concrete integers

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rC354909: [AMDGPU] Allow using integral non-type template parameters (authored by hliao, committed by ). Changed prior to commit: https://reviews.llvm.org/D58623?vs=188172&id=188416#toc Repository: rC

r354909 - [AMDGPU] Allow using integral non-type template parameters

Author: hliao Date: Tue Feb 26 10:49:36 2019 New Revision: 354909 URL: http://llvm.org/viewvc/llvm-project?rev=354909&view=rev Log: [AMDGPU] Allow using integral non-type template parameters Summary: - Allow using integral non-type template parameters in the following attributes __attribute_

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. There's a new quirk we've ran into after this patch landed. Consider this code: int foo() { int prev; __asm__ __volatile__("whatever" : "=a" (prev)::); return prev; } When we compile for device, asm constraint is not valid for NVPTX, we emit delayed diag and

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188411. jdoerfert marked an inline comment as done. jdoerfert added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files: clang/include/clang/B

[clang-tools-extra] r354903 - [clang-tidy] undo bitfields in ExceptionAnalyzer

Author: jonastoth Date: Tue Feb 26 10:15:17 2019 New Revision: 354903 URL: http://llvm.org/viewvc/llvm-project?rev=354903&view=rev Log: [clang-tidy] undo bitfields in ExceptionAnalyzer Scoped enums do induce some problems with some MSVC and GCC versions if used as bitfields. Therefor this is deac

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58623/new/ https://reviews.llvm.org/D58623 __

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255 + // in the other unit it has none. + if (LangTo.CPlusPlus11 != LangFrom.CPlusPlus11 || + LangTo.CPlusPlus14 != LangFrom.CPlusPlus14 || ---

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188397. tmroeder added a comment. Added the other expectation, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D58683: [clangd] Set thread priority on Windows

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, gribozavr. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58683 Files: clang-tools-extra/clangd/Threading.

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

This revision was automatically updated to reflect the committed changes. Closed by commit rL354899: [X86] AMD znver2 enablement (authored by ggopala, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58344?

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

This revision was automatically updated to reflect the committed changes. Closed by commit rL354897: [X86] AMD znver2 enablement (authored by ggopala, committed by ). Changed prior to commit: https://reviews.llvm.org/D58343?vs=187389&id=188391#toc Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57716/new/ https://reviews.llvm.org/D57716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); +template static aut

r354893 - [OpenCL] Fix assertion due to blocks

Author: yaxunl Date: Tue Feb 26 08:20:41 2019 New Revision: 354893 URL: http://llvm.org/viewvc/llvm-project?rev=354893&view=rev Log: [OpenCL] Fix assertion due to blocks A recent change caused assertion in CodeGenFunction::EmitBlockCallExpr when a block is called. There is code Func = CGM.ge

[PATCH] D58658: [OpenCL] Fix assertion due to blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC354893: [OpenCL] Fix assertion due to blocks (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58658/new/ h

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 188379. martong marked 4 inline comments as done. martong added a comment. - getDefinition -> getTemplateDefinition - Remove comments for braces, added FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://re

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev created this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, arphaman, mgrang, hiraditya, mgorny, mehdi_amini. Herald added projects: clang, LLVM. This is the first part of time tracing system, I have splitted them cause this part is mostly written by Ar

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright marked an inline comment as done. hwright added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:97 +void TimeSubtractionCheck::check(const MatchFinder::MatchResult &Result) { + const auto *BinOp = Result.Nodes.getNodeAs("binop"); + std::string in

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1410153 , @rjmccall wrote: > In D56411#1406212 , @yaxunl wrote: > > > I would like to fix the validation issue only and leave the overload > > resolution issue for future. > > > As

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright updated this revision to Diff 188372. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58137/new/ https://reviews.llvm.org/D58137 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationRewriter.cpp clang-tidy/abseil/DurationR

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11292 +} + +/// Argument's value might be modified, so update the info. riccibruno wrote: > Hmm, I don't think that this will work. Suppose that you have

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

MyDeveloperDay added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang/lib/Format/ContinuationIndenter.cpp:193 RawStringFormat.Language, &PredefinedStyle)) { -PredefinedStyle = getLLVMStyle(); +PredefinedStyle

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio added a comment. Thank you for all the reviews! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

This revision was automatically updated to reflect the committed changes. emilio marked an inline comment as done. Closed by commit rC354885: [libclang] Avoid crashing when getting layout info of an undeduced type. (authored by emilio, committed by ). Changed prior to commit: https://reviews.ll

  1   2   >