vsk added inline comments.
================
Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28
+// FIXME: Should we emit coverage info for deleting dtors? They do contain
+// conditional branches. LLVM IR PGO will insrument them just fine, though.
+
----------------
Probably not. IIUC the branches aren't visible at the source-level?
================
Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:52
+
+// LINUX-NOT: @__profn_{{.*}}D[01]Ev =
+// LINUX: @__profn__ZN10DerivedABCD2Ev =
----------------
Do you need {{[01]}}?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58691/new/
https://reviews.llvm.org/D58691
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
