r354549 - Revert r354546

Author: serge_sans_paille Date: Wed Feb 20 22:59:21 2019 New Revision: 354549 URL: http://llvm.org/viewvc/llvm-project?rev=354549&view=rev Log: Revert r354546 This triggers an ICE on gcc 7, see http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/17598/steps/build%20stage%201/logs/

r354548 - Fix typo in r354546

Author: serge_sans_paille Date: Wed Feb 20 22:12:41 2019 New Revision: 354548 URL: http://llvm.org/viewvc/llvm-project?rev=354548&view=rev Log: Fix typo in r354546 Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h URL: http

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Hi Jonas, I've committed what I think should be a fix for the build issue in r354545. Douglas Yung -Original Message- From: cfe-commits On Behalf Of via cfe-commits Sent: Wednesday, February 20, 2019 16:57 To: jonas.t...@gmail.com Cc: cfe-commits@lists.llvm.org Subject: RE: [clang-tool

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL354546: [NFC] Always initialize all members in ABIArgInfo (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57523?vs=184529

[clang-tools-extra] r354545 - Attempt to fix VS2015 build breakage from r354517. NFCI.

Author: dyung Date: Wed Feb 20 20:55:31 2019 New Revision: 354545 URL: http://llvm.org/viewvc/llvm-project?rev=354545&view=rev Log: Attempt to fix VS2015 build breakage from r354517. NFCI. Modified: clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h Modified: clang-tools-extra/trun

r354546 - [NFC] Always initialize all members in ABIArgInfo

Author: serge_sans_paille Date: Wed Feb 20 20:55:50 2019 New Revision: 354546 URL: http://llvm.org/viewvc/llvm-project?rev=354546&view=rev Log: [NFC] Always initialize all members in ABIArgInfo Differential Revision: https://reviews.llvm.org/D57523 Modified: cfe/trunk/include/clang/CodeGen/C

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

serge-sans-paille added a comment. @hans agreed; Thanks for taking the time to try to reproduce the original issue o/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57523/new/ https://reviews.llvm.org/D57523 ___ cfe-

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ added a comment. Thx!~ In D58368#1404747 , @Charusso wrote: > This is a cool approach, but it is difficult to use this API in other > checkers. If you do not out-chain D58367 I > would like to see something like tha

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

srhines accepted this revision. srhines added a comment. Dan, this seems pretty important for the NDK. If you submit this, would you want it cherry-picked ASAP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58477/new/ https://reviews.llvm.org/D584

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + -

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + ebevhan wrote: > leonardchan wrote

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 187706. leonardchan marked an inline comment as done. Herald added a subscriber: jdoerfert. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/Operatio

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. So I was able compile a couple of C++ code bases through csa-testbench. I built cppcheck and tinyxml2 without any problems. cppcheck has one invocation std::sort but the keys are not pointers whereas tinyxml2 does not use std::sort. I tried bitcoin, rtags, xerces but run

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187698. smeenai retitled this revision from "[clang] Add install targets for development headers" to "[clang] Add install targets for library headers". smeenai edited the summary of this revision. smeenai added a comment. Update description Repository: rG

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187697. smeenai added a comment. Switch to clang-library-headers pending cfe-dev discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 Files: clang/CMakeLists.tx

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

ab added a comment. Thanks for checking, much appreciated! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58306/new/ https://reviews.llvm.org/D58306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354538: [AArch64] Change size suffix for FP16FML intrinsics. (authored by ab, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r354538 - [AArch64] Change size suffix for FP16FML intrinsics.

Author: ab Date: Wed Feb 20 17:13:27 2019 New Revision: 354538 URL: http://llvm.org/viewvc/llvm-project?rev=354538&view=rev Log: [AArch64] Change size suffix for FP16FML intrinsics. These currently use _u32, but they should instead use _f16, the types of the multiplication (matching the various i

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ marked 3 inline comments as done. NoQ added a comment. Thx! Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ostream OS(Str); +OS << "Deallocating object passed through parameter '" << PVD->getName() + << '\''; --

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Hi Jonas, Your commit seems to hit a compilation error on our internal build bot when built on Windows using Visual Studio 2015. Can you take a look? ExceptionAnalyzer.cpp c:\src\upstream\llvm_clean\tools\clang\tools\extra\clang-tidy\utils\ExceptionAnalyzer.h(112): error C3431: 'State': a sco

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1403653 , @Szelethus wrote: > In D50488#1403197 , @mgrang wrote: > > > > It's because it invokes CodeChecker, which by default enables > > > valist.Uninitialized, but not ValistBas

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187695. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

This revision was automatically updated to reflect the committed changes. stephanemoore marked an inline comment as done. Closed by commit rCTE354534: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈 (authored by stephanemoore, committed by ). Changed prior to commit: h

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D58478: [index-while-building] FileIndexRecord

Eugene.Zelenko added inline comments. Comment at: clang/include/clang/Index/DeclOccurrence.h:1 +//===--- DeclOccurrence.h - An occurrence of a decl within a file -===// +// Missing C++ tag. See other headers as example. Comment at: cla

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

a_sidorin added a comment. Hi Tom, Thank for the fixes, now the patch looks almost fine. I have a small nit inline, but I think the patch can land after this fix. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto

r354531 - [attributes] Fix buildbot after r354530.

Author: dergachev Date: Wed Feb 20 16:19:24 2019 New Revision: 354531 URL: http://llvm.org/viewvc/llvm-project?rev=354531&view=rev Log: [attributes] Fix buildbot after r354530. Update the test after adding more attribute subjects. Differential Revision: https://reviews.llvm.org/D58365 Modified:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354530: [attributes] Add an attribute for server routines in Mach kernel and extensions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

r354530 - [attributes] Add an attribute for server routines in Mach kernel and extensions.

Author: dergachev Date: Wed Feb 20 16:01:02 2019 New Revision: 354530 URL: http://llvm.org/viewvc/llvm-project?rev=354530&view=rev Log: [attributes] Add an attribute for server routines in Mach kernel and extensions. The new __attribute__ ((mig_server_routine)) is going to be used for annotating

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. Herald added subscribers: jdoerfert, arphaman. @apaprocki, as mentioned in our recent RFC ( http://lists.llvm.org/pipermail/llvm-dev/2019-February/130175.html ), IBM is working on AIX support for Clang and LLVM. We would like to continue the work on this

[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1404966 , @smeenai wrote: > In D58317#1404961 , @phosek wrote: > > > In D58317#1400223 , @smeenai wrote: > > > > > I'm not entirely happy wi

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor documentation nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4049 +it will be automatically applied to overrides if the method is virtual. The +attribute can be written using C++11 sy

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

This revision was automatically updated to reflect the committed changes. Closed by commit rL354527: [clang] Add CMake target for installing clang's CMake exports (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58317: [clang] Add install targets for development headers

smeenai added a comment. In D58317#1404961 , @phosek wrote: > In D58317#1400223 , @smeenai wrote: > > > I'm not entirely happy with the name clang-dev-headers, and am open to > > suggestions. It's unfortunate clang

r354527 - [clang] Add CMake target for installing clang's CMake exports

Author: smeenai Date: Wed Feb 20 15:16:15 2019 New Revision: 354527 URL: http://llvm.org/viewvc/llvm-project?rev=354527&view=rev Log: [clang] Add CMake target for installing clang's CMake exports This mirrors LLVM's install-cmake-exports target. Differential Revision: https://reviews.llvm.org/D5

[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1400223 , @smeenai wrote: > I'm not entirely happy with the name clang-dev-headers, and am open to > suggestions. It's unfortunate clang-headers was already taken for something > different, but renaming that target or in

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

This revision was automatically updated to reflect the committed changes. Closed by commit rL354525: [clang] Switch to LLVM_ENABLE_IDE (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https://reviews.llvm.org/D58284 ___

r354525 - [clang] Switch to LLVM_ENABLE_IDE

Author: smeenai Date: Wed Feb 20 15:08:43 2019 New Revision: 354525 URL: http://llvm.org/viewvc/llvm-project?rev=354525&view=rev Log: [clang] Switch to LLVM_ENABLE_IDE r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES, which expresses the

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58480/new/ https://reviews.llvm.org/D58480 ___

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. smeenai retitled this revision from "[clang] Add CMake target for clang's CMake exports" to "[clang] Add CMake target for installing clang's CMake exports". Thi

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous created this revision. jkorous added reviewers: dexonsmith, nathawes, akyrtzi, arphaman, ioeric, malaperle. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. Basic data structures for index Tests are missing from this patch - will be covered properl

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Android doesn't regress back to soft float after ARMv7 :) Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58477 File

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you. Comment at: lib/Sema/Sema.cpp:1494-1496 +if (getLangOpts().CUDAIsDevice) + return CUDADiagIfDeviceCode(Loc, DiagID); +return CUDADiagIfHostCode(Loc, DiagID)

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:277 + } + return ""; +} peter.smith wrote: > I'm a bit worried that we've changed the default behaviour for gnueabi[hf] > targets here. > For example with: > ``` > .text > v

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert updated this revision to Diff 187670. danalbert marked 6 inline comments as done. danalbert added a comment. Updated to address some review comments: - Additional tests for gnueabi/gnueabihf - Fixed behavior for `-mfpu=neon -mfloat-abi=soft`, added test. Repository: rG LLVM Github M

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:47 REGISTER_TRAIT_WITH_PROGRAMSTATE(ReleasedParameter, bool); `;` is not necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://revie

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso added a comment. In D53076#1403436 , @NoQ wrote: > I'll take a closer look in a few days, sorry for the delays! The progress > you're making is fantastic and i really appreciate your work, but i have an > urgent piece of work of my own to deal w

[clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Author: jonastoth Date: Wed Feb 20 13:04:36 2019 New Revision: 354517 URL: http://llvm.org/viewvc/llvm-project?rev=354517&view=rev Log: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer Summary: The analsis on the throwing behvaiour on functions and statements gave only a bin

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D57883?vs=187635&id=187662#toc

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added a reviewer: Charusso. Charusso requested changes to this revision. Charusso added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:113 + }); + C.addTransition(C.getState()->set(true), T);

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Charusso requested changes to this revision. Charusso added a comment. This revision now requires changes to proceed. First of all, thanks you for working on this, as I wanted to do the same, but I did not know how to. I did not know also that 15 of the checkers already implements `BugReporterVi

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ added inline comments. Comment at: clang/test/Sema/attr-mig.c:6 + +__attribute__((mig_server_routine)) kern_return_t var = KERN_SUCCESS; // expected-warning-re{{'mig_server_routine' attribute only applies to functions, Objective-C methods, and blocks{{$ + --

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ updated this revision to Diff 187656. NoQ marked 5 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/

r354512 - Make predefined FLT16 macros conditional on support for the type

Author: nemanjai Date: Wed Feb 20 12:27:33 2019 New Revision: 354512 URL: http://llvm.org/viewvc/llvm-project?rev=354512&view=rev Log: Make predefined FLT16 macros conditional on support for the type We unconditionally predefine these macros. However, they may be used to determine if the type is

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

This revision was automatically updated to reflect the committed changes. Closed by commit rL354512: Make predefined FLT16 macros conditional on support for the type (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

r354509 - [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC.

Author: abataev Date: Wed Feb 20 11:37:17 2019 New Revision: 354509 URL: http://llvm.org/viewvc/llvm-project?rev=354509&view=rev Log: [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/lib/Sema/SemaStmt.cpp Modif

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187635. JonasToth marked an inline comment as done. JonasToth added a comment. - be explicit about the State enumerator values Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 3 inline comments as done. JonasToth added a comment. all comments resolved. I will land this now. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:26-31 + enum class State : std::int8_t { +Throwing,///< The function can definitly throw given an AST. +

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187634. JonasToth marked 2 inline comments as done. JonasToth added a comment. - [Refactor] move support classes into the analyzer - [Refactor] move bigger methods into implementation file - minor adjustments Repository: rCTE Clang Tools Extra CHANGES S

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added a comment. Also, don't forget that `inotify()` is not 100% reliable on Linux, and it can miss events under high loads. So technically you should probably include periodic directory scans if you are going to rely on this actually reporting every file added. Comme

[clang-tools-extra] r354507 - [clangd] Fix a crash in Selection

Author: ibiryukov Date: Wed Feb 20 11:26:39 2019 New Revision: 354507 URL: http://llvm.org/viewvc/llvm-project?rev=354507&view=rev Log: [clangd] Fix a crash in Selection Summary: The assertion checking that a range of a node is a token range does not hold in case of "split" tokens, e.g. between t

[PATCH] D58447: [clangd] Fix a crash in Selection

This revision was automatically updated to reflect the committed changes. Closed by commit rL354507: [clangd] Fix a crash in Selection (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson abandoned this revision. aemerson added a comment. After discussion on the thread, we can implement this requirement with -nolibc -nostdlib++ -nostartfiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58320/new/ https://reviews.llvm.org/

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:47 + // headers (e.g. std::move from and ), using + // qualified name can not disambiguate headers. Instead we should return all + // headers and do the disam

[PATCH] D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354502: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. (authored by sivachandra, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

This revision was automatically updated to reflect the committed changes. Closed by commit rL354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index' (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58440?vs=187627&id=187629#toc Repos

[clang-tools-extra] r354505 - [clangd] Store index in '.clangd/index' instead of '.clangd-index'

Author: ibiryukov Date: Wed Feb 20 11:08:06 2019 New Revision: 354505 URL: http://llvm.org/viewvc/llvm-project?rev=354505&view=rev Log: [clangd] Store index in '.clangd/index' instead of '.clangd-index' Summary: To take up the .clangd folder for other potential uses in the future. Reviewers: kad

r354503 - Fix remaining semicolon pedantic errors for intel

Author: martong Date: Wed Feb 20 11:07:36 2019 New Revision: 354503 URL: http://llvm.org/viewvc/llvm-project?rev=354503&view=rev Log: Fix remaining semicolon pedantic errors for intel Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp

r354502 - [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

Author: sivachandra Date: Wed Feb 20 11:07:04 2019 New Revision: 354502 URL: http://llvm.org/viewvc/llvm-project?rev=354502&view=rev Log: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. Summary: This change mimics GCC's support for the "-static-pie" argument. Subscribe

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov updated this revision to Diff 187627. ilya-biryukov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update .gitignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.l

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 187623. jkorous added a comment. [DirectoryWatcher] Fix detection of FSEvents for iOS [DirectoryWatcher][NFC] Doxygen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWat

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDirectory, ".clangd-index/"); +llvm::sys::path::append(CDBDirectory, ".clangd", "

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov updated this revision to Diff 187622. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove trailing slash from the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.llvm.o

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev created this revision. ABataev added reviewers: tra, jlebar. Herald added a subscriber: jdoerfert. Herald added a project: clang. Adapted targetDiag for the CUDA and used for the delayed diagnostics in asm constructs. Works for both host and device compilation sides. Repository: rC Cla

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8702 +def warn_mig_server_routine_does_not_return_kern_return_t : Warning< + "'%0' attribute only applies to functions that return a kernel return code">, + InGroup; --

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D53701: [Analyzer] Record and process comparison of symbols instead of iterator positions in interator checkers

baloghadamsoftware updated this revision to Diff 187611. baloghadamsoftware added a comment. Instead of recording comparisons do an eager state split if the result is a symbolic value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53701/new/ https://reviews.llvm.org/D53701 Files: li

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

aaron.ballman added a comment. Still LGTM, thanks for adding the license snippet! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58095/new/ https://reviews.llvm.org/D58095 ___ cfe-commits mailing list c

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354486: [OPENMP] Delay emission of the asm target-specific error messages. (authored by ABataev, committed by ). Herald ad

r354486 - [OPENMP] Delay emission of the asm target-specific error messages.

Author: abataev Date: Wed Feb 20 09:42:57 2019 New Revision: 354486 URL: http://llvm.org/viewvc/llvm-project?rev=354486&view=rev Log: [OPENMP] Delay emission of the asm target-specific error messages. Summary: Added the ability to emit target-specific builtin assembler error messages only in case

[PATCH] D56896: Update property prefix regex to allow numbers.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354485: Update property prefix regex to allow numbers. (authored by Wizard, committed by ). Herald added a subscriber: jdoerfert. Herald added a project: clang. Changed prior to commit: https://review

[clang-tools-extra] r354485 - Update property prefix regex to allow numbers.

Author: wizard Date: Wed Feb 20 09:32:41 2019 New Revision: 354485 URL: http://llvm.org/viewvc/llvm-project?rev=354485&view=rev Log: Update property prefix regex to allow numbers. Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D56896 Modified: clang-tools-extr

r354482 - Fix compile error with Intel's compiler (-Werror=pedantic)

Author: martong Date: Wed Feb 20 08:57:41 2019 New Revision: 354482 URL: http://llvm.org/viewvc/llvm-project?rev=354482&view=rev Log: Fix compile error with Intel's compiler (-Werror=pedantic) An extra semicolon at the end of macro invocations caused a build bot failure for Intel's compiler when

[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL354481: [CodeGen] Enable the complex-math test for arm (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

r354481 - [CodeGen] Enable the complex-math test for arm

Author: phosek Date: Wed Feb 20 08:53:08 2019 New Revision: 354481 URL: http://llvm.org/viewvc/llvm-project?rev=354481&view=rev Log: [CodeGen] Enable the complex-math test for arm This test wasn't running due to a missing : after the RUN statement. Enabling this test revealed that it's actually b

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDire

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Great! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 ___ cfe-commits mail

[PATCH] D58449: Junk: Add assert to find GCCBuiltins with constant arguments missing

arsenm created this revision. arsenm added a reviewer: atanasyan. Herald added subscribers: jdoerfert, fedor.sergeev, aheejin, wdng, dschuff. Don't bother reviewing this, I have no intention of committing this hack to find builtins missing immarg https://reviews.llvm.org/D58449 Files: lib/Se

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1404053 , @riccibruno wrote: > Wait no, can you really define the `SanitizerMask`s in the header ? Isn't > that an odr violation ? A yes I better move the definitions, thanks! CHANGES SINCE LAST ACTION https://re

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. I can confirm that this fix is effective at addressing the problem we experienced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:131 +static const BlockExpr *getBlockExpr(const Expr *E) { + if (auto Cast = dyn_cast(E)) { +E = Cast->getSubExpr(); Anastasia wrot

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187575. AlexeySotkin added a comment. Fix resolving of block invoke function in case of sequence of assignments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp lib/C

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia updated this revision to Diff 187573. Anastasia added a comment. Added a CodeGen test to cover address space of reference in `reinterpret_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 Files: include/clang/Basic/DiagnosticSem

[PATCH] D58447: [clangd] Fix a crash in Selection

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 ___

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno requested changes to this revision. riccibruno added a comment. This revision now requires changes to proceed. Wait no, can you really define the `SanitizerMask`s in the header ? Isn't that an odr violation ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://r

[PATCH] D58447: [clangd] Fix a crash in Selection

ilya-biryukov updated this revision to Diff 187569. ilya-biryukov added a comment. - Fix a syntax error in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 Files: clang-tools-extra/clangd/Selectio

  1   2   >