[PATCH] D58065: [analyzer] Document the frontend library

NoQ added a comment. In D58065#1400615 , @Szelethus wrote: > I've also wasted my second weekend trying to make Static Analyzer unit tests > run under check-clang-analysis :) I tried to have a quick look but got confused pretty quickly. In D58065#140061

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

ABataev added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58243/new/ https://reviews.llvm.org/D58243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

SjoerdMeijer added a comment. I am discussing this with our GCC team as we would like both Clang/GCC implementation to be the same. But you're right that _f16 looks like to be the more consistent choice. I will let you know as soon I know more. Repository: rC Clang CHANGES SINCE LAST ACTION

r354235 - [analyzer] Make valist.Uninitialized depend on ValistBase

Author: szelethus Date: Sun Feb 17 11:51:42 2019 New Revision: 354235 URL: http://llvm.org/viewvc/llvm-project?rev=354235&view=rev Log: [analyzer] Make valist.Uninitialized depend on ValistBase Accidentally left this dependency out, resulting in an assert failure if only valist.Uninitialized is e

r354233 - [NFC] Add a llvm_unreachable to silence a warning in SubstObjCTypeArgsVisitor

Author: brunoricci Date: Sun Feb 17 11:18:38 2019 New Revision: 354233 URL: http://llvm.org/viewvc/llvm-project?rev=354233&view=rev Log: [NFC] Add a llvm_unreachable to silence a warning in SubstObjCTypeArgsVisitor All cases in the switch are covered. NFC. Modified: cfe/trunk/lib/AST/Type.c

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus added a comment. Thanks for the review on my patches! I'm a little busy atm (I've also wasted my second weekend trying to make Static Analyzer unit tests run under check-clang-analysis), but I'll see to fixing these in the coming weeks. In D58065#1400154

r354232 - Recommit "[AST] Factor out the logic of the various Expr::Ignore*"

Author: brunoricci Date: Sun Feb 17 10:50:51 2019 New Revision: 354232 URL: http://llvm.org/viewvc/llvm-project?rev=354232&view=rev Log: Recommit "[AST] Factor out the logic of the various Expr::Ignore*" (Originally commited in r354215 and reverted in r354216 because of a missed failing clang-ti

[clang-tools-extra] r354228 - [clang-tidy][NFCI] DanglingHandleCheck: Remove a superflous IgnoreParenImpCasts

Author: brunoricci Date: Sun Feb 17 10:21:54 2019 New Revision: 354228 URL: http://llvm.org/viewvc/llvm-project?rev=354228&view=rev Log: [clang-tidy][NFCI] DanglingHandleCheck: Remove a superflous IgnoreParenImpCasts ExprWithCleanups is currently not skipped by IgnoreParenImpCasts, but is skipped

[PATCH] D47127: [RISCV] Default enable RISCV linker relaxation

This revision was automatically updated to reflect the committed changes. Closed by commit rC354222: [RISCV] Default enable RISCV linker relaxation (authored by shiva, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47127/new/ https://reviews.llvm.or

r354222 - [RISCV] Default enable RISCV linker relaxation

Author: shiva Date: Sun Feb 17 08:05:51 2019 New Revision: 354222 URL: http://llvm.org/viewvc/llvm-project?rev=354222&view=rev Log: [RISCV] Default enable RISCV linker relaxation Differential Revision: https://reviews.llvm.org/D47127 Modified: cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D47127: [RISCV] Default enable RISCV linker relaxation

shiva0217 updated this revision to Diff 187160. shiva0217 changed the repository for this revision from rL LLVM to rC Clang. shiva0217 edited projects, added clang; removed LLVM. shiva0217 added a comment. Update patch to address Alex's comment. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

malcolm.parsons added a comment. Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's macro automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 ___ cfe-commits ma

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG but is this information really useful to users? According to LSP `The diagnostic's code, which might appear in the user interface.`, I think seeing this will be mostly noise for users.

r354216 - Revert "[AST] Factor out the logic of the various Expr::Ignore*"

Author: brunoricci Date: Sun Feb 17 05:47:29 2019 New Revision: 354216 URL: http://llvm.org/viewvc/llvm-project?rev=354216&view=rev Log: Revert "[AST] Factor out the logic of the various Expr::Ignore*" This breaks some clang-tidy checks. For some reason they were not included in check-clang ? M

Re: [PATCH] D58326: [Driver][Gnu] Support -nolibc flag

See https://fuchsia.googlesource.com/fuchsia/+/48c987febf4077e52985f1ce1edc957b39bc5481/zircon/public/gn/config/BUILD.gn#219 and https://fuchsia.googlesource.com/fuchsia/+/48c987febf4077e52985f1ce1edc957b39bc5481/zircon/public/gn/config/libc-dummy for what happens without it... On Sat, Feb 16, 201

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

This revision was automatically updated to reflect the committed changes. Closed by commit rL354215: [AST] Factor out the logic of the various Expr::Ignore* (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

r354215 - [AST] Factor out the logic of the various Expr::Ignore*

Author: brunoricci Date: Sun Feb 17 05:32:39 2019 New Revision: 354215 URL: http://llvm.org/viewvc/llvm-project?rev=354215&view=rev Log: [AST] Factor out the logic of the various Expr::Ignore* Now that the implementation of all of the Expr::Ignore* is in Expr.cpp we can try to remove some duplica

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 187155. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Address review comments - change OverrideMacro to OverrideSpelling - change FinalMacro to FinalSpelling - fix unit tests - show warning without fix-it if Macros a