Re: r353729 - Attempt to pacify bots more after r353718 and r353725

PAssed on our bots too. Thanks! /Mikael On 2/13/19 10:03 PM, Galina Kistanova wrote: > Passed on llvm-clang-x86_64-expensive-checks-win and > llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast. > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/15787 > http://lab.

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

jfb added a comment. In D58149#1397532 , @rsmith wrote: > In D58149#1397499 , @ldionne wrote: > > > In D58149#1397390 , @jfb wrote: > > > > > In D58149#1397382

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb marked an inline comment as done. jfb added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1640 // Only initialize a __block's storage: we always initialize the header. -if (emission.IsEscapingByRef) +if (emission.IsEscapingByRef && isa(Loc.getPointer()))

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Doesn't seem to break anything as far as I can see. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58214/new/ https://reviews.llvm.org/D58214

[PATCH] D58091: Customize warnings for missing built-in type

jyknight added a comment. I think this warning (-Wbuiltin-requires-header) doesn't really make sense as its own warning. We already have two related (on-by-default) warnings. For declarations: test.c:1:6: warning: incompatible redeclaration of library function 'exit' [-Wincompatible-library

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Awesome, thanks. Comment at: clang/test/Lexer/keywords_test.cpp:57 +#else +// MS compiler recognizes static_assert in all modes. So should we. +IS_KEYWORD(static_assert); ---

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL354009: Print a note to the called macro when diagnosing err_embedded_directive (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r354009 - Print a note to the called macro when diagnosing err_embedded_directive

Author: nico Date: Wed Feb 13 20:13:17 2019 New Revision: 354009 URL: http://llvm.org/viewvc/llvm-project?rev=354009&view=rev Log: Print a note to the called macro when diagnosing err_embedded_directive Fixes PR40713, see there for the motivation for this. Differential Revision: https://reviews.

r354008 - [NewPM] Add explicit triple to test

Author: thegameg Date: Wed Feb 13 20:13:00 2019 New Revision: 354008 URL: http://llvm.org/viewvc/llvm-project?rev=354008&view=rev Log: [NewPM] Add explicit triple to test This prevents warnings like: > warning: overriding the module target triple with x86_64-apple-darwin on macOS. Modified:

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

thakis added a comment. Thanks for starting the thread, Reid. In D58157#1397260 , @mehdi_amini wrote: > Sorry, I don't have time to do archeology for you right now. But this is > beside the point: your patch is changing a 2 years status quo, so my take o

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

thakis marked 2 inline comments as done. thakis added a comment. Thanks! Comment at: clang/lib/Lex/PPMacroExpansion.cpp:497 + Args = ReadMacroCallArgumentList(Identifier, MI, ExpansionEnd); rnk wrote: > thakis wrote: > > rnk wrote: > > > Can this re-ente

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

rjmccall added a comment. Basically LGTM, especially if we need an emergency fix, but please consider addressing my comment before committing since I'd expect it to be straightforward to solve. Comment at: clang/lib/Sema/SemaChecking.cpp:10634 + // warning. + else if (Resul

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1640 // Only initialize a __block's storage: we always initialize the header. -if (emission.IsEscapingByRef) +if (emission.IsEscapingByRef && isa(Loc.getPointer())) Loc = emitBlockByrefAddress(

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjC.cpp:475-483 case ObjCMessageExpr::Class: { ReceiverType = E->getClassReceiver(); const ObjCObjectType *ObjTy = Recei

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

erik.pilkington marked 2 inline comments as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:459 + llvm::Value *Receiver = + CGF.CGM.getObjCRuntime().GetClass(CGF, ObjTy->getInterface()); + return CGF.EmitObjCAllocInit(Receiver, CGF.Con

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

erik.pilkington updated this revision to Diff 186784. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57936/new/ https://reviews.llvm.org/D57936 Files: clang/include/clang/Basic/

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

rsmith added a comment. In D58149#1397499 , @ldionne wrote: > In D58149#1397390 , @jfb wrote: > > > In D58149#1397382 , @efriedma > > wrote: > > > > > Formally, I don't thin

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

This revision was automatically updated to reflect the committed changes. Closed by commit rC354004: [CUDA][HIP] Use device side kernel and variable names when registering them (authored by yaxunl, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/

r354004 - [CUDA][HIP] Use device side kernel and variable names when registering them

Author: yaxunl Date: Wed Feb 13 18:00:09 2019 New Revision: 354004 URL: http://llvm.org/viewvc/llvm-project?rev=354004&view=rev Log: [CUDA][HIP] Use device side kernel and variable names when registering them __hipRegisterFunction and __hipRegisterVar need to accept device side kernel and variab

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

smeenai accepted this revision. smeenai added a comment. LGTM. There's more clean up that could be done here, but this addresses the immediate issue. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58204/new/ https://reviews.llvm.org/D58204

r354001 - Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear.

Author: dyung Date: Wed Feb 13 17:11:32 2019 New Revision: 354001 URL: http://llvm.org/viewvc/llvm-project?rev=354001&view=rev Log: Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear. The CHECK lines as structured were requiring them to appear only in a certain positi

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. In D58149#1397390 , @jfb wrote: > In D58149#1397382 , @efriedma wrote: > > > Formally, I don't think C11 is a normative reference for C++11 or C++14, > > only C++17 (see [intro.refs] in the

r353999 - Fix for asan bots

Author: leonardchan Date: Wed Feb 13 17:07:47 2019 New Revision: 353999 URL: http://llvm.org/viewvc/llvm-project?rev=353999&view=rev Log: Fix for asan bots Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL: http://llvm.org/viewvc/llvm-projec

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

erik.pilkington updated this revision to Diff 186774. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. I was taking a final look at this, and I noticed that we were sending the wrong arguments to `DiagnoseFloatingImpCast`. The expression argument is meant to be

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb created this revision. jfb added a reviewer: ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Blocks that capture themselves (and escape) after initialization currently codegen wrong because this: bool capturedByInit = Init && emiss

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler created this revision. rafauler added reviewers: rsmith, ldionne, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: clang. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member func

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar updated this revision to Diff 186769. tstellar added a comment. Updated patch to fix non-standalone builds. There is more refactoring that could be done, but this at least restores functionality to before r353268. I have tested non-standalone builds and standalone builds with and withou

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

jfb added a comment. In D58149#1397382 , @efriedma wrote: > Formally, I don't think C11 is a normative reference for C++11 or C++14, only > C++17 (see [intro.refs] in the standard). Right, this was changed in wg21.link/p0063r3 That being said, we *can*

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1397302 , @rnk wrote: > In D58157#1397274 , @mehdi_amini > wrote: > > > It'd still be nice to identify the end goal with most cfe people (i.e. even > > if you land this right

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

efriedma added a comment. Formally, I don't think C11 is a normative reference for C++11 or C++14, only C++17 (see [intro.refs] in the standard). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58149/new/ https://reviews.llvm.org/D58149

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

ebevhan added a comment. In D58060#1396565 , @Anastasia wrote: > We had discussion related to this with John earlier. And I documented it in > this bug: https://bugs.llvm.org/show_bug.cgi?id=39674 I think we observed something similar to this downstream

[PATCH] D58091: Customize warnings for missing built-in type

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:591 +def warn_implicit_decl_no_jmp_buf +: Warning<"declaration of built-in '%0' requires the definition of the " + "'jmp_buf' type">, We only require a dec

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1397316 , @mikhail.ramalho wrote: > I just sent the first prototype of the solution. All the magic happens inside > the `CHECK_CXX_SOURCE_RUNS` call. I think hardcoding the version into the binary is too brittle. Instead

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous added a comment. @sammccall I think you touched this part of the code recently in r352079 (revert of r347205). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 ___ cfe

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We plan on using experimental new pass manager for Fuchsia toolchain. Repository: rC Clang https://reviews.llvm.org/D58214 Files: clang/cmake/ca

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous created this revision. jkorous added reviewers: sammccall, arphaman. Herald added subscribers: cfe-commits, kadircet, dexonsmith, ioeric, ilya-biryukov. Herald added a project: clang. This fixes an internal test failure in clangd - ClangdTests.GoToInclude.All rdar://47536127 Repository

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Hi guys, I just sent the first prototype of the solution. All the magic happens inside the `CHECK_CXX_SOURCE_RUNS` call. There is still one thing to do: currently, the program is hard-coded to check for version 4.7.1. We should either get it from the `find_pack

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

phosek added a comment. We need to update https://github.com/llvm/llvm-zorg/blob/master/zorg/buildbot/builders/FuchsiaBuilder.py#L102 as well as our downstream bots, but other than that I'm fine with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58157/new/ https://reviews

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 186757. mikhail.ramalho added a comment. Update FindZ3.cmake to do a runtime check of the version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: clang/CMakeLists.txt clang/cmake/modules/

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

rnk added a comment. In D58157#1397274 , @mehdi_amini wrote: > It'd still be nice to identify the end goal with most cfe people (i.e. even > if you land this right now, discussing the desired layout in the monorepo) I sent off http://lists.llvm.org/pipe

[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353990: [HWASAN] Updated HWASAN design document to better portray the chance of missing… (authored by hctim, committed by ). Changed prior to commit: https://reviews.llvm.org/D58195?vs=186695&id=186754#

[PATCH] D58164: Block+lambda: allow reference capture

jfb added a comment. I talked to Akira in meatspace, and it seems like this updated patch does the right thing. He suggested changing the AST as a longer-term solution, but for now this approach seems simple enough. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D58164: Block+lambda: allow reference capture

jfb updated this revision to Diff 186752. jfb added a comment. - Check for references when looking for copyexpr directly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58164/new/ https://reviews.llvm.org/D58164 Files: lib/CodeGen/CGBlocks.cpp test/CodeGenCXX

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1396824 , @rnk wrote: > And, this change really just keeps us at parity with what we had with svn. > We can always revisit the decision to merge the clang tools into clang. This > particular change just gives us m

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1396072 , @thakis wrote: > In D58157#1395762 , @mehdi_amini > wrote: > > > In D58157#1395716 , @rnk wrote: > > > > > I think we have c

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

rnk added a comment. In D17444#1397179 , @STL_MSFT wrote: > @rnk I've forwarded this to the compiler front-end and Universal CRT teams. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ htt

[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM and welcome back to the project! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58195/new/ https://reviews.llvm.org/D58195 _

r353985 - [NewPM] Second attempt at porting ASan

Author: leonardchan Date: Wed Feb 13 14:22:48 2019 New Revision: 353985 URL: http://llvm.org/viewvc/llvm-project?rev=353985&view=rev Log: [NewPM] Second attempt at porting ASan This is the second attempt to port ASan to new PM after D52739. This takes the initialization requried by ASan from the

[PATCH] D56470: [NewPM] Second attempt at porting ASan

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC353985: [NewPM] Second attempt at porting ASan (authored by leonardchan, committed by ). Herald added a project: clang. He

r353984 - Restore Check for Unreachable Exit Block in -Winfinite-recursion

Author: codafi Date: Wed Feb 13 14:22:23 2019 New Revision: 353984 URL: http://llvm.org/viewvc/llvm-project?rev=353984&view=rev Log: Restore Check for Unreachable Exit Block in -Winfinite-recursion Summary: When this was rewritten in D43737, the logic changed to better explore infinite loops. Th

[PATCH] D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion

This revision was automatically updated to reflect the committed changes. Closed by commit rL353984: Restore Check for Unreachable Exit Block in -Winfinite-recursion (authored by CodaFi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh updated this revision to Diff 186742. lildmh added a comment. 1. Move mapper related info to `OMPMappableExprListClause`, so that `to` and `from` clauses can utilize the same infrastructure as well (real support for them will be in another patch); 2. Combine the function parameters for `d

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. As it looks like libc++ isn't going to define the type for earlier dialects, libstdc++ doesn't either (which seems right anyway because the names aren't reserved prior to C++20). We now define the type and variable unconditionally for C++2a, but only define the `__cpp_

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

rnk commandeered this revision. rnk edited reviewers, added: andreybokhanko; removed: rnk. rnk added a comment. This revision now requires review to proceed. Comandeering and updating description... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1744

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

STL_MSFT added a comment. @rnk I've forwarded this to the compiler front-end and Universal CRT teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 ___ cfe-co

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

rnk updated this revision to Diff 186741. rnk added a comment. This revision is now accepted and ready to land. Herald added a project: clang. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 Files:

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL353983: [WebAssembly] Bulk memory intrinsics and builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D57736?vs=186504&id=186740#toc Repository: rL LLVM C

r353983 - [WebAssembly] Bulk memory intrinsics and builtins

Author: tlively Date: Wed Feb 13 14:11:16 2019 New Revision: 353983 URL: http://llvm.org/viewvc/llvm-project?rev=353983&view=rev Log: [WebAssembly] Bulk memory intrinsics and builtins Summary: implements llvm intrinsics and clang intrinsics for memory.init and data.drop. Reviewers: aheejin Subs

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

rnk added a subscriber: STL_MSFT. rnk added a comment. I chatted with @rsmith offline and the solution we came up with was to do both of the following: - make static_assert a keyword under -fms-compatibility (it is a technically non-conforming extension) - ask @STL_MSFT if `#define static_asser

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

rsmith updated this revision to Diff 186731. rsmith marked 7 inline comments as done. rsmith added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57984/new/ https://reviews.llvm.org/D57984 Files: include/clang/AST/Expr.h in

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

rsmith added inline comments. Comment at: include/clang/Parse/Parser.h:374 +/// This context is at the top level of a GNU statement expression. +InStmtExpr = 0x4, + aaron.ballman wrote: > It's a bit strange that the previous two enumerators are "Allow" an

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

smeenai added a comment. This could also be improved by teaching clang to use LLVM_BUILD_MAIN_SRC_DIR when that's available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58204/new/ https://reviews.llvm.org/D58204 __

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:13 -set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake") +set(generate_vcs_version_script "${LLVM_CMAKE_DIR}/GenerateVersionFrom

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

andrewrk accepted this revision. andrewrk added a comment. I confirm this solves the issue. Comment at: llvm/cmake/modules/AddLLVM.cmake:1739 execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --git-dir WORKING_DIRECTORY ${path} RESULT_VARIABLE git_res

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1396927 , @ddcc wrote: > The old `version.h` header isn't externally exposed, only the newer > `z3_version.h` header starting with version 4.8.1. I built a copy of 4.7.1 > from source, and I don't see it, so unfortunate

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

smeenai added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:13 -set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake") +set(generate_vcs_version_script "${LLVM_CMAKE_DIR}/GenerateVersionFromVCS.cmake") Will this wor

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58204/new/ https://reviews.llvm.org/D58204 ___

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar created this revision. tstellar added reviewers: phosek, andrewrk, smeenai. Herald added subscribers: cfe-commits, mgorny. Herald added projects: clang, LLVM. Handle the case where LLVM_MAIN_SRC_DIR is not set and also use LLVM_CMAKE_DIR for locating installed cmake files rather than LLVM

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Lex/PPMacroExpansion.cpp:497 + Args = ReadMacroCallArgumentList(Identifier, MI, ExpansionEnd); thakis wrote: > rnk wrote: > > Can

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

Passed on llvm-clang-x86_64-expensive-checks-win and llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast. http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/15787 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/23624 Thanks, Nico

[PATCH] D50106: [libc++] Fix tuple assignment from type derived from a tuple-like

ldionne added a comment. Herald added a subscriber: jdoerfert. In D50106#1352469 , @EricWF wrote: > Our constructors still have the same bug,. Are you planning on fixing those > as well? Doing so will require a metric butt-tonne of overloads. > If you're

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

I'm fine with rolling it into 8.0. ~Aaron On Wed, Feb 13, 2019 at 3:47 PM Erik Pilkington via cfe-commits wrote: > > It isn’t a super common issue, but this is a pretty low-risk fix so I think > it would be nice to have in 8.0. > > On Feb 13, 2019, at 12:40 PM, Shoaib Meenai wrote: > > Should

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

It isn’t a super common issue, but this is a pretty low-risk fix so I think it would be nice to have in 8.0. > On Feb 13, 2019, at 12:40 PM, Shoaib Meenai wrote: > > Should this be considered for 8.0? It's late in the branch and I don't know > how prevalent the issue being fixed is, but it cau

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

Should this be considered for 8.0? It's late in the branch and I don't know how prevalent the issue being fixed is, but it caught my eye. From: cfe-commits on behalf of Erik Pilkington via cfe-commits Reply-To: Erik Pilkington Date: Wednesday, February 13, 2019 at 12:32 PM To: "cfe-commits@li

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1396403 , @brzycki wrote: > That is almost exactly what I was thinking about this morning. I'd prefer the > following since it's more robust for older versions: The old `version.h` header isn't externally exposed, only th

r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

Author: epilk Date: Wed Feb 13 12:32:37 2019 New Revision: 353976 URL: http://llvm.org/viewvc/llvm-project?rev=353976&view=rev Log: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method This fixes a regression that was caused by r335084, which reversed the

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

This revision was automatically updated to reflect the committed changes. Closed by commit rC353976: [Sema] Delay checking whether objc_designated_initializer is being applied to… (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D58152?vs=186712&id=186717#t

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. In D58091#1396437 , @aaron.ballman wrote: > In D58091#1396397 , @jdoerfert wrote: > > > In D58091#1396382 , @aaron.ballman > > wrote: > > > > > -

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

danalbert added a comment. In D58153#1395601 , @efriedma wrote: > The official documentation still says "Your app must perform runtime > detection to confirm that NEON-capable machine code can be run on the target > device" > (https://developer.android.

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rC353975: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D58128?vs=186480&id=186715#toc Reposi

r353975 - [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

Author: hubert.reinterpretcast Date: Wed Feb 13 12:17:13 2019 New Revision: 353975 URL: http://llvm.org/viewvc/llvm-project?rev=353975&view=rev Log: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up Summary: The predefined macro `_ARCH_PWR6X` is associated with GCC's `-mcpu=power6x` option, wh

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

JonasToth added a comment. In D57662#1392509 , @MyDeveloperDay wrote: > Just a question.. If clang tidy is running with -fix in parallel, what stops > each clang-tidy invocation altering a common header at the same time? `clang-apply-replacements` does

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang/test/SemaObjC/attr-designated-init.m:433-438 +- (instancetype)foo +__attribute__((objc_designated_initializer

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

erik.pilkington updated this revision to Diff 186712. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Remove an `auto`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58152/new/ https://reviews.llvm.org/D58152 Files: clang/include/clang/Basic/Attr.td

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7258-7267 + // Do this check after processing D's attributes because the attribute + // objc_method_family can change whether the given method is in the init + // family, and it can be applied a

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

rnk added a comment. In D58157#1395762 , @mehdi_amini wrote: > In D58157#1395716 , @rnk wrote: > > > I think we have consensus, > > > Based on three comments in a revision? Seems strange to me. > I don't really car

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

tra accepted this revision. tra added a comment. Thank you. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58163/new/ https://reviews.llvm.org/D58163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

yaxunl updated this revision to Diff 186711. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58163/new/ https://reviews.llvm.org/D58163 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/CodeGen/CGCUDANV.cpp lib/C

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1395562 , @mikhail.ramalho wrote: > Hi @brzycki, but isn't it exactly what we want? I mean, if we try to > cross-compile and it fails for any reason (non-native library, wrong > version), then Z3_FOUND shouldn't be set

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:412 + for (auto &&I : EmittedKernels) { +llvm::Constant *KernelName = makeConstantString(I.DeviceSideName); llvm::Constant *NullPtr = llvm::ConstantPointerNull::g

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGCUDANV.cpp:412 + for (auto &&I : EmittedKernels) { +llvm::Constant *KernelName = makeConstantString(I.DeviceSideName); llvm::Constant *NullP

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 ___

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:412 + for (auto &&I : EmittedKernels) { +llvm::Constant *KernelName = makeConstantString(I.DeviceSideName); llvm::Constant *NullPtr = llvm::ConstantPointerNull::g

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rC353970: [clang] Make sure C99/C11 features in are provided in C++11 (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D58149?vs=186544&id=186703#toc Repo

r353970 - [clang] Make sure C99/C11 features in are provided in C++11

Author: ldionne Date: Wed Feb 13 11:08:01 2019 New Revision: 353970 URL: http://llvm.org/viewvc/llvm-project?rev=353970&view=rev Log: [clang] Make sure C99/C11 features in are provided in C++11 Summary: Previously, those #defines were only provided in C or when GNU extensions were enabled. We ne

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. I'll ship this. @eli.friedman I think this is your playground -- if you want any changes to happen post-review, please LMK and I will gladly cooperate. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58149/new/ https://reviews.llvm.org/D58

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

I re-enabled the test in r353969, hopefully it'll pass when using gcc as host too this time. On Tue, Feb 12, 2019 at 9:10 AM Mikael Holmén wrote: > > > On 2/12/19 1:41 PM, Nico Weber wrote: > > Thanks for reporting that this depends on the host compiler. > > > > I disabled the test again in r353

r353969 - Re-enable the test disabled in r353836 and hopefully make it pass in gcc builds

Author: nico Date: Wed Feb 13 11:04:26 2019 New Revision: 353969 URL: http://llvm.org/viewvc/llvm-project?rev=353969&view=rev Log: Re-enable the test disabled in r353836 and hopefully make it pass in gcc builds Argument evaluation order is different between gcc and clang, so pull out the Builder

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

Anastasia updated this revision to Diff 186699. Anastasia added a comment. Herald added a subscriber: javed.absar. - Changed the diagnostic for binding reference and combined with existing similar one. That affected more tests however. - Changed comment explaining address space behavior in the re

  1   2   >