[clang-tools-extra] r352953 - [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct.

Author: sammccall Date: Fri Feb 1 21:56:00 2019 New Revision: 352953 URL: http://llvm.org/viewvc/llvm-project?rev=352953&view=rev Log: [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct. Summary: This helps m

[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

leonardchan added a comment. In D57553#1380157 , @ebevhan wrote: > This doesn't seem to address the particular case in the integer conversion > patch. In fact, I don't see those conversions at all. I was initially planning on rebasing and updating the p

[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

leonardchan updated this revision to Diff 184888. leonardchan retitled this revision from "[Fixed Point Arithmetic] Check against source value when converting during saturation" to "[Fixed Point Arithmetic] Avoid resizing for types with the same width". leonardchan edited the summary of this revi

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

smeenai added subscribers: hans, smeenai. smeenai added reviewers: rnk, efriedma. smeenai added a comment. +@hans for the release branch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57636/new/ https://reviews.llvm.org/D57636 _

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > Are padding bits guaranteed ze

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 184886. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

glandium added a comment. Opened D57636 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51204/new/ https://reviews.llvm.org/D51204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

glandium created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. r344765 added those intrinsics, but used the wrong types. I /think/ the code in EmitAArch64BuiltinExpr does the right thing, though, but I'm not familiar with it. Th

[PATCH] D57634: Support for GCC's `__builtin_va_arg_pack{,_len}`

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, jfb, aaron.ballman. Herald added subscribers: kristina, dexonsmith, jkorous. Herald added a project: clang. You can read more about these attributes here: https://gcc.gnu.org/onlinedocs/gcc-4.4.2/gcc/Constructing-Call

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rC352949: [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial (aut

r352949 - [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial

Author: ahatanak Date: Fri Feb 1 18:23:40 2019 New Revision: 352949 URL: http://llvm.org/viewvc/llvm-project?rev=352949&view=rev Log: [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial ownership qualifications in C++ unions under ARC. An ObjC pointer member with non-trivial owner

r352948 - [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

Author: yln Date: Fri Feb 1 18:05:16 2019 New Revision: 352948 URL: http://llvm.org/viewvc/llvm-project?rev=352948&view=rev Log: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return` Summary: Currently, ASan inserts a call to `__asan_handle_no_return` before every `nore

[PATCH] D57489: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

This revision was automatically updated to reflect the committed changes. Closed by commit rC352948: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return` (authored by yln, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews

r352946 - Remove redundant FunctionDecl argument from a couple functions.

Author: jyknight Date: Fri Feb 1 17:48:23 2019 New Revision: 352946 URL: http://llvm.org/viewvc/llvm-project?rev=352946&view=rev Log: Remove redundant FunctionDecl argument from a couple functions. This argument was added in r254554 in order to support the pass_object_size attribute. However, in

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits > wrote: > > > > Author: djg > > Date: Fri Feb 1 14:25:23 2019 > > New Revision: 352930 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > > Log: > > [WebAssembly]

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57631/new/ https://reviews.llvm.org/D57631 ___ cfe-commit

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

TomTan created this revision. TomTan added reviewers: rnk, mstorsjo, efriedma. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. The MSDN document was also updated to reflect this, but it probably will take a few days to show in below link. https://docs.microso

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added a comment. Forgot about protected scopes... This patch is missing code and testcases for JumpScopeChecker. (The behavior should be roughly equivalent to what we do for indirect goto.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai updated this revision to Diff 184866. vsapsai added a comment. - Improve the diagnostic message wording. Rebased the patch, so the diff between 2 revisions can be noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56561/new/ https://reviews.llvm.org/D56561 Files: clang/inc

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: lib/Analysis/CFG.cpp:3137 + + Block = createBlock(false); + Block->setTerminator(G); Passing add_successor=false seems suspect; this could probably use more test coverage. Comment at: lib/CodeGen/C

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:7886 + if (!HasNonDeletedCopyOrMoveConstructor()) { +PrintDiagAndRemoveAttr(); +return; This is not a very useful diagnostic. We have several different reasons why we reject the attri

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

rjmccall added a comment. Asking for a minor tweak, but feel free to commit with that. Comment at: lib/Sema/SemaDeclCXX.cpp:7084 + if (FD->getParent()->isUnion() && + shouldDeleteForVariantObjCPtrMember(FD, FieldType)) ahatanak wrote: > rjmccall wrote:

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai created this revision. vsapsai added reviewers: akyrtzi, benlangmuir. Herald added subscribers: arphaman, dexonsmith, jkorous. Currently the symbol for MSPropertyDecl has kind `SymbolKind::Unknown` which can trip up various indexing tools. rdar://problem/46764224 https://reviews.llvm.or

[PATCH] D57619: [analyzer] Canonicalize variable declarations in VarRegion objects.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Looks good, nice catch. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57619/new/ https://reviews.llvm.org/D576

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall, aaron.ballman. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. Instead of forcing the class to be passed in registers, which was what r350920 did, issue a warning and inform the user that t

r352938 - [analyzer] Hotfix for RetainCountChecker: assert was too strong.

Author: george.karpenkov Date: Fri Feb 1 15:06:44 2019 New Revision: 352938 URL: http://llvm.org/viewvc/llvm-project?rev=352938&view=rev Log: [analyzer] Hotfix for RetainCountChecker: assert was too strong. Bridged casts can happen to non-CF objects as well. Modified: cfe/trunk/lib/StaticA

[PATCH] D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo

benhamilton created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is another test for the new Herald rules to subscribe cfe-commits to revisions sent out from the Github monorepo under the "clang/" subdirectory. Repository: rG LLVM Github Monorepo

r352936 - [WebAssembly] Fix ImportName's position in this test.

Author: djg Date: Fri Feb 1 14:52:29 2019 New Revision: 352936 URL: http://llvm.org/viewvc/llvm-project?rev=352936&view=rev Log: [WebAssembly] Fix ImportName's position in this test. This is a follow-up to r352930. Modified: cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.te

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

glandium added a comment. In D51204#1271564 , @dmajor wrote: > In D51204#1253230 , @mgrang wrote: > > > Will abandon this patch since I have implementations of these which I will > > upstream soon. > > > Just to li

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak updated this revision to Diff 184851. ahatanak marked an inline comment as done. ahatanak added a comment. Add a test case for an anonymous struct nested inside an anonymous union. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57438/new/ https://reviews.

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:7084 + if (FD->getParent()->isUnion() && + shouldDeleteForVariantObjCPtrMember(FD, FieldType)) rjmccall wrote: > rjmccall wrote: > > I believe

r352933 - Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks"

Author: lebedevri Date: Fri Feb 1 14:43:08 2019 New Revision: 352933 URL: http://llvm.org/viewvc/llvm-project?rev=352933&view=rev Log: Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks" Further reviews (D57594, D57615) have revealed that this was not reviewed,

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > Anasta

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Fri Feb 1 14:25:23 2019 > New Revision: 352930 > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > Log: > [WebAssembly] Add an import_field function attribute > > This is similar to import_modu

r352930 - [WebAssembly] Add an import_field function attribute

Author: djg Date: Fri Feb 1 14:25:23 2019 New Revision: 352930 URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev Log: [WebAssembly] Add an import_field function attribute This is similar to import_module, but sets the import field name instead. By default, the import field name is th

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. Fxd the global variable problem in D57619 , thanks! I think you should change back to `getInit()` once D57619 lands. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46421/new/

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} rjmccall wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevh

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: include/clang/AST/Stmt.h:1008 + (*iterator_adaptor_base::I)->getStmtClass() <= lastExprConstant); + return *reinterpret_cast(iterator_adaptor_base::I); } Ugh. This cast violates strict aliasing, and

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381461 , @ABataev wrote: > In D57615#1381443 , @lebedev.ri > wrote: > > > Let's instead solve the problem of structured block not having an AST > > representation. > > > Agai

r352927 - Improve diagnostic to tell you a type is incomplete.

Author: ericwf Date: Fri Feb 1 14:06:02 2019 New Revision: 352927 URL: http://llvm.org/viewvc/llvm-project?rev=352927&view=rev Log: Improve diagnostic to tell you a type is incomplete. I recently ran into this code: ``` \#include void foo(const std::string &s, const std::string& = ""); \#includ

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder abandoned this revision. scott.linder added a comment. See https://reviews.llvm.org/D56871 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/ https://reviews.llvm.org/D53153 ___ cfe-commits mailing list cfe-commits@lists.

r352925 - Factor out duplication between ExprIterator and ConstExprIterator.

Author: rsmith Date: Fri Feb 1 13:58:17 2019 New Revision: 352925 URL: http://llvm.org/viewvc/llvm-project?rev=352925&view=rev Log: Factor out duplication between ExprIterator and ConstExprIterator. This also exposes a more general iterator cast mechanism suitable for use in http://reviews.llvm.

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381467 , @lebedev.ri wrote: > In D57615#1381447 , @ABataev wrote: > > > > Okay, enough is enough :) > > > I think a very important phrase was repeated a number of times, and it

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381447 , @ABataev wrote: > > Okay, enough is enough :) > > I think a very important phrase was repeated a number of times, and it > > highlights the **actual** problem here: > > > >> is not the representation of th

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381443 , @lebedev.ri wrote: > Let's instead solve the problem of structured block not having an AST > representation. Again, this is not a problem for the compiler. If you want this idiom for the analyzer, you need t

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. > Okay, enough is enough :) > I think a very important phrase was repeated a number of times, and it > highlights the **actual** problem here: > >> is not the representation of the structured block It is not a problem! It is the internal implementation design! What do

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

lebedev.ri abandoned this revision. lebedev.ri added a comment. Let's instead solve the problem of structured block not having an AST representation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57594/new/ https://reviews.llvm.org/D57594

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri abandoned this revision. lebedev.ri added a comment. Let's instead solve the problem of structured block not having an AST representation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57615/new/ https://reviews.llvm.org/D57615

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381428 , @ABataev wrote: > In D57615#1381427 , @lebedev.ri > wrote: > > > In D57615#1381418 , @ABataev wrote: > > > > > In D57615#1381

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381427 , @lebedev.ri wrote: > In D57615#1381418 , @ABataev wrote: > > > In D57615#1381416 , @lebedev.ri > > wrote: > > > > > @ABataev i'm

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381418 , @ABataev wrote: > In D57615#1381416 , @lebedev.ri > wrote: > > > @ABataev i'm not sure i have fully followed the > > https://bugs.llvm.org/show_bug.cgi?id=40563#c1 >

r352919 - Don't use ASTContext in DeclOpenMP.h because it's still incomplete.

Author: ericwf Date: Fri Feb 1 13:19:20 2019 New Revision: 352919 URL: http://llvm.org/viewvc/llvm-project?rev=352919&view=rev Log: Don't use ASTContext in DeclOpenMP.h because it's still incomplete. Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h cfe/trunk/lib/AST/DeclOpenMP.cpp Mod

Re: r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Hi, I never used modules. Can you give me hint where it exactly breaks? Is it line 294 and 298 where it calls getExternalSource of ASTContext? Michael Am Fr., 1. Feb. 2019 um 12:58 Uhr schrieb Eric Fiselier : > > This breaks my build (I have modules enabled). > > DeclOpenMP.h uses ASTContext w

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381416 , @lebedev.ri wrote: > @ABataev i'm not sure i have fully followed the > https://bugs.llvm.org/show_bug.cgi?id=40563#c1 > > > The outlined function is not generated for the loop, so there is no problem > > with

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. @ABataev i'm not sure i have fully followed the https://bugs.llvm.org/show_bug.cgi?id=40563#c1 > The outlined function is not generated for the loop, so there is no problem > with the standard compatibility. Are you saying that in these cases of `master`, `critical`

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:6058 + // longjmp() and throw() must not violate the entry/exit criteria. + cast(AStmt)->getCapturedDecl()->setNothrow(); + Generally speaking, this is not required. It is required only for thos

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, OpenMP. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: openmp-commits, guansong. Much like `single` construct (D57594 ): `OpenMP Application Programming Interface Version 5

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

This revision was automatically updated to reflect the committed changes. Closed by commit rC352906: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive. (authored by Meinersbur, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION ht

r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Author: meinersbur Date: Fri Feb 1 12:25:04 2019 New Revision: 352906 URL: http://llvm.org/viewvc/llvm-project?rev=352906&view=rev Log: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive. This patch implements parsing and sema for "omp declare mapper" directive. User defined ma

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added a comment. In D56326#1381229 , @Meinersbur wrote: > @lildmh Thanks for the patch. I can commit this patch for you. The tests run > fine on my machine. However, for committing on other's behalf, we were asked > to make the contributor aware t

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

Meinersbur added a comment. @lildmh Thanks for the patch. I can commit this patch for you. The tests run fine on my machine. However, for committing on other's behalf, we were asked to make the contributor aware that the contribution will be published under a new license

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// steveire wrote: > I think I'll rename this to `ASTNodeTraverser`. Any objections? Nope,

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// I think I'll rename this to `ASTNodeTraverser`. An

Re: r352055 - Fix failing buildbots

Dave, The idea to check explicitly the triple inside the test function is quite convincing. Will you try to fix it that way? Or if it can wait a bit, this will be my first thing to do on Monday. Gábor On Fri, 1 Feb 2019, 19:39 David Green Hello > > > I think, because this is a unit-test, the co

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman added a comment. In D57532#1380383 , @ilya-biryukov wrote: > @arphaman, thanks for pointing this out. It's definitely nice to change stuff > only in one place. > There are two issues still pending: > > - `index-file.cu` still fails, I haven't l

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

Eugene.Zelenko added a comment. Herald added subscribers: dkrupp, rnkovacs. Herald added a project: LLVM. Please look at recently filed PR40544. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35937/new/ https://reviews.llvm.org/D35937 ___

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

justice_adams added a comment. @thakis thanks for the review. I don't have commit access, would you mind committing this for me? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/ https://reviews.llvm.org/D57592 _

Re: r352055 - Fix failing buildbots

Hello I think, because this is a unit-test, the compile will happen for the host (x86_64 in this case). So the binary will still be x86_64. The compile that the test runs will pick up whatever the default target triple is (hexagon for the bot, aarch64 for us). I don't know a lot about these t

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. > Previously this was not required since all VarDecls were canonical. Not sure > if this change was intended. I did some digging, but am not familiar enough > with the code base to figure out what changed. Does anyone have an idea about > this? We changed the ASTImport

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57594/new/ https://reviews.llvm.org/D57594 ___ cfe-commits ma

[PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

thakis closed this revision. thakis added a comment. David landed a better fix in r260388. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16951/new/ https://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, OpenMP. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: openmp-commits, guansong. `OpenMP Application Programming Interface Version 5.0 November 2018`

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Normally when needing a directory you'd `mkdir %t.dir` before using it, but since you don't' want the directory to exist here this should be good as-is. Thanks! Repository: rC Clang CHANG

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} ebevhan wrote: > Anastasia wrote: > > ebevhan wrote: > > > Just

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

justice_adams created this revision. justice_adams added reviewers: stella.stamenova, thakis. justice_adams added a project: clang. After committing a change I had made to a few frontend tests, it was pointed out to me that %T is being deprecated in LLVM in favor of %t. This change simply conver

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

justice_adams added a comment. @stella.stamenova These are the changes from our previous discussion regarding the usage of %T Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/ https://reviews.llvm.org/D57592

r352890 - Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Author: dor1s Date: Fri Feb 1 09:12:35 2019 New Revision: 352890 URL: http://llvm.org/viewvc/llvm-project?rev=352890&view=rev Log: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. Summary: There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it

Re: r352055 - Fix failing buildbots

Hi, Thank you for catching this. I thought that the macros like __x86_64__ are defined for the target. I just don't understand: If they are defined for the host, that would mean we can't cross compile on the same host for different targets, wouldn't it? I couldn't find out which macros to use to

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

This revision was automatically updated to reflect the committed changes. Dor1s marked an inline comment as done. Closed by commit rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. (authored by Dor1s, committed by ). Changed prior to commit: https://revie

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4693 +T2Quals.addAddressSpace(AS2); + QualType WithAScv1T4 = S.Context.getQualifiedType(IgnoreAScv2T2, T1Quals); + Sequence.AddQualificationConversionStep(WithAScv1T4, ValueKind); ---

r352887 - Fix some sphinx doc errors.

Author: jyknight Date: Fri Feb 1 09:06:41 2019 New Revision: 352887 URL: http://llvm.org/viewvc/llvm-project?rev=352887&view=rev Log: Fix some sphinx doc errors. Modified: cfe/trunk/docs/ClangTools.rst Modified: cfe/trunk/docs/ClangTools.rst URL: http://llvm.org/viewvc/llvm-project/cfe/tru

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

rjmccall added a comment. I agree: if a test doesn't seem to require the GNU extensions, let's not use `-std=gnu++XX`. Otherwise this LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581 _

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___ cfe-comm

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s marked 2 inline comments as done. Dor1s added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. +

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s updated this revision to Diff 184766. Dor1s added a comment. Herald added a project: clang. Clarify that only linkers other than LLD are affected. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 Files: docs/Saniti

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai added a comment. In D57581#1380609 , @ilya-biryukov wrote: > ... > Do have a comment, though. Any, reason to use `-std=gnu++14` and not > `-std=c++14`? > Most (all?) of the tests do not seem to have anything to do with the gnu > extensions, s

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

ABataev added a comment. In D57162#1380795 , @probinson wrote: > LGTM. I'll trust you on the actual address-class values. Thanks, Paul! If you want, you can find those values in the table here https://docs.nvidia.com/cuda/archive/10.0/ptx-writers-guide-

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl added a comment. Thanks for the comments! All good points. Nice idea with the constructor, but that can probably happen in a follow up patch. In D46421#1380619 , @xazax.hun wrote: > I know you probably tired of me making you split all the patches

Re: r352055 - Fix failing buildbots

Hello Sorry for the late reply. I'm not sure this ifdef is quite correct. It will be testing the _host_ architecture, presuming the default target is the same. If they are different (for example if the default target is aarch64 on an x86 machine), the test will presumably still fail. I went lo

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > Anastasia wrote: > > > > ebevhan wrote: > > > > > Is there a reason that the attributes are parsed here and not i

[PATCH] D57220: Test fix for isViableInline remark message

xbolva00 added inline comments. Herald added a project: clang. Comment at: test/Frontend/optimization-remark-with-hotness.c:63 // NO_PGO: '-fdiagnostics-hotness-threshold=' requires profile-guided optimization information // expected-remark@+1 {{foo inlined into bar with (

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM. I'll trust you on the actual address-class values. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57162/new/ https://

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC352882: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

r352882 - [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

Author: lebedevri Date: Fri Feb 1 07:41:54 2019 New Revision: 352882 URL: http://llvm.org/viewvc/llvm-project?rev=352882&view=rev Log: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks Summary: I'm working on a clang-tidy check, much like existing [[ http://clang.llvm

r352881 - [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

Author: stefan.graenitz Date: Fri Feb 1 07:35:25 2019 New Revision: 352881 URL: http://llvm.org/viewvc/llvm-project?rev=352881&view=rev Log: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests Summary: Apparently `LLVMTestingSupport` must be built before `llv

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL352881: [CMake] External compiler-rt-configure requires LLVMTestingSupport when… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[clang-tools-extra] r352876 - [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches.

Author: sammccall Date: Fri Feb 1 07:09:47 2019 New Revision: 352876 URL: http://llvm.org/viewvc/llvm-project?rev=352876&view=rev Log: [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches. Summary: This reduces the per-check implementation burden and redundant work. It a

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added a comment. Thanks a lot Alexey! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

  1   2   >