[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 added a comment. Yes, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

kthomsen added a comment. @vit9696 I'm working since 3 days on that issue, and found nothing... PPCISelLowering.cpp has 2 functions: LowerVASTART() and LowerVAARG(). LowerVASTART is correctly called (store the GPR to the internal va_list structure), but LowerVAARG is never called and I don't un

r352456 - Remove unused variable to silence compiler warning

Author: uabelho Date: Mon Jan 28 22:53:31 2019 New Revision: 352456 URL: http://llvm.org/viewvc/llvm-project?rev=352456&view=rev Log: Remove unused variable to silence compiler warning Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: http://llvm.o

[PATCH] D57369: [CUDA][HIP] Do not diagnose use of _Float16

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57369/new/ https://reviews.llvm.org/D57369 ___ cfe-commits mailing list cfe-comm

[PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. LGTM, but for one comment that requires a fix I believe (lld on Windows) Comment at: libcxx/docs/BuildingLibcxx.rst:47 - * ``cd build`` - * ``cmake -G [options] `` So nice to see these steps going away :) C

[PATCH] D57369: [CUDA][HIP] Do not diagnose use of _Float16

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. r352221 caused regressions in CUDA/HIP since device function may use _Float16 whereas host does not support it. In this case host compilation should not diagnose usage of _Float16 in device functions or variables. For now just

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

stephanemoore planned changes to this revision. stephanemoore added a comment. Reiterating outstanding action items: • Evaluate using hasDeclContext instead of hasAncestor. • Include type encoding size information in diagnostic messages. I've been observing some unexpected behaviors with matching

r352449 - [CMake][Fuchsia] Temporarily disable modules for second stage

Author: phosek Date: Mon Jan 28 19:38:26 2019 New Revision: 352449 URL: http://llvm.org/viewvc/llvm-project?rev=352449&view=rev Log: [CMake][Fuchsia] Temporarily disable modules for second stage This is breaking some of builders, disable modules until it's resolved. Modified: cfe/trunk/cmake

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. Regardless, I think it would be fine if you wanted to add a CUDA/HIP exception to this check in the short term. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 _

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. In D57188#1374890 , @yaxunl wrote: > This change causes regressions for CUDA/HIP. As single-source language, > CUDA/HIP code contains both device and host code. It has separate compilation > for host and device. > In host compi

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

yaxunl added a comment. This change causes regressions for CUDA/HIP. As single-source language, CUDA/HIP code contains both device and host code. It has separate compilation for host and device. In host compilation, device function is parsed but not emitted in IR. The device function may have _

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

rsmith added inline comments. Comment at: clang/include/clang/AST/Type.h:4183 +/// Sugar type that represents a type that was defined in a macro. +class MacroDefinedType : public Type { + friend class ASTContext; // ASTContext creates these. This represents a ma

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184001. domdom added a comment. Thanks for your comments, @aaron.ballman. I've addressed the comments and added a test case as suggested. This revealed an issue with the code-gen side of things, so I fixed that and added another test case for that as well.

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. Is it necessary to remove visitation of 'noreturn' call sites from ASan? I'd expect that to break non-C frontends which emit noreturn calls (rust/swift?). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D5727

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

dlj accepted this revision. dlj added a comment. In D57303#1373163 , @mgorny wrote: > Given that this path changes with every clang release, so you're effectively > making a hard dependency on the clang version used to build the program, I > dare say som

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Since the previous iteration of this was controversial, please wait for at least one more review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. In D46421#1354188 , @r.stahl wrote: > In my old version I seemed to get away with the tests, but they failed after > rebasing. It seems like earlier there was only a single VarDecl for the > imported ones with InitExpr. Now after imp

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova added a comment. @thakis Thanks for the information, I had actually missed that. The way this test is written, it needs to use a directory (so %T is "correct"), but to remove %T, it could be changed to use something like ```%t.doesnotexist.somename``` instead. If you feel stron

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ accepted this revision. NoQ added a comment. Thanks!!~ I'm slow, but at least i admit it... Just made myself a fancier phabricator query so that not to forget about patches, so hopefully i won't forget about patches that often anymore :/ I mean, seriously, i'm very happy that we're all doi

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_comparisons.c:56 + +void TestComparisons() { + short _Accum sa; ebevhan wrote: > leonardchan wrote: > > ebevhan wrote: > > > Missing saturating and saturating/non-saturating compariso

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 183980. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

NoQ accepted this revision. NoQ added a comment. Ok! I hope that the C11 check would do the trick, let's see how it goes :) In D35068#1364947 , @xazax.hun wrote: > What do we want to validate here? The lack of crashes? Or evaluate false > positive ratio?

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

arsenm closed this revision. arsenm added a comment. r352443 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57349/new/ https://reviews.llvm.org/D57349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

r352443 - AMDGPU: Add ds append/consume builtins

Author: arsenm Date: Mon Jan 28 15:59:18 2019 New Revision: 352443 URL: http://llvm.org/viewvc/llvm-project?rev=352443&view=rev Log: AMDGPU: Add ds append/consume builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/Cod

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. In D55734#1372972 , @boga95 wrote: > Is it ready to land? Whops. Yes, right, it's totally ready to land! Sorry. Should i commit? CHANGES SINCE LAST AC

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews.llvm.org/D56852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight added inline comments. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:460-463 + // Honor -w: this disables all messages mapped to Warning severity, and *also* + // any diagnostics which are not Error/Fatal by default (that is, they were + // upgraded by any of the mec

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight updated this revision to Diff 183966. jyknight marked 2 inline comments as done. jyknight added a comment. Fix to not disable remarks, reword comment, adjust implementation-of-module.m test-case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53199/new/ https://reviews.llvm.org

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ accepted this revision. NoQ added a comment. In D57230#1373721 , @xazax.hun wrote: > Do you think I should try to reduce additional files? Aha, ok, it reduced an interesting positive into a non-interesting positive. So i guess my method only works w

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:319-346 +class PreferredTypeBuilder::RestoreRAII { +public: + RestoreRAII(RestoreRAII const &) = delete; + RestoreRAII &operator=(RestoreRAII const &) = delete; + + explicit RestoreRAII(PreferredTypeBuil

[PATCH] D57330: Adjust documentation for git migration.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The amount of duplicated and out-of-date documentation makes me sad, but this is an awesome effort to clean that up. Comment at: lldb/packages/Python/lldbsuite/test/funct

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56936: Fix handling of overriden methods during ASTImport

This revision was automatically updated to reflect the committed changes. Closed by commit rC352436: [ASTImporter] Fix handling of overriden methods during ASTImport (authored by shafik, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ http

r352436 - [ASTImporter] Fix handling of overriden methods during ASTImport

Author: shafik Date: Mon Jan 28 13:55:33 2019 New Revision: 352436 URL: http://llvm.org/viewvc/llvm-project?rev=352436&view=rev Log: [ASTImporter] Fix handling of overriden methods during ASTImport Summary: When importing classes we may add a CXXMethodDecl more than once to a CXXRecordDecl when

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits it appears that va_list is not functional with SPE (va_arg returns garbage for double and stuff like printf is not functional). Is this expected or I miss a patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https

[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

george.karpenkov added a comment. I personally do use HTML output quite a lot (and we do have non-Xcode projects), and complex macros in HTML are currently totally unusable. I'm not sure whether this is a right approach to handling this, but it's definitely a problem for us. In general - thanks

[PATCH] D57230: [analyzer] Toning down invalidation a bit

george.karpenkov added a comment. I'm in favor of this change, I never understood how invalidating a field invalidates entire structure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 ___ cfe-commi

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/DurationDoubleConversionCheck.cpp:48 + + if (!isNotInMacro(Result, OuterCall)) return; + Please run Clang-format. Comment at: docs/ReleaseNotes.rst:85 + + Find and fix cases

[PATCH] D57223: [Tooling] Handle #pragma once header guard in include insertion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Tooling/Inclusions/HeaderIncludes.cpp:77 +// before/after header guards (e.g. #ifndef/#define pair, #pragma once). If no +// header guard p

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:425 +const llvm::StringLiteral ExecuteCommandParams::CLANGD_APPLY_TWEAK = +"clangd.applyCodeAction"; + sammccall wrote: > tweak or applyTweak Done. Thanks for spotting this

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 183949. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - s/applyCodeAction/applyTweak - Added a comment to TweakArgs - Added a unit test for sourceLocationInMainFile - Extract a 'validateRegistry' function - Do not log Can

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

rnk added a comment. Thanks for following up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57114/new/ https://reviews.llvm.org/D57114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[libunwind] r352427 - Revert "[libunwind] Drop the dependency on , add placement new inline"

Author: phosek Date: Mon Jan 28 12:55:12 2019 New Revision: 352427 URL: http://llvm.org/viewvc/llvm-project?rev=352427&view=rev Log: Revert "[libunwind] Drop the dependency on , add placement new inline" This reverts commit r352384: this broke on ARM as UnwindCursor.hpp still has some C++ librar

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright created this revision. hwright added reviewers: hokein, JonasToth, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57353 Files: clang-tidy/abseil/AbseilTi

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. In D53329#1373799 , @yonghong-song wrote: > @dblaikie As I mentioned in one of my earlier comments, after some analysis, > I think this patch definitely not the right way to fix the problem. We just > cannot default to the main

r352421 - [OPENMP][NVPTX]Emit service debug variable for NVPTX.

Author: abataev Date: Mon Jan 28 12:03:02 2019 New Revision: 352421 URL: http://llvm.org/viewvc/llvm-project?rev=352421&view=rev Log: [OPENMP][NVPTX]Emit service debug variable for NVPTX. In case of the empty module, the ptxas tool may emit error message about empty debug info sections. This patc

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov updated this revision to Diff 183937. ilya-biryukov added a comment. - Use 'else if' to simplify the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/CodeCo

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57349/new/ https://reviews.llvm.org/D57349 ___ cfe-commits mailing list cfe-commi

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:373 +} +Type = QualType(); + }); ilya-biryukov wrote: > kadircet wrote: > > nit: maybe move this into top and get rid of the re

[PATCH] D56936: Fix handling of overriden methods during ASTImport

teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: unittests/AST/ASTImporterTest.cpp:2271 +struct D:B { void f(){}; }; + )"; + auto BFP = I think this should be formatted in the same way as the snippet above.

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D57349 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/b

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik updated this revision to Diff 183923. shafik marked 2 inline comments as done. shafik added a comment. Addressing comments on commenting and naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ https://reviews.llvm.org/D56936 Files: lib/AST/ASTImporter.cpp test/A

[libunwind] r352411 - Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library"

Author: phosek Date: Mon Jan 28 11:26:41 2019 New Revision: 352411 URL: http://llvm.org/viewvc/llvm-project?rev=352411&view=rev Log: Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library" This reverts commit r352341: it broke the build on macOS which doesn't seem to

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis created this revision. thakis added a reviewer: arphaman. - fixes the test on macOS with LLVM_ENABLE_PIC=OFF - together with D57343 , gets the test to pass on Windows - makes it run everywhere (it seems to just pass on Linux) The main change is in CIndexer

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

zturner added a comment. Shouldn't the hash be case-insensitive on windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57343/new/ https://reviews.llvm.org/D57343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis created this revision. thakis added a reviewer: zturner. Herald added a subscriber: delcypher. Herald added a reviewer: serge-sans-paille. `LLVMConfig.with_environment()` uses `os.path.normcase(os.path.normpath(x))` to normalize temporary env vars. `LLVMConfig.use_clang()` uses `with_envi

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

rsmith added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch memory, so we take the parent context. +isInSystemHea

r352405 - Correct help text for --unwindlib options.

Author: saugustine Date: Mon Jan 28 10:56:44 2019 New Revision: 352405 URL: http://llvm.org/viewvc/llvm-project?rev=352405&view=rev Log: Correct help text for --unwindlib options. Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: ht

r352404 - Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=

Author: saugustine Date: Mon Jan 28 10:56:43 2019 New Revision: 352404 URL: http://llvm.org/viewvc/llvm-project?rev=352404&view=rev Log: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= Summary: "clang++ hello.cc --rtlib=compiler-rt" now works without specifying additional unwind or exc

r352403 - Revert "[AST] Introduce GenericSelectionExpr::Association"

Author: brunoricci Date: Mon Jan 28 10:40:26 2019 New Revision: 352403 URL: http://llvm.org/viewvc/llvm-project?rev=352403&view=rev Log: Revert "[AST] Introduce GenericSelectionExpr::Association" This breaks GCC 4.8.4. Reported by email by Hans Wennborg. Modified: cfe/trunk/include/clang/AS

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183902. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. - Rebased - Go back to storing the actual AST class type as string in `ASTNodeKind::KindInfo ASTNodeKind::AllKindInfo[]`. - Add `OpenMPClauseKind ASTNodeKind::getOMPClauseKind

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183903. lebedev.ri added a comment. NFC. - Rebased - Switched to `OpenMPClauseKind ASTNodeKind::getOMPClauseKind()`. This is better anyway, since it avoids string comparisons, and is a simple switch over an enum. Repository: rCTE Clang Tools Extra C

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. @thakis Sorry I don't understand your point. At the end of the day, ProgramPoint and BodyFarm are only used by the static analyzer. If you disagree, what is your proposed directory structure? What would be the benefits? Repository: rC Clang CHANGES SINCE LA

Re: r352369 - [AST] Introduce GenericSelectionExpr::Association

Hi, This doesn't compile when using GCC 4.8.4: 372/372] Building CXX object tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o FAILED: tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o /work/gccprefix/bin/g++ -

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371563 , @george.karpenkov wrote: > > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > > used by tooling-like t

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371562 , @george.karpenkov wrote: > > Can you elaborate a bit in what sense this decouples ARCMT from the > > analyzer? > > ARCMT now does not need to link against the analyzer > > > Can CLANG_ENABLE_STATIC_ANALYZER now

[PATCH] D57337: [Targets] Adjust ARM data layout

michaelplatings updated this revision to Diff 183893. michaelplatings added a comment. Diff with -U9 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57337/new/ https://reviews.llvm.org/D57337 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k

[PATCH] D57330: Adjust documentation for git migration.

jyknight updated this revision to Diff 183891. jyknight added a comment. Fix some warnings I added. Restore TestSuiteMakefileGuide.rst, which apparently isn't 100% obsolete. (But it is incorrect, and I'm not sure exactly how to fix it, so I just left a FIXME). CHANGES SINCE LAST ACTION https:

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rL352391: Add -fapply-global-visibility-to-externs for -cc1 (authored by scott.linder, committed by ). Changed prior to commit: https://reviews.llvm.org/D56868?vs=182559&id=183886#toc Repository: rL LL

r352391 - Add -fapply-global-visibility-to-externs for -cc1

Author: scott.linder Date: Mon Jan 28 09:12:19 2019 New Revision: 352391 URL: http://llvm.org/viewvc/llvm-project?rev=352391&view=rev Log: Add -fapply-global-visibility-to-externs for -cc1 Introduce an option to request global visibility settings be applied to declarations without a definition or

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

This revision was automatically updated to reflect the committed changes. Closed by commit rL352390: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" --

r352390 - [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

Author: lebedevri Date: Mon Jan 28 09:04:11 2019 New Revision: 352390 URL: http://llvm.org/viewvc/llvm-project?rev=352390&view=rev Log: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists Summary: As discussed in https://reviews.llvm.org/D57112#inline-506781, 'flush' clause does no

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. @dblaikie As I mentioned in one of my earlier comments, after some analysis, I think this patch definitely not the right way to fix the problem. We just cannot default to the main file if the DIFile source is not available. I have a bug filed for the same issue (

[libunwind] r352384 - [libunwind] Drop the dependency on , add placement new inline

Author: phosek Date: Mon Jan 28 08:44:56 2019 New Revision: 352384 URL: http://llvm.org/viewvc/llvm-project?rev=352384&view=rev Log: [libunwind] Drop the dependency on , add placement new inline We haven't eliminated C++ library dependency altogether in D57251, UnwindCursor.hpp had an unused depe

Re: r346652 - Make clang-based tools find libc++ on MacOS

This seems to fix it, but I don't know if it's the right fix: diff --git a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp b/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp index b62416ffd9e..d933f8c1b70 100644 --- a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp +++ b/clang/

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. I tried to creduce one file where the result differed and this is the result: typedef struct { int a; int b } c; d; e(c *f) { d < f->a; c g; h(&g.b); e(&g); } I think this the core idea is quite straightforward but this example is a bi

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matcher

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

ABataev added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" lebedev.ri wrote: > ABataev wrote: > > Just `

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +static Expr *IgnoreImpCastsSingleStep(Expr *E) { + if (auto *ICE = dyn_cast_or_null(E)) +return ICE->getSubExpr(); aaron.ballman wrote: > Do we really need to accept null arguments? We didn

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 183865. riccibruno marked 4 inline comments as done. riccibruno added a comment. Removed the separator comments in `Expr.cpp` Mode `IgnoreExprNodes` work with an arbitrary number of functions. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" ABataev wrote: > Just `.Case("flush", OMPC

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

alexfh added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher, yman

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri added a comment. In D57280#1373547 , @ABataev wrote: > LG with a nit Thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57280/new/ https://reviews.llvm.org/D57280 _

[PATCH] D57330: Adjust documentation for git migration.

jyknight created this revision. jyknight added reviewers: jlebar, rnk, mehdi_amini. Herald added subscribers: jsji, jfb, arphaman, christof, delcypher, hiraditya, nhaehnle, jvesely, nemanjai, kubamracek, arsenm. Herald added a reviewer: bollu. Herald added a reviewer: serge-sans-paille. This fixe

[PATCH] D56928: Support attribute used in member funcs of class templates

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2182 + if (Method->hasAttr()) { +if (auto *A = dyn_cast(Owner)) { + SourceLocation Loc; `const auto *`? ==

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

aaron.ballman added a comment. In D56160#1372766 , @bernhardmgruber wrote: > Thank you for the feedback! > > @JonasToth I added tests for `decltype` and i can rewrite all signatures > where `decltype` is not the top level expression. The reason is, that

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard for opinions on whether `IgnoreParenImpCasts` should skip full expressions, and also the changes to accepting null expressions as arguments in more places. Comment at: lib/AST/Expr.cpp:2559

Re: r346652 - Make clang-based tools find libc++ on MacOS

I think c-index-test has the same problem: $ cat test.cc #include $ out/gn/bin/c-index-test -write-pch foo.pch test.cc test.cc:1:10: fatal error: 'iostream' file not found Since https://reviews.llvm.org/rL350714 was a driver-side fix and c-index-test doesn't use lib/Driver, it didn't do anything

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57325: [clangd] Collect macros in static index.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. We are missing macros in static index. symbols: before 407 K vs after 420 K dex memory usage (static index): before 299 MB vs 304 MB Reposito

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matcher

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56943/new/ https://reviews.llvm.org/D56943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 183845. ioeric added a comment. - Rebase on origin/master Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clangd/IncludeFixer.cpp clang

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

This revision was automatically updated to reflect the committed changes. Closed by commit rL352369: [AST] Introduce GenericSelectionExpr::Association (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57106?vs=18

r352369 - [AST] Introduce GenericSelectionExpr::Association

Author: brunoricci Date: Mon Jan 28 06:18:11 2019 New Revision: 352369 URL: http://llvm.org/viewvc/llvm-project?rev=352369&view=rev Log: [AST] Introduce GenericSelectionExpr::Association Introduce a new class GenericSelectionExpr::Association which bundle together an association expression and it

Re: [clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

Merged to 8.0 in r352368. On Fri, Jan 25, 2019 at 11:05 AM Jonas Toth via cfe-commits wrote: > > Author: jonastoth > Date: Fri Jan 25 11:05:12 2019 > New Revision: 352231 > > URL: http://llvm.org/viewvc/llvm-project?rev=352231&view=rev > Log: > [clang-tidy] fix unit tests for dropped _Float16 sup

[PATCH] D46871: [AMDGPU] Add interpolation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC352358: [AMDGPU] Add interpolation builtins (authored by timcorringham, committed by ). Herald added a subscriber: jvesely. Changed prior to commit: https://reviews.llvm.org/D46871?vs=147460&id=183837#t

r352358 - [AMDGPU] Add interpolation builtins

Author: timcorringham Date: Mon Jan 28 05:50:37 2019 New Revision: 352358 URL: http://llvm.org/viewvc/llvm-project?rev=352358&view=rev Log: [AMDGPU] Add interpolation builtins Summary: Added builtins for the interpolation intrinsics, and related LIT test. Reviewers: arsenm, tpr, dstuttard, #amdg

  1   2   >