r352344 - [X86] Add new variadic avx512 compress/expand intrinsics that use vXi1 types for the mask argument.

Author: ctopper Date: Sun Jan 27 23:03:10 2019 New Revision: 352344 URL: http://llvm.org/viewvc/llvm-project?rev=352344&view=rev Log: [X86] Add new variadic avx512 compress/expand intrinsics that use vXi1 types for the mask argument. Custom lower the builtins to these intrinsics. This enables th

[libunwind] r352341 - [CMake] Use __libc_start_main rather than fopen when checking for C library

Author: phosek Date: Sun Jan 27 20:12:54 2019 New Revision: 352341 URL: http://llvm.org/viewvc/llvm-project?rev=352341&view=rev Log: [CMake] Use __libc_start_main rather than fopen when checking for C library The check_library_exists CMake uses a custom symbol definition. This is a problem when c

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny added a comment. Given that this path changes with every clang release, so you're effectively making a hard dependency on the clang version used to build the program, I dare say some systems may either decide not to support shared runtimes at all or use `ld.so.conf` or equivalent that ca

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay added a comment. Friendly ping :) (This is related to FreeBSD, not OpenBSD) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D57001: [libunwind] Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__

mstorsjo updated this revision to Diff 183776. mstorsjo added a comment. I had to update the signature of assembly functions which have got the concrete type of unw_fpreg_t in the mangled name. I chose to use void* for these functions, as I believe the same functions also are used for ARM EHABI,

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a comment. In D57303#1373077 , @phosek wrote: > In D57303#1373061 , @krytarowski > wrote: > > > How do you resolve paths? Linker cache with registry of libraries? > > > `DT_NEEDED` aren't treated

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373061 , @krytarowski wrote: > How do you resolve paths? Linker cache with registry of libraries? `DT_NEEDED` aren't treated as paths, they are used as object names (keys); dynamic linker passes those to the loader ser

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a comment. In D57303#1373057 , @phosek wrote: > In D57303#1373035 , @krytarowski > wrote: > > > + vitalybuka > > > > Can we fix it for everybody? It's certainly not restricted to NetBSD. > > > As

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373035 , @krytarowski wrote: > + vitalybuka > > Can we fix it for everybody? It's certainly not restricted to NetBSD. As a point of reference, we use shared runtimes on Fuchsia but we don't use rpath so this is not som

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303 ___ cfe-commits ma

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

krytarowski added a reviewer: vitalybuka. krytarowski added a comment. + vitalybuka Can we fix it for everybody? It's certainly not restricted to NetBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303

Re: r352323 - [SemaCXX] Fix ICE with structure bindings to members of template

Hi Hans, This is a safe change that fixes a crash; it'd be good to get this into clang 8. Thanks! On Sun, 27 Jan 2019, 11:19 Nicolas Lesser via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: rakete > Date: Sun Jan 27 11:19:59 2019 > New Revision: 352323 > > URL: http://llvm.org

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

Rakete added a comment. Backporting to 8.0.0 is possibly possible, you'll need to ping Hans. I don't know about previous versions though. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974 _

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

This revision was automatically updated to reflect the committed changes. Closed by commit rL352323: [SemaCXX] Fix ICE with structure bindings to members of template (authored by Rakete, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r352323 - [SemaCXX] Fix ICE with structure bindings to members of template

Author: rakete Date: Sun Jan 27 11:19:59 2019 New Revision: 352323 URL: http://llvm.org/viewvc/llvm-project?rev=352323&view=rev Log: [SemaCXX] Fix ICE with structure bindings to members of template Summary: Trying to use structure binding with a structure that doesn't implement std::tuple_siz

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 marked 4 inline comments as done. boga95 added a comment. Is it ready to land? Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:212 + llvm::StringSwitch(Name) + .Case("atoi", TaintPropagationRule({0}, {ReturnValueIndex})) + .Case("at

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, phosek, dlj. Herald added a subscriber: dberris. Append appropriate -rpath when using shared compiler-rt runtimes, e.g. '-fsanitize=address -shared-libasan'. There's already a similar logic in CommonArgs.cpp but it uses non

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

ddiproietto added a comment. Sorry, I don't have commit access, can someone push this, please? Also, should this be backported to 8.x? I'm actually interested in a backport up to 5.x, if possible. If not possible, that's fine too. Thanks! Cheers, Daniele Repository: rC Clang CHANGES SINCE

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183755. riccibruno added a comment. Removed duplicated comment in `AssociationIteratorTy` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106 Files: include/clang/AST/Expr.h includ

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

AlexAltea added a comment. My open-source project would heavily benefit from //clang-format//, but we require this proposed `AlignConsecutiveMacros` feature. I've placed a modest bounty of 50 USD for it. Since BountySource isn't compatible with Phabricator, I linked the bounty to an "external" i

[PATCH] D57235: [AST] Add structural eq tests for template args

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. There are never enough tests :) Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57235/new/ https://reviews.llvm.org/D57235 __

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri added subscribers: sbenza, klimek. lebedev.ri added a comment. In D57113#1372891 , @JonasToth wrote: > LGTM with the few language nits. > The new matchers look better and are more matcher style, gj :) Thank you for the review! I'm not quite s

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:40-43 + { NKI_None, "OMPClause" }, +#define OPENMP_CLAUSE(TextualSpelling, DERIVED) \ + {NKI_OMPClause, #TextualSpelling}, +#include "clang/Basic/OpenMPKinds.def" ---

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM with the few language nits. The new matchers look better and are more matcher style, gj :) Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:126 + // Don't re

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183752. riccibruno added a comment. Use `iterator_facade_base`. It didn't work the first time because I forgot to bring in the name `operator++` from `iterator_facade_base` into `AssociationIteratorTy`. Since name lookup occurs before overload resolution