lebedev.ri added inline comments.
================ Comment at: lib/AST/ASTTypeTraits.cpp:40-43 + { NKI_None, "OMPClause" }, +#define OPENMP_CLAUSE(TextualSpelling, DERIVED) \ + {NKI_OMPClause, #TextualSpelling}, +#include "clang/Basic/OpenMPKinds.def" ---------------- Humm, though i guess this will need to be changed back for when the matchers evolve from the check into the ASTMatchers, for better clang-query expirience. Would it be ok to add the opposite direction functionality as compared to `static ASTNodeKind getFromNode(const OMPClause &C);`? I.e. roughly `OMPClauseKind getOMPClauseKindFromASTNodeKind() const;` ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits