[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

This revision was automatically updated to reflect the committed changes. Closed by commit rC352307: Remove Expr sugar decorating the CXXUuidofExpr node. (authored by void, committed by ). Changed prior to commit: https://reviews.llvm.org/D57114?vs=183180&id=183750#toc Repository: rC Clang

r352307 - Remove Expr sugar decorating the CXXUuidofExpr node.

Author: void Date: Sat Jan 26 23:24:03 2019 New Revision: 352307 URL: http://llvm.org/viewvc/llvm-project?rev=352307&view=rev Log: Remove Expr sugar decorating the CXXUuidofExpr node. Summary: Sugar, like ConstantExpr, causes an infinite expansion of the template object. Reviewers: rsmith, aaro

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

thakis added a comment. (fwiw using %T is discouraged nowadays, see https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions / https://reviews.llvm.org/D35396 ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D5056

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Thank you for the feedback! @JonasToth I added tests for `decltype` and i can rewrite all signatures where `decltype` is not the top level expression. The reason is, that the source range of a `clang::DecltypeTyp

r352299 - [FIX] Adjust CXX microsoft abi dynamic cast test to r352293

Author: jdoerfert Date: Sat Jan 26 16:22:10 2019 New Revision: 352299 URL: http://llvm.org/viewvc/llvm-project?rev=352299&view=rev Log: [FIX] Adjust CXX microsoft abi dynamic cast test to r352293 Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp cfe/trunk/test/CodeGenCXX/

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974 ___ cfe-c

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. In D56935#1370861 , @philip.pfaffe wrote: > It would be good to check, since the bots won't! Otherwise this looks good. Thanks! I attempted to test on Windows, but noticed that for a shared library CMake already reports "Loadab

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 183729. mgorny added a comment. Ok, here's my proposition of using trinary enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files: ELF/Config.h ELF/Driver.cpp ELF/Writer.cpp docs/ld.lld.1 test/

[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

Szelethus abandoned this revision. Szelethus added a comment. As we currently support the actual `macro_expansions` format in CodeChecker, and AFAIK you guys at Apple prefer relying on Xcode (http://lists.llvm.org/pipermail/cfe-dev/2018-September/059231.html), I'd like to focus on more pressing

[PATCH] D55429: [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL352292: [analyzer] Add CheckerManager::getChecker, make sure that a registry function… (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r352292 - [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker

Author: szelethus Date: Sat Jan 26 13:41:50 2019 New Revision: 352292 URL: http://llvm.org/viewvc/llvm-project?rev=352292&view=rev Log: [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker This patch effectively fixes the almost decade ol

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369606 , @mgorny wrote: > In D56554#1369592 , @ruiu wrote: > > > No, I'm suggesting you add execstack, noexecstack and nognustack as a > > tri-state -z flag. Does this sound good?

[clang-tools-extra] r352290 - Fix a lit test failure after D54438

Author: szelethus Date: Sat Jan 26 13:22:58 2019 New Revision: 352290 URL: http://llvm.org/viewvc/llvm-project?rev=352290&view=rev Log: Fix a lit test failure after D54438 Modified: clang-tools-extra/trunk/test/clang-tidy/static-analyzer-config.cpp Modified: clang-tools-extra/trunk/test/clan

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

mgorny added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56932/new/ https://reviews.llvm.org/D56932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus added a comment. In D54438#1372324 , @NoQ wrote: > *gets hyped for the upcoming patchlanding party* Oh yeah, super excited about this! It was a blast! > In D54438#1329425 , @Szelethus wrote: > >> Hmmm,

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5084 + /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr. + template class AssociationIteratorTy { +friend class GenericSelectionExpr; riccibruno wrote: > aaron.ball

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 183715. melver added a comment. - Improve error reporting. While testing on Windows, noticed that Clang wants the error to be checked otherwise crashed quite verbosely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.or

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. In D57230#1372523 , @NoQ wrote: > In D57230#1372488 , @xazax.hun wrote: > > > In D57230#1372275 , @NoQ wrote: > > > > > > > > > > > Do you have suc

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5084 + /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr. + template class AssociationIteratorTy { +friend class GenericSelectionExpr; -

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5084 + /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr. + template class AssociationIteratorTy { +friend class GenericSelectionExpr; riccibruno wrote: > aaron.ball

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

Szelethus added a comment. Oops, I ran into the issue of `check-clang-analysis` not actually running out unit tests. I decided not to revert this patch and just commit the fix: rC352284 . Any objections? Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. In D57230#1372488 , @xazax.hun wrote: > In D57230#1372275 , @NoQ wrote: > > > > > > Do you have success reducing false positives using creduce? My problem > usually is that we cannot tell if a

r352284 - [analyzer] Fix an bug where statically linked, but not registered checkers weren't recognized

Author: szelethus Date: Sat Jan 26 09:27:40 2019 New Revision: 352284 URL: http://llvm.org/viewvc/llvm-project?rev=352284&view=rev Log: [analyzer] Fix an bug where statically linked, but not registered checkers weren't recognized My last patch, D56989, moved the validation of whether a checker e

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL352282: [analyzer][NFC] Keep track of whether enabling a checker was explictly… (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

r352282 - [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

Author: szelethus Date: Sat Jan 26 08:35:33 2019 New Revision: 352282 URL: http://llvm.org/viewvc/llvm-project?rev=352282&view=rev Log: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments I added a new enum to CheckerInfo, so we can easily t

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:143 + // Would it be better to name it '~experimental' or something else + // that's ASCIIbetically last? + llvm::sort(Checkers, checkerName

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. I was just working on this this afternoon to show you the difference when it is split up. Looks like you committed this meanwhile. While building I noticed that you introduced a `-Wreorder` bug in D57238 , which isn't surprising given h

[PATCH] D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL352279: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56

r352279 - [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions

Author: szelethus Date: Sat Jan 26 07:59:21 2019 New Revision: 352279 URL: http://llvm.org/viewvc/llvm-project?rev=352279&view=rev Log: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions Since pretty much all methods of CheckerRegistry has AnalyzerOptions as an argument, it makes sense t

[PATCH] D55425: [analyzer] Split unix.API up to UnixAPIMisuseChecker and UnixAPIPortabilityChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL352278: [analyzer] Split unix.API up to UnixAPIMisuseChecker and… (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5542

r352278 - [analyzer] Split unix.API up to UnixAPIMisuseChecker and UnixAPIPortabilityChecker

Author: szelethus Date: Sat Jan 26 07:56:40 2019 New Revision: 352278 URL: http://llvm.org/viewvc/llvm-project?rev=352278&view=rev Log: [analyzer] Split unix.API up to UnixAPIMisuseChecker and UnixAPIPortabilityChecker The actual implementation of unix.API features a dual-checker: two checkers i

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun updated this revision to Diff 183702. xazax.hun added a comment. - Added some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/call-invalidation.cpp test/Analysis/cx

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun marked 2 inline comments as done. xazax.hun added a comment. In D57230#1372275 , @NoQ wrote: > Could you share reproducible examples for these, probably in the form of > FIXME tests? Given that they are "regressions", they are easy to creduce do

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183701. lebedev.ri added a comment. Herald added a subscriber: arphaman. Mention new module in `docs/clang-tidy/index.rst`. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D5

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

Eugene.Zelenko added a comment. New module is still not mentioned in docs/clang-tidy/index.rst. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D57113 ___ cfe-commits m

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

This revision was automatically updated to reflect the committed changes. Closed by commit rC352277: [analyzer] Supply all checkers with a shouldRegister function (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ http

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Szelethus added a comment. In D55424#1364696 , @Szelethus wrote: > In D55424#1326397 , @NoQ wrote: > > > Should we also pass `CheckerManager` into `shouldRegister...`? Or is it > > entirely useless? > > > I wouldn'

r352277 - [analyzer] Supply all checkers with a shouldRegister function

Author: szelethus Date: Sat Jan 26 06:23:08 2019 New Revision: 352277 URL: http://llvm.org/viewvc/llvm-project?rev=352277&view=rev Log: [analyzer] Supply all checkers with a shouldRegister function Introduce the boolean ento::shouldRegister##CHECKERNAME(const LangOptions &LO) function very simila

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183699. lebedev.ri added a comment. Adjust a few comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D57113 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyFo

[PATCH] D57104: [AST] Pack GenericSelectionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL352276: [AST] Pack GenericSelectionExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57104?vs=183349&id=183698#toc

r352276 - [AST] Pack GenericSelectionExpr

Author: brunoricci Date: Sat Jan 26 06:15:10 2019 New Revision: 352276 URL: http://llvm.org/viewvc/llvm-project?rev=352276&view=rev Log: [AST] Pack GenericSelectionExpr Store the controlling expression, the association expressions and the corresponding TypeSourceInfos as trailing objects. Additi

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL352275: [AST][NFC] Various cleanups to GenericSelectionExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57238?vs=

r352275 - [AST][NFC] Various cleanups to GenericSelectionExpr

Author: brunoricci Date: Sat Jan 26 05:58:15 2019 New Revision: 352275 URL: http://llvm.org/viewvc/llvm-project?rev=352275&view=rev Log: [AST][NFC] Various cleanups to GenericSelectionExpr Various cleanups to GenericSelectionExpr factored out of D57104. In particular: 1. Move the friend declarat

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 183696. riccibruno added a comment. Update the comment in `IgnoreImpCastsExtraSingleStep` and return early from `IgnoreImpCastsExtraSingleStep` and `IgnoreImplicitSingleStep` when `IgnoreImpCastsSingleStep` skipped something. Repository: rC Clang CHA

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183694. lebedev.ri marked 28 inline comments as done. lebedev.ri added a comment. Addressed review notes; found a way to use the `OMPClause` matcher in `isAllowedToContainClause()`, as opposed to passing the `OpenMPClauseKind`. Repository: rCTE Clang To

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

riccibruno updated this revision to Diff 183695. riccibruno added a comment. Removed superfluous braces added in some if statements. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57266/new/ https://reviews.llvm.org/D57266 Files: include/clang/AST/Expr.h incl

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:49-50 +/// +/// FIXME: would be better to pass the actual class name (e.g. OMPDefaultClause) +///instead of the actual OpenMPClauseKind. +AST_MATCHER_P(OMPExecutableDirective, isAllow

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183692. lebedev.ri added a comment. Store OpenMP clause spelling in the `ASTNodeKind::KindInfo ASTNodeKind::AllKindInfo[]`, not the stringified clang AST class name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183690. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Rebased ontop of D57280 , use `const auto*`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https:

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam marked an inline comment as done. zahiraam added a comment. Aaron, Please advise. Thanks. Comment at: test/Sema/dllexport.c:70 +// const variables +__declspec(dllexport) int const x = 3; aaron.ballman wrote: > Can you think of any redeclaration sce

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked 5 inline comments as done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Bas

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri created this revision. lebedev.ri added a reviewer: ABataev. lebedev.ri added a project: OpenMP. Herald added subscribers: arphaman, guansong. As discussed in https://reviews.llvm.org/D57112#inline-506781, 'flush' clause does not exist in the OpenMP spec, it can not be specified, and `