[clang-tools-extra] r352031 - [extra] unit tests enable crash-recovery cases on FreeBSD

Author: devnexen Date: Wed Jan 23 23:58:42 2019 New Revision: 352031 URL: http://llvm.org/viewvc/llvm-project?rev=352031&view=rev Log: [extra] unit tests enable crash-recovery cases on FreeBSD Seems the previous statement does not hold up anymore. Reviewers: steveire Reviewed By: steveire Diff

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352031: [extra] unit tests enable crash-recovery cases on FreeBSD (authored by devnexen, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

hultman added a comment. @benhamilton Would you mind landing the patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56909/new/ https://reviews.llvm.org/D56909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57072: Don't codegen an unreachable return block

bmoody added a comment. Great, I don't have commit access so you're welcome to commit on my behalf. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57072/new/ https://reviews.llvm.org/D57072 ___ cfe-commits m

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added inline comments. Comment at: include/clang/Basic/TargetInfo.h:52 -/// Exposes information about the current target. -/// -class TargetInfo : public RefCountedBase { - std::shared_ptr TargetOpts; - llvm::Triple Triple; -protected: - // Target values set by the

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik updated this revision to Diff 183251. shafik added a comment. Addressing comments on naming in the unit test and refactoring of duplicated code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ https://reviews.llvm.org/D56936 Files: lib/AST/ASTImporter.cpp unittests

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik marked 17 inline comments as done. shafik added a comment. @martong I don't follow the discussion on `VisitParmVarDecl` an what seems like an alternate fix. Can you elaborate? Comment at: lib/AST/ASTImporter.cpp:3042 + if (FoundByLookup) { +if (auto *MD = dyn_cas

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added a comment. In D55850#1368767 , @Anastasia wrote: > In D55850#1366709 , @rjmccall wrote: > > > Most of the remaining OpenCL checks are for OpenCL-specific logic like > > inferring the default address

[PATCH] D57072: Don't codegen an unreachable return block

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, I have no objection to doing this at this point. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57072/new/ https://reviews.llvm.org/D57072

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF updated this revision to Diff 183248. EricWF marked 2 inline comments as done. EricWF added a comment. - Add or correct tests as requested. - Fix code gen for initializers of reference types to correctly evaluate the initializer as a constant expression. CHANGES SINCE LAST ACTION https

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. One minor request about regarding a dyn_cast, but this looks like the right approach. Thank you! Comment at: clang/lib/AST/Type.cpp:1293 + +const auto *newAttr

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352025: Reland r345009 "[DebugInfo] Generate debug information for labels." (authored by HsiangKai, committed by ). Chang

r352025 - Reland r345009 "[DebugInfo] Generate debug information for labels."

Author: hsiangkai Date: Wed Jan 23 21:34:29 2019 New Revision: 352025 URL: http://llvm.org/viewvc/llvm-project?rev=352025&view=rev Log: Reland r345009 "[DebugInfo] Generate debug information for labels." Generate DILabel metadata and call llvm.dbg.label after label statement to associate the meta

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF marked 6 inline comments as done. EricWF added inline comments. Comment at: test/CodeGenCXX/builtin-is-constant-evaluated.cpp:41-42 + +// CHECK-STATIC-DAG: @p = global i32 26, +CONSTINIT int p = f(); // f().m == 13; initialized to 26 + rsmith wrote: > Do w

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:958-964 + // Remove the address_space qualifier so it does not get printed. We + // instead want to print the macro only. + SplitQualType Spli

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 183242. leonardchan added a comment. - Rebase after D55447 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTCo

r352018 - [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia

Author: phosek Date: Wed Jan 23 19:24:37 2019 New Revision: 352018 URL: http://llvm.org/viewvc/llvm-project?rev=352018&view=rev Log: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia Similarly to libc++, we want to use hermetic static libc++abi. Differential Revision: https://reviews

[PATCH] D57136: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352018: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia (authored by phosek, committed by ). Changed prior

[PATCH] D57136: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Similarly to libc++, we want to use hermetic static libc++abi. Repository: rC Clang https://reviews.llvm.org/D57136 File

[PATCH] D57135: [ExprConstant] Unify handling of array init with lvalues.

efriedma created this revision. efriedma added a reviewer: rsmith. This should have no functional effect; evaluation is still generating the same result. But the assertions and comments should make it more clear what's actually happening. Part of a fix to https://bugs.llvm.org/show_bug.cgi?id

[libunwind] r352016 - [libunwind] Don't abort if encoutering invalid .eh_frame_hdr

Author: phosek Date: Wed Jan 23 19:04:42 2019 New Revision: 352016 URL: http://llvm.org/viewvc/llvm-project?rev=352016&view=rev Log: [libunwind] Don't abort if encoutering invalid .eh_frame_hdr Recent Linux kernel release has introduced a bug as part of the ORC rollout where the vDSO has a valid

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

rsmith added a comment. Thanks for the added tests! They seem to have found a bug in the handling of local const integral variables. Comment at: test/CodeGenCXX/builtin-is-constant-evaluated.cpp:41-42 + +// CHECK-STATIC-DAG: @p = global i32 26, +CONSTINIT int p = f(); // f().m

r352011 - Improve diagnostic for -fvisibility mismatch between module/PCH build

Author: rsmith Date: Wed Jan 23 18:41:46 2019 New Revision: 352011 URL: http://llvm.org/viewvc/llvm-project?rev=352011&view=rev Log: Improve diagnostic for -fvisibility mismatch between module/PCH build and use. Modified: cfe/trunk/include/clang/Basic/LangOptions.def Modified: cfe/trunk/incl

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1366709 , @rjmccall wrote: > Most of the remaining OpenCL checks are for OpenCL-specific logic like > inferring the default address space, and yeah, we could probably make that a > target option or something. We hav

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

mclow.lists closed this revision. mclow.lists added a comment. Herald added a reviewer: EricWF. For some reason, this test was not marked `// XFAIL gnu-linux` like all the other tests that use the `LOCALE_cs_CZ_ISO8859_2` locale. In revision 352006, I uncommented this entire test, and added the X

r352003 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Author: yln Date: Wed Jan 23 17:06:19 2019 New Revision: 352003 URL: http://llvm.org/viewvc/llvm-project?rev=352003&view=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai updated this revision to Diff 183216. vsapsai added a comment. Update diff to ignore parent patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57076/new/ https://reviews.llvm.org/D57076 Files: clang/lib/AST/Type.cpp clang/test/SemaObjC/kindof.m Index: clang/test/SemaObjC

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai updated this revision to Diff 183215. vsapsai added a comment. - Add a test that `__kindof` works with type sugar such as typedef. - Use early return to reduce nesting. Also it's consistent with the previous early returns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57076/new/

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin updated this revision to Diff 183214. dmikushin added a comment. Adding test case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 Files: lib/Driver/ToolChains/MSP430.h test/CodeGen/msp430-reloc.c Index: te

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai added a comment. In D57076#1368407 , @jordan_rose wrote: > I //think// this is reasonable but Doug was the one who worked on this. I > wonder if it also helps with the test cases in rdar://problem/24619481. Yep, it helps with the test cases in r

[libunwind] r352000 - Creating release candidate rc1 from release_800 branch

Author: hans Date: Wed Jan 23 16:44:29 2019 New Revision: 352000 URL: http://llvm.org/viewvc/llvm-project?rev=352000&view=rev Log: Creating release candidate rc1 from release_800 branch Added: libunwind/tags/RELEASE_800/ libunwind/tags/RELEASE_800/rc1/ - copied from r351999, libunwi

[libclc] r352000 - Creating release candidate rc1 from release_800 branch

Author: hans Date: Wed Jan 23 16:44:29 2019 New Revision: 352000 URL: http://llvm.org/viewvc/llvm-project?rev=352000&view=rev Log: Creating release candidate rc1 from release_800 branch Added: libclc/tags/RELEASE_800/ libclc/tags/RELEASE_800/rc1/ - copied from r351999, libclc/branch

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

This revision was automatically updated to reflect the committed changes. Closed by commit rL351997: [Sema] Fix Modified Type in address_space AttributedType (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D554

r351997 - [Sema] Fix Modified Type in address_space AttributedType

Author: leonardchan Date: Wed Jan 23 16:11:35 2019 New Revision: 351997 URL: http://llvm.org/viewvc/llvm-project?rev=351997&view=rev Log: [Sema] Fix Modified Type in address_space AttributedType This is a fix for https://reviews.llvm.org/D51229 where we pass the address_space qualified type as th

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. Friendly ping @EricWF Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54399/new/ https://reviews.llvm.org/D54399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams added a comment. @stella.stamenova Thanks for the input, what about now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D50563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams updated this revision to Diff 183197. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D50563 Files: test/Frontend/output-failures.c test/Frontend/stats-file.c Index: test/Frontend/stats-file.c =

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

riccibruno added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:6311 if (isa(E)) { - Converted = TemplateArgument(ArgResult.get()); + Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts()); break; A remark wh

[PATCH] D26110: Add a check for GCC to the _LIBCPP_EXPLICIT define

mclow.lists closed this revision. mclow.lists added a comment. Yes, this appears to have been landed. Closing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26110/new/ https://reviews.llvm.org/D26110 ___ cfe-commits mailing list cfe-commits

[PATCH] D28248: Work around GCC PR37804

mclow.lists closed this revision. mclow.lists added a comment. I changed the `_LIBCPP_TYPE_VIS_ONLY` to `_LIBCPP_TEMPLATE_VIS` and committed this as revision 351993. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28248/new/ https://reviews.llvm.org/D28248

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

void updated this revision to Diff 183180. void added a comment. Move test to proper place and add "-verify" flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57114/new/ https://reviews.llvm.org/D57114 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/PR40395.

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

void marked 2 inline comments as done. void added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:6311 if (isa(E)) { - Converted = TemplateArgument(ArgResult.get()); + Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts()); br

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. @ddunbar is that ok with you? Thanks See https://bugs.llvm.org/show_bug.cgi?id=38836 https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1810860 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llv

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. Thanks. You have to change a couple of the locations to '%T' though - '%t' is a file and '%T' is a directory - and you're using '%t' as a directory in a couple of

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. I did filled the form already ... do not know if it needs days to take effects ... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams added a comment. @stella.stamenova Good suggestion, I think you are right. I have updated the diff to use %t, that way any end-users can control the way their lit test work in a read-only mount by simply altering the test_exec_root in their config CHANGES SINCE LAST ACTION http

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire added a comment. You may need to accept the new license terms: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129069.html Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds.

NoQ added a subscriber: alexfh. NoQ added a comment. I think there are much more problems that we will find this way, starting from long foo(long x) { unsigned y = (unsigned)x; if (y <= -1) return 0; return (y + 2) < 2; // crash :( } I don't mind delaying this patch unti

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams updated this revision to Diff 183170. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D50563 Files: test/Frontend/output-failures.c test/Frontend/stats-file.c Index: test/Frontend/stats-file.c =

[PATCH] D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds.

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. We would start getting crashes from `TrustNonnullChecker` if we enable it. Shouldn't those be fixed first? An input which crashes with this assertion is `test/Ana

[PATCH] D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds.

a_sidorin accepted this revision. a_sidorin added a comment. Oh, I remember how much pain have debug mode-only assertions caused. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57062/new/ https://reviews.llvm.org/D57062 _

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

jordan_rose added a comment. I //think// this is reasonable but Doug was the one who worked on this. I wonder if it also helps with the test cases in rdar://problem/24619481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57076/new/ https://reviews.llvm.org/D57076 ___

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

For completeness, in case the construction isn't clear, here's a full repro of the symptom. $ cat pch.cc $ cat pch.h #include "foo.h" $ rm bar/foo.h $ for i in {1..300}; do echo '#include "foo'$i'.h"' >> bar/foo.h; done $ for i in {1..300}; do touch bar/foo$i.h; done $ cat client.cc #include "bar/

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. Seems I can t commit myself to the svn repo ... had moved to git ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___ cfe-commits mail

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. In D57102#1368373 , @steveire wrote: > The question was whether there is a build-bot for FreeBSD (if there is, then > it is covered by CI). > > Doesn't matter though. If no such bot exists, this isn't the commit to > enforce req

[PATCH] D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno abandoned this revision. riccibruno marked 2 inline comments as done. riccibruno added a comment. Closed in favor of D57104 and D57106 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire added a comment. The question was whether there is a build-bot for FreeBSD (if there is, then it is covered by CI). Doesn't matter though. If no such bot exists, this isn't the commit to enforce requiring one! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. In D57102#1368309 , @steveire wrote: > Is this covered by CI? The tests pass. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 _

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183160. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Fix documentation nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D57113 Files: clan

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1368292 , @steveire wrote: > In D57104#1368072 , @riccibruno > wrote: > > > In D57104#1368055 , @steveire > > wrote: > > > > > Splitti

r351977 - [Documentation] Fix problem in docs/SafeStack.rst introduced in r351976.

Author: eugenezelenko Date: Wed Jan 23 12:51:06 2019 New Revision: 351977 URL: http://llvm.org/viewvc/llvm-project?rev=351977&view=rev Log: [Documentation] Fix problem in docs/SafeStack.rst introduced in r351976. Modified: cfe/trunk/docs/SafeStack.rst Modified: cfe/trunk/docs/SafeStack.rst U

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

Eugene.Zelenko added a comment. Please mention new module in docs/clang-tidy/index.rst. Comment at: docs/ReleaseNotes.rst:76 +- New OpenMP module. + Please put new module before list of new checks. Comment at: docs/ReleaseNotes.rst:83 + +

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. In D57111#1368277 , @rzhikharevich wrote: > In D57111#1368256 , @riccibruno > wrote: > > > I guess yo

r351976 - [Documentation] Use HTTPS whenever possible

Author: eugenezelenko Date: Wed Jan 23 12:39:07 2019 New Revision: 351976 URL: http://llvm.org/viewvc/llvm-project?rev=351976&view=rev Log: [Documentation] Use HTTPS whenever possible Differential revision: https://reviews.llvm.org/D56946 Modified: cfe/trunk/docs/AutomaticReferenceCounting.r

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL351976: [Documentation] Use HTTPS whenever possible (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56946?vs=18264

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Is this covered by CI? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1368072 , @riccibruno wrote: > In D57104#1368055 , @steveire wrote: > > > Splitting the introduction of and porting to `Create` would significantly > > reduce the number of files

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

erik.pilkington added a comment. In D56760#1368216 , @rsmith wrote: > I don't see any evidence of that. Jakub said that modes 0-3 should stay > static, but that's in line with what we suggested. I don't think Jakub really said anything about whether we

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

rzhikharevich added a comment. In D57111#1368256 , @riccibruno wrote: > I guess you will want someone to commit it ? Yes, if the fix is correct. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57111/new/ https://reviews.l

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

jfb added a comment. In D56760#1368216 , @rsmith wrote: > In D56760#1368054 , @erik.pilkington > wrote: > > > So it seems like the GCC people want to keep `__builtin_object_size` static. > > > I don't see any evide

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:6311 if (isa(E)) { - Converted = TemplateArgument(ArgResult.get()); + Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts()); break; `IgnoreP

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

riccibruno added a comment. In D57111#1368230 , @rzhikharevich wrote: > In D57111#1368224 , @riccibruno > wrote: > > > Upload patches with full context please. > > Also the diagnostic seems to be wrong ? > > > I

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

void created this revision. void added a reviewer: rsmith. Herald added a subscriber: cfe-commits. Sugar, like ConstantExpr, causes an infinite expansion of the template object. Repository: rC Clang https://reviews.llvm.org/D57114 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/pr40395.

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5099 + public: +using iterator_category = std::forward_iterator_tag; +using value_type = AssociationTy; Carrying over the conversation from D57098: >> @aaron.ballman It seems like

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

rzhikharevich added a comment. In D57111#1368224 , @riccibruno wrote: > Upload patches with full context please. > Also the diagnostic seems to be wrong ? I don't think so, the valid code would be 'p->~C()'. > And finally is there a bug report for this

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56561/new/ https://reviews.llvm.org/D56561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

riccibruno added a comment. Upload patches with full context please. Also the diagnostic seems to be wrong ? And finally is there a bug report for this ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57111/new/ https://reviews.llvm.org/D57111 _

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

rsmith added a comment. In D56760#1368054 , @erik.pilkington wrote: > So it seems like the GCC people want to keep `__builtin_object_size` static. I don't see any evidence of that. Jakub said that modes 0-3 should stay static, but that's in line with w

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, xazax.hun, hokein. lebedev.ri added projects: clang-tools-extra, OpenMP. Herald added subscribers: guansong, rnkovacs, mgorny. Finds OpenMP directives that are allowed to contain `default` clause, but e

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri created this revision. lebedev.ri added reviewers: sbenza, bkramer, pcc, klimek, hokein. lebedev.ri added a project: OpenMP. lebedev.ri added a child revision: D57113: [clang-tidy] openmp-use-default-none - a new module and a check. `OMPClause` is the base class, it is not descendant f

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

This might finally be a repro! Nicos-MacBook-Pro:llvm-mono-2 thakis$ ls bar foo.h foo2.h Nicos-MacBook-Pro:llvm-mono-2 thakis$ type foo.h -bash: type: foo.h: not found Nicos-MacBook-Pro:llvm-mono-2 thakis$ ls bar foo.h foo2.h Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat bar/foo.h #include "foo2.h" Ni

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

rzhikharevich created this revision. rzhikharevich added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes handling of code like this: c++ struct Foo; void foo(Foo *p) { p.~Foo(); } Repository: rC Clang https://reviews.llvm.org/D57111 Files: clang/l

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. Thanks for filing the bug/reducing a test case - this change should include an automated test case that captures this issue (check for other tests that pass -gembed-source to see how this might be tested, possibly expanding the existing test case case or introducing a

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Thanks! In D56935#1367545 , @philip.pfaffe wrote: > I'm not sure what the current state of plugins on windows is. They were > broken and disabled last time I worked on this, but that might've changed in > the meantime! Worth che

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 183140. melver added a comment. - Revert use of SmallVector CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

On Wed, Jan 23, 2019 at 2:17 PM Nico Weber wrote: > Here's what I think is a repro: > > Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo.h > Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo2.h > Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.h > #include "foo.h" > Nicos-MacBook-Pro:llvm-mono-2 thakis$ c

[PATCH] D57104: [AST] Pack GenericSelectionExpr

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5043 + // association expressions. + enum { CONTROLLING = 0, ASSOC_EXPR_START = 1 }; + Do we want to use `ControllingIndex` and `AssocExprStartIndex` and combine with the enum you intr

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1367450 , @sammccall wrote: > This is definitely an improvement, though I don't know if it's *right*. > @akyrtzi, thoughts? Yeah, I'm not sure what the desired behavior is. When writing up the test I noticed there is

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

Here's what I think is a repro: Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo.h Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo2.h Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.h #include "foo.h" Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.cc Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat client.cc #in

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

JonasToth updated this revision to Diff 183136. JonasToth added a comment. - rebase to current refactoring Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57108/new/ https://reviews.llvm.org/D57108 Files: clang-tidy/bugprone/ExceptionEscapeCheck.cp

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183134. JonasToth marked an inline comment as done. JonasToth added a comment. - add license to exceptionanalyzer Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow); FunctionsThatShouldN

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: xazax.hun, mgorny. This patch utilizes the refactored `ExceptionAnalyzer` for `modernize-use-noexcept` to diagnose possibilties to introduce `noexcept` if there is no exception spec

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow); FunctionsThatShouldNotThrow.insert(FunctionsThatShouldNotThrowV

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183131. JonasToth added a comment. - [Fix] make class name correct Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files: clang-tidy/bugprone/ExceptionEscapeCheck.cp

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno marked an inline comment as done. riccibruno added a comment. In D57104#1368055 , @steveire wrote: > Splitting the introduction of and porting to `Create` would significantly > reduce the number of files touched by the 'real' change in this com

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1465 - for (unsigned I = 0, N = E->getNumAssocs(); I != N; ++I) { + for (GenericSelectionExpr::ConstAssociation Assoc : E->associations()) { dumpChild([=] { Range for loops in this file ge

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added a comment. Just in case you didn't know, you could have (and still can!) just update https://reviews.llvm.org/D57098 instead of creating a new PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. I haven't done a full review as it's not obvious what parts of the diff relate to which separate change. Perhaps Aaron will review and approve though for you anyway. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57104/new/ htt

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

The way things worked before your patch is that getFile() calls for headers that are loaded from a PCH file hit the early-ish return in if (UFE.isValid()) { // Already have an entry with this inode, return it. The first stack I posted (with ReadControlBlock() in it) populates this UniqueRealFil

  1   2   >