rjmccall added a comment.

In D55850#1368767 <https://reviews.llvm.org/D55850#1368767>, @Anastasia wrote:

> In D55850#1366709 <https://reviews.llvm.org/D55850#1366709>, @rjmccall wrote:
>
> > Most of the remaining OpenCL checks are for OpenCL-specific logic like 
> > inferring the default address space, and yeah, we could probably make that 
> > a target option or something.
>
>
> We have an address space map in the targets that can be used to map default 
> address space if needed. Or are you suggesting to migrate functionality like 
> `deduceOpenCLImplicitAddrSpace()` to the target setting? Although I feel this 
> belong to the language rather.


True.  But we could make it a Sema-wide setting, configured immediately so that 
we don't have to repeatedly check a language option whenever we parse or 
synthesize a method.  It would make that logic feel less language-specific.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55850/new/

https://reviews.llvm.org/D55850



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to