[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. @ruiu, what if one of the systems changes defaults (e.g. due to Hardening) and starts defaulting to noexecstack? In that case we'd want `-z execstack' to actually emit PT_GNU_STACK, and I don't think we really are able to 100% detect the default in clang. I'd really see

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

This is an ABI break (theoretically), but due to its nature I'm not too concerned. Please update the documentation for the attribute to describe these new semantics, though: the documentation currently says that we're just treating certain special members as if they were trivial when determining w

r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Author: ahatanak Date: Thu Jan 10 23:06:38 2019 New Revision: 350920 URL: http://llvm.org/viewvc/llvm-project?rev=350920&view=rev Log: [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed to it is a trivial_abi class. A class that has all of its copy and move constructors delete

r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

Author: ahatanak Date: Thu Jan 10 20:57:34 2019 New Revision: 350917 URL: http://llvm.org/viewvc/llvm-project?rev=350917&view=rev Log: [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto variable during auto type deduction, use the rewritten initializer when performing initializatio

RE: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

Syntax for asm goto: Syntax: asm [volatile] goto ( AssemblerTemplate : : InputOperands : Clobbers : GotoLabels) Only input is allowed. Output is not allowed Thanks. Jennifer -Original Message- From:

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

modocache added a comment. Great, thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56509/new/ https://reviews.llvm.org/D56509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

nickdesaulniers added a comment. Thanks for all the work that went into this patch, both initially and rebasing! Comment at: lib/AST/Stmt.cpp:465 + const LabelDecl *LD = getLabelExpr(i)->getLabel(); + return LD->getName(); +} These 2 statements can probably b

[PATCH] D3853: Begin implementing Plan 9 C extensions.

rsmith added a comment. If someone wants to pick this up and run with it, this patch is fine as a starting point (though will need to be rebased). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3853/new/ https://reviews.llvm.org/D3853 ___ c

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 181204. hwright marked an inline comment as done. hwright added a comment. Run `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abse

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

NoQ added a comment. Hmm, it disappeared after a clean rebuild. I think the problem was that i did `make clang` and then ran tests manually, instead of `make`, so the tool was not rebuilt and was only present under its old name. Because the tool does get rebuilt under `make check-clang-analysis

[clang-tools-extra] r350916 - Adapt to CXXMethodDecl::getThisType change (NFC)

Author: modocache Date: Thu Jan 10 18:12:31 2019 New Revision: 350916 URL: http://llvm.org/viewvc/llvm-project?rev=350916&view=rev Log: Adapt to CXXMethodDecl::getThisType change (NFC) Summary: https://reviews.llvm.org/D56509 changed the API of the CXXMethodDecl::getThisType method. Adapt to the

r350915 - Remember to instantiate explicit template argument lists in a friend

Author: rsmith Date: Thu Jan 10 17:59:33 2019 New Revision: 350915 URL: http://llvm.org/viewvc/llvm-project?rev=350915&view=rev Log: Remember to instantiate explicit template argument lists in a friend function declaration. We'd previously often just drop these on the floor, and friend redeclarat

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC350914: [AST] Remove ASTContext from getThisType (NFC) (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D56509?vs=180893&id=181200#toc Repository: rC Clang C

r350914 - [AST] Remove ASTContext from getThisType (NFC)

Author: modocache Date: Thu Jan 10 17:54:53 2019 New Revision: 350914 URL: http://llvm.org/viewvc/llvm-project?rev=350914&view=rev Log: [AST] Remove ASTContext from getThisType (NFC) Summary: https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from within the `CXXMethodDecl::getTh

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

efriedma added a comment. Missing changes to lib/Analysis/CFG.cpp. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; This looks suspicious; an AddrLab

r350913 - Fix header issues.

Author: rtrieu Date: Thu Jan 10 17:32:35 2019 New Revision: 350913 URL: http://llvm.org/viewvc/llvm-project?rev=350913&view=rev Log: Fix header issues. Several headers would fail to compile if other headers were not previously included. The usual issue is that a class is forward declared, but th

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

craig.topper created this revision. craig.topper added reviewers: erichkeane, nickdesaulniers, chandlerc, jyu2. Herald added a subscriber: eraman. Herald added a reviewer: shafik. This patch accompanies the RFC posted here: http://lists.llvm.org/pipermail/llvm-dev/2018-October/127239.html This is

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

pcc added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5112 + bool EnableSplitLTOUnit = Args.hasFlag( + options::OPT_fsplit_lto_unit, options::OPT_fno_split_lto_unit, false); + if (EnableSplitLTOUnit || WholeProgramVTables || Sanitize.needsLTO()) {

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Basic/CodeGenOptions.def:120 +CODEGENOPT(EnableSplitLTOUnit, 1, 0) ///< Enable LTO unit splitting to support +///

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively closed this revision. tlively added a comment. Closed by commit rC350909 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 ___ cfe-c

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. What do you think about this new logic: 1. specified `-z execstack` -> do not emit GNU STACK segment 2. specified `-z noexecstack` -> emit GNU STACK segment 3. no option specified -> detect `findSection(".note.GNU-stack")` (I might miss offhand some details here to b

Re: r350891 - Correct the source range returned from preprocessor callbacks.

On Thu, Jan 10, 2019 at 6:18 PM Nico Weber wrote: > > ../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field > 'ExprRange' initializer [-Wmissing-field-initializers] > return {false, DT.IncludedUndefinedIds}; > ^ Sorry about that -- fix

r350912 - Add an explicit initializer to silence a -Wmissing-field-initializers diagnostic; NFC.

Author: aaronballman Date: Thu Jan 10 16:13:57 2019 New Revision: 350912 URL: http://llvm.org/viewvc/llvm-project?rev=350912&view=rev Log: Add an explicit initializer to silence a -Wmissing-field-initializers diagnostic; NFC. Modified: cfe/trunk/lib/Lex/PPExpressions.cpp Modified: cfe/trunk

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. GNU linkers assume that input object files that work with non-executable stack has a .note.GNU-stack section, and they emit a PT_GNU_STACK segment to mark the stack area non-executable if all input files have that marker section. If restoring default means we implement tha

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/TextNodeDumper.cpp:44-45 +void TextNodeDumper::Visit(const Attr *A) { + { +ColorScope Color(OS, ShowColors, AttrColor); aaron.ballman wrote: > Formatting is inco

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire updated this revision to Diff 181182. steveire marked an inline comment as done. steveire added a comment. Nits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55492/new/ https://reviews.llvm.org/D55492 Files: include/clang/AST/AttrVisitor.h include/c

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:89 // Utilities -void dumpType(QualType T) { NodeDumper.dumpType(T); } void dumpTypeAsChild(QualType T); aaron.ballman wrote: > This seems unrelated to this patch (same below) ? These

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. I understand the concerns, but lld is biased with being a Linux linker. We need to customize it (restore defaults?) for NetBSD. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 _

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. Shouldn't the logic of emitting/not-emitting be based on `findSection(".note.GNU-stack")`? @mgorny can you please investigate it? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. In D56554#1353527 , @krytarowski wrote: > In D56554#1353513 , @ruiu wrote: > > > In D56554#1353487 , @krytarowski > > wrote: > > > > > In D56554#135336

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. Actually looking at GNU ld(1) source code, the logic is a little bit more complex and it depends on more aspects like relocations. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 __

r350909 - [WebAssembly] Add unimplemented-simd128 feature, gate builtins

Author: tlively Date: Thu Jan 10 15:49:00 2019 New Revision: 350909 URL: http://llvm.org/viewvc/llvm-project?rev=350909&view=rev Log: [WebAssembly] Add unimplemented-simd128 feature, gate builtins Summary: Depends on D56501. Also adds a macro define `__wasm_unimplemented_simd128__` for feature de

Re: r350891 - Correct the source range returned from preprocessor callbacks.

This revision has broken http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18904. Please take a look. On Thu, Jan 10, 2019 at 3:18 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field > 'ExprRange'

[PATCH] D56042: [analyzer] pr38838, pr39976: Fix a crash on emitting diagnostics before destructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350907: [analyzer] pr38838, pr39976: Fix crash on diagnosing before implicit destructor. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r350907 - [analyzer] pr38838, pr39976: Fix crash on diagnosing before implicit destructor.

Author: dergachev Date: Thu Jan 10 15:44:44 2019 New Revision: 350907 URL: http://llvm.org/viewvc/llvm-project?rev=350907&view=rev Log: [analyzer] pr38838, pr39976: Fix crash on diagnosing before implicit destructor. We need to be able to emit the diagnostic at PreImplicitCall, and the patch impl

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. In D56554#1353513 , @ruiu wrote: > In D56554#1353487 , @krytarowski > wrote: > > > In D56554#1353368 , @ruiu wrote: > > > > > The absence of PT_

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. In D56554#1353487 , @krytarowski wrote: > In D56554#1353368 , @ruiu wrote: > > > The absence of PT_GNU_STACK segment makes stack area executable on systems > > that recognizes PT_GNU_STACK seg

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

mattd added a comment. *Ping* to see if anyone else has any feedback towards this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55039/new/ https://reviews.llvm.org/D55039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/DurationConversionCastCheck.cpp:41 + + if (!isNotInMacro(Result, MatchedCast)) return; + Please run Clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://revi

Re: r350891 - Correct the source range returned from preprocessor callbacks.

../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field 'ExprRange' initializer [-Wmissing-field-initializers] return {false, DT.IncludedUndefinedIds}; ^ On Thu, Jan 10, 2019 at 4:26 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llv

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 181171. tlively marked an inline comment as done. tlively added a comment. - Change names again to reflect latest committed LLVM change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. In D56554#1353368 , @ruiu wrote: > The absence of PT_GNU_STACK segment makes stack area executable on systems > that recognizes PT_GNU_STACK segment. So, I think if `-z execstack` is > specified, we should omit PT_GNU_STACK s

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

NoQ added a comment. Hmm, this fails for me. The substitution fails for some reason: FAIL: Clang :: Analysis/func-mapping-test.cpp (211 of 569) TEST 'Clang :: Analysis/func-mapping-test.cpp' FAILED Script: -- : 'RUN: at line 1'; %clang_extdef

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

alxu added a comment. FYI, according to my comment on D49652 , assuming I checked it correctly, gcc applies the maps in reverse order of command line specification, not sorted order. It seems unlikely that anyone is actually depending on the order though. Repo

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:573-574 if (!File) { Diag(SourceLocation(), diag::err_pp_through_header_not_found) << PPOpts->PCHThroughHeader; return; --

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai created this revision. vsapsai added reviewers: arphaman, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. When a framework with the same name is available at multiple framework search paths, we use the first matching location. If a framework at this location doesn't have al

[PATCH] D55016: Correctly support -shared-libgcc.

saugustine closed this revision. saugustine added a comment. Committed with r350900. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55016/new/ https://reviews.llvm.org/D55016 ___ cfe-commits mailing list cfe-commits@l

r350900 - Properly support -shared-libgcc.

Author: saugustine Date: Thu Jan 10 14:25:58 2019 New Revision: 350900 URL: http://llvm.org/viewvc/llvm-project?rev=350900&view=rev Log: Properly support -shared-libgcc. This revision was revied in D55016. Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp cfe/trunk/test/Driver/lin

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 181151. dankm added a comment. Added unit tests for the prefix remapping. Switched the sorting on the prefix map, so that /sub gets remapped before if both are specified. I intend to do a more invasive change after this review to unify path prefix remapping

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. The absence of PT_GNU_STACK segment makes stack area executable on systems that recognizes PT_GNU_STACK segment. So, I think if `-z execstack` is specified, we should omit PT_GNU_STACK segment rather than adding it, which I think you guys want. If we do that, it seems `-z

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r350891 (clang part) and r350892 (clang-tools-extra part). If @rsmith has concerns, we can fix or revert when raised. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D544

[clang-tools-extra] r350892 - Update clang-tools-extra for r350891 from Clang.

Author: aaronballman Date: Thu Jan 10 13:22:28 2019 New Revision: 350892 URL: http://llvm.org/viewvc/llvm-project?rev=350892&view=rev Log: Update clang-tools-extra for r350891 from Clang. Modified: clang-tools-extra/trunk/test/modularize/ProblemsInconsistent.modularize clang-tools-extra/t

r350891 - Correct the source range returned from preprocessor callbacks.

Author: aaronballman Date: Thu Jan 10 13:22:13 2019 New Revision: 350891 URL: http://llvm.org/viewvc/llvm-project?rev=350891&view=rev Log: Correct the source range returned from preprocessor callbacks. This adjusts the source range passed in to the preprocessor callbacks to only include the cond

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. In D56444#1353003 , @sammccall wrote: > In D56444#1351714 , @JonasToth wrote: > > > @sammccall I (hopefully) fixed the type-issue in my test-cases. They > > nevertheless fail both on me,

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

Romain-Geissler-1A updated this revision to Diff 181140. Romain-Geissler-1A added a comment. Rebased to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54071/new/ https://reviews.llvm.org/D54071 Files: utils/perf-training/perf-helper.py Index: utils/per

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 created this revision. joedaniels29 added reviewers: erik.pilkington, rjmccall. Currently to get a nonlazy class in objective c, you need to define a +load method. Because we do other work when we realize a class, other than just call that load method, it would be ideal to have an

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1353176 , @rjmccall wrote: > In D56318#1353116 , @yaxunl wrote: > > > In D56318#1353106 , @rjmccall > > wrote: > > > > > No, I understand t

r350890 - NFC: Change case of identifiers

Author: steveire Date: Thu Jan 10 12:58:21 2019 New Revision: 350890 URL: http://llvm.org/viewvc/llvm-project?rev=350890&view=rev Log: NFC: Change case of identifiers Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/TextNodeDumpe

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

vmiklos added a comment. @aaron.ballman do you wait for someone else to commit this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D54450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny updated this revision to Diff 181133. mgorny retitled this revision from "[compiler-rt] [test] Support using libtirpc on Linux" to "[compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing". mgorny edited the summary of this revision. mgorny added a reviewer: vitalybuka. mgorny

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. In D53153#1317977 , @rjmccall wrote: > I think `-fvisibility=hidden` isn't good enough because you want to infer > hidden visibility even for external symbol references, and that's just not > how global visibility works. Bu

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang added a comment. In D53541#1282900 , @rnk wrote: > In D53541#1282764 , @mgrang wrote: > > > Updated the patch with the following changes: > > > > 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. F

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}} +- (void) m

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington updated this revision to Diff 181130. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Fix some triples in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56523/new/ https://reviews.llvm.org/D56523 Files: clang/include/clang/

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added inline comments. Comment at: ELF/Driver.cpp:874 Config->ZGlobal = hasZOption(Args, "global"); + Config->ZNognustack = hasZOption(Args, "nognustack"); Config->ZHazardplt = hasZOption(Args, "hazardplt"); I would add `gnustack` vs `nognustac

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

This revision was automatically updated to reflect the committed changes. Closed by commit rL350887: [Sema] Call CheckPlaceholderExpr to resolve typeof or decltype (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

r350887 - [Sema] Call CheckPlaceholderExpr to resolve typeof or decltype

Author: ahatanak Date: Thu Jan 10 12:12:16 2019 New Revision: 350887 URL: http://llvm.org/viewvc/llvm-project?rev=350887&view=rev Log: [Sema] Call CheckPlaceholderExpr to resolve typeof or decltype placeholder expressions while an unevaluated context is still on the expression evaluation context s

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL350885: [HIP] Use nul instead of /dev/null when running on windows (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56225?

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added inline comments. Comment at: ELF/Writer.cpp:1980 + if (!Config->ZNognustack) { +// PT_GNU_STACK is a special section to tell the loader to make the +// pages for the stack non-executable. If you really want an executable section -> segm

r350885 - [HIP] Use nul instead of /dev/null when running on windows

Author: yaxunl Date: Thu Jan 10 12:09:52 2019 New Revision: 350885 URL: http://llvm.org/viewvc/llvm-project?rev=350885&view=rev Log: [HIP] Use nul instead of /dev/null when running on windows When clang is running on windows, /dev/null is not available. Use nul as empty input file instead. Diff

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: docs/ld.lld.1:515 +.Dv PT_GNU_STACK +segment. .It Cm norelro krytarowski wrote: > section? I think 'segment' is actually the correct term here. Repository: rLLD LLVM Linker C

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. Looks good, we don't GNU STACK on NetBSD. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 181125. hwright marked 5 inline comments as done. hwright added a comment. Update documentation line wrapping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:20 + + + // Original - Cast from a double to an integer MyDeveloperDay wrote: > nit: double blank line This is intentional (and consistent with other examples i

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added inline comments. Comment at: docs/ld.lld.1:515 +.Dv PT_GNU_STACK +segment. .It Cm norelro section? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 __

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350882: [sanitizer_common] Define __sanitizer_FILE on NetBSD (authored by mgorny, committed by ). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ h

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski. Herald added subscribers: llvm-commits, arichardson, emaste. Herald added a reviewer: espindola. Add a new '-z nognustack' option that suppresses emitting PT_GNU_STACK segment. This segment is not supported at all on NetBSD

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL350881: [sanitizer_common] Remove support for tirpc/rpc/xdr.h (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D47817?vs=17955

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/integrations.rst:118 +allows to use a custom :program:`clang-tidy` binary. \ No newline at end of file Please add newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/AST/Expr.cpp:1618 assert(getValueKindForType(Ty) == Expr::getValueKindForType(SETy)); -if (!isGLValue()) +if (!isGLValue() && !getSubExpr()->isXValue()) { Ty = Ty->getPointeeType(); What's this a

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1460 + for (const auto &Entry : MacroPrefixMap) +if (Path.startswith(Entry.first)) + return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); Lekensteyn wrote: > joerg wr

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. In D56318#1353116 , @yaxunl wrote: > In D56318#1353106 , @rjmccall wrote: > > > No, I understand that things like the function-call ABI should be different > > from the associated host ABI

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1296790 , @ChristophBerg wrote: > PostgreSQL 11 is now using LLVM to do JITing of SQL expressions. We'd need > this feature to strip the build directory off the .bc bitcode files so the > .deb packages build reproducibly

r350878 - fixup: sphinx warning

Author: nickdesaulniers Date: Thu Jan 10 11:26:35 2019 New Revision: 350878 URL: http://llvm.org/viewvc/llvm-project?rev=350878&view=rev Log: fixup: sphinx warning Fixes the sphinx warning: tools/clang/docs/DiagnosticsReference.rst:7889: WARNING: Title underline too short. That I just introduced

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181114. Anastasia added a comment. Removed FIXME that this patch fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: include/clang/Sema/Sema.h lib/AST/Expr.cpp lib/CodeGen/CGCall.cpp lib/

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

This revision was automatically updated to reflect the committed changes. Closed by commit rL350877: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181112. Anastasia added a comment. Modified conversion sequence to perform address space conversion after temporary materialization conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: inc

r350877 - [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

Author: nickdesaulniers Date: Thu Jan 10 11:12:39 2019 New Revision: 350877 URL: http://llvm.org/viewvc/llvm-project?rev=350877&view=rev Log: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides Summary: https://bugs.llvm.org/show_bug.cgi?id=40251 https://github.com/ClangBuiltLinux/linu

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

sunfish added a comment. With https://reviews.llvm.org/D48471 and related work, it's not less urgent to do this. And since there were objections to having target-specific warnings anyway, let's close this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43540/new/

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350874: Fix false positive unsequenced access and modification warning in array… (authored by Rakete, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5076

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

nickdesaulniers updated this revision to Diff 181108. nickdesaulniers added a comment. - add gcc compat comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56522/new/ https://reviews.llvm.org/D56522 Files: docs/DiagnosticsReference.rst include/clang/Basic/

[PATCH] D56523: Improve a -Wunguarded-availability note

dexonsmith added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}} +- (void) method

r350874 - Fix false positive unsequenced access and modification warning in array subscript expression.

Author: rakete Date: Thu Jan 10 11:03:33 2019 New Revision: 350874 URL: http://llvm.org/viewvc/llvm-project?rev=350874&view=rev Log: Fix false positive unsequenced access and modification warning in array subscript expression. Summary: In the [expr.sub] p1, we can read that for a given E1[E2

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang updated this revision to Diff 181106. mgrang retitled this revision from "[COFF, ARM64] Support SEH for ARM64 Windows" to "[COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541 Files: lib

[PATCH] D41941: [WebAssembly] Change int_fast16_t to 32-bit

sunfish added a comment. As @nw points out, clang's lib/Headers/stdint.h doesn't support this yet. Unless anyone feels strongly, I now propose we close this and just leave int_fast16_t/uint_fast16_t as-is. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41941/new/

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1353106 , @rjmccall wrote: > No, I understand that things like the function-call ABI should be different > from the associated host ABI, but things like the size of `long` and the > bit-field layout algorithm presumably

[PATCH] D56552: [clang-tidy] update FunctionSizeCheck for D56444

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56552/new/ https://reviews.llvm.org/D56552 _

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. No, I understand that things like the function-call ABI should be different from the associated host ABI, but things like the size of `long` and the bit-field layout algorithm presumably shouldn't be, and that's the sort of thing that's configured by `TargetInfo`. CH

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/n

  1   2   >