AlexeySachkov added a comment.
I'm running OpenCL on an x886 and everything is fine, but there are a lot of
build bots which build different targets on different architectures. Since
there are no `target` option specified, `c-index-test` uses native target.
I just realized: may be it is better
void added a comment.
Ping? :-)
Repository:
rC Clang
https://reviews.llvm.org/D54355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson updated this revision to Diff 174332.
tejohnson added a comment.
Update a couple tests due to new default of splitting off and new flag.
Repository:
rC Clang
https://reviews.llvm.org/D53891
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/cl
lonico added a comment.
> The second way to handle this use case is possible on a different level: one
> can run clang-tidy over the whole project with `-header-filter=.*` and then
> filter the results and use a specialized tool to display them, e.g.
> https://github.com/Ericsson/codechecker.
tejohnson updated this revision to Diff 174329.
tejohnson added a comment.
- As discussed off-patch, will use a new, separate option to control this
splitting, here I am using -f[no]split-lto-unit.
- Switch the default of splitting lto units to off by default, unless
compiled with CFI or -fwhol
Hi Galina,
a) "llvm-mips-linux" buildbot is active now. There are some failed
tests but I'm working to make the buildbot "green".
b) For now "clang-cmake-mips" and "clang-cmake-mipsel" can be removed.
Later we probably restore these buildbots.
On Sat, Nov 3, 2018 at 11:26 AM Simon Atanasyan wro
dylanmckay added a comment.
I'd like feedback on the new AVR-specific warnings, and the new warning group.
I have not added a warning or error to clang before, but this seems consistent
with how the other targets implement it.
Repository:
rC Clang
https://reviews.llvm.org/D54334
Author: phosek
Date: Thu Nov 15 20:50:12 2018
New Revision: 347026
URL: http://llvm.org/viewvc/llvm-project?rev=347026&view=rev
Log:
[CMake] Support cross-compiling with Fuchsia toolchain build
When second stage is being cross-compiled for a different platform
we need to build enough of first sta
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347026: [CMake] Support cross-compiling with Fuchsia
toolchain build (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5446
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347025: [CMake] Support cross-compiling with multi-stage
builds (authored by phosek, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D54461?vs=1
Author: phosek
Date: Thu Nov 15 20:46:48 2018
New Revision: 347025
URL: http://llvm.org/viewvc/llvm-project?rev=347025&view=rev
Log:
[CMake] Support cross-compiling with multi-stage builds
When using multi-stage builds, we would like support cross-compilation.
Example is 2-stage build when the fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347021: [CMake] Use the correct spelling for armv7 in
Fuchsia's toolchain (authored by phosek, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D
Author: phosek
Date: Thu Nov 15 20:09:47 2018
New Revision: 347021
URL: http://llvm.org/viewvc/llvm-project?rev=347021&view=rev
Log:
[CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
We need to explicitly specify the architecture version.
Differential Revision: https://reviews.ll
Author: wuzish
Date: Thu Nov 15 19:00:00 2018
New Revision: 347019
URL: http://llvm.org/viewvc/llvm-project?rev=347019&view=rev
Log:
[Clang][Sema]Choose a better candidate in overload function call if there is a
compatible vector conversion instead of ambiguous call error
There are 2 function va
This revision was automatically updated to reflect the committed changes.
wuzish marked an inline comment as done.
Closed by commit rC347019: [Clang][Sema]Choose a better candidate in overload
function call if there is a… (authored by wuzish, committed by ).
Changed prior to commit:
https://rev
Szelethus added a comment.
In https://reviews.llvm.org/D54557#1300581, @NoQ wrote:
> In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote:
>
> > Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm
> > curious how this patch behaves on that project. I'll take a look.
>
kcc added a comment.
I think you can safely abandon this change in favor of
https://reviews.llvm.org/D54604 -- please join the review there.
Repository:
rC Clang
https://reviews.llvm.org/D54473
___
cfe-commits mailing list
cfe-commits@lists.llvm
NoQ added a comment.
In https://reviews.llvm.org/D54557#1299736, @xazax.hun wrote:
> It would be great to have a way to extend the list of (possibly non-stl)
> types to check. But I do understand that the analyzer does not have a great
> way to set such configuration options right now.
Do you
NoQ added a comment.
In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote:
> I think we should either remove the non-default functionality (which wouldn't
> be ideal), or emphasise somewhere (open projects?) that there is still work
> to be done, but leaving it to be forgotten and essen
Author: vsapsai
Date: Thu Nov 15 17:18:04 2018
New Revision: 347012
URL: http://llvm.org/viewvc/llvm-project?rev=347012&view=rev
Log:
[VFS] Implement `RedirectingFileSystem::getRealPath`.
It fixes the case when Objective-C framework is added as a subframework
through a symlink. When parent framew
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347009: [VFS] Implement
`RedirectingFileSystem::getRealPath`. (authored by vsapsai, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
https://reviews.llvm.org/D54245?vs=17309
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347006: [analyzer] ConversionChecker: handle floating point
(authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52730?vs=172922&id=174306#toc
Repository:
rC Cla
Author: szelethus
Date: Thu Nov 15 17:00:55 2018
New Revision: 347006
URL: http://llvm.org/viewvc/llvm-project?rev=347006&view=rev
Log:
[analyzer] ConversionChecker: handle floating point
Extend the alpha.core.Conversion checker to handle implicit converions
where a too large integer value is con
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347005: [WebAssembly] Change type of wake count to unsigned
int (authored by aheejin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54572?vs=174169&id=174302#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347005: [WebAssembly] Change type of wake count to unsigned
int (authored by aheejin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54572
Files
Author: aheejin
Date: Thu Nov 15 16:48:58 2018
New Revision: 347005
URL: http://llvm.org/viewvc/llvm-project?rev=347005&view=rev
Log:
[WebAssembly] Change type of wake count to unsigned int
Summary:
We discussed this at the Nov 12th CG meeting, and decided to use the
unsigned semantics for the wa
kristina added a comment.
Phab lost this inline command for some reason, but please leave some comment
regarding why that part in `Driver.cpp` does what it does (summarize the
conclusion of the discussion in https://reviews.llvm.org/D54378).
Comment at: lib/Driver/Driver.cpp:
NoQ added a comment.
In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote:
> Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm
> curious how this patch behaves on that project. I'll take a look.
Whoops, sry, i accidentally had a look because i misread your message
jfb added a comment.
In https://reviews.llvm.org/D54604#1300544, @t.p.northover wrote:
> > This isn't meant to change the semantics of C and C++.
>
> As I said in the cfe-dev thread, that's exactly what it does. Specifically I
> think this is essentially defining a new dialect of C++, which I ha
kristina added inline comments.
Comment at: lib/Driver/Driver.cpp:392
+static void replaceString(std::string &S,
+ const char *Other,
Same as previous comment regarding this type of function.
Repository:
rC Clang
https://reviews.ll
Szelethus added a comment.
Herald added a subscriber: gamesh411.
In https://reviews.llvm.org/D52730#1289989, @donat.nagy wrote:
> Could someone with commit rights commit this patch (if it is acceptable)? I
> don't have commit rights myself.
I'll do the honors. Thanks!
Repository:
rC Clang
kristina added a comment.
Added first batch of comments regarding the patch. Some style, some
semantics-related.
Comment at: lib/Basic/Targets/OSTargets.h:283
+Builder.defineMacro("__GLIBC__");
+Builder.defineMacro("__ELF__");
+if (Opts.POSIXThreads)
--
kcc added reviewers: glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich.
kcc added a comment.
exciting. adding more folks FYI and to help review
Repository:
rC Clang
https://reviews.llvm.org/D54604
___
cfe-commits mailing list
cfe-commits@lists.l
t.p.northover added a comment.
> This isn't meant to change the semantics of C and C++.
As I said in the cfe-dev thread, that's exactly what it does. Specifically I
think this is essentially defining a new dialect of C++, which I have massive
concerns about. Additionally, as much as we might cl
kristina added reviewers: aaron.ballman, erik.pilkington, rsmith.
kristina added a comment.
Alright, once this is fully reviewed, if accepted, I can land the LLVMSupport
change and add your new target and close the stack. In the meantime, adding
some more reviewers who have more experience with
rjmccall added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1749-1750
+On 64-bit ARM targets, this argument causes the function to obey the vector
+procedural call standard (VPCS) rules as described in the Vector ABI for
+AArch64. In particular, the register calle
Author: stephanemoore
Date: Thu Nov 15 14:38:39 2018
New Revision: 347000
URL: http://llvm.org/viewvc/llvm-project?rev=347000&view=rev
Log:
[clang-tidy] Fix reference to -[NSError init] in AvoidNSErrorInitCheck.h
Modified:
clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h
Modif
jfb created this revision.
jfb added reviewers: kcc, rjmccall, rsmith.
Herald added subscribers: dexonsmith, jkorous, JDevlieghere.
Add an option to initialize automatic variables with either a pattern or with
zeroes. The default is still that automatic variables are uninitialized. Also
add attrib
thakis added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D54426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE346998: Remove myself as owner of clang-query. (authored
by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54453?vs=173776&id=174282#toc
Repository:
rCTE Clang Tools Extra
Author: pcc
Date: Thu Nov 15 14:02:10 2018
New Revision: 346998
URL: http://llvm.org/viewvc/llvm-project?rev=346998&view=rev
Log:
Remove myself as owner of clang-query.
I haven't been involved with the project for years, so it's probably
best for someone else to be the code owner.
Differential R
calixte created this revision.
calixte added a reviewer: marco-c.
Herald added a subscriber: cfe-commits.
the previous patch (https://reviews.llvm.org/rC346642) has been reverted
because of test failure under windows.
So this patch fix the test cfe/trunk/test/CodeGen/code-coverage-filter.c.
Rep
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346997: [CMake] Explicitly list Linux targets for Fuchsia
toolchain (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54598?vs=174273&id=174280#toc
Repository:
r
Author: phosek
Date: Thu Nov 15 13:55:59 2018
New Revision: 346997
URL: http://llvm.org/viewvc/llvm-project?rev=346997&view=rev
Log:
[CMake] Explicitly list Linux targets for Fuchsia toolchain
Not all Linux targets use the ${arch}-linux-gnu spelling, so instead
specify the list of Linux explicitl
leonardchan added a comment.
> Good case to bring up. For addition, I think we just need to add an extra
> condition that checks for unsigned padding in the result. Added this test
> also.
Actually this was wrong. Updated and instead dictate how the appropriate number
of bits to `getCommonSema
dblaikie added a subscriber: scott.linder.
dblaikie added a comment.
Thanks!
So I can see where/how this fails now - the LLVM backend seems to require that
if any file has embedded source, they all do. Would you be able to/would you
mind adding a debug info verifier check for this? That'd help
leonardchan updated this revision to Diff 174279.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Type.h
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ASTContext.cpp
clang/lib/Basic/FixedPoint.cpp
clang
smeenai planned changes to this revision.
smeenai added a comment.
In https://reviews.llvm.org/D52674#1298115, @rjmccall wrote:
> In https://reviews.llvm.org/D52674#1297893, @smeenai wrote:
>
> > In https://reviews.llvm.org/D52674#1297879, @rjmccall wrote:
> >
> > > I'm not worried about the mang
Author: erichkeane
Date: Thu Nov 15 13:35:35 2018
New Revision: 346996
URL: http://llvm.org/viewvc/llvm-project?rev=346996&view=rev
Log:
Fix parens warning in assert in ASTMatchFinder
Change-Id: Ie34f9c6846b98fba87449e73299519fc2346bac1
Modified:
cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jkorous.
LGTM
https://reviews.llvm.org/D54245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
Not all Linux targets use the ${arch}-linux-gnu spelling, so
specify the list of Linux explicitly.
Repository:
rC Clang
https://reviews.llvm.org/D54598
F
rjmccall added inline comments.
Comment at: docs/ClangCommandLineReference.rst:797
+
+Generate a section .LLVM.command.line containing the clang driver command line.
+
scott.linder wrote:
> rjmccall wrote:
> > 1. Is this section always called `.LLVM.command.line`
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D53764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
kkwli0 added a comment.
Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp
needs to update too.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3707
/// UB >= Var
- bool TestIsLessOp = false;
+ /// This will has no value when the condition is !=
+ ll
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:951
+}
} else {
+// We're removing the underlying mutex. Warn on double unlocking.
aaronpuchert wrote:
> aaronpuchert wrote:
> > delesley wrote:
> > > aaronpuchert wr
devnexen created this revision.
devnexen added reviewers: george.karpenkov, dergachev.a.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- explicit_bzero has limited scope/usage only for security/crypto purposes but
is non-optimisable version of m
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Agreed - looks like this went in untested in r175813 & has never been used.
https://reviews.llvm.org/D54576
___
cfe-commits mailing list
cfe-
scott.linder closed this revision.
scott.linder added a comment.
r346884
https://reviews.llvm.org/D51223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.
r346884
https://reviews.llvm.org/D51223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
lebedev.ri created this revision.
lebedev.ri added reviewers: ABataev, craig.topper, vsk, rsmith, rnk,
Sanitizers, erichkeane, filcab, rjmccall.
lebedev.ri added a project: Sanitizers.
lebedev.ri added a dependency: D54588: [llvm][IRBuilder] Introspection for
CreateAlignmentAssumption*() function
shafik added a comment.
Did you ever resolve the issue of libcxx tests not running
https://reviews.llvm.org/D53697
Repository:
rC Clang
https://reviews.llvm.org/D53702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
shafik added inline comments.
Comment at: include/clang/AST/Expr.h:1407
public:
- enum CharacterKind {
-Ascii,
-Wide,
-UTF8,
-UTF16,
-UTF32
- };
+ enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 };
riccibruno wrote:
> shafik wrote:
russellmcc added a comment.
bump! Thanks for your consideration.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
leonardchan updated this revision to Diff 174235.
leonardchan marked 13 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Type.h
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ASTConte
leonardchan added a comment.
In https://reviews.llvm.org/D53738#1299557, @ebevhan wrote:
> I'd be interested in seeing tests for two saturating unsigned _Fract with and
> without padding.
>
> If the padding case emits a uadd_sat, that seems wrong; uadd_sat doesn't
> saturate on the padding bit,
jkorous planned changes to this revision.
jkorous added a comment.
In https://reviews.llvm.org/D54428#1297147, @sammccall wrote:
> A question about the high-level build target setup (I don't know much about
> XPC services/frameworks, bear with me...):
>
> This is set up so that the clangd binary
Szelethus added a comment.
Herald added a subscriber: gamesh411.
In https://reviews.llvm.org/D54438#1297602, @NoQ wrote:
> Hmm, makes sense. Maybe `static bool BlahBlahChecker::isApplicable(const
> LangOpts &LO)` or something like that.
>
> Btw, maybe instead of default constructor and `->setup(
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346969: [AST] Store the string data in StringLiteral in a
trailing array of chars (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: brunoricci
Date: Thu Nov 15 09:31:16 2018
New Revision: 346969
URL: http://llvm.org/viewvc/llvm-project?rev=346969&view=rev
Log:
[AST] Store the string data in StringLiteral in a trailing array of chars
Use the newly available space in the bit-fields of Stmt and store the
string data in a
astrelni updated this revision to Diff 174226.
astrelni added a comment.
Fix incorrect uploaded diff.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
clang-tidy/abseil/Up
astrelni updated this revision to Diff 174218.
astrelni marked an inline comment as done.
astrelni added a comment.
Fix to use `hasAnyName` everywhere
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDu
scott.linder added a comment.
Looking a bit further, it seems some other object-file formats have conventions
for naming (e.g. Mach-O sections are `_snake_case`) and so `.LLVM.command.line`
may not end up being what we want universally.
Additionally it seems things like `.ident` are not support
Author: brunoricci
Date: Thu Nov 15 08:42:14 2018
New Revision: 346967
URL: http://llvm.org/viewvc/llvm-project?rev=346967&view=rev
Log:
[AST][NFC] Various NFCs in StringLiteral
Factored out of D54166
([AST] Store the string data in StringLiteral in a trailing array of chars):
* For-range loops
jhibbits added a comment.
Hi Vit,
The register spilling bug is being addressed in https://reviews.llvm.org/D54409
now.
Repository:
rC Clang
https://reviews.llvm.org/D49754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ExpectedTypes.cpp:12
+
+static llvm::Optional toEquivClass(ASTContext &Ctx, QualType T) {
+ if (T.isNull() || T->isDependentType())
sammccall wrote:
> returni
ilya-biryukov updated this revision to Diff 174217.
ilya-biryukov marked 10 inline comments as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52273
Files:
clangd/CMakeLists.txt
clangd/ExpectedTypes.cpp
clangd/Expecte
Szelethus added a comment.
Alpha checkers, at least to developers, are clearly stating "Please finish
me!", but a non-alpha, enabled-by-default checker with a flag that you'd never
know about unless you looked at the source code (at least up until I fix these)
sounds like it'll be forgotten lik
riccibruno added a comment.
In https://reviews.llvm.org/D54547#1299883, @erichkeane wrote:
> Added to the release notes. Also, an email was sent out to cfe-dev.
>
> @riccibruno and I are separately looking into IdentifierInfo, because it
> seems that there are some pretty massive optimization o
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
How about `std::list::splice`?
Repository:
rC Clang
https://reviews.llvm.org/D54563
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Awesome! :D
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386
+ }
+ // Provide the caller with the classification of the object
+ // we've obtained her
Szelethus added a comment.
I think we should either remove the non-default functionality (which wouldn't
be ideal), or emphasise somewhere (open projects?) that there is still work to
be done, but leaving it to be forgotten and essentially making it an extra
maintenance work would be, in my opt
kadircet updated this revision to Diff 174215.
kadircet marked 13 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
Files:
clangd/CMakeLists.txt
clangd/index/Background.cpp
clangd/index/Background.h
Szelethus accepted this revision.
Szelethus added a comment.
LGTM, both the concept and the patch! I have read your followup patches up to
part 4, I'll leave some thoughts there.
Repository:
rC Clang
https://reviews.llvm.org/D54556
___
cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346961: [clang-tidy] Update checks to play nicely with
limited traversal scope added in… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Author: sammccall
Date: Thu Nov 15 07:06:11 2018
New Revision: 346961
URL: http://llvm.org/viewvc/llvm-project?rev=346961&view=rev
Log:
[clang-tidy] Update checks to play nicely with limited traversal scope added in
r346847
Summary: (See D54204 for original review)
Reviewers: hokein
Subscriber
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:567
replaceCompoundReturnWithCondition(Result, Compound, true);
- else if (const auto TU = Result.N
HsiangKai added a comment.
In https://reviews.llvm.org/D45045#1299507, @tyb0807 wrote:
> Hello all,
>
> This commit has been reverted by https://reviews.llvm.org/rC345026. It was
> reported that this broke the Chromium build (again). Have you had a look to
> fix this, @HsiangKai?
I have fixed
scott.linder added inline comments.
Comment at: docs/ClangCommandLineReference.rst:797
+
+Generate a section .LLVM.command.line containing the clang driver command line.
+
rjmccall wrote:
> 1. Is this section always called `.LLVM.command.line`, or does it differ
Author: brunoricci
Date: Thu Nov 15 06:30:18 2018
New Revision: 346957
URL: http://llvm.org/viewvc/llvm-project?rev=346957&view=rev
Log:
[AST][NFC] Re-add comment in BinaryOperator which was removed by r346954
Modified:
cfe/trunk/include/clang/AST/Stmt.h
Modified: cfe/trunk/include/clang/AS
sammccall updated this revision to Diff 174204.
sammccall added a comment.
Remove clang-tidy changes, add FIXME comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
Files:
clangd/CMakeLists.txt
clangd/ClangdUnit.cpp
clangd/XRefs.cpp
unittests/clangd/ClangdUnitT
sammccall added a comment.
Moved the clang-tidy changes to https://reviews.llvm.org/D54579.
Sorry for mixing everything up!
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:518
void SimplifyBooleanExprCheck::registerMatchers(MatchFinder *Finder) {
- Finder->add
sammccall updated this revision to Diff 174203.
sammccall added a comment.
Address comments from the last round of review in
https://reviews.llvm.org/D54204.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54579
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
clang-tidy/mo
malaperle updated this revision to Diff 174202.
malaperle added a comment.
Address comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54553
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
(See https://reviews.llvm.org/D54204 for original review)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54579
Files:
clang-tidy/misc/UnusedParametersCheck.c
Author: hokein
Date: Thu Nov 15 06:15:19 2018
New Revision: 346955
URL: http://llvm.org/viewvc/llvm-project?rev=346955&view=rev
Log:
[clangd] global-symbol-builder => clangd-indexer
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp
Modified: clang-tools-extra/trunk/clangd/inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346954: [AST] Pack BinaryOperator (authored by brunoricci,
committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54526
Files:
include/clang/AST/Expr.h
include/clang/AST/Stmt.h
Index: inc
Author: brunoricci
Date: Thu Nov 15 06:12:51 2018
New Revision: 346954
URL: http://llvm.org/viewvc/llvm-project?rev=346954&view=rev
Log:
[AST] Pack BinaryOperator
Use the newly available space in the bit-fields of Stmt.
This saves 8 bytes per BinaryOperator.
Differential Revision: https://review
Author: brunoricci
Date: Thu Nov 15 05:56:22 2018
New Revision: 346953
URL: http://llvm.org/viewvc/llvm-project?rev=346953&view=rev
Log:
[AST] Pack MemberExpr
Use the newly available space in the bit-fields of Stmt
to store some data from MemberExpr. This saves
one pointer per MemberExpr.
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346953: [AST] Pack MemberExpr (authored by brunoricci,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54525?vs=174026&id=174196#toc
Repository:
rC Clang
https://reviews.llvm.org/
1 - 100 of 143 matches
Mail list logo
