[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

lebedev.ri added a comment. Looks about right, but needs tests. Repository: rC Clang https://reviews.llvm.org/D54565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

tyb0807 reopened this revision. tyb0807 added a comment. Hello all, This commit has been reverted by https://reviews.llvm.org/rC345026. It was reported that this broke the Chromium build (again). Have you had a look to fix this, @HsiangKai? Repository: rC Clang https://reviews.llvm.org/D45

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete added inline comments. Comment at: include/clang/Parse/Parser.h:2119 DeclSpecContext DSC = DeclSpecContext::DSC_normal, - LateParsedAttrList *LateAttrs = nullptr); + LateParsedAttrList *LateAttrs = nullptr) { +return ParseDeclarationSpecifiers(DS,

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete added inline comments. Comment at: lib/Sema/Sema.cpp:2006-2019 +bool Sema::isDeclaratorFunctionLike(const Declarator &D) { + assert(D.getCXXScopeSpec().isSet() && + "can only be called for qualified names"); + LookupResult LR(*this, D.getIdentifier(), D.getBe

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 174158. Rakete marked 11 inline comments as done. Rakete added a comment. Addressed review comments :) Repository: rC Clang https://reviews.llvm.org/D53847 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Parser.h in

[PATCH] D53702: [ASTImporter] Set redecl chain of functions before any other import

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Hi Gabor, The change looks fine. Thanks! Repository: rC Clang https://reviews.llvm.org/D53702 ___

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

Quuxplusone updated this revision to Diff 174152. Quuxplusone added a comment. Third time's the charm! Repository: rC Clang https://reviews.llvm.org/D54565 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td Index: include/clang/Basic/DiagnosticSem

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

Quuxplusone updated this revision to Diff 174150. Quuxplusone added a comment. Fix naming. (Uploaded an earlier diff by accident.) Repository: rC Clang https://reviews.llvm.org/D54565 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td Index: inclu

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

Quuxplusone created this revision. Quuxplusone added a reviewer: rsmith. Herald added a subscriber: cfe-commits. Since I am interested in diagnosing this specific C++17ism (but not necessarily other C++17isms) in our codebase going forward. I //think// I got the naming convention right! Personall

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Sema/altivec-generic-overload.c:73 + + __v16sc *gv1_p = convert1(gv1); + __v16uc *gv2_p = convert1(gv2); --

r346929 - NFC cleanup: Prefer make_unique over reset(new T())

Author: dblaikie Date: Wed Nov 14 19:04:23 2018 New Revision: 346929 URL: http://llvm.org/viewvc/llvm-project?rev=346929&view=rev Log: NFC cleanup: Prefer make_unique over reset(new T()) Modified: cfe/trunk/lib/Parse/ParsePragma.cpp Modified: cfe/trunk/lib/Parse/ParsePragma.cpp URL: http://

r346926 - Stmt bits: Make ExprBits relative to StmtBits

Author: dblaikie Date: Wed Nov 14 19:04:18 2018 New Revision: 346926 URL: http://llvm.org/viewvc/llvm-project?rev=346926&view=rev Log: Stmt bits: Make ExprBits relative to StmtBits Seems like it makes it a bit easier to read/validate/update in the future. Modified: cfe/trunk/include/clang/AS

r346927 - Rewrite-imports on crash: Simplify handling

Author: dblaikie Date: Wed Nov 14 19:04:19 2018 New Revision: 346927 URL: http://llvm.org/viewvc/llvm-project?rev=346927&view=rev Log: Rewrite-imports on crash: Simplify handling -frewrite-imports already implies -frewrite-includes (it piggy-backs on/extends the implementation) so there's no need

r346928 - Fix combining pragma __debug dump & parser_crash with -E

Author: dblaikie Date: Wed Nov 14 19:04:21 2018 New Revision: 346928 URL: http://llvm.org/viewvc/llvm-project?rev=346928&view=rev Log: Fix combining pragma __debug dump & parser_crash with -E Previously these would be transformed into annotation tokens and the preprocessor would then assume they

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, baloghadamsoftware. This covers methods that //may// reset the state depending on the value

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. So, like, with locals it should be possible to easily and intuitively suppress the false positive, even if there is one, by simply using an extra variable, and additionally there's the `[[clang::reinitializes]]` attribute added by @xazax.hun that will help people suppress t

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, baloghadamsoftware. The warning piece traditionally describes the bug itself, i.e., "//The b

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

arphaman added a comment. I don't think we should be using `textDocument/definition` here, and I agree with Sam that a new method would be better. We don't actually need the semantic guarantees/constrains imposed by LSP's description of `textDocument/definition`, as we want to find any declara

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, baloghadamsoftware. This patch implements the post important part of the plan proposed in h

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. F7549230: clang-crash-x86.tar Just attached a new test case (clang-crash-x86.tar) which works even if the compiler is compiled with assertion on. JIT now generates x86-64 code instead of BPF code. The error message looks like:

[PATCH] D54556: [analyzer] MoveChecker Pt.1: Give MisusedMovedObject checker a more consistent name.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, baloghadamsoftware, mgorny. NoQ edited the summary of this revision. NoQ added a dependency:

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

riccibruno added a comment. In https://reviews.llvm.org/D54166#1299230, @rjmccall wrote: > In https://reviews.llvm.org/D54166#1299149, @riccibruno wrote: > > > In https://reviews.llvm.org/D54166#1298889, @rjmccall wrote: > > > > > IIRC, abbreviations just silently don't take effect if the record

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

rjmccall added a comment. Oh, I see, sorry. Please rename these functions to make their purpose clear. Also, you could reasonably do this substitution on all targets. Repository: rC Clang https://reviews.llvm.org/D54539 ___ cfe-commits mailing

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D54166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

rjmccall added a comment. In https://reviews.llvm.org/D54166#1299149, @riccibruno wrote: > In https://reviews.llvm.org/D54166#1298889, @rjmccall wrote: > > > IIRC, abbreviations just silently don't take effect if the record doesn't > > conform; so things will appear to work, but the size on disk

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + 1. Is this section always called `.LLVM.command.line`, or does it differ by target object-file

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. You compiled with the assertion on, which triggered the issue. I should have thought about this. Sorry. For error, clang-test: /usr/local/google/home/blaikie/dev/llvm/src/lib/ExecutionEngine/MCJIT/MCJIT.cpp:204: virtual void llvm::MCJIT::generateCodeForModule(l

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14946 + // as invalid as well. + if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) { +if (RD->isInvalidDecl()) { rsmith wrote: > You'

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe updated this revision to Diff 174118. jgorbe added a comment. Fixed some issues pointed out in review comments: - call to getBaseElementType before checking type validity. - when the type is incomplete, mark not only the lambda closure type as invalid but also the field Also, added a cou

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

This revision was automatically updated to reflect the committed changes. jfb marked an inline comment as done. Closed by commit rL346915: CGDecl::emitStoresForConstant fix synthesized constant's name (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r346915 - CGDecl::emitStoresForConstant fix synthesized constant's name

Author: jfb Date: Wed Nov 14 16:19:18 2018 New Revision: 346915 URL: http://llvm.org/viewvc/llvm-project?rev=346915&view=rev Log: CGDecl::emitStoresForConstant fix synthesized constant's name Summary: The name of the synthesized constants for constant initialization was using mangling for static

[PATCH] D54553: [clangd] Fix crash hovering on non-decltype trailing return

malaperle updated this revision to Diff 174117. malaperle added a comment. Fix comment in test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54553 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp =

[PATCH] D54553: [clangd] Fix crash hovering on non-decltype trailing return

malaperle created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. More specifically, hovering on "auto" in auto main() -> int { return 0; } Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://re

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

rsmith added a comment. Thanks! Comment at: clang/lib/Sema/SemaExpr.cpp:14946 + // as invalid as well. + if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) { +if (RD->isInvalidDecl()) { You'll need to use `FieldType->getBaseElementTypeUnsafe()

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe created this revision. jgorbe added a reviewer: rsmith. This causes the compiler to crash when trying to compute a layout for the lambda closure type (see included test). Repository: rC Clang https://reviews.llvm.org/D54550 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/lam

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

riccibruno marked 2 inline comments as done. riccibruno added a comment. In https://reviews.llvm.org/D54166#1298889, @rjmccall wrote: > IIRC, abbreviations just silently don't take effect if the record doesn't > conform; so things will appear to work, but the size on disk will be bigger. I loo

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF added a comment. In https://reviews.llvm.org/D40218#1298943, @Romain-Geissler-1A wrote: > Is there any news on this code review ? Is it ready to land ? I think so, but there were some changes regarding incomplete types since Richard last looked at it. I wanted him to sign off on the new

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 174109. EricWF added a comment. Merge with upstream. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp t

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added a comment. I received commit access yesterday so I believe I should be able to land this myself (after I get myself set up and land a test commit). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 ___ cfe-co

[PATCH] D54499: [codeview] Make "clang -g" emit codeview by default when targetting MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rC346907: [codeview] Make "clang -g" emit codeview by default when targetting MSVC (authored by rnk, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

r346907 - [codeview] Make "clang -g" emit codeview by default when targetting MSVC

Author: rnk Date: Wed Nov 14 14:59:27 2018 New Revision: 346907 URL: http://llvm.org/viewvc/llvm-project?rev=346907&view=rev Log: [codeview] Make "clang -g" emit codeview by default when targetting MSVC Summary: If you're using the Microsoft ABI, chances are that you want PDBs and codeview debug

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. Thanks for this - though it looks like the test program hits an assertion failure (for me at least - before it gets to the interesting point. clang-test: /usr/local/google/home/blaikie/dev/llvm/src/lib/ExecutionEngine/MCJIT/MCJIT.cpp:204: virtual void llvm::MCJIT::gen

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 174104. scott.linder retitled this revision from "Implement -frecord-gcc-switches" to "Implement -frecord-command-line (-frecord-gcc-switches)". scott.linder added a comment. Change canonical option name to -frecord-command-line and add an alias from -f

[PATCH] D54547: PTH-- Remove feature entirely-

chandlerc added a comment. Should likely add release notes about this. Also might be worth sending a note to cfe-dev as a heads up and give folks some time to say "wait wait". Repository: rC Clang https://reviews.llvm.org/D54547 ___ cfe-commits

[PATCH] D54547: PTH-- Remove feature entirely-

erichkeane added inline comments. Comment at: include/clang/Driver/Options.td:261 MetaVarName<"">; -def ccc_pch_is_pch : Flag<["-"], "ccc-pch-is-pch">, InternalDriverOpt, - HelpText<"Use lazy PCH for precompiled headers">; The default behavior is exactly to u

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

ahatanak added a comment. In https://reviews.llvm.org/D54539#1298949, @rjmccall wrote: > This should not be changing the actual `@`-encoding value. If we want to use > the `@`-encoding in the symbol name, we can change it when naming the symbol, > provided that \1 is not legal in the `@`encodi

[PATCH] D54525: [AST] Pack MemberExpr

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:2802 - friend class ASTReader; - friend class ASTStmtWriter; }; Having this at the bottom is so painful for the reader, and people seems to put them at the top of the class usually. But yes

[PATCH] D54526: [AST] Pack BinaryOperator

riccibruno marked an inline comment as done. riccibruno added a comment. Added some inline comments. Comment at: include/clang/AST/Expr.h:3220 - SourceLocation getExprLoc() const LLVM_READONLY { return OpLoc; } - SourceLocation getOperatorLoc() const { return OpLoc; } - vo

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

a_sidorin added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Hi Balasz, As I guess, the next step is to convert all `Import`calls to `Import_New` and then rename `Import_New` into `Import`. If so, why aren't we able to just change the behaviour of `Import` m

[PATCH] D52440: Emit lifetime markers for temporary function parameter aggregates

rjmccall added a comment. In https://reviews.llvm.org/D52440#1298816, @itessier wrote: > > This is problematic because we're not necessarily in a scope that usefully > > limits the duration of cleanups — we don't push full-expression scopes when > > emitting an arbitrary statement. Probably we

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

jfb marked an inline comment as done. jfb added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:990-998 + std::string Name = ("__const." + FunctionName(D.getParentFunctionOrMethod()) + + "." + D.getName()) + .str(); + llvm::Glob

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

jfb updated this revision to Diff 174090. jfb added a comment. - Inline the name creating, save a heap allocation. Repository: rC Clang https://reviews.llvm.org/D54055 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/decl.c test/CodeGen/dump-struct-builtin.c test/CodeGenCXX/amdgcn-string-l

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

rjmccall added a comment. This should not be changing the actual `@`-encoding value. If we want to use the `@`-encoding in the symbol name, we can change it when naming the symbol, provided that \1 is not legal in the `@`encoding. Repository: rC Clang https://reviews.llvm.org/D54539 ___

[PATCH] D40218: [Clang] Add __builtin_launder

Romain-Geissler-1A added a comment. Hi, Is there any news on this code review ? Is it ready to land ? Cheers, Romain https://reviews.llvm.org/D40218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r346892 - [c++20] Implement P0482R6: enable -fchar8_t by default in C++20 mode.

Author: rsmith Date: Wed Nov 14 13:04:34 2018 New Revision: 346892 URL: http://llvm.org/viewvc/llvm-project?rev=346892&view=rev Log: [c++20] Implement P0482R6: enable -fchar8_t by default in C++20 mode. This unfortunately results in a substantial breaking change when switching to C++20, but it's

[PATCH] D54524: [AST] Pack UnaryOperator

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rC Clang https://reviews.llvm.org/D54524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D54525: [AST] Pack MemberExpr

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Comment at: include/clang/AST/Expr.h:2799-2802 - - friend TrailingObjects; - friend class ASTReader; - friend class ASTStmtWriter; ---

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

dexonsmith added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:990-998 + std::string Name = ("__const." + FunctionName(D.getParentFunctionOrMethod()) + + "." + D.getName()) + .str(); + llvm::GlobalVariable *InsertBefore = null

[PATCH] D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets.

ahatanak created this revision. ahatanak added reviewers: theraven, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This fixes a bug introduced in r340041 (see the discussion in https://reviews.llvm.org/D50783). '@' can't be used in block descriptors' sy

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

jfb added a comment. Small update to use `std::string` because `Twine` lifetimes are sad. This didn't trigger on any of the tests, but did in a stage2 build. Repository: rC Clang https://reviews.llvm.org/D54055 ___ cfe-commits mailing list cfe-c

[PATCH] D54055: CGDecl::emitStoresForConstant fix synthesized constant's name

jfb updated this revision to Diff 174087. jfb added a comment. Herald added a subscriber: jkorous. - Fix lifetime of the name, Twine bites again. Repository: rC Clang https://reviews.llvm.org/D54055 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/decl.c test/CodeGen/dump-struct-builtin.c

[PATCH] D54526: [AST] Pack BinaryOperator

dblaikie added inline comments. Comment at: include/clang/AST/Stmt.h:572 CastExprBitfields CastExprBits; +BinaryOperatorBitfields BinaryOperatorBits; InitListExprBitfields InitListExprBits; Oh, just a thought - wonder if we could/should have an asse

[PATCH] D54526: [AST] Pack BinaryOperator

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! just a few things that could be cleaned up. Comment at: include/clang/AST/Expr.h:3220 - SourceLocation getExprLoc() const LLVM_READONLY { return O

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

rjmccall added a comment. IIRC, abbreviations just silently don't take effect if the record doesn't conform; so things will appear to work, but the size on disk will be bigger. Comment at: include/clang/AST/Expr.h:1615 + } + + /// Build a string literal. ric

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:1096 + equivalent to copying the underlying bytes and then dropping the source object + on the floor. * ``__is_destructible`` (MSVC 2013) Quuxplusone wrote: > dblaikie wrote: > > Quuxplus

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

dblaikie added inline comments. Comment at: docs/LanguageExtensions.rst:1096 + equivalent to copying the underlying bytes and then dropping the source object + on the floor. * ``__is_destructible`` (MSVC 2013) Quuxplusone wrote: > dblaikie wrote: > > Quuxplus

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone added inline comments. Comment at: docs/LanguageExtensions.rst:1096 + equivalent to copying the underlying bytes and then dropping the source object + on the floor. * ``__is_destructible`` (MSVC 2013) dblaikie wrote: > Quuxplusone wrote: > > rjmcc

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D53768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4289 + /*BasePath=*/nullptr, CCK) + .get(); Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccall wrote: > > > > Anastasia wrote: > >

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:129 + std::max(NonFractBits, OtherNonFractBits) + CommonScale; + + bool ResultIsSigned = isSigned() || Other.isSigned(); ebevhan wrote: > Does this properly compensate for types o

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174080. leonardchan marked 5 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContex

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

dblaikie added inline comments. Comment at: docs/LanguageExtensions.rst:1096 + equivalent to copying the underlying bytes and then dropping the source object + on the floor. * ``__is_destructible`` (MSVC 2013) Quuxplusone wrote: > rjmccall wrote: > > Quuxplus

[PATCH] D48144: [Support] Teach YAMLIO about polymorphic types

This revision was automatically updated to reflect the committed changes. Closed by commit rC346884: [Support] Teach YAMLIO about polymorphic types (authored by scott.linder, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D48144?vs=1719

[clang-tools-extra] r346884 - [Support] Teach YAMLIO about polymorphic types

Author: scott.linder Date: Wed Nov 14 11:39:59 2018 New Revision: 346884 URL: http://llvm.org/viewvc/llvm-project?rev=346884&view=rev Log: [Support] Teach YAMLIO about polymorphic types Add support for "polymorphic" types to YAMLIO. PolymorphicTraits can dynamically switch between other traits (

r346884 - [Support] Teach YAMLIO about polymorphic types

Author: scott.linder Date: Wed Nov 14 11:39:59 2018 New Revision: 346884 URL: http://llvm.org/viewvc/llvm-project?rev=346884&view=rev Log: [Support] Teach YAMLIO about polymorphic types Add support for "polymorphic" types to YAMLIO. PolymorphicTraits can dynamically switch between other traits (

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

sammccall added a comment. @benlangmuir: I hadn't seen your comment while replying, sorry for any confusion... > The most critical piece of this is being able to ask "what symbol is at this > location" and correlate that with index queries. This makes sense (at least doing follow-up index quer

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah updated this revision to Diff 174076. jessicah added a comment. Update test case for "--coverage" upon review comments. Repository: rC Clang https://reviews.llvm.org/D54195 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c

[PATCH] D54536: [AST] Fix typo in MicrosoftMangle

This revision was automatically updated to reflect the committed changes. Closed by commit rC346882: [AST] Fix typo in MicrosoftMangle (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D54536?vs=174064&id=174075#toc Repository: rC Clang https://reviews.

r346882 - [AST] Fix typo in MicrosoftMangle

Author: smeenai Date: Wed Nov 14 11:16:22 2018 New Revision: 346882 URL: http://llvm.org/viewvc/llvm-project?rev=346882&view=rev Log: [AST] Fix typo in MicrosoftMangle Correct the spelling from Artifical to Artificial. Differential Revision: https://reviews.llvm.org/D54536 Modified: cfe/tru

[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:982 + int ParenthesesDepth = 1; + while (ParenthesesDepth != 0) { ++It; xazax.hun wrote: > Is the misspelling already comm

[PATCH] D54536: [AST] Fix typo in MicrosoftMangle

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I'd say feel free to commit typo fixes like this in the future. I'd avoid fixing typos where there is spelling disagreement, like "prolog vs prologue", so just use your best judgement as always. lgt

[PATCH] D52440: Emit lifetime markers for temporary function parameter aggregates

itessier added a comment. > This is problematic because we're not necessarily in a scope that usefully > limits the duration of cleanups — we don't push full-expression scopes when > emitting an arbitrary statement. Probably we should, but we don't. > If you'd like to take a look at solving t

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

aaron.ballman added inline comments. Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:37 +CheckMacroRedundancy(Loc, Condition, IfStack, + "nested redundant if; consider removing it", + "previous if was here", tr

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

sammccall added a comment. If we're extending the API, we should be careful to do it in an orthogonal and reasonable general way. Apple may not need USR in other places now, but there are users other than Apple and times other than today :-) One of the reasons this looks odd is the method is "f

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:63 + assert(FloatLit != nullptr && "Neither IntLit nor FloatLit set"); + return FloatLit->getValueAsApproximateDouble(); +} hwright wrote: > aaron.ballman wrote: >

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. @george.karpenkov Matching macros is a very non-trivial job, how would you feel if we shipped this patch as-is, and maybe leave a TODO about adding macro `assert`s down the line? https://reviews.llvm.org/D51866

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

benlangmuir added a comment. @sammccall RE using USRs: we want to integrate clangd into a larger source tooling system that is already using USRs extensively to identify symbols. The most obvious case is that we have an index outside of clangd that uses USRs from clang-the-compiler, so exposing

[PATCH] D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion

dgoldman added a comment. @sammccall to land this Repository: rC Clang https://reviews.llvm.org/D53900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

Anastasia added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4289 + /*BasePath=*/nullptr, CCK) + .get(); rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > Anastasia wrote: > > > > rjmccall wrote: > >

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

jkorous added a comment. Correction - I asked offline about our intended use of USR in LSP and it seems we might want to receive it as part of other responses too. Nothing specific for now but it's probable that it won't be just this singular case. Repository: rCTE Clang Tools Extra https:/

[PATCH] D54536: [AST] Fix typo in MicrosoftMangle

smeenai created this revision. smeenai added reviewers: majnemer, rnk. I noticed that we were spelling it as Artifical instead of Artificial when working on the mangling for Obj-C RTTI. I'm putting this up for review instead of committing it directly because I'm not 100% sure what the policy here

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

marco-c accepted this revision. marco-c added a comment. This revision is now accepted and ready to land. Thanks! Comment at: test/Driver/clang_f_opts.c:89 +// RUN: %clang -### -fprofile-arcs -ftest-coverage %s 2>&1 | FileCheck -check-prefix=CHECK-u %s +// CHECK-u-NOT: "-u{{.*

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4289 + /*BasePath=*/nullptr, CCK) + .get(); Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccall wrote: > > > > Okay. But if `ToTyp

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. If I am using regular files instead of remapped files, I did not see the segfault. So is it possible that this is a clang issue? Repository: rC Clang https://reviews.llvm.org/D53329 ___ cfe-commits mailing list cfe

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

jkorous added a comment. We are also discussing creating separate method as we'll likely want to add other data to the response in the future. Would you prefer USR not to be in the standard part of LSP but only in our extension? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5

[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

Szelethus added a comment. Herald added a subscriber: gamesh411. Unfortunately, I found //yet another// corner case I didn't cover: if the macro arguments themselves are macros. I already fixed it, but it raises the question that what other things I may have missed? I genuinely dislike this proj

[PATCH] D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. Unfortunately, I found //yet another// corner case I didn't cover: if the macro arguments themselves are macros. I already fixed it, but it raises the question that what other things I may have missed? I genuinel

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

jkorous added a comment. Hi Sam! I am aware of clangd using SymbolID. We basically need USR for integration with our external indexing service. We don't plan to systematically use it in the protocol and I am not aware of any other requirement for using USR in LSP - will double check that to be

[PATCH] D54535: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1

jankratochvil created this revision. jankratochvil added a reviewer: mikhail.ramalho. jankratochvil added a project: clang. Herald added subscribers: cfe-commits, mgorny. D54391 comment by @mikhail.ramalho says: > Since we're supporting version 4.8.1 now

  1   2   >