EricWF added a comment.

In https://reviews.llvm.org/D40218#1298943, @Romain-Geissler-1A wrote:
> Is there any news on this code review ? Is it ready to land ?


I think so, but there were some changes regarding incomplete types since 
Richard last looked at it.
I wanted him to sign off on the new behavior.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:1037
+
+  // FIXME: We either have an incomplete class type, or we have a class 
template
+  // whose instantiation has not been forced. Example:
----------------
@rsmith I believe this changed since you approved the patch.

We talked about this offline, but could you give it a thumbs up?


https://reviews.llvm.org/D40218



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D40218: [... Romain Geissler via Phabricator via cfe-commits
    • [PATCH] D402... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D402... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D402... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to