sylvestre.ledru added a comment.
Herald added a subscriber: arphaman.
I am sorry but I am not the right reviewer for that. Sorry!
Repository:
rC Clang
https://reviews.llvm.org/D52173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
mwasplund added a comment.
In https://reviews.llvm.org/D52973#1259909, @rsmith wrote:
> Generally this looks good, but it needs an accompanying test.
I was looking into that and trying to read up on the documentation for adding
tests. I think I understand the crazy comment RUN test invocation,
ZaMaZaN4iK added a comment.
Herald added a subscriber: Szelethus.
What is the status of the PR?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
lebedev.ri added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
thi
erik.pilkington updated this revision to Diff 168939.
erik.pilkington added a comment.
Merge the common pointers rather than trying to use the previous one. Thanks!
https://reviews.llvm.org/D53046
Files:
clang/include/clang/AST/DeclTemplate.h
clang/lib/AST/DeclTemplate.cpp
clang/lib/Sema/
MaskRay created this revision.
MaskRay added a reviewer: hokein.
Herald added subscribers: cfe-commits, ioeric.
The use sites are enclosed by `namespace clang`, so clang:: is not
necessary. Many unqualified names have already been used, e.g. SourceManager
SourceLocation LangOptions. This change m
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
jfb added a comment.
Can you add tests with arrays?
The error message doesn't really say what to do instead. What's wrong? What's
correct instead?
In C++17 and later we should suggest using `std::size` for some cases instead.
https://reviews.llvm.org/D52949
__
rjmccall added a comment.
In https://reviews.llvm.org/D53046#1259945, @erik.pilkington wrote:
> In https://reviews.llvm.org/D53046#1259933, @rjmccall wrote:
>
> > The linking does actually happen in this test case, right? Can we just do
> > something when linking them to unify their `Common` st
erik.pilkington added a comment.
In https://reviews.llvm.org/D53046#1259933, @rjmccall wrote:
> The linking does actually happen in this test case, right? Can we just do
> something when linking them to unify their `Common` structures?
Yep, that would work too I think. We can't properly merge
thiagomacieira updated this revision to Diff 168936.
thiagomacieira added a comment.
Added test update
https://reviews.llvm.org/D53042
Files:
lib/Basic/Targets/X86.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-macros.c
=
rjmccall added a comment.
In https://reviews.llvm.org/D50616#1259769, @leonardchan wrote:
> @ebevhan @rjmccall Seeing that the saturation intrinsic in
> https://reviews.llvm.org/D52286 should be put on hold for now, would it be
> fine to submit this patch as is? Then if the intrinsic is finishe
rjmccall added a comment.
The linking does actually happen in this test case, right? Can we just do
something when linking them to unify their `Common` structures?
Repository:
rC Clang
https://reviews.llvm.org/D53046
___
cfe-commits mailing lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344110: ExprConstant: Make __builtin_object_size use
EM_IgnoreSideEffects. (authored by jyknight, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
https://reviews.llvm.org/D
Author: jyknight
Date: Tue Oct 9 19:53:43 2018
New Revision: 344110
URL: http://llvm.org/viewvc/llvm-project?rev=344110&view=rev
Log:
ExprConstant: Make __builtin_object_size use EM_IgnoreSideEffects.
And, since EM_OffsetFold is now unused, remove it.
While builtin_object_size intends to ignore
rsmith added a comment.
Generally this looks good, but it needs an accompanying test.
Comment at: include/clang/AST/ASTContext.h:1129-1130
+ /// Retrieve the declaration for the type_info class type.
+ RecordDecl *getTypeInfoClassDecl() const;
+
Please indi
thiagomacieira added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
But there is definitely at least one test that needs to be updated.
@thiagomacieira, can update them or would you like me to?
Comment at: lib/Basic/Tar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344101: [Basic] Split out -Wimplicit-int-conversion and
-Wimplicit-float-conversion… (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
Author: epilk
Date: Tue Oct 9 17:40:50 2018
New Revision: 344101
URL: http://llvm.org/viewvc/llvm-project?rev=344101&view=rev
Log:
[Basic] Split out -Wimplicit-int-conversion and -Wimplicit-float-conversion
from -Wconversion
These two diagnostics are noisy, so its reasonable for users to opt-ou
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
l
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344100: clang: Allow ifunc resolvers to accept arguments
(authored by emaste, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52703
Files:
include/clang/Basic/AttrDocs.td
include/cl
Author: emaste
Date: Tue Oct 9 17:34:17 2018
New Revision: 344100
URL: http://llvm.org/viewvc/llvm-project?rev=344100&view=rev
Log:
clang: Allow ifunc resolvers to accept arguments
When ifunc support was added to Clang (r265917) it did not allow
resolvers to take function arguments. This was ba
xbolva00 added a comment.
ping
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I wonder if we should have a `-fno-strict-something` flag for this. I suppose
there's no more effective way to find out than to try this and see what happens.
Comment at: li
krytarowski added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:323
Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag;
- else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet))
+ else if (T.getOS() == Triple::Linux &&
+LangOpts.Sanitize
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344098: [Driver][cc1][cc1as] Call OptTable::PrintHelp with
explicit " [options] file..." (authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
Author: maskray
Date: Tue Oct 9 17:15:33 2018
New Revision: 344098
URL: http://llvm.org/viewvc/llvm-project?rev=344098&view=rev
Log:
[Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."
Summary: This is to accommodate a change in llvm/lib/Option/OptTable.cpp D51009
R
leonardchan added a comment.
@ebevhan @rjmccall Seeing that the saturation intrinsic in
https://reviews.llvm.org/D52286 should be put on hold for now, would it be fine
to submit this patch as is? Then if the intrinsic is finished, come back to
this and update this patch to use the intrinsic?
MaskRay updated this revision to Diff 168913.
MaskRay retitled this revision from "[cc1][cc1as] Call OptTable::PrintHelp with
explicit " [options] file..."" to "[Driver][cc1][cc1as] Call
OptTable::PrintHelp with explicit " [options] file..."".
MaskRay added a comment.
Another reference in driver
erik.pilkington updated this revision to Diff 168912.
erik.pilkington added a comment.
Actually run the tests!
https://reviews.llvm.org/D53048
Files:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/test/Sema/implicit-int-conversion.c
erik.pilkington added inline comments.
Comment at: clang/test/Sema/implicit-int-conversion.c:1-4
+// RUN: %clang_cc1 -Wconversion -Wno-implicit-int-conversion -DSMALL=char
-DBIG=int -DNO_DIAG
+// RUN: %clang_cc1 -Wno-conversion -Wimplicit-int-conversion -DSMALL=char
-DBIG=int
+
dexonsmith added inline comments.
Comment at: clang/test/Sema/implicit-int-conversion.c:1-4
+// RUN: %clang_cc1 -Wconversion -Wno-implicit-int-conversion -DSMALL=char
-DBIG=int -DNO_DIAG
+// RUN: %clang_cc1 -Wno-conversion -Wimplicit-int-conversion -DSMALL=char
-DBIG=int
+// RU
MaskRay updated this revision to Diff 168898.
MaskRay retitled this revision from "[cc1][cc1as] Call OptTable::PrintHelp with
explicit " [options] "" to "[cc1][cc1as] Call OptTable::PrintHelp with
explicit " [options] file..."".
MaskRay removed a reviewer: clang.
MaskRay removed subscribers: sdar
lebedev.ri added a comment.
LG other than the `hasCanonicalType()` vs `hasType()` question.
https://reviews.llvm.org/D52727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D52998#1258962, @eandrews wrote:
> Yes. I understand. At the moment, exception handling flags are generated
> based on `BENCHMARK_ENABLE_EXCEPTIONS` in `utils/benchmark/CMakeLists.txt` .
> However, `_HAS_EXCEPTIONS` is not defined based
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:519
+
+if (FirstAccess->getBeginLoc() < FirstGuard->getBeginLoc())
+ return true;
george.karpenkov wrote:
> Szelethus wrote:
> >
Szelethus updated this revision to Diff 168885.
Szelethus added a comment.
Added new guards as recommended by @xazax.hun
https://reviews.llvm.org/D51866
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/Uninitialized
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, aaron.ballman.
Herald added a subscriber: dexonsmith.
These two diagnostics are noisy, so its reasonable for users to opt-out of them
when -Wconversion is enabled.
Fixes rdar://45058981
Thanks for taking a look!
R
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:10015
// merged.
if (MergeFunctionDecl(NewFD, OldDecl, S, MergeTypeWithPrevious)) {
NewFD->setInvalidDecl();
The problem is here, MergeFunctionDecl() needs the injecte
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, rjmccall.
Herald added a subscriber: dexonsmith.
Clang used to error out on the attached testcase, due to multiple definitions
of `foo`. The problem is that multiple FunctionTemplateDecl::Common
pointers are created
steveire added a comment.
> What's more, given that clang-output has no real documentation to speak of,
> how will users even *know* to update their scripts?
The release notes will tell them.
But your comment also raises a different point: If there is so little
clang-query documentation, what
george.karpenkov added a comment.
> there's a way to run clang-tidy over all of clang+llvm automatically
cmake should generate compile_commands.json by default, and then you could just
point clang-tidy at that.
Repository:
rC Clang
https://reviews.llvm.org/D52905
lebedev.ri added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
> h
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
thiagomacieira created this revision.
thiagomacieira added reviewers: erichkeane, craig.topper.
Herald added a subscriber: cfe-commits.
craig.topper retitled this revision from "Remove FeatureRTM from Skylake
processor list" to "[X86] Remove FeatureRTM from Skylake processor list".
There are a LO
Szelethus added a comment.
Thanks!
I admit that the difficulty was mostly chosen at random, so that could be
brought closer to the actual difficulty of the project.
Comment at: www/analyzer/open_projects.html:86-87
+the opposite direction - integers to pointers - are comp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D52990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Hi ymandel,
welcome to the LLVM community and thank you very much for working on that check!
If you have any questions or other issues don't hesitate to ask ;)
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:25
+
+// Finds the location
sidneym created this revision.
sidneym added reviewers: shankare, ruiu, kparzysz, bcain.
Herald added a subscriber: cfe-commits.
Use GetLinkerPath method instead of hard-coding linker name.
Change should allow -fuse-ld to work on the Hexagon target.
Repository:
rC Clang
https://reviews.llvm.
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
Thanks!
https://reviews.llvm.org/D52924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1258893, @steveire wrote:
> - The scripts will continue to work at least until `set output` is removed,
> which is not going to happen soon.
Certainly, but given that deprecation implies eventual removal, people are
still being
NoQ added a comment.
Whoa thanks! Will have a closer look again.
Comment at: www/analyzer/open_projects.html:33
+
+Handle aggregate construction.
+Aggregates are object that can be brace-initialized without calling a
I'll try to list other constructor k
NoQ added a comment.
In https://reviews.llvm.org/D52983#1258499, @xazax.hun wrote:
> In https://reviews.llvm.org/D52983#1258466, @NoQ wrote:
>
> > Yay, these look useful. Is there also an attribute for methods that should
> > never be called on a 'moved-from' object?
>
>
> I do not know about su
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:12-32
// Constant expression evaluation produces four main results:
//
// * A success/failure flag indicating whether constant folding was
successful.
//This is the 'bool' return value used by most
ymandel marked 3 inline comments as done.
ymandel added a comment.
Thanks for the review. I've addressed the comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks like this has been largely redundant since r294800 removed the
only interesting thing that `EM_OffsetFold` did.
https://reviews.llvm.org/D52924
__
NoQ added a comment.
In https://reviews.llvm.org/D52905#1259249, @NoQ wrote:
> > where `isStaticLocal` is defined as:
>
> You can send this one as well if you like! It's weird that we don't already
> have it.
Or actually maybe it can be implemented as `allOf(hasStaticStorageDuration(),
unless
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, this one looks great as well. I'll commit. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52906
___
cfe-commits mailing list
cfe-commit
ymandel updated this revision to Diff 168858.
ymandel added a comment.
Add missing const.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/ConstValueRe
NoQ added a comment.
> where `isStaticLocal` is defined as:
You can send this one as well if you like! It's weird that we don't already
have it.
Repository:
rC Clang
https://reviews.llvm.org/D52905
___
cfe-commits mailing list
cfe-commits@lists
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Cool, thanks! I'll commit.
Repository:
rC Clang
https://reviews.llvm.org/D52905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
ymandel updated this revision to Diff 168857.
ymandel marked 2 inline comments as done.
ymandel added a comment.
Dropped unneeded clang qualifier.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstV
ymandel updated this revision to Diff 168856.
ymandel added a comment.
Minor changes addressing comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readabil
ashi1 updated this revision to Diff 168855.
ashi1 marked an inline comment as done.
ashi1 added a comment.
I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index:
SGTM.
On Tue, Oct 9, 2018, 7:57 AM James Y Knight via Phabricator <
revi...@reviews.llvm.org> wrote:
> jyknight accepted this revision.
> jyknight added a comment.
> This revision is now accepted and ready to land.
>
> Given that there's no technical reason for the compiler to prohibit this
> (it
sammccall created this revision.
sammccall added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
I think this was just copied from somewhere with the belief that it actually
did some crash handling.
Of course the question arises: *sho
mstorsjo added a comment.
If relying on logic in lld, this one can be discarded.
Repository:
rC Clang
https://reviews.llvm.org/D53013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
mstorsjo updated this revision to Diff 168848.
mstorsjo added a comment.
Relying on a linker pragma in sanitizers and mingw lib name logic in lld.
https://reviews.llvm.org/D52990
Files:
lib/CodeGen/TargetInfo.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
=
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jfb, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov, mgorny.
See tinyurl.com/clangd-automatic-index for design and goals.
Lots of limitations to keep this patch smallish, TODOs everyw
Author: rsmith
Date: Tue Oct 9 11:49:22 2018
New Revision: 344070
URL: http://llvm.org/viewvc/llvm-project?rev=344070&view=rev
Log:
PR39231: fix null dereference when diagnosing deduction failure due to
conflicting values for a non-type pack.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Anastasia added a comment.
It would be good to test your `CIndex` changes in `test/Index/opencl-types.cl`.
Comment at: test/SemaOpenCL/intel-subgroup-avc-ext-types.cl:26
+ char4 c4, event_t e, struct st ss) {
+ intel_sub_group_avc_mce_payload_t payload_mce = 0; // No z
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:85
C.addTempFile(C.getArgs().MakeArgString(TmpName));
CmdArgs.push_back(OutputFileName);
SmallString<128> ExecPath(C.getDriver().Dir);
maybe we should put hip.amdgcn.bc at the be
ashi1 updated this revision to Diff 168836.
ashi1 added a comment.
The device libraries has been updated, and the hip.amdgcn.bc library is now
available there.
Repository:
rC Clang
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Ind
Eugene.Zelenko added a comment.
GCC has -Wignored-qualifiers for long time, so may be better to implement it in
Clang?
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:66
+ llvm::Optional Loc = findConstToRemove(Def, Result);
+ if (!Loc) return;
+ DiagnosticBuil
ymandel created this revision.
ymandel added reviewers: aaron.ballman, JonasToth, ioeric.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
Adds a new check readability-const-value-return, which checks for functions with
a ``const``-qualified return type and recommends removal of the `cons
Szelethus added inline comments.
Comment at: www/analyzer/alpha_checks.html:352-405
+
+alpha.cplusplus.InvalidatedIterator
+(C++)
+Check for use of invalidated iterators.
+
+
@baloghadamsoftware Is this a good description of your checker(s)?
https://reviews.l
Szelethus added a comment.
Mind you, there are some ideas I didn't add to the list -- I just don't know
how to put them to words nicely, but I'm on it.
Also, a lot of these is outdated, but I joined the project relatively recently,
so I'm not sure what's the state on all of them.
Repository:
Anastasia added a comment.
In https://reviews.llvm.org/D51402#1252619, @sidorovd wrote:
> @Anastasia , since there is a problem I described, wouldn't you mind if I
> stay with the first iteration of the patch (adding the extension to
> OpenCLExtensions.def) and after we'll investigate what is w
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D52292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
jranieri-grammatech updated this revision to Diff 168815.
jranieri-grammatech added a comment.
Added more context.
Repository:
rC Clang
https://reviews.llvm.org/D52905
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h
include/clang/StaticAnalyzer/Core/PathSensitive/
kpn updated this revision to Diff 168814.
kpn added a comment.
Update based on feedback to https://reviews.llvm.org/D52839: add missing AST
(de)serialization support.
Ping.
https://reviews.llvm.org/D51372
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
lib/AST/ASTImporter.cp
eandrews added a comment.
Yes. I understand. At the moment, exception handling flags are generated based
on `BENCHMARK_ENABLE_EXCEPTIONS` in `utils/benchmark/CMakeLists.txt` .
However, `_HAS_EXCEPTIONS` is not defined based on this (code below). The
warnings are a result of this mismatch.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344058: [clang-tidy] Fix handling of parens around new
expressions in make_… (authored by alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
Author: alexfh
Date: Tue Oct 9 08:58:18 2018
New Revision: 344058
URL: http://llvm.org/viewvc/llvm-project?rev=344058&view=rev
Log:
[clang-tidy] Fix handling of parens around new expressions in make_
checks.
Summary:
Extra parentheses around a new expression result in incorrect code
after apply
alexfh updated this revision to Diff 168812.
alexfh marked 2 inline comments as done.
alexfh added a comment.
- Remove recursion, use `auto`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52989
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmar
alexfh added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:246
+ ASTContext *Ctx) {
+ std::function SkipParensParents =
+ [&](const Expr *E) {
hokein wrote:
> nit: I'd use `auto` to avoid this long
Author: yaxunl
Date: Tue Oct 9 08:53:14 2018
New Revision: 344057
URL: http://llvm.org/viewvc/llvm-project?rev=344057&view=rev
Log:
[CUDA][HIP] Fix ShouldDeleteSpecialMember for inherited constructors
ShouldDeleteSpecialMember is called upon inherited constructors.
It calls inferCUDATargetForImp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344057: [CUDA][HIP] Fix ShouldDeleteSpecialMember for
inherited constructors (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Szelethus added a comment.
Please reupload with full context (`-U9`).
Repository:
rC Clang
https://reviews.llvm.org/D52905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/Checker.cpp:20
+int ImplicitNullDerefEvent::Tag;
+
Szelethus wrote:
> nit: Static fields initialize to 0 without out of line definition.
Never mind, you still have to define it. It's been a wh
Szelethus added a comment.
Please reupload with full context (`-U`).
Comment at: lib/StaticAnalyzer/Core/Checker.cpp:20
+int ImplicitNullDerefEvent::Tag;
+
nit: Static fields initialize to 0 without out of line definition.
Repository:
rC Clang
https:
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC.
Herald added subscribers: cfe-commits, jfb, mikhail.ramalho, a.sidorin,
rnkovacs, szepet, whisperity.
Added some extra tasks to the open projects. These are the ideas of @NoQ and
@george.karpenkov,
yaxunl added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:7231
+if (ICI)
+ CSM = getSpecialMember(MD);
+
jlebar wrote:
> LGTM, but perhaps we should use a new variable instead of modifying `CSM` in
> case someone adds code beneath this branch?
Author: ioeric
Date: Tue Oct 9 08:17:16 2018
New Revision: 344055
URL: http://llvm.org/viewvc/llvm-project?rev=344055&view=rev
Log:
[clang-move] Fix broken json output.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: clang-tools-extra/trunk/clang-move/tool/Clan
Author: hokein
Date: Tue Oct 9 08:16:14 2018
New Revision: 344054
URL: http://llvm.org/viewvc/llvm-project?rev=344054&view=rev
Log:
[clangd] Fix an accident change in r342999.
Modified:
clang-tools-extra/trunk/clangd/index/YAMLSerialization.cpp
Modified: clang-tools-extra/trunk/clangd/index
sammccall added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:65
+ clang::clangd::SymbolID SymID;
+ // We choose the first one if there are overloaded symbols.
+ Index->fuzzyFind(Request, [&](const Symbol &Sym) {
I don't think this is reasonable
hokein updated this revision to Diff 168802.
hokein added a comment.
Minor fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53019
Files:
clangd/index/dex/dexp/CMakeLists.txt
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
===
hokein added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:204
{"lookup", "Dump symbol details by ID", llvm::make_unique},
+{"refs", "Find references by qualified name", llvm::make_unique},
};
sammccall wrote:
> I'm not sure "by qualified
hokein updated this revision to Diff 168801.
hokein marked 3 inline comments as done.
hokein added a comment.
Herald added a subscriber: mgorny.
Address review comments:
- provide query by qualified name (with -name)
- add -name support for Lookup.
Repository:
rCTE Clang Tools Extra
https://
1 - 100 of 155 matches
Mail list logo
