Author: maskray
Date: Tue Sep 25 23:28:14 2018
New Revision: 343072
URL: http://llvm.org/viewvc/llvm-project?rev=343072&view=rev
Log:
[Frontend] Tidy up -print-decl-contexts conditions
The existing conditions are not consistent. Some have braces and define a
temporary Decl while others simply ca
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:339
+llvm::ErrorOr status(const Twine &Path) override {
+ auto I = StatCache.find(Path.str());
+ return (I != StatCache.end()) ? I->getValue() : FS->status(Path);
ioeric wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343067: [clangd] Fix crash if pending computations were
active on exit (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: ibiryukov
Date: Tue Sep 25 22:48:29 2018
New Revision: 343067
URL: http://llvm.org/viewvc/llvm-project?rev=343067&view=rev
Log:
[clangd] Fix crash if pending computations were active on exit
Summary:
Make sure JSONRPCDispatcher outlives the worker threads, they access
its fields to remove
Author: ibiryukov
Date: Tue Sep 25 22:45:31 2018
New Revision: 343066
URL: http://llvm.org/viewvc/llvm-project?rev=343066&view=rev
Log:
[clangd] Handle template args for disabled function arg snippets
Reviewers: kadircet, ioeric, sammccall
Reviewed By: kadircet
Subscribers: MaskRay, jkorous, ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343066: [clangd] Handle template args for disabled function
arg snippets (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:507
+ if (Snippet->front() == '<')
+return EmptyArgs ? "<$0>()" : "<$1>($0)";
+ if (Snippet->front() == '(')
kadircet wrote:
ilya-biryukov updated this revision to Diff 167044.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Remove debug formatting
- Update snippet for no-arg case with the suggested changes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52422
Files:
Author: rsmith
Date: Tue Sep 25 21:36:55 2018
New Revision: 343064
URL: http://llvm.org/viewvc/llvm-project?rev=343064&view=rev
Log:
P0859R0: List-initialization is potentially-constant-evaluated and
triggers instantiation of constexpr functions.
We mostly implemented this since Clang 6, but miss
Author: kli
Date: Tue Sep 25 21:28:39 2018
New Revision: 343063
URL: http://llvm.org/viewvc/llvm-project?rev=343063&view=rev
Log:
[OPENMP] Add support for OMP5 requires directive + unified_address clause
Add support for OMP5.0 requires directive and unified_address clause.
Patches to follow will
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343063: [OPENMP] Add support for OMP5 requires directive +
unified_address clause (authored by kli, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52359?vs=166471&id=167042#toc
Repo
owenpan created this revision.
owenpan added reviewers: sammccall, klimek, djasper, krasimir.
Herald added a subscriber: cfe-commits.
https://bugs.llvm.org/show_bug.cgi?id=38686
Repository:
rC Clang
https://reviews.llvm.org/D52527
Files:
include/clang/Format/Format.h
lib/Format/Format.cp
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:176
+ pushFullExprCleanup(NormalEHLifetimeMarker,
+ Slot.getAddress(), Size);
+}
This is problematic because we're not necessarily in a scope tha
I'd like to understand this better as well, in particular what would be a
proper fix?
On Tue, Sep 25, 2018 at 2:15 PM David Blaikie wrote:
> +Shuai Wang
>
> On Tue, Sep 25, 2018 at 2:14 PM David Blaikie wrote:
>
>> Hey Eric - thanks for the fix - but could you explain the issue here in a
>> bit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343051: [analyzer] Fix a crash on casting symbolic pointers
to derived classes. (authored by dergachev, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52189
Files:
lib/StaticAnalyzer/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343051: [analyzer] Fix a crash on casting symbolic pointers
to derived classes. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: dergachev
Date: Tue Sep 25 17:17:14 2018
New Revision: 343051
URL: http://llvm.org/viewvc/llvm-project?rev=343051&view=rev
Log:
[analyzer] Fix a crash on casting symbolic pointers to derived classes.
Commit r340984 causes a crash when a pointer to a completely unrelated type
UnrelatedT (e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343048: [analyzer] Add a testing facility for testing
relationships between symbols. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: epilk
Date: Tue Sep 25 16:52:29 2018
New Revision: 343050
URL: http://llvm.org/viewvc/llvm-project?rev=343050&view=rev
Log:
Fix a bot failure from r343042.
Modified:
cfe/trunk/test/Sema/warn-duplicate-enum.c
Modified: cfe/trunk/test/Sema/warn-duplicate-enum.c
URL:
http://llvm.org/vi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343048: [analyzer] Add a testing facility for testing
relationships between symbols. (authored by dergachev, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52133
Files:
docs/analyzer/
Author: dergachev
Date: Tue Sep 25 16:50:53 2018
New Revision: 343048
URL: http://llvm.org/viewvc/llvm-project?rev=343048&view=rev
Log:
[analyzer] Add a testing facility for testing relationships between symbols.
Tests introduced in r329780 was disabled in r342317 because these tests
were acciden
Author: kristina
Date: Tue Sep 25 16:17:09 2018
New Revision: 343044
URL: http://llvm.org/viewvc/llvm-project?rev=343044&view=rev
Log:
[clang-check-codegen][cfstring] Accept either @ or % for progbits to make
ppc64be bots happy.
PPC64BE bots use % instead of @ for directives like progbits. Since
yunlian created this revision.
Herald added a subscriber: cfe-commits.
When using clang as a cross-compiler, we should not use system headers or
libraries to do the compilation. This CL creates a new warning flag
-Wpoison-system-directories support to emit warnings if --sysroot is set and
header
Author: epilk
Date: Tue Sep 25 15:53:06 2018
New Revision: 343042
URL: http://llvm.org/viewvc/llvm-project?rev=343042&view=rev
Log:
[Sema] Use a more civilized hash map to implement -Wduplicate-enum.
DenseMap used LONG_MAX as a tombstone, so it asserts
when you try to insert it!
rdar://44774672
Author: rsmith
Date: Tue Sep 25 15:34:45 2018
New Revision: 343040
URL: http://llvm.org/viewvc/llvm-project?rev=343040&view=rev
Log:
Don't emit "will be treated as an identifier character" warning for
UTF-8 characters that aren't identifier characters in the current
language mode.
Modified:
c
Author: maskray
Date: Tue Sep 25 15:32:11 2018
New Revision: 343039
URL: http://llvm.org/viewvc/llvm-project?rev=343039&view=rev
Log:
[clangd] Remove unused using-declaration testing::AllOf
Modified:
clang-tools-extra/trunk/unittests/clangd/SerializationTests.cpp
Modified: clang-tools-extra/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343038: Reland "[Clang][CodeGen][ObjC]: Fix
CoreFoundation on ELF with `-fconstant… (authored by kristina, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: kristina
Date: Tue Sep 25 15:27:40 2018
New Revision: 343038
URL: http://llvm.org/viewvc/llvm-project?rev=343038&view=rev
Log:
Reland "[Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with
`-fconstant-cfstrings`"
Relanding rL342883 with more fragmented tests to test ELF-specific
section
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343037: [analyzer] NFC: CallDescription: Improve array
management. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51390
Files:
include/clang/StaticAnalyzer/Co
Author: dergachev
Date: Tue Sep 25 15:13:31 2018
New Revision: 343037
URL: http://llvm.org/viewvc/llvm-project?rev=343037&view=rev
Log:
[analyzer] NFC: CallDescription: Improve array management.
Combine the two constructor overrides into a single ArrayRef constructor
to allow easier brace initial
Author: rsmith
Date: Tue Sep 25 15:12:44 2018
New Revision: 343036
URL: http://llvm.org/viewvc/llvm-project?rev=343036&view=rev
Log:
P0969R0: allow structured binding of accessible members, not only public
members.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343035: [analyzer] NFC: Legalize state manager factory
injection. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5138
Author: dergachev
Date: Tue Sep 25 15:10:12 2018
New Revision: 343035
URL: http://llvm.org/viewvc/llvm-project?rev=343035&view=rev
Log:
[analyzer] NFC: Legalize state manager factory injection.
When a checker maintains a program state trait that isn't a simple
list/set/map, but is a combination
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:143
TSK_ExplicitSpecialization &&
!Function->getClassScopeSpecializationPattern()))
break;
It loo
kristina updated this revision to Diff 166996.
kristina added a comment.
Split up the tests for ELF into tests 1). Checking whether CF can be built and
linked correctly 2). Asm section tests originally from `CFStrings.c` as they
had additional ELF-related cruft that should have been a separate t
sammccall updated this revision to Diff 167000.
sammccall added a comment.
Remove unused function.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52517
Files:
clangd/index/Serialization.h
clangd/index/YAMLSerialization.cpp
clangd/indexer/IndexerMain.cpp
Index: clangd/ind
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, rjmccall.
Herald added a subscriber: dexonsmith.
Previously, we stopped early on a class-scope explicit specialization, leading
us to lose enclosing levels of template arguments. I'm not entirely convinced
that this
sammccall added a comment.
This is really cool!
From reading the code this behaves exactly how I'd expect.
Ranking will be the real test.
Main comment is I'd like to tweak the interface on FuzzyFindRequest, rest is
basically nits.
Comment at: clangd/CodeComplete.cpp:367
dblaikie added a comment.
"The three checks mentioned in the Title are two noisy if the code uses
intrusive smart (reference counting) pointers. LLVM/Clang is such a code, it
has lots of such types, e.g. StringRef, SymbolRef or ProgramStateRef, all of
them based llvm::IntrusiveRefCntPtr. Every
boga95 updated this revision to Diff 166994.
boga95 marked 12 inline comments as done.
https://reviews.llvm.org/D52281
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp
clang-tidy/modernize/Repla
jdenny updated this revision to Diff 166992.
jdenny set the repository for this revision to rC Clang.
jdenny added a comment.
Ping. Rebased. This patch intends to perform cleanup that @rsmith suggested
while reviewing another patch from me. If there's no more interest, it's fine
with me to ab
+Shuai Wang
On Tue, Sep 25, 2018 at 2:14 PM David Blaikie wrote:
> Hey Eric - thanks for the fix - but could you explain the issue here in a
> bit more detail, as I'm a bit confused (& really interested in
> understanding any layering problems in LLVM - and fixing them/making sure
> they're fixe
Hey Eric - thanks for the fix - but could you explain the issue here in a
bit more detail, as I'm a bit confused (& really interested in
understanding any layering problems in LLVM - and fixing them/making sure
they're fixed/holding the line/etc)
What do you mean by "pull all of the AST matchers l
sammccall added a comment.
Generally LG. A few things I'm unsure about.
Comment at: clangd/CodeComplete.cpp:1028
+ IntrusiveRefCntPtr VFS = Input.VFS;
+ if (Input.PreambleStatCache)
ioeric wrote:
> ilya-biryukov wrote:
> > It feels like we could apply this
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:37
+
+enum class LengthHandleKind { LHK_Increase, LHK_Decrease };
+
Please drop the `LHK_` prefix -- the enum class name is sufficient as a prefix.
===
sammccall added a comment.
This was previously in https://reviews.llvm.org/D52465, but I reduced the scope
of that patch to make it easier to land.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52517
___
cfe-commits mailing list
c
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
It's slow, and the open-source reduce implementation doesn't scale properly.
While here, tidy up some dead headers and comments.
Repos
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343019: [clangd] Extract mapper logic from clangd-indexer
into a library. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: sammccall
Date: Tue Sep 25 13:02:36 2018
New Revision: 343019
URL: http://llvm.org/viewvc/llvm-project?rev=343019&view=rev
Log:
[clangd] Extract mapper logic from clangd-indexer into a library.
Summary: Soon we can drop support for MR-via-YAML.
I need to modify some out-of-tree versions t
On 2018-09-25, Ed Maste via Phabricator wrote:
emaste added a comment.
I'm using this change:
https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21
In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have
gas and objdump from the outdated binu
Author: sammccall
Date: Tue Sep 25 12:53:33 2018
New Revision: 343017
URL: http://llvm.org/viewvc/llvm-project?rev=343017&view=rev
Log:
[clangd] Fix reversed RIFF/YAML serialization
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
Modified: clang-tools-extra/trunk/clangd/inde
kristina added a comment.
Turns out test didn't execute as there are two tests named `CFString.c` and
`cfstring.c` which usually shouldn't matter unless LLVM source checkout is done
into a case insensitive filesystem in which case the failing test is skipped,
this seems like a bug, going to ren
sammccall added a comment.
On second thoughts, let's just leave the MR functionality in place for now so
this can be landed.
Then the out-of-tree stuff can migrate to the library, and we can rip out the
MR stuff soon.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
___
ormris added a comment.
//Ping//
Repository:
rC Clang
https://reviews.llvm.org/D52058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 166970.
sammccall added a comment.
Leave functionality of clangd-indexer unchanged, to make this easier to land.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
Files:
clangd/CMakeLists.txt
clangd/index/IndexAction.cpp
clangd/i
sammccall updated this revision to Diff 166968.
sammccall marked an inline comment as done.
sammccall added a comment.
Rebase and address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
Files:
clangd/CMakeLists.txt
clangd/index/IndexAction.cpp
clangd/index/
rsmith added a comment.
The right way to produce diagnostics under pedantic mode is to model them as
Extension or ExtWarn in the .td file, not by checking the Pedantic diagnostic
option directly. If this is an intentional GNU extension too, that makes things
a bit more complex (one approach wou
sammccall marked 3 inline comments as done.
sammccall added a comment.
Thanks!
Will land in a day or two, we maintain some out-of-tree mapreduce patches to
this file that I need to turn into a real fork.
Comment at: clangd/index/IndexAction.h:24
+// - references are always c
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, v.g.vassilev.
This is a follow-up patch of
https://reviews.llvm.org/rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set
File modification with modules is also fine for our usecase as we
want to reuse p
Author: abataev
Date: Tue Sep 25 11:31:56 2018
New Revision: 343002
URL: http://llvm.org/viewvc/llvm-project?rev=343002&view=rev
Log:
Revert "[DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file
types."
It reverts commit r342991 + several other commits intended to fix the
tests. Still ha
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
FWIW, Microsoft's newest documentation does not say that `/O2` and `/O1` imply
`/Gs`:
https://docs.microsoft.com/en-us/cpp/build/reference/o1-o2-minimize-size-maximize-speed?view=vs-2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343001: [clang-tidy] use CHECK-NOTES in tests for
bugprone-macro-repeated-side-effects (authored by JonasToth, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52230?vs=165942&id=166
Author: jonastoth
Date: Tue Sep 25 11:15:52 2018
New Revision: 343001
URL: http://llvm.org/viewvc/llvm-project?rev=343001&view=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects
Reviewers: alexfh, aaron.ballman, hokein
Reviewed By: alexfh
Subscribers: xazax.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343000: [clang-tidy] Add modernize-concat-nested-namespaces
check (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5213
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343000: [clang-tidy] Add
modernize-concat-nested-namespaces check (authored by JonasToth, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52136
Files:
clang-tidy/modernize/CMakeLists
JonasToth added a comment.
Commited for you.
https://reviews.llvm.org/D52136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jonastoth
Date: Tue Sep 25 11:12:28 2018
New Revision: 343000
URL: http://llvm.org/viewvc/llvm-project?rev=343000&view=rev
Log:
[clang-tidy] Add modernize-concat-nested-namespaces check
Summary:
Finds instances of namespaces concatenated using explicit syntax, such as
`namespace a { name
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:251
Bytes += InvertedIndex.getMemorySize();
- for (const auto &P : InvertedIndex)
-Bytes += P.second.bytes();
+ for (const auto &TokenToPostingList : InvertedIndex)
+Bytes += TokenTo
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342999: [clangd] Merge binary + YAML serialization behind
a (mostly) common interface. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52453?vs=166828&id=166
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342999: [clangd] Merge binary + YAML serialization behind a
(mostly) common interface. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
emaste added a comment.
I'm using this change:
https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21
In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have
gas and objdump from the outdated binutils 2.17.50.)
Repository:
rC Clang
https://r
Author: sammccall
Date: Tue Sep 25 11:06:43 2018
New Revision: 342999
URL: http://llvm.org/viewvc/llvm-project?rev=342999&view=rev
Log:
[clangd] Merge binary + YAML serialization behind a (mostly) common interface.
Summary:
Interface is in one file, implementation in two as they have little in co
leonardchan added inline comments.
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1119
+ case ISD::SSAT:
+// Target legalization checked here?
+Action = TargetLowering::Expand;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > leonardcha
Author: abataev
Date: Tue Sep 25 10:58:08 2018
New Revision: 342996
URL: http://llvm.org/viewvc/llvm-project?rev=342996&view=rev
Log:
[OPENMP] Fix the test, NFC.
Fixed test to pacify buildbot.
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified: cfe/trunk/test/Driver/openmp-offload.c
ioeric added a comment.
Thanks for the reviews!
Comment at: clangd/ClangdUnit.cpp:155
+auto S = FS->status(Path);
+if (S)
+ cacheStatus(*S);
sammccall wrote:
> why are you only caching success?
I had a comment in `openFileForRead`:
```
// Only
ioeric updated this revision to Diff 166951.
ioeric marked 10 inline comments as done.
ioeric added a comment.
Herald added a subscriber: mgorny.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52419
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/24083
FAIL: Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp (1692 of 13357)
TEST 'Clang ::
CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp' FAILED
Script:
--
: 'RUN: at line 1';
/b/sanitiz
Author: abataev
Date: Tue Sep 25 10:47:53 2018
New Revision: 342995
URL: http://llvm.org/viewvc/llvm-project?rev=342995&view=rev
Log:
[OPENMP] Fix failed test, NFC.
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified: cfe/trunk/test/Driver/openmp-offload.c
URL:
http://llvm.org/viewvc/
tks2103 added a comment.
ping @GorNishanov SAVE ME GOR! YOU'RE MY ONLY HOPE!
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wgml added a comment.
Thanks you all for your participation in the review process. I guess it is done
now.
I don't have write access to the repositories, @aaron.ballman, could you apply
the patch on my behalf?
Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:3
shuaiwang updated this revision to Diff 166947.
shuaiwang marked 6 inline comments as done.
shuaiwang added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52219
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analysis/ExprMutationAn
wgml updated this revision to Diff 166945.
wgml marked 10 inline comments as done.
wgml added a comment.
Dropped a few consts, updated doc text.
https://reviews.llvm.org/D52136
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp
clang-tidy/moder
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:251
Bytes += InvertedIndex.getMemorySize();
- for (const auto &P : InvertedIndex)
-Bytes += P.second.bytes();
+ for (const auto &TokenToPostingList : InvertedIndex)
+Bytes += Token
ABataev added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2304
+ const auto *C = S.getSingleClause();
+ if (C) {
+// If schedule clause is present.
Restore original code here
Comment at: lib/CodeGen/CGStmtOpenMP.
nickdesaulniers added a comment.
> Should GCC instead warn for the typedef case for -std=c89 (non pedantic),
> according to C90 6.5.3?
Seems like yes: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80868#c6
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87435
But let's wait a bit to see what the GCC
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:251
Bytes += InvertedIndex.getMemorySize();
- for (const auto &P : InvertedIndex)
-Bytes += P.second.bytes();
+ for (const auto &TokenToPostingList : InvertedIndex)
+Bytes += TokenTo
Author: abataev
Date: Tue Sep 25 10:09:17 2018
New Revision: 342991
URL: http://llvm.org/viewvc/llvm-project?rev=342991&view=rev
Log:
[DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file types.
clang-offload-bundler should not be invoked with the unbundling action
when the input file typ
Eric Liu schrieb am Di., 25. Sep. 2018, 01:22:
> On Tue, Sep 25, 2018 at 6:34 AM Ilya Biryukov
> wrote:
>
>> Why would we want to serialize the origin?
>>
> We only serialize and deserialize for the static index, it does not seem
>> to be useful to serialize origin in that scenario.
>>
> We seri
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342990: [AArch64] Support adding X[8-15,18] registers as
CSRs. (authored by trong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52399?vs=166722&id=166940#toc
Repository:
rC Clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342990: [AArch64] Support adding X[8-15,18] registers as
CSRs. (authored by trong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52399
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for factoring out this to a library.
Comment at: clangd/index/IndexAction.cpp:41
+ llvm::errs()
+ << "Found uncompilable errors in the translat
Author: trong
Date: Tue Sep 25 09:48:40 2018
New Revision: 342990
URL: http://llvm.org/viewvc/llvm-project?rev=342990&view=rev
Log:
[AArch64] Support adding X[8-15,18] registers as CSRs.
Summary:
Making X[8-15,18] registers call-saved is used to support
CONFIG_ARM64_LSE_ATOMICS in Linux kernel.
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
It's unfortunate that lit does not scrub the environment in order to make tests
hermetic.
Repository:
rC Clang
https://reviews.llvm.org/D52259
___
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks okay to me
Comment at: test/Driver/arm-cortex-cpus.c:338
+
+// RUN: %clang -target armv8a-linux-eabi -march=armv8.5-a+fp16 -### -c %s 2>&1
| FileCheck --ch
Szelethus added a comment.
Thanks!
> any particular motivation for this?
I'm currently trying to include macro expansions in the Static Analyzer's plist
output, and I only managed to make this happen by some `Token` handling
hackery, including printing them. I saw this trick in
`lib/Rewrite/H
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
This patch adds `Token`'s string data to the memory estimation. While it is
only responsible for a couple of ex
rnk added a comment.
Should `--target=mipsZZZ -mabi=n64` be meaningful? What does `clang
--target=i686-linux-gnu -m64` do? If this matches that, then let's do it.
I think each listed reviewer is currently at CppCon, hence the delay.
Repository:
rC Clang
https://reviews.llvm.org/D52290
__
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
any particular motivation for this? But looks fine to me in any case.
Repository:
rC Clang
https://reviews.llvm.org/D52502
___
cfe-commits
Szelethus created this revision.
Szelethus added a reviewer: dblaikie.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D52502
Files:
include/clang/Lex/TokenConcatenation.h
lib/Lex/TokenConcatenation.cpp
Index: lib/Lex/TokenConcatenation.cpp
=
dpayne added a comment.
@djasper @klimek
Are there any comments here about this approach?
Repository:
rC Clang
https://reviews.llvm.org/D51120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
1 - 100 of 173 matches
Mail list logo
