wuzish added a comment.
Please make this patch commit after https://reviews.llvm.org/D52072
Repository:
rC Clang
https://reviews.llvm.org/D52074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
wuzish created this revision.
wuzish added reviewers: hfinkel, nemanjai, kbarton.
Herald added a subscriber: kristina.
> unsigned long long __builtin_unpack_vector_int128 (vector __int128_t, int);
> vector __int128_t __builtin_pack_vector_int128 (unsigned long long, unsigned
> long long);
Built
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
To stay fast, enable single-file-mode instead. This is fine since completions
in the preamble are simple.
The net effect for now is to
shuaiwang added a comment.
In https://reviews.llvm.org/D52008#1232923, @lebedev.ri wrote:
> Thanks for working on this! I tried, and it appears to not fix the issue at
> hand.
>
> - ``` struct C1 { C1(const C1* c, int num); };
>
> int x = 0; auto y = std::make_unique(nullptr, x); // <- still
shuaiwang updated this revision to Diff 165420.
shuaiwang marked 10 inline comments as done.
shuaiwang added a comment.
More test cases addressing review comments
Repository:
rC Clang
https://reviews.llvm.org/D52008
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analys
zhaomo updated this revision to Diff 165415.
zhaomo added a comment.
Fixed issues pointed out by Peter and Vlad.
Richard:
I just saw comments but I will travel tomorrow and this weekend so I will reply
to your comments when I get a chance.
https://reviews.llvm.org/D51905
Files:
clang/inclu
zhaomo added a comment.
In https://reviews.llvm.org/D51905#1231383, @vlad.tsyrklevich wrote:
> This change causes all compiler-rt cfi tests to be UNSUPPORTED for me
> locally, do you have any idea why that might be? The lit changes don't make
> it immediately clear.
Not sure why that happened
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I hope we'll be able to come up with a reasonable default regex.
Comment at: test/Analysis/cxx-uninitialized-object-unionlike-constructs.cpp:1-4
+// RUN: %clang_analyze_cc1
-analy
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:61-63
+ bool IsPedantic;
+ bool ShouldConvertNotesToWarnings;
+ bool CheckPointeeInitializ
NoQ requested changes to this revision.
NoQ added a comment.
This revision now requires changes to proceed.
Or, wait, hmm, no, we can still de-duplicate the reports with a global set
stored in the checker object. Because we would probably like to de-duplicate
across different paths as well.
ht
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Hmm, i guess it's necessary to de-duplicate across multiple reports as well.
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@l
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342200: [XRay][clang] Emit "never-instrument"
attribute (authored by dberris, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52015?vs=165407&id=165408#toc
Repository:
rC Clang
ht
NoQ added a comment.
Hmm, so we're reporting the same region twice in the same bug report through
different field chains, right? Why is a state trait necessary here? Maybe just
de-duplicate them locally before throwing the report?
https://reviews.llvm.org/D51531
Author: dberris
Date: Thu Sep 13 18:59:12 2018
New Revision: 342200
URL: http://llvm.org/viewvc/llvm-project?rev=342200&view=rev
Log:
[XRay][clang] Emit "never-instrument" attribute
Summary:
Before this change, we only emit the XRay attributes in LLVM IR when the
-fxray-instrument flag is provide
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good i guess. I'm glad this is sorted out^^
https://reviews.llvm.org/D51057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
dberris updated this revision to Diff 165407.
dberris retitled this revision from "[XRay][clang] Always emit XRay attributes
for LLVM IR" to "[XRay][clang] Emit "never-instrument" attribute".
dberris added a comment.
Retitle, add different test case for -fno-xray-instrument.
https://reviews.llv
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks as expected. I hope that assertion does actually hold. Should AST folks
have a look as well?
Comment at: clang/lib/AST/Stmt.cpp:310
+ return *Out / alignof(Stmt);
+
+}
glaubitz created this revision.
glaubitz added reviewers: kristina, dschuff.
Herald added subscribers: cfe-commits, nemanjai.
On powerpc-linux-gnuspe, the header files are located in their
own include directory named /usr/lib/powerpc-linux-gnuspe,
so add this directory to PPCMultiarchIncludeDirs.
Author: rtrieu
Date: Thu Sep 13 18:15:28 2018
New Revision: 342199
URL: http://llvm.org/viewvc/llvm-project?rev=342199&view=rev
Log:
[ODRHash] Fix early exit that skipped code.
There is a bit of code at the end of AddDeclaration that should be run on
every exit of the function. However, there wa
rsmith added inline comments.
Comment at: clang/include/clang/Driver/CC1Options.td:356-357
+HelpText<"Enable VTable interleaving">;
+def disable_vtable_interleaving : Flag<["-"], "disable-vtable-interleaving">,
+HelpText<"Disable VTable interleaving">;
//===
Author: maskray
Date: Thu Sep 13 17:56:11 2018
New Revision: 342198
URL: http://llvm.org/viewvc/llvm-project?rev=342198&view=rev
Log:
[clangd] Fix TUScheduler typos
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
clang-tools-extra/trunk/clangd/TUScheduler.h
Modified: clang-tools
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great to me and pretty trivial, should somebody who's more familiar with
this code take a look?
Comment at: clang/lib/AST/StmtPrinter.cpp:72
PrintingPolicy Policy;
+
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: vedantk
Date: Thu Sep 13 17:16:37 2018
New Revision: 342196
URL: http://llvm.org/viewvc/llvm-project?rev=342196&view=rev
Log:
Relax alignment assumptions in a test after r342194
Don't hardcode align 8.
Fixes a bot failure:
http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/6
NoQ added a comment.
What do you think about the following approach:
1. Define a `lit` substitution `%diff_plist` that resolves to `diff -u -w -I
"/" -I ".:" -I "version" -`.
2. Update these flags in your downstream fork.
It's kinda cool because it'll allow us to test exactly what we want in th
vsk updated this revision to Diff 165403.
vsk marked an inline comment as done.
https://reviews.llvm.org/D52064
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Frontend/FrontendActions.cpp
clang/lib/Sema/SemaLambda.cpp
clang/lib/Sema/Sem
vsk added inline comments.
Comment at: clang/test/SemaCXX/lambda-expressions.cpp:87
+(void)^{ // expected-error@+1 {{no matching constructor for initialization
of 'const G'}}
+ return [=]{ // expected-error@+1 {{no matching constructor for
initialization of 'const G'}}
Author: vedantk
Date: Thu Sep 13 16:50:20 2018
New Revision: 342195
URL: http://llvm.org/viewvc/llvm-project?rev=342195&view=rev
Log:
Update a clang-tidy test for r342194
The location of implicit captures has changed. Update a use-after-move
checker test to reflect that.
This fixes a bot failure
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaLambda.cpp:1427
if (RefResult.isInvalid())
return ExprError();
Expr *Ref = RefResult.get();
This early exit leaves your CodeSynthesisContext on the stack. Consider using
RAII?
vsk created this revision.
vsk added reviewers: rsmith, erichkeane.
When it's not possible to initialize an implicit capture, add a note
pointing to the first use of the captured variable.
Example (the `note` is new):
lambda-expressions.cpp:81:15: error: no matching constructor for initializatio
zhaomo added inline comments.
Comment at: compiler-rt/test/cfi/lit.cfg:33
dso = '-fsanitize-cfi-cross-dso -fvisibility=default '
+ interleave = '-Xclang -enable-vtable-interleaving
-Wl,-plugin-opt,-enable-vtable-interleaving -Wl,-plugin-opt=save-temps
-fno-sanitize=cfi-mfca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342194: [Sema] Remove location from implicit capture init
expr (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50927?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342194: [Sema] Remove location from implicit capture init
expr (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50927?vs=162918&id=165400#toc
Repository:
rL LL
Author: vedantk
Date: Thu Sep 13 16:28:25 2018
New Revision: 342194
URL: http://llvm.org/viewvc/llvm-project?rev=342194&view=rev
Log:
[Sema] Remove location from implicit capture init expr
A lambda's closure is initialized when the lambda is declared. For
implicit captures, the initialization cod
erik.pilkington added a comment.
Looks good to me! @rsmith should probably have the final word though. Thanks
for fixing this.
Repository:
rC Clang
https://reviews.llvm.org/D51997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
zhaomo added inline comments.
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:939
+/// We should only interleave vtables when the module has the hidden
+/// LTO visibility, cfi-vcall is enabled and EnableVTableInterleaving
vlad.tsyrklevich wrote:
> doxygen comm
aaronpuchert planned changes to this revision.
aaronpuchert added a comment.
This doesn't work with loops yet:
void relockLoop() {
RelockableExclusiveMutexLock scope(&mu);
while (b) {
scope.Unlock(); // releasing mutex 'scope' that was not held
scope.Lock(); // acquirin
Author: rsmith
Date: Thu Sep 13 15:47:33 2018
New Revision: 342192
URL: http://llvm.org/viewvc/llvm-project?rev=342192&view=rev
Log:
Fix crash on call to __builtin_memcpy with a null pointer to an
incomplete type.
Also improve the diagnostics for similar situations.
Modified:
cfe/trunk/inclu
rsmith added a comment.
Thank you!
Comment at: include/clang/Basic/DiagnosticASTKinds.td:172
"non-trivially-copyable type %1">;
+def note_constexpr_memcpy_incompletetype : Note<
+ "cannot constant evaluate '%select{memcpy|memmove}0' between objects of "
Nit
ldionne added a comment.
I created https://bugs.llvm.org/show_bug.cgi?id=38942 to keep track of the
problem for partial specializations and explicit specializations. Moving
forward with this patch will allow me to land the `no_extern_template`
attribute.
Repository:
rC Clang
https://review
kristina added a comment.
Fine with me, I wasn't really suggesting a revision just making a remark more
or less. Sorry if it came off that way.
Repository:
rC Clang
https://reviews.llvm.org/D51921
___
cfe-commits mailing list
cfe-commits@lists.l
Author: rsmith
Date: Thu Sep 13 14:10:08 2018
New Revision: 342177
URL: http://llvm.org/viewvc/llvm-project?rev=342177&view=rev
Log:
Diagnose likely typos in #include directives.
Summary:
When someone writes
#include ""
or
#include " some_file "
the compiler returns "file not fuond..." wi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342177: Diagnose likely typos in #include directives.
(authored by rsmith, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51333?vs=165361&id=
ldionne updated this revision to Diff 165375.
ldionne added a comment.
Drop support for partial specializations and explicit specializations.
Address comments by Erik.
Repository:
rC Clang
https://reviews.llvm.org/D51997
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/test/Se
ldionne added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268
+ // Instantiate the attributes on both the template declaration and the
associated record declaration.
+ SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, LateAttrs,
Sta
sammccall added a comment.
(Just checking - IIUC neither of you are asking for changes, and this is
waiting on review of the latest snapshot?)
Repository:
rC Clang
https://reviews.llvm.org/D51921
___
cfe-commits mailing list
cfe-commits@lists.ll
calixte added inline comments.
Comment at: include/clang/Driver/CC1Options.td:236
+def coverage_exclude_EQ : Joined<["-"], "coverage-exclude=">,
+ Alias;
def coverage_exit_block_before_body : Flag<["-"],
"coverage-exit-block-before-body">,
vsk wrote:
> Have yo
ormris created this revision.
ormris added reviewers: dblaikie, aprantl, probinson, JDevlieghere, clayborg,
jingham.
This patch adds the associated template parameters to the DWARF name attribute
of all template variable specializations, mirroring how they are referenced in
the source code.
Orig
lebedev.ri added a comment.
In https://reviews.llvm.org/D51949#1233951, @JonasToth wrote:
> Yes, do you think it should be included in the diag?
Yes, please :) Else, the message seems a bit too empty.
I **don't** think it should point (via `NOTE:`) at the each decl though.
> Am 13.09.2018 um 2
JonasToth added a comment.
Yes, do you think it should be included in the diag?
Am 13.09.2018 um 22:09 schrieb Roman Lebedev via Phabricator:
> lebedev.ri added inline comments.
>
>
> Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:200
> +
> + diag(WholeDecl->getBeg
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:200
+
+ diag(WholeDecl->getBeginLoc(), "make only one declaration per statement")
+ << FixItHint::CreateReplacement(WholeDecl->getSourceRange(),
Replacement);
I think
christylee updated this revision to Diff 165361.
christylee added a comment.
Added tests.
https://reviews.llvm.org/D51333
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPDirectives.cpp
test/Preprocessor/empty_file_to_include.h
test/Preprocessor/include-likely-typo.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342165: Support -fno-omit-frame-pointer with -pg. (authored
by srhines, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51713
Files:
cfe/trunk/
Author: srhines
Date: Thu Sep 13 12:50:02 2018
New Revision: 342165
URL: http://llvm.org/viewvc/llvm-project?rev=342165&view=rev
Log:
Support -fno-omit-frame-pointer with -pg.
Summary:
Previously, any instance of -fomit-frame-pointer would make it such that
-pg was an invalid flag combination. If
sammccall accepted this revision.
sammccall added a comment.
Awesome, thank you.
Just a couple of last nits.
Comment at: unittests/clangd/ClangdTests.cpp:984
+std::vector Diagnostics) override {
+ std::lock_guard Lock(Mutex);
+ for(const Di
vsk added a comment.
Please document the filter behavior (see docs/UsersManual.rst).
Comment at: include/clang/Driver/CC1Options.td:236
+def coverage_exclude_EQ : Joined<["-"], "coverage-exclude=">,
+ Alias;
def coverage_exit_block_before_body : Flag<["-"],
"coverage-exit-bl
lebedev.ri added a comment.
The tests seem to have disappeared form the diff.
https://reviews.llvm.org/D51333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
christylee added a comment.
@rsmith , thanks for the review, I fixed the variable capitalization. If you
could land it for me that'll be awesome!
In https://reviews.llvm.org/D51333#1233042, @sammccall wrote:
> One thing I'd like to do sometime is add code completion of filenames in
> #include
christylee updated this revision to Diff 165350.
https://reviews.llvm.org/D51333
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPDirectives.cpp
Index: lib/Lex/PPDirectives.cpp
===
--- lib/Lex/PPDirectives.cpp
+++ lib
christylee updated this revision to Diff 165349.
https://reviews.llvm.org/D51333
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPDirectives.cpp
Index: lib/Lex/PPDirectives.cpp
===
--- lib/Lex/PPDirectives.cpp
+++ lib
xbolva00 added a comment.
Where here, I would love to have a fixint hints for unknown functions.
E.g.
std::forward somewhere in code-> fixit: "try to add #include "
https://reviews.llvm.org/D51333
___
cfe-commits mailing list
cfe-commits@lists.llvm
glaubitz created this revision.
glaubitz added reviewers: rsmith, dschuff.
Herald added a subscriber: cfe-commits.
When targeting x32, the x32 libraries and headers should be used, not
the x86_64 ones (which may not even be available), so prioritise those
and use the right multiarch triple.
Repo
glaubitz added a comment.
I have pushed a rebase revision here: https://reviews.llvm.org/D52050
I have no idea how to edit the author though.
Repository:
rC Clang
https://reviews.llvm.org/D43630
___
cfe-commits mailing list
cfe-commits@lists.llv
glaubitz added a comment.
I don't think that "test/Driver/linux-header-search.cpp" needs to be updated.
x32 is actually supported in both an x86_64-linux-gnu environment and
x86_64-linux-gnux32 environment. In order to update
test/Driver/linux-header-search.cpp, we would have to add a debian-10
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good (with a couple of minor code style adjustments). Do you need someone
to commit this for you?
In https://reviews.llvm.org/D51333#1233042, @sammccall wrote:
> One thing I'd like to d
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268
+ // Instantiate the attributes on both the template declaration and the
associated record declaration.
+ SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, LateAttrs,
Star
glaubitz added a comment.
I have just rebased the patch and I am looking at the tests now.
Repository:
rC Clang
https://reviews.llvm.org/D43630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
lebedev.ri added a comment.
In https://reviews.llvm.org/D52008#1233667, @shuaiwang wrote:
> Just some quick comments, I'll take a deeper look into other comments later.
>
> This diff along unfortunately won't be able to handle `emplace_back` just yet
My apologies, for some reason i though it wa
JonasToth added a comment.
In https://reviews.llvm.org/D52008#1233667, @shuaiwang wrote:
> Just some quick comments, I'll take a deeper look into other comments later.
>
> This diff along unfortunately won't be able to handle `emplace_back` just
> yet, the reason (I believe, haven't fully tested
ldionne marked 2 inline comments as done.
ldionne added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268
+ // Instantiate the attributes on both the template declaration and the
associated record declaration.
+ SemaRef.InstantiateAttrsForDecl(Te
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:35
+namespace {
+SourceLocation findNextTerminator(SourceLocation Start, const SourceManager
&SM,
+ const LangOptions &LangOpts) {
Remove du
shuaiwang added a comment.
Just some quick comments, I'll take a deeper look into other comments later.
This diff along unfortunately won't be able to handle `emplace_back` just yet,
the reason (I believe, haven't fully tested) is that `std::forward` is not
handled properly and almost all std f
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
While this looks like misuse of benchmark library, this can be still when
experimenting with ind
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342155: [clangd] Introduce PostingList interface (authored
by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51982?vs=165324&id=165325#toc
Repository:
rCTE Clang Tools
Author: omtcyfz
Date: Thu Sep 13 10:11:03 2018
New Revision: 342155
URL: http://llvm.org/viewvc/llvm-project?rev=342155&view=rev
Log:
[clangd] Introduce PostingList interface
This patch abstracts `PostingList` interface and reuses existing
implementation. It will be used later to test different `
kbobyrev updated this revision to Diff 165324.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Pull `DocID` to `Iterator.h`.
https://reviews.llvm.org/D51982
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/cla
tra added a comment.
@rsmith ping.
https://reviews.llvm.org/D51808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth updated this revision to Diff 165321.
JonasToth added a comment.
This is the newer and better working code to slice and separate multiple
vardecls in a multi-decl stmt.
I want this version only for now, as the multiple variable definitions in one
statement are by far the most common vari
Author: erichkeane
Date: Thu Sep 13 09:58:24 2018
New Revision: 342152
URL: http://llvm.org/viewvc/llvm-project?rev=342152&view=rev
Log:
[NFC]Refactor MultiVersion Resolver Emission to combine types
Previously, both types (plus the future target-clones) of
multiversioning had a separate ResolverO
Author: abataev
Date: Thu Sep 13 09:54:05 2018
New Revision: 342151
URL: http://llvm.org/viewvc/llvm-project?rev=342151&view=rev
Log:
[OPENMP] Fix PR38903: Crash on instantiation of the non-dependent
declare reduction.
If the declare reduction construct with the non-dependent type is
defined in t
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:39
#include
+#include "PostingList.h"
kbobyrev wrote:
> sammccall wrote:
> > Why this dep? Seems circular
> `Iterator` interface uses `DocID`, so I guess it should depen
kbobyrev marked an inline comment as done.
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:39
#include
+#include "PostingList.h"
sammccall wrote:
> Why this dep? Seems circular
`Iterator` interface uses `DocID`, so I
kbobyrev updated this revision to Diff 165320.
kbobyrev added a comment.
Wording: traversed *in order*.
https://reviews.llvm.org/D51982
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/clangd/index/dex/Dex.h
clang-tools-extra/cl
kbobyrev updated this revision to Diff 165318.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D51982
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/clangd/index/dex/Dex.h
clang-tools-extra/clangd/index/dex/I
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Great!
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:11
#include "Iterator.h"
+#include "PostingList.h"
#include
And here
==
christylee updated this revision to Diff 165311.
christylee added a comment.
Addressed @rsmith 's comments.
https://reviews.llvm.org/D51333
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPDirectives.cpp
Index: lib/Lex/PPDirectives.cpp
===
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51747#1233499, @kadircet wrote:
> Np, not planning to land it before we figure out the issue with vim can't
> handling lots of diagnostics anyway.
Just wondering: what's the problem with Vim? Slowness? Bad UI for diagnostics
when the
christylee added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1901
+FilenameLoc,
+LangOpts.MSVCCompat ? NormalizedPath.c_str() : Filename, false,
+LookupFrom, LookupFromFile, CurDir,
rsmith wrote:
> You're passing in `
Author: omtcyfz
Date: Thu Sep 13 08:35:55 2018
New Revision: 342143
URL: http://llvm.org/viewvc/llvm-project?rev=342143&view=rev
Log:
[clangd] Fix Dexp build
%s/MaxCandidateCount/Limit/g after rL342138.
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp
Modified: clang-tools-e
kadircet added a comment.
In https://reviews.llvm.org/D51747#1233401, @sammccall wrote:
> In https://reviews.llvm.org/D51747#1233377, @kadircet wrote:
>
> > In https://reviews.llvm.org/D51747#1233371, @sammccall wrote:
> >
> > > Sorry for all the back and forth on this patch, but I have to ask...
kadircet updated this revision to Diff 165302.
kadircet added a comment.
This revision is now accepted and ready to land.
- Turn back to unit tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51747
Files:
clangd/ClangdServer.cpp
unittests/clangd/ClangdTests.cpp
Index:
kbobyrev updated this revision to Diff 165298.
kbobyrev added a comment.
Remove artifacts from assertion messages.
https://reviews.llvm.org/D51982
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/clangd/index/dex/Dex.h
clang-too
kbobyrev updated this revision to Diff 165297.
kbobyrev added a comment.
Don't create abstractions for now.
https://reviews.llvm.org/D51982
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/clangd/index/dex/Dex.h
clang-tools-extr
miyuki created this revision.
miyuki added reviewers: NoQ, dcoughlin, george.karpenkov.
Herald added subscribers: Szelethus, mikhail.ramalho, a.sidorin, szepet,
eraman, xazax.hun.
A recent change https://reviews.llvm.org/D50545 started using diff to
compare plist output against reference output.
sammccall added a comment.
In https://reviews.llvm.org/D51747#1233377, @kadircet wrote:
> In https://reviews.llvm.org/D51747#1233371, @sammccall wrote:
>
> > Sorry for all the back and forth on this patch, but I have to ask... what's
> > up with switching to lit tests?
> >
> > We've mostly start
kbobyrev added a comment.
In https://reviews.llvm.org/D52030#1233395, @kbobyrev wrote:
> In https://reviews.llvm.org/D52030#1233349, @sammccall wrote:
>
> > In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote:
> >
> > > Looks good, thanks!
> > >
> > > While we're here: I'm wondering wheth
kbobyrev added a subscriber: rnk.
kbobyrev added a comment.
In https://reviews.llvm.org/D52030#1233349, @sammccall wrote:
> In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote:
>
> > Looks good, thanks!
> >
> > While we're here: I'm wondering whether we should also introduce very basic
>
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342139: Print correctly dependency paths on Windows
(authored by xbolva00, committed by ).
Repository:
rC Clang
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342138: [clangd] Cleanup FuzzyFindRequest filtering limit
semantics (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52028?vs=165283&id=165284#toc
Repository:
Author: xbolva00
Date: Thu Sep 13 07:27:32 2018
New Revision: 342139
URL: http://llvm.org/viewvc/llvm-project?rev=342139&view=rev
Log:
Print correctly dependency paths on Windows
Summary:
Before:
main.o: main.c ../include/lib\test.h
After:
main.o: main.c ../include/lib/test.h
Fixes PR38877
Rev
1 - 100 of 210 matches
Mail list logo
