lebedev.ri added a comment.

In https://reviews.llvm.org/D52008#1233667, @shuaiwang wrote:

> Just some quick comments, I'll take a deeper look into other comments later.
>
> This diff along unfortunately won't be able to handle `emplace_back` just yet


My apologies, for some reason i though it was supposed to.
Once again, thank you for working on this!

> , the reason (I believe, haven't fully tested) is that `std::forward` is not 
> handled properly and almost all std functions involving forwarding references 
> at least `std::forward`'ed once.
>  I have some more changes locally that treats `std::move` and `std::forward` 
> just as casts and that should be able to really push the analysis further 
> down the forwarding chain instead of stopping at `std::forward` call.



> Rephased diff description to be more clear. Sorry for the confusion.

No problem!


Repository:
  rC Clang

https://reviews.llvm.org/D52008



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to