MTC added a comment.
LGTM, @NoQ May have further feedback. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb added a comment.
In https://reviews.llvm.org/D47290#1126443, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote:
>
> > Okay, that's fair, but the vendor-specific type for my Windows example is
> > spelled `DWORD`. I'm really worried that this special cas
leonardchan added inline comments.
Comment at: include/clang/AST/Type.h:6552
+// as a scaled integer.
+std::string FixedPointValueToString(unsigned Radix, unsigned Scale,
+uint64_t Val);
ebevhan wrote:
> This should probably ta
leonardchan updated this revision to Diff 150602.
leonardchan marked 14 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D46915
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Expr.h
include/clang/AST/OperationKinds.def
include/clang/AST/RecursiveASTVisito
Higuoxing marked 3 inline comments as done.
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1126607, @dexonsmith wrote:
> In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D47687#1126032, @Higuoxing wrote:
> >
> > > In https://reviews.l
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
Well, I don't think that pointing out that we shouldn't convert strings between
UTF8 and UTF16 back and forth is nitpicking, but yeah, this has already been
addressed, so feel free to submit. LGTM
Author: ctopper
Date: Fri Jun 8 17:30:45 2018
New Revision: 334339
URL: http://llvm.org/viewvc/llvm-project?rev=334339&view=rev
Log:
Use SmallPtrSet instead of SmallSet in places where we iterate over the set.
SmallSet forwards to SmallPtrSet for pointer types. SmallPtrSet supports
iteration, b
thakis added a comment.
ruiu: This review has now gone on for a week, with one cycle per day due to
timezones. Since the comments are fairly minor nits, do you think you could
address them yourself while landing this, in the interest of not spending
another week on this?
https://reviews.llvm.
vsapsai added a comment.
In https://reviews.llvm.org/D45015#1121762, @EricWF wrote:
> In https://reviews.llvm.org/D45015#1121581, @ahatanak wrote:
>
> > Could you elaborate on what kind of changes you are planning to make in
> > libc++ after committing this patch?
>
>
> Libc++ shouldn't actually
vsapsai added a comment.
Sorry for the churn but can you please take out `-nostdinc++` part out of this
change? After more thinking and discussion we think there is a chance
developers can use `-nostdinc++` not only for building the standard library.
`-nostdinc++` is a signal of building the st
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
emmettneyman created this revision.
emmettneyman added reviewers: kcc, morehouse, vitalybuka.
Herald added a subscriber: cfe-commits.
Cahnged the function signature and removed conditionals from loop body.
Repository:
rC Clang
https://reviews.llvm.org/D47964
Files:
tools/clang-fuzzer/cxx_l
vsapsai added inline comments.
Comment at: lib/Lex/HeaderSearch.cpp:683
+ // from Foo.framework/PrivateHeaders, since this violates public/private
+ // api boundaries and can cause modular dependency cycles.
+ if (!IsIncluderPrivateHeader && IsIncludeeInFramework &&
--
Author: ctopper
Date: Fri Jun 8 15:19:42 2018
New Revision: 334334
URL: http://llvm.org/viewvc/llvm-project?rev=334334&view=rev
Log:
[X86] Add avx512 feature flags to __builtin_ia32_select*.
There are many masked intrinsics that just wrap a select around a legacy
intrinsic from a pre-avx512 ins
Author: ctopper
Date: Fri Jun 8 14:50:08 2018
New Revision: 334331
URL: http://llvm.org/viewvc/llvm-project?rev=334331&view=rev
Log:
[X86] Add back some masked vector truncate builtins. Custom IRgen a a few
others.
I'd like to make the select builtins require an avx512f, avx512bw, or avx512vl
Author: ctopper
Date: Fri Jun 8 14:50:07 2018
New Revision: 334330
URL: http://llvm.org/viewvc/llvm-project?rev=334330&view=rev
Log:
[X86] Fold masking into subvector extract builtins.
I'm looking into making the select builtins require avx512f, avx512bw, or
avx512vl since masking operations ge
gtbercea added a comment.
I just stumbled upon a very interesting situation.
I noticed that, for OpenMP, the use of device math functions happens as I
expected for -O0. For -O1 or higher math functions such as "sqrt" resolve to
llvm builtins/intrinsics:
call double @llvm.sqrt.f64(double %1)
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
ruiu added inline comments.
Comment at: llvm/lib/Support/Windows/Process.inc:216
+ wchar_t ModuleName[MAX_PATH];
+ int Length = ::GetModuleFileNameW(NULL, ModuleName, MAX_PATH);
+ if (Length == 0 || Length == MAX_PATH) {
Can't this be size_t?
https://reviews
ruiu added inline comments.
Comment at: llvm/lib/Support/Windows/Process.inc:227
return mapWindowsError(GetLastError());
- if (Length > LongPath.capacity()) {
+ if (static_cast(Length) > MAX_PATH) {
// We're not going to try to deal with paths longer than MAX_PATH, so
Author: sammccall
Date: Fri Jun 8 14:17:19 2018
New Revision: 334323
URL: http://llvm.org/viewvc/llvm-project?rev=334323&view=rev
Log:
[clangd] Deduplicate CompletionItemKind conversion.
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeC
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D47958#1126875, @tra wrote:
> Drive-by review:
>
> The patch could use a better description.
> Something that describes *what* the patch does (E.g. enforce that attributes
> X/Y/Z are only applied to __
ormris marked 3 inline comments as done.
ormris added a comment.
Thanks for the comments so far.
Comment at: test/Analysis/loop-widening-invalid-type.cpp:1
+// RUN: %clang_cc1 -analyze
-analyzer-checker=core,unix.Malloc,debug.ExprInspection -analyzer-max-loop 4
-analyzer-conf
ormris updated this revision to Diff 150567.
ormris added a comment.
Herald added a subscriber: mikhail.ramalho.
- Reformat with clang-format-diff.py
- Rename test
- Modify test to use clang_analyzer_eval
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
include/clang/StaticAnaly
tra added a comment.
Drive-by review:
The patch could use a better description.
Something that describes *what* the patch does (E.g. enforce that attributes
X/Y/Z are only applied to __global__ functions.)
*why* the change is needed is relevant, too, but it's not very useful without
the *what*
thanks!
On Fri, Jun 8, 2018 at 1:31 PM Sam McCall wrote:
> Oops, thank you!
> r334315 should fix this.
>
>
>
> On Fri, Jun 8, 2018 at 9:45 PM Kostya Serebryany wrote:
>
>> Looks like this broke the clang-fuzzer:
>> https://oss-fuzz-build-logs.storage.googleapis.com/index.html
>>
>> Step #4:
>>
Oops, thank you!
r334315 should fix this.
On Fri, Jun 8, 2018 at 9:45 PM Kostya Serebryany wrote:
> Looks like this broke the clang-fuzzer:
> https://oss-fuzz-build-logs.storage.googleapis.com/index.html
>
> Step #4:
> /src/llvm/tools/clang/tools/extra/clangd/fuzzer/ClangdFuzzer.cpp:31:17:
>
Author: sammccall
Date: Fri Jun 8 13:25:05 2018
New Revision: 334315
URL: http://llvm.org/viewvc/llvm-project?rev=334315&view=rev
Log:
[clangd] Fix fuzzer after r333993
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuz
yaxunl updated this revision to Diff 150559.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Wrap long RUN lines in test.
https://reviews.llvm.org/D47733
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/TargetInfo.cpp
lib/CodeGen/TargetInfo.h
te
lahwaacz added a comment.
This revision does not do the right thing because it makes it impossible to use
the std::min and std::max functions in __host__ __device__ functions under
C++14: https://bugs.llvm.org/show_bug.cgi?id=37753
Repository:
rC Clang
https://reviews.llvm.org/D46993
___
yaxunl created this revision.
yaxunl added a reviewer: kzhuravl.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng.
There are HIP applications e.g. Tensorflow 1.3 using amdgpu kernel attributes.
https://reviews.llvm.org/D47958
Files:
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCUDA/
Looks like this broke the clang-fuzzer:
https://oss-fuzz-build-logs.storage.googleapis.com/index.html
Step #4: /src/llvm/tools/clang/tools/extra/clangd/fuzzer/ClangdFuzzer.cpp:31:17:
error: no viable conversion from 'std::istringstream' (aka
'basic_istringstream') to 'std::FILE *' (aka '_IO_FILE *
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
This folds together overloads items into a single CompletionItem.
It's full of hacks and breaks all the tests.
We may want to experiment with unfolding them sometimes, but this doesn't
thakis added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:6597
+ (getLangOpts().CPlusPlus17 ||
+ Context.getTargetInfo().getCXXABI().isMicrosoft()))
NewVD->setImplicitlyInline();
Is this related to /Zc:externConstexpr / PR3
jyknight added a comment.
In https://reviews.llvm.org/D47894#1125961, @srhines wrote:
> In https://reviews.llvm.org/D47894#1125728, @jyknight wrote:
>
> > In https://reviews.llvm.org/D47894#1125653, @efriedma wrote:
> >
> > > The problem would come from propagating nonnull-ness from something whi
spatel added a comment.
In https://reviews.llvm.org/D45202#1126616, @craig.topper wrote:
> I'm not sure whether we should be doing this here or in InstCombine. @spatel,
> what do you think?
It's been a while since I looked at these. Last memory I have is for the
conversion from x86 masked ops
rnk created this revision.
rnk added a reviewer: thakis.
Microsoft seems to do this regardless of the language mode, so we must
also do it in order to be ABI compatible.
Fixes PR36125
https://reviews.llvm.org/D47956
Files:
clang/lib/Sema/SemaDecl.cpp
clang/test/CXX/dcl.dcl/dcl.spec/dcl.con
Author: ctopper
Date: Fri Jun 8 11:00:22 2018
New Revision: 334310
URL: http://llvm.org/viewvc/llvm-project?rev=334310&view=rev
Log:
[X86] Change immediate type for some builtins from char to int.
These builtins are all handled by CGBuiltin.cpp so it doesn't much matter what
the immediate type
Author: ctopper
Date: Fri Jun 8 11:00:25 2018
New Revision: 334311
URL: http://llvm.org/viewvc/llvm-project?rev=334311&view=rev
Log:
[X86] Add builtins for vpermq/vpermpd instructions to enable target feature
checking.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/li
paulsemel added a comment.
This version is working for non packed structures. For packed structures, it
might sometimes work, sometimes not.
The resulting assembly code seems to be the right one.
If someone went through bitfields manipulation, please do not hesitate to
comment !
Requesting for h
paulsemel created this revision.
paulsemel added a reviewer: aaron.ballman.
This is an attempt for adding bitfield support to __builtin_dump_struct.
Repository:
rC Clang
https://reviews.llvm.org/D47953
Files:
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
svenvh updated this revision to Diff 150535.
svenvh retitled this revision from "[OpenCL] Support placement new/delete in
Sema" to "[OpenCL] Support new/delete in Sema".
svenvh edited the summary of this revision.
svenvh added a comment.
Relaxed the new/delete restrictions following the Khronos a
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 150531.
sammccall added a comment.
Simplify logic/make more consistent. Couple of extra test cases.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
unittests/clangd/FuzzyMatchTes
craig.topper added a comment.
I'm not sure whether we should be doing this here or in InstCombine. @spatel,
what do you think?
https://reviews.llvm.org/D45202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric.
This is a small code change but vastly reduces noise in code completion results.
The intent of allowing this was to let [sc] ~ "strncpy" and [strcpy] ~ "strn
dexonsmith added a comment.
In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote:
> In https://reviews.llvm.org/D47687#1126032, @Higuoxing wrote:
>
> > In https://reviews.llvm.org/D47687#1125926, @rnk wrote:
> >
> > > @dexonsmith is there someone from Apple who can comment on rdar://8678
Maybe we're checking the range too early. Maybe we need to do it during IR
emission instead of during semantic analysis.
~Craig
On Fri, Jun 8, 2018 at 12:59 AM Martin Storsjö via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, 7 Jun 2018, Craig Topper via cfe-commits wrote:
>
> > Aut
gerazo created this revision.
gerazo added reviewers: a.sidorin, r.stahl.
Herald added a subscriber: cfe-commits.
Importing a function having a struct definition in the parameter list causes a
crash in the importer via infinite recursion. This patch avoids the crash and
reports such functions as
Higuoxing added a comment.
This diff version pass the both `parentheses.c` and `logical-op-parentheses.c`
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Higuoxing updated this revision to Diff 150517.
https://reviews.llvm.org/D47687
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/logical-op-parentheses-in-macros.c
Index: test/Sema/logical-op-parentheses-in-macros.c
sylvestre.ledru added a comment.
This was merged here: https://reviews.llvm.org/D23317
we can close this review
https://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ioeric added a comment.
Here are some numbers by completing "clang::^" 40 times (with result limit 1000
instead of 100).
Timing in `CodeCompleteFlow::measureResults`
Before: Avg: 1811 us Med: 1792 us
After: Avg: 2714 us Med: 2689 us
As a reference, a full CodeCompleteFlow (with 1000 candi
Anastasia requested changes to this revision.
Anastasia added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
svenvh wrote:
> rjmccall wrote:
> > I think a better interpretation of this r
MTC added a comment.
I didn't test the code, but the code seems correct. Thanks!
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:88
+ MatchFinder Finder;
+ Finder.addMatcher(varDecl(hasType(referenceType())).bind("match"), new
Callback(LCtx, MRMgr, ITraits));
+ Finder.
pilki created this revision.
pilki added a reviewer: alexfh.
Herald added a subscriber: cfe-commits.
Add support for arrays (and structure that use naked pointers for their
iterator, like std::array) in performance-implicit-conversion-in-loop
Repository:
rCTE Clang Tools Extra
https://review
takuto.ikuta marked 2 inline comments as done.
takuto.ikuta added a comment.
Can the patch be merged this time?
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
takuto.ikuta updated this revision to Diff 150515.
https://reviews.llvm.org/D47578
Files:
llvm/lib/Support/Windows/Process.inc
llvm/unittests/Support/CommandLineTest.cpp
Index: llvm/unittests/Support/CommandLineTest.cpp
===
---
Typz added a comment.
Would it be acceptable to introduce an option to allow enabling this behavior?
I mean would it have a chance of being integrated, or must I keep maintaining a
fork of clang-format...
Repository:
rC Clang
https://reviews.llvm.org/D42787
___
pilki created this revision.
pilki added a reviewer: alexfh.
Herald added subscribers: cfe-commits, jkorous.
Add support for arrays (and structure that use naked pointers for their
iterator, like std::array) in performance-implicit-conversion-in-loop.
Repository:
rCTE Clang Tools Extra
https
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D37813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote:
> Okay, that's fair, but the vendor-specific type for my Windows example is
> spelled `DWORD`. I'm really worried that this special case will become a
> precedent and we'll wind up with -Wformat bei
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334287: [clangd] Require case-insensitive prefix match for
macro completions. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: sammccall
Date: Fri Jun 8 06:32:25 2018
New Revision: 334287
URL: http://llvm.org/viewvc/llvm-project?rev=334287&view=rev
Log:
[clangd] Require case-insensitive prefix match for macro completions.
Summary: Macros are terribly spammy at the moment and this offers some relief.
Reviewers:
Higuoxing marked 2 inline comments as done.
Higuoxing added a comment.
Sorry, I will check it and update the test case
Besides, shall I add the macro-parentheses checking test cases to the original
'parentheses.c'?
https://reviews.llvm.org/D47687
lebedev.ri added inline comments.
Comment at: test/Sema/logical-op-parentheses-in-macros.c:3-4
+// RUN:-verify=logical-op-parentheses %s
+// RUN: %clang_cc1 -fsyntax-only %s
+// RUN: %clang_cc1 -Wparentheses -fsyntax-only %s
+
The comment got lost, b
lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:264-265
def LogicalOpParentheses: DiagGroup<"logical-op-parentheses">;
+def LogicalOpParenthesesInMacros:
DiagGroup<"logical-op-parentheses-in-macros">;
def LogicalNotParentheses: DiagGroup<"
Higuoxing updated this revision to Diff 150507.
Higuoxing marked 4 inline comments as done.
Higuoxing added a comment.
Hope this not disturb you too much : ) thanks
https://reviews.llvm.org/D47687
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
li
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM. Looks like LLDB has some uses of VersionTuple, you should fix those to
#include the LLVM version before removing the header here. (Or, better yet, do
it all atomically
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for adding the test!
Repository:
rL LLVM
https://reviews.llvm.org/D47887
___
cfe-commits mailing list
cfe-commi
lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:264-265
def LogicalOpParentheses: DiagGroup<"logical-op-parentheses">;
+def LogicalOpParenthesesInMacros:
DiagGroup<"logical-op-parentheses-in-macros">;
def LogicalNotParentheses: DiagGroup<"
Higuoxing updated this revision to Diff 150495.
Higuoxing added a comment.
Update without conflict with test case `parentheses.c`... I add a separate
option [-Wlogical-op-parentheses-in-macros] and will be silence by default
thanks
https://reviews.llvm.org/D47687
Files:
include/clang/Basic/
ioeric added a comment.
In https://reviews.llvm.org/D47935#1126283, @sammccall wrote:
> Can you benchmark this? I'm nervous about the URI stuff in the hot path.
> Timing CodeCompleteFlow::measureResults before/after with index enabled
> seems like a reasonable test.
> (But you might want to ma
sammccall added a comment.
Going to put this on hold until someone actually reports the bug.
Repository:
rC Clang
https://reviews.llvm.org/D47896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Agreed: supported architectures are v7/A32/A64.
https://reviews.llvm.org/D47446
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
QF5690 updated this revision to Diff 150487.
QF5690 added a comment.
Remove warning for `Class` type, change warning message.
Repository:
rC Clang
https://reviews.llvm.org/D44539
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaObjC
sammccall added a comment.
Oops, couple more comments.
But the big things I think are:
- what's the performance impact of doing all this work (including the URI
stuff) inside the scoring loop?
- what's the most useful formula for the proximity score
Comment at: clangd/Quality
sammccall added a comment.
Can you benchmark this? I'm nervous about the URI stuff in the hot path.
Timing CodeCompleteFlow::measureResults before/after with index enabled seems
like a reasonable test.
(But you might want to make this apply to sema first too for realistic numbers?)
===
kosarev added a comment.
Ping.
https://reviews.llvm.org/D47446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334281: [CUDA] Fix emission of constant strings in sections
(authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47902?vs=15
Author: hahnfeld
Date: Fri Jun 8 04:17:08 2018
New Revision: 334281
URL: http://llvm.org/viewvc/llvm-project?rev=334281&view=rev
Log:
[CUDA] Fix emission of constant strings in sections
CGM.GetAddrOfConstantCString() sets the adress of the created GlobalValue
to unnamed. When emitting the object
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47937
Files:
clangd/CodeComplete.cpp
clangd/index/Index.h
Index: clangd/index/Index.h
===
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
I like this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
ioeric updated this revision to Diff 150477.
ioeric added a comment.
- Rebase again...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
unittests/clangd/TestFS.cpp
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Macros are terribly spammy at the moment and this offers some relief.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47936
Files:
clang
ioeric updated this revision to Diff 150475.
ioeric added a comment.
Rebase on https://reviews.llvm.org/D47931
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Q
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Also move unittest: URI scheme to TestFS so that it can be shared by
different tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
F
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334274: [clangd] Downrank symbols with reserved names
(score *= 0.1) (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47707?vs=150115&id=150469#toc
Repositor
Author: sammccall
Date: Fri Jun 8 02:36:34 2018
New Revision: 334274
URL: http://llvm.org/viewvc/llvm-project?rev=334274&view=rev
Log:
[clangd] Downrank symbols with reserved names (score *= 0.1)
Reviewers: ilya-biryukov
Subscribers: klimek, ioeric, MaskRay, jkorous, cfe-commits
Differential R
Higuoxing added a comment.
Thanks, let me have a try
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
+ there will need to be a new standalone test for
`-Wlogical-op-parentheses-in-macros`,
what it does, how it relates to `-Wlogical-op-parentheses`,`-Wparentheses`, etc.
Comment at: include/clang/Basic/DiagnosticGroups.td:264-265
def LogicalOpParent
Higuoxing updated this revision to Diff 150465.
Higuoxing added a comment.
I step out a little further... I made an attempt to add a new warning
`[-Wlogical-op-parentheses-in-macros]`. Comparing to the previous one, which do
you prefer? I am new to llvm community, and as you see, this is my firs
krasimir requested changes to this revision.
krasimir added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Format/BreakableToken.cpp:327
+ TokenText.substr(2, TokenText.size() - 4)
+ .split(Lines, TokenText.count('\r') > 0 ? "\r\n" : "\n");
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, sorry for the delay
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
___
cfe-commits mailing list
cfe-co
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47896#1126171, @sammccall wrote:
> Hmm, musl does `#define stderr (stderr)` :-( And they discussed #define
> stderr (stderr+0).
> (To enforce it's not assigned to etc)
> https://github.com/cloudius-systems/musl/blob/master/include/std
sammccall added a comment.
Hmm, musl does `#define stderr (stderr)` :-( And they discussed #define stderr
(stderr+0).
(To enforce it's not assigned to etc)
https://github.com/cloudius-systems/musl/blob/master/include/stdio.h#L61
Ilya also pointed out offline the windows API convention: CreateFil
hans updated this revision to Diff 150462.
hans added a comment.
Falling back to the "Otherwise, number using $S" code for non-empty enums.
https://reviews.llvm.org/D47875
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenCXX/mangle-ms-cxx11.cpp
Index: test/CodeGenCXX/mangle-ms-cxx11.cpp
===
Author: hokein
Date: Fri Jun 8 01:19:22 2018
New Revision: 334270
URL: http://llvm.org/viewvc/llvm-project?rev=334270&view=rev
Log:
[clang-tidy] Improve string type matcher for abseil-string-find-starts-with
check.
Summary:
This patch improves the check to match the desugared "string" type (so
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334270: [clang-tidy] Improve string type matcher for
abseil-string-find-starts-with… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
1 - 100 of 104 matches
Mail list logo
