Ka-Ka added a reviewer: JDevlieghere.
Ka-Ka added a comment.
Added Jonas Devlieghere as reviewer as he was involved in the review of
https://reviews.llvm.org/rL327851 (which seems to be the reason for this patch).
https://reviews.llvm.org/D45686
__
Thanks. :)
On Fri, May 25, 2018, 7:56 PM Richard Smith wrote:
> Congratulations?
>
> On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: gbiv
>> Date: Fri May 25 19:29:14 2018
>> New Revision: 33
>>
>> URL: http://llvm.org/viewvc/
Congratulations?
On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Date: Fri May 25 19:29:14 2018
> New Revision: 33
>
> URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
> Log:
> Test commit; please ignore.
>
> Modi
Author: gbiv
Date: Fri May 25 19:29:14 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
Test commit; please ignore.
Modified:
cfe/trunk/lib/Sema/SemaAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaAttr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
vsapsai planned changes to this revision.
vsapsai added a comment.
After looking into this more, I think there are 2 different bugs: one with
infinite loop and another with `DelayedTypos.empty() && "Uncorrected typos!"`
assertion. And disabling typo correction happened to fix both of them.
Infi
NoQ added inline comments.
Comment at: test/Analysis/cxx17-mandatory-elision.cpp:185-191
+// Check if the last destructor is an automatic destructor.
+// A temporary destructor would have fired by now.
+#if __cplusplus >= 201703L
+clang_analyzer_eval(v.len == 1); // e
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
The refactoring conducted in https://reviews.llvm.org/D47304 made it easy for
the analyzer to find the target region for
NoQ added a comment.
The remaining slowness is in `removeDead()`. It's going to be fun to optimize.
Some parts of it are already memoized (eg. the live set in `SymbolReaper`).
Memory usage on the artificial test seems stable.
Repository:
rC Clang
https://reviews.llvm.org/D47402
_
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D47340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
george.karpenkov added a comment.
@NoQ we should make sure the memory is not exploding and that we don't make the
analyzer slower in other cases. Though we could commit this, and then let CI
figure out potential regressions.
Repository:
rC Clang
https://reviews.llvm.org/D47402
__
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1626-1627
+
+ // Casting to pointer that does not carry dynamic information (provided
by
+ // invariant.group) requires stripping it.
+ Src = Builder.CreateStripInvariantGroup(Src);
-
juliehockett added inline comments.
Comment at: clang-doc/Representation.h:138
+ SymbolID USR =
+ SymbolID(); // Unique identifier for the decl described by this Info.
+ const InfoType IT = InfoType::IT_default; // InfoType of this particular
Info.
ioeric
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
Memoize `SValBuilder::simplifySVal()` so that it didn't try to re-simplify the
same symbolic expression in the same prog
Author: jfb
Date: Fri May 25 17:13:53 2018
New Revision: 27
URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev
Log:
Fix GCC handling of ATOMIC_VAR_INIT
r25 from D47225 added warning checks, and the test was written to be C++11
correct by using ATOMIC_VAR_INIT (note that the com
jfb added a comment.
GCC in libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03 seems to mis-handle
ATOMIC_VAR_INIT:
File
/home/llvm-builder/llvm-buildslave-root/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03/llvm/projects/libcxx/test/libcxx/atomics/diagnose_nonnull.fail.cpp
Line 20: non-aggregate type
NoQ added a comment.
Ouch, this one really got out of hand. Sorry.
Repository:
rC Clang
https://reviews.llvm.org/D41881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC26: [analyzer] Add security checks for bcmp(), bcopy(),
bzero(). (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41881
Files:
include/clang/StaticAnalyzer/
Author: dergachev
Date: Fri May 25 17:04:26 2018
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev
Log:
[analyzer] Add security checks for bcmp(), bcopy(), bzero().
These functions are obsolete. The analyzer would advice to replace them with
memcmp(), memcpy() or m
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:377
+ if (!State->contains(Key)) {
+return State->set(Key, V);
}
george.karpenkov wrote:
> nitpick: most C++ containers eliminate the need for two lookups by allowing
> the `ge
NoQ updated this revision to Diff 148692.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Fix review comments.
https://reviews.llvm.org/D47303
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/Expr
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
If a standard library implements LWG 1203 (which I am implementing in MSVC++
right now) the return value of (istringstream() << A{}) is an rvalue, so it
can't have an lvalue reference bound to it. Change this test
Author: jfb
Date: Fri May 25 16:43:53 2018
New Revision: 25
URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev
Log:
Add nonnull; use it for atomics
Summary:
The atomic non-member functions accept pointers to std::atomic /
std::atomic_flag as well as to the non-atomic value. These a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL25: Add nonnull; use it for atomics (authored by jfb,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47225
Files:
libcxx/trunk/include/__c
Author: gbiv
Date: Fri May 25 16:40:59 2018
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
Fix typo + reflow comment; NFC
Reflow brings said comment below 80 cols
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
Modified: cfe/trunk/include/clang/AST
stephanemoore added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:37-38
/// The acronyms are from
///
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20
NoQ updated this revision to Diff 148684.
NoQ added a comment.
Add an explicit brute-force protection against re-entering `simplifySVal()`.
Remove the threshold completely.
https://reviews.llvm.org/D47155
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
lib/StaticAnalyz
NoQ added a comment.
I only essentially did one optimization - introduce a short path that returns
the original value if visiting its sub-values changed nothing, which is a
relatively common case. The reason it works though is that `evalBinOp()` will
be called later to combine the sub-values, w
Author: ctopper
Date: Fri May 25 15:52:29 2018
New Revision: 21
URL: http://llvm.org/viewvc/llvm-project?rev=21&view=rev
Log:
[X86] Add const to another builtin that was missed from r331814.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cfe/trunk/include/clang/Bas
NoQ updated this revision to Diff 148681.
NoQ added a comment.
Optimize `simplifySVal()` instead of reducing the threshold.
I'll address the memoization separately.
https://reviews.llvm.org/D47155
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
lib/StaticAnalyzer/Core/
Author: ctopper
Date: Fri May 25 15:43:20 2018
New Revision: 20
URL: http://llvm.org/viewvc/llvm-project?rev=20&view=rev
Log:
[X86] Correct the target features on two avx512bw builtins that were
incorrectly labeled as avx512f.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Reverted in r19 because I got failure notices from
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/17262
and (for stage 1, but not stage 2, which is pretty weird)
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10824
The Bots Know when I'm about to go out of town...
Author: probinson
Date: Fri May 25 15:35:59 2018
New Revision: 19
URL: http://llvm.org/viewvc/llvm-project?rev=19&view=rev
Log:
Revert "[DebugInfo] Don't bother with MD5 checksums of preprocessed files."
This reverts commit d734f2aa3f76fbf355ecd2bbe081d0c1f49867ab.
Also known as r11.
Author: sas
Date: Fri May 25 13:23:42 2018
New Revision: 02
URL: http://llvm.org/viewvc/llvm-project?rev=02&view=rev
Log:
Convert clang-interpreter to ORC JIT API
Summary: This mostly re-uses code from the KaleidoscopeJIT example.
Reviewers: ddunbar, lhames
Reviewed By: lhames
Subscrib
trixirt added a comment.
Herald added a reviewer: george.karpenkov.
I need someone to commit this..
Repository:
rC Clang
https://reviews.llvm.org/D41881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
juliehockett updated this revision to Diff 148678.
juliehockett marked 11 inline comments as done.
juliehockett added a comment.
Reworking the reducer interface a bit to address comments.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-do
Author: ctopper
Date: Fri May 25 15:07:43 2018
New Revision: 18
URL: http://llvm.org/viewvc/llvm-project?rev=18&view=rev
Log:
[X86] Mark a few more builtins const that were missed in r331814.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cfe/trunk/include/clang/Ba
gtbercea updated this revision to Diff 148677.
Repository:
rC Clang
https://reviews.llvm.org/D47394
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/Compilation.cp
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:265-276
+ const llvm::APSInt &from = i->From(), &to = i->To();
+ const llvm::APSInt &newFrom = (to.isMinSignedValue() ?
+ BV.getMaxValue(to) :
+
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char
value is always passed through in its entirety, since the default codepage is
something like Windows-1252. The replacement character is
Author: jfb
Date: Fri May 25 14:32:27 2018
New Revision: 17
URL: http://llvm.org/viewvc/llvm-project?rev=17&view=rev
Log:
Fix optional test breakage
It seems GCC and clang disagree. Talked to mclow on IRC, disabling for now.
Modified:
libcxx/trunk/test/std/utilities/optional/optiona
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
(FYI, Please use a weekly frequency for Pings).
Repository:
rCXX libc++
https://reviews.llvm.org/D47225
___
cfe-commits mailing list
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, hfinkel, caomhin, carlo.bertolli, tra.
Herald added subscribers: cfe-commits, guansong.
So far, the clang-offload-bundler has been the default tool for bundling
together various files types produced by the different OpenMP offloa
stephanemoore updated this revision to Diff 148672.
Repository:
rC Clang
https://reviews.llvm.org/D47393
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
--- uni
bob.wilson closed this revision.
bob.wilson added a comment.
Committed in Clang r16
Repository:
rC Clang
https://reviews.llvm.org/D46550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: bwilson
Date: Fri May 25 14:26:03 2018
New Revision: 16
URL: http://llvm.org/viewvc/llvm-project?rev=16&view=rev
Log:
Support Swift calling convention for PPC64 targets
This adds basic support for the Swift calling convention with PPC64 targets.
Patch provided by Atul Sowani in bu
stephanemoore created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D47393
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: jfb
Date: Fri May 25 14:17:43 2018
New Revision: 15
URL: http://llvm.org/viewvc/llvm-project?rev=15&view=rev
Log:
Fix array deduction guide test breakage
No matching constructor
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.cons/deduct.pass.cpp
Modified:
NoQ added a comment.
Ok! Putting any remaining work into follow-up patches would be great indeed.
Let's land this into `alpha.cplusplus` for now because i still haven't made up
my mind for how to organize the proposed `bugprone` category (sorry!).
Comment at: lib/StaticAnalyz
xbolva00 added a comment.
Ok?
https://reviews.llvm.org/D47340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rL11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Herald added a subscriber: llvm-commits.
Chan
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rC11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Changed prior to commit:
https://reviews.ll
Author: probinson
Date: Fri May 25 13:59:29 2018
New Revision: 11
URL: http://llvm.org/viewvc/llvm-project?rev=11&view=rev
Log:
[DebugInfo] Don't bother with MD5 checksums of preprocessed files.
The checksum will not reflect the real source, so there's no clear
reason to include them in t
probinson marked an inline comment as done.
probinson added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
aprantl wrote:
> Can you add a comment e
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Minor comment inline.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
Author: jfb
Date: Fri May 25 13:43:57 2018
New Revision: 08
URL: http://llvm.org/viewvc/llvm-project?rev=08&view=rev
Log:
Fix optional deduction guide test breakage
Modified:
libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.fail.cpp
libcxx/tru
probinson updated this revision to Diff 148663.
probinson added a comment.
Upload patch to suppress checksums when we see a preprocessed file.
https://reviews.llvm.org/D47260
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/test/CodeGen/md5-checksum-crash.c
Author: phosek
Date: Fri May 25 13:39:37 2018
New Revision: 07
URL: http://llvm.org/viewvc/llvm-project?rev=07&view=rev
Log:
[Support] Avoid normalization in sys::getDefaultTargetTriple
The return value of sys::getDefaultTargetTriple, which is derived from
-DLLVM_DEFAULT_TRIPLE, is used t
rsmith added a comment.
In https://reviews.llvm.org/D41039#984009, @ahatanak wrote:
> Yes, please document this in itanium-cxx-abi. Thanks!
Looks like this hasn't happened yet.
Repository:
rL LLVM
https://reviews.llvm.org/D41039
___
cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL02: Convert clang-interpreter to ORC JIT API (authored
by sas, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45897?vs=143376&id=148656#t
Author: abataev
Date: Fri May 25 13:16:03 2018
New Revision: 01
URL: http://llvm.org/viewvc/llvm-project?rev=01&view=rev
Log:
[OPENMP, NVPTX] Fixed codegen for orphaned parallel region.
If orphaned parallel region is found, the next code must be emitted:
```
if(__kmpc_is_spmd_exec_mode()
vsk added a comment.
Ping.
https://reviews.llvm.org/D46918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
trixirt added a comment.
commandeer away!
Sure that is fine.
Repository:
rC Clang
https://reviews.llvm.org/D47260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
In https://reviews.llvm.org/D46845#1105638, @erik.pilkington wrote:
> make __map_node_handle use a const_cast on the key instead of type-punning
> between pair and pair. Add calls to std::launder in key()
> and before inserting a node handle.
Can you do this as a separ
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good!
Do you have commit access? I think you should get commit access.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1650
+
+// If there is a list, but no
leonardchan marked 2 inline comments as done.
leonardchan added inline comments.
Comment at: include/clang/Driver/Options.td:882
+def enable_fixed_point : Flag<["-", "--"], "enable-fixed-point">,
Group,
+ Flags<[CC1Option]>, HelpText<"Enable fixed point
leonardchan updated this revision to Diff 148637.
leonardchan added a comment.
Changed flag names
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommon
Quuxplusone added a comment.
Just commenting to say that this LGTM and I have no further nitpicks. I have
verified that I cannot detect any change in the behavior of
`-Wpessimizing-move` or `-Wreturn-std-move` due to this change (and I //can//
successfully detect the additional copy-elision du
probinson added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
filcab wrote:
> I'd pref
rnk added a comment.
I think the approach makes sense.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.ge
jfb added a comment.
Fixed by r333290.
Repository:
rL LLVM
https://reviews.llvm.org/D47229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jfb
Date: Fri May 25 10:36:49 2018
New Revision: 333290
URL: http://llvm.org/viewvc/llvm-project?rev=333290&view=rev
Log:
Follow-up fix for nonnull atomic non-member functions
Handling of the third parameter was only checking for *_n and not for the C11
variant, which means that cmpxchg
jfb added a comment.
In https://reviews.llvm.org/D47229#1112549, @jakehehrlich wrote:
> This is causing breaks in fuchsia,
>
> Code that looks like this
>
> uintptr_t last_unlogged =
>atomic_load_explicit(&unlogged_tail, memory_order_acquire);
>do {
>if (last_unlogged == 0)
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jakehehrlich added a comment.
This is causing breaks in fuchsia,
Code that looks like this
uintptr_t last_unlogged =
atomic_load_explicit(&unlogged_tail, memory_order_acquire);
do {
if (last_unlogged == 0)
return;
} while (!atomic_compare_exchange_weak_explicit(
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333283: [Sema] Add tests for weak functions (authored by
Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47200?vs=148021&id=148616#t
Author: hahnfeld
Date: Fri May 25 08:56:12 2018
New Revision: 333283
URL: http://llvm.org/viewvc/llvm-project?rev=333283&view=rev
Log:
[Sema] Add tests for weak functions
I found these checks to be missing, just add some simple cases.
Differential Revision: https://reviews.llvm.org/D47200
Modif
probinson added a comment.
@trixirt do you mind if I commandeer this review? I think I have a patch.
Repository:
rC Clang
https://reviews.llvm.org/D47260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
probinson added a comment.
LGTM with the indicated test tweak, but best if @filcab also takes a look.
Comment at: lib/Driver/ToolChains/PS4CPU.cpp:87
+CmdArgs.push_back("--dependent-lib=libSceDbgAddressSanitizer_stub_weak.a");
+ }
+}
Don't bother with brac
yaxunl created this revision.
yaxunl added a reviewer: tra.
CUDA and HIP action builder currently tries to do offloading for -M, which
causes dependency file
not generated.
This patch changes action builder so that only host compilation is performed to
generate dependency
file.
This assumes th
pgousseau created this revision.
pgousseau added reviewers: rsmith, filcab, probinson, gbedwell.
Herald added a subscriber: cfe-commits.
NFC for targets other than PS4.
Simplify users' workflow when enabling asan or ubsan and calling the linker
separately.
Repository:
rC Clang
https://revie
Author: ibiryukov
Date: Fri May 25 07:55:18 2018
New Revision: 333280
URL: http://llvm.org/viewvc/llvm-project?rev=333280&view=rev
Log:
[clangd] Temporarily disable the test that crashes under asan.
It turns out that our fix did not solve the problem completely and the
crash due to stale preamble
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333278: [analyzer] Added a getLValue method to ProgramState
for bases (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer
Author: szelethus
Date: Fri May 25 07:48:33 2018
New Revision: 333278
URL: http://llvm.org/viewvc/llvm-project?rev=333278&view=rev
Log:
[analyzer] Added a getLValue method to ProgramState for bases
Differential Revision: https://reviews.llvm.org/D46891
Modified:
cfe/trunk/include/clang/Stat
ebevhan added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:89
SymMgr(context, BasicVals, alloc), MemMgr(context, alloc),
-StateMgr(stateMgr), ArrayIndexTy(context.LongLongTy),
+StateMgr(stateMgr), ArrayIndexTy
a.sidorin added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:89
SymMgr(context, BasicVals, alloc), MemMgr(context, alloc),
-StateMgr(stateMgr), ArrayIndexTy(context.LongLongTy),
+StateMgr(stateMgr), ArrayIndex
ilya-biryukov updated this revision to Diff 148605.
ilya-biryukov added a comment.
- Rewrote findDecl, it will deserialize decls if needed now
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47331
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/XRefs.cpp
unittest
dstenb updated this revision to Diff 148604.
dstenb added a comment.
Query TheDriver.isSaveTempsEnabled() at uses instead of storing the value in
the constructor.
https://reviews.llvm.org/D45686
Files:
include/clang/Driver/Compilation.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
tzik added inline comments.
Comment at: lib/Sema/Scope.cpp:128
- if (getEntity())
-return;
-
- if (NRVO.getInt())
-getParent()->setNoNRVO();
- else if (NRVO.getPointer())
-getParent()->addNRVOCandidate(NRVO.getPointer());
+ if (getParent())
+getParent()->set
tzik updated this revision to Diff 148603.
tzik added a comment.
reuse getParent() result
Repository:
rC Clang
https://reviews.llvm.org/D47067
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaSt
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:81
ASTContext &getASTContext();
const ASTContext &getASTContext() const;
ioeric wrote:
> IIUC, `ASTContext` in a `ParsedAST` may not contain information from
> preambles and thus may gi
ilya-biryukov updated this revision to Diff 148602.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Rename the field in addition to the getter
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47331
Files:
clangd/ClangdU
sammccall added a comment.
The cache looks way simpler now, thank you!
As discussed offline, flattening ASTBuilder right into ASTWorker still seems
like a good idea to me, but happy with what you come up with there.
Comment at: clangd/TUScheduler.cpp:71
+
+ /// Update the fun
filcab added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
I'd prefer to have the way
Author: yvvan
Date: Fri May 25 06:46:07 2018
New Revision: 333276
URL: http://llvm.org/viewvc/llvm-project?rev=333276&view=rev
Log:
Fix members initialization order in constructor (fails with -Werror)
Modified:
cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
Modified: cfe/trunk/include/c
ilya-biryukov added a comment.
I have addressed the comments regarding the cache implementation. ASTBuilder
ones are still pending, but I would appreciate the feedback on how
`TUScheduler.cpp` looks like.
Comment at: clangd/ClangdUnit.h:132
-/// Manages resources, required
lebedev.ri added a comment.
LGTM, but i'm quite unfamiliar with this area of the code,
so please wait for someone else to accept :)
Comment at: lib/Driver/Compilation.cpp:276-277
+
+ // Temporary files added by diagnostics should be kept.
+ SaveTempsEnabled = true;
}
---
ilya-biryukov updated this revision to Diff 148599.
ilya-biryukov added a comment.
- Rebase, fix merge conflicts
- Simpler implemenataion of the Cache
- s/IdleASTs/ASTCache
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47063
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
dstenb added inline comments.
Comment at: lib/Driver/Compilation.cpp:276-277
+
+ // Temporary files added by diagnostics should be kept.
+ SaveTempsEnabled = true;
}
lebedev.ri wrote:
> Is there a test that breaks without this?
Yes, the following tests fail:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333275: [analyzer] Added template argument lists to the
Pathdiagnostic output (authored by Szelethus, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.o
1 - 100 of 133 matches
Mail list logo
