rtrieu added a comment.
> I believe you were around this code last, so can you remember why it was
> there?
Yes, that's an early exit to speed up the check. You can remove that check and
add a test case for it.
This was a little confusing for me, so let's refactor it a little. These
chang
jloser created this revision.
jloser added reviewers: EricWF, matthew.
Herald added subscribers: cfe-commits, christof.
[libc++] Fix Container::insert(value_type const&) tests
Several unit tests meaning to test the behavior of lvalue insertion incorrectly
pass rvalues. Fixes bug 27394.
Reposi
jdenny added a comment.
In https://reviews.llvm.org/D43248#1035509, @aaron.ballman wrote:
> LGTM with the test comments fixed up.
Thanks! I'll commit tomorrow.
https://reviews.llvm.org/D43248
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with the test comments fixed up.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN:
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp
aaron.ballman wrote:
> Just to verify my und
aaron.ballman added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp
Just to verify my understanding, this
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2
+// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse
+// it here to check -emit-ast for attributes.
+
aaron.ballman wrote:
> jdenny wrote:
> > aaron.ballm
aaron.ballman added a comment.
In https://reviews.llvm.org/D43248#1035477, @jdenny wrote:
> In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote:
>
> > It seems like there are some other changes than just the serialize and
> > deserialize that I'm not opposed to, but am wondering why
simark added a comment.
I uploaded a new patch that moves the draft store to ClangdLSPServer, that
implements what you suggested.
https://reviews.llvm.org/D44408
I will update the incremental sync patch once that patch is in.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D442
simark created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov,
mgorny, klimek.
This patch moves the draft manager closer to the edge of Clangd, from
ClangdServer to ClangdLSPServer. This will make it easier to implement
incremental document sync, by ma
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2
+// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse
+// it here to check -emit-ast for attributes.
+
aaron.ballman wrote:
> Can you move this below the R
jdenny added a comment.
In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote:
> It seems like there are some other changes than just the serialize and
> deserialize that I'm not opposed to, but am wondering why they're needed. It
> seems some functions are now `getFoo()` calls
The
Author: dyung
Date: Mon Mar 12 17:41:44 2018
New Revision: 327354
URL: http://llvm.org/viewvc/llvm-project?rev=327354&view=rev
Log:
Add missing "env" so that test added in r327322 passes on Windows bots.
Modified:
cfe/trunk/test/Index/reparsed-live-issue.cpp
Modified: cfe/trunk/test/Index/re
aaron.ballman added a comment.
It seems like there are some other changes than just the serialize and
deserialize that I'm not opposed to, but am wondering why they're needed. It
seems some functions are now `getFoo()` calls and it seems like some
declarations moved around. Are those intended a
jdenny updated this revision to Diff 138113.
jdenny added a comment.
Well, that didn't work. Here's another attempt at getting the paths right.
https://reviews.llvm.org/D43248
Files:
cfe/trunk/include/clang/AST/Attr.h
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/AST/ExprConstant.c
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CERTTidyModule.cpp:40
// DCL
-CheckFactories.registerCheck(
-"cert-dcl21-cpp");
+CheckFactories.registerCheck("cert-dcl21-cpp");
CheckFactories.registerCheck("cert-dcl50-cpp");
jdenny updated this revision to Diff 138111.
jdenny added a comment.
OK, this diff has the svn paths, and I've rebased to a more recent master.
https://reviews.llvm.org/D43248
Files:
trunk/include/clang/AST/Attr.h
trunk/include/clang/Basic/Attr.td
trunk/lib/AST/ExprConstant.cpp
trunk/li
compnerd closed this revision.
compnerd added a comment.
SVN r327336. Addressed comments in SVN r327351, because I forgot to
incorporate them in the first try.
Repository:
rL LLVM
https://reviews.llvm.org/D44327
___
cfe-commits mailing list
cfe
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327352: [CFG] [analyzer] Don't add construction context
to a return-by-reference call. (authored by dergachev, committed b
Author: dergachev
Date: Mon Mar 12 16:52:36 2018
New Revision: 327352
URL: http://llvm.org/viewvc/llvm-project?rev=327352&view=rev
Log:
[CFG] [analyzer] Don't add construction context to a return-by-reference call.
Call expressions that return objects by an lvalue reference or an rvalue
reference
aaron.ballman added a comment.
Can you regenerate the patch using the same paths as
https://reviews.llvm.org/D43248?id=136811? When I try to do a diff between what
was accepted & committed and the current patch, Phabricator gets confused
because the paths are too different from one another.
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327348: [analyzer] Support temporaries conjured by
conservatively evaluated functions. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44131
Files:
lib/StaticA
Author: dergachev
Date: Mon Mar 12 16:36:12 2018
New Revision: 327348
URL: http://llvm.org/viewvc/llvm-project?rev=327348&view=rev
Log:
[analyzer] Support temporaries conjured by conservatively evaluated functions.
Properly perform destruction and lifetime extension of such temporaries.
C++ obje
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327347: [analyzer] NFC: Move the code for setting temp
object lifetime into method. (authored by dergachev, committed by )
Author: dergachev
Date: Mon Mar 12 16:27:52 2018
New Revision: 327347
URL: http://llvm.org/viewvc/llvm-project?rev=327347&view=rev
Log:
[analyzer] NFC: Move the code for setting temp object lifetime into method.
Differential Revision: https://reviews.llvm.org/D44129
Modified:
cfe/trunk/inclu
Author: juliehockett
Date: Mon Mar 12 16:23:24 2018
New Revision: 327346
URL: http://llvm.org/viewvc/llvm-project?rev=327346&view=rev
Log:
Revert "Reland "[clang-doc] Setup clang-doc frontend framework""
This reverts commit r327295 since it was causing the Windows bots to
fail.
Removed:
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327345: [analyzer] Destroy and lifetime-extend inlined
function return values properly. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44124
Files:
lib/Static
Author: sammccall
Date: Mon Mar 12 16:22:35 2018
New Revision: 327344
URL: http://llvm.org/viewvc/llvm-project?rev=327344&view=rev
Log:
[clangd] Remove Tagged and some related APIs from ClangdServer.
Context can do what Tagged was intended to support (snapshot filesystems),
and less intrusively.
Author: dergachev
Date: Mon Mar 12 16:22:35 2018
New Revision: 327345
URL: http://llvm.org/viewvc/llvm-project?rev=327345&view=rev
Log:
[analyzer] Destroy and lifetime-extend inlined function return values properly.
This patch uses the newly added CFGCXXRecordTypedCall element at the call site
of
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327343: [CFG] [analyzer] Add construction context to C++
return-by-value call elements. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44120?vs=137116&id=1381
Author: dergachev
Date: Mon Mar 12 16:12:40 2018
New Revision: 327343
URL: http://llvm.org/viewvc/llvm-project?rev=327343&view=rev
Log:
[CFG] [analyzer] Add construction context to C++ return-by-value call elements.
This patch adds a new CFGStmt sub-class, CFGCXXRecordTypedCall, which replaces
th
Hi Alex,
The test you added in this commit seems to be failing on the Windows bot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/15855:
FAIL: Clang :: Index/reparsed-live-issue.cpp (7841 of 38815)
TEST 'Clang :: Index/reparsed-live-
Author: rnk
Date: Mon Mar 12 14:43:02 2018
New Revision: 327334
URL: http://llvm.org/viewvc/llvm-project?rev=327334&view=rev
Log:
Re-land "[Sema] Make getCurFunction() return null outside function parsing"
This relands r326965.
There was a null dereference in typo correction that was triggered i
Author: juliehockett
Date: Mon Mar 12 14:39:01 2018
New Revision: 327333
URL: http://llvm.org/viewvc/llvm-project?rev=327333&view=rev
Log:
[docs] Adding clang-doc to CTE toctree to fix docs build error
Modified:
clang-tools-extra/trunk/docs/clang-doc.rst
clang-tools-extra/trunk/docs/index
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bumblebritches57 added a comment.
Herald added a subscriber: christof.
This is the wrong approach.
C and C++ compatibility is far more important than taking the easy way out.
By doing this, you're potentially breaking the ABI for all software that relies
on atomic operations...
https://review
russellmcc added a comment.
Bump!
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this check LGTM.
https://reviews.llvm.org/D41655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44
+CheckFactories.registerCheck(
+"fuchsia-zx-temporary-objects");
}
Do we want a zircon module instead? I'm wondering about people who enable
modules by do
Hi Julie,
It looks like this commit is causing Clang tests in Windows bots to crash.
Could you take a look?
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9413
Thanks,
Matthew
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Author: jvesely
Date: Mon Mar 12 12:46:52 2018
New Revision: 327324
URL: http://llvm.org/viewvc/llvm-project?rev=327324&view=rev
Log:
nan: Implement
Passes CTS on carrizo and turks
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/math/nan.h
libcl
Author: jvesely
Date: Mon Mar 12 12:46:48 2018
New Revision: 327323
URL: http://llvm.org/viewvc/llvm-project?rev=327323&view=rev
Log:
travis: Add build using llvm-6
Acked-by: Aaron Watry
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/.travis.yml
Modified: libclc/trunk/.travis.yml
URL:
boga95 added a subscriber: szepet.
boga95 marked 4 inline comments as done.
boga95 added inline comments.
Comment at: test/clang-tidy/cert-properly-seeded-random-generator.cpp:76
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: random number generator must be
seeded with a random
Author: arphaman
Date: Mon Mar 12 12:36:29 2018
New Revision: 327322
URL: http://llvm.org/viewvc/llvm-project?rev=327322&view=rev
Log:
[Tooling] Clear the PreambleSrcLocCache when preamble is discarded during
reparsing
This ensures that diagnostics are not remapped to incorrect preamble location
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4406
Author: vedantk
Date: Mon Mar 12 12:18:51 2018
New Revision: 327317
URL: http://llvm.org/viewvc/llvm-project?rev=327317&view=rev
Log:
Check that ubsan is the only supported sanitizer on OpenBSD
Patch by David Carlier!
Differential Revision: https://reviews.llvm.org/D44069
Modified:
cfe/trun
ahatanak updated this revision to Diff 138066.
ahatanak added a comment.
The new patch passes the calling context to CheckNonDependent so that
Sema::CheckAddressOfMemberAccess uses the correct context to check
accessibility of explicit template arguments. I initially tried moving the
declaratio
jdemeule added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:213-221
// Use the file manager to deduplicate paths. FileEntries are
// automatically canonicalized.
- if (const FileEntry *Entry =
SM.getFileMa
ahatanak reopened this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
The patch got reverted in r325335 as it broke the Chromium build. I'm reopening
this review.
Repository:
rC Clang
https://reviews.llvm.org/D36918
___
Author: jkorous
Date: Mon Mar 12 11:33:55 2018
New Revision: 327313
URL: http://llvm.org/viewvc/llvm-project?rev=327313&view=rev
Log:
[Driver] Add text description of --help-hidden so it is shown in help
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Dr
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327309: [analyzer] Move the GCDAsyncSemaphoreChecker to
optin.performance (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.
Author: george.karpenkov
Date: Mon Mar 12 11:27:36 2018
New Revision: 327309
URL: http://llvm.org/viewvc/llvm-project?rev=327309&view=rev
Log:
[analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance
rdar://38383753
Differential Revision: https://reviews.llvm.org/D44228
Added:
cfe/
vsapsai marked 6 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1798
+ // already done some merging. Either way, just merge into it.
+ if (Canon->DefinitionData && Canon->DefinitionData != DD) {
MergeDefinition
devnexen added a comment.
Yes I do ☺ thanks.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai updated this revision to Diff 138059.
vsapsai added a comment.
- Some more cleanup. NFC.
https://reviews.llvm.org/D43494
Files:
clang/lib/Serialization/ASTReaderDecl.cpp
clang/test/Modules/Inputs/self-referencing-lambda/a.h
clang/test/Modules/Inputs/self-referencing-lambda/module.
Author: sqlbyme
Date: Mon Mar 12 11:06:37 2018
New Revision: 327304
URL: http://llvm.org/viewvc/llvm-project?rev=327304&view=rev
Log:
[libcxx][test] Adding apple-clang-9 to UNSUPPORTED in
iter_alloc_deduction.fail.cpp.
After two failed attempts last week to make this work I am
going back to a k
vsk added a comment.
The new changes look fine. Do you need someone to commit this for you?
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I will try implementing John's suggestions. Thanks.
Sam
From: rjmcc...@apple.com [mailto:rjmcc...@apple.com]
Sent: Saturday, March 10, 2018 12:14 PM
To: Richard Smith
Cc: Liu, Yaxun (Sam) ; cfe-commits
Subject: Re: r326946 - CodeGen: Fix address space of indirect function argument
On Mar 9, 2
Thanks a lot Akira!
FWIW, it seems that the FIXME here might be related
https://github.com/llvm-mirror/clang/blob/master/include/clang/AST/DeclCXX.h#L1484
On Mon, Mar 12, 2018 at 6:03 PM Akira Hatanaka wrote:
> I’m not sure if this a bug r327206 introduced or an existing bug in
> ASTImporter as
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1034919, @lebedev.ri wrote:
> Since the commit was reverted, did you mean to either recommit it, or reopen
> this (with updated diff), so it does not get lost?
Relanded in r327295.
Comment at: clang-doc/Bitcod
Author: juliehockett
Date: Mon Mar 12 10:05:14 2018
New Revision: 327295
URL: http://llvm.org/viewvc/llvm-project?rev=327295&view=rev
Log:
Reland "[clang-doc] Setup clang-doc frontend framework"
There was a missing newline in the docs, and a static_assert that needed
to be a normal assert.
Added
s
patch.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180312/221427.html
Removed:
cfe/trunk/test/CodeGenObjC/weak-in-c-struct.m
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/lib/AST/A
I’m not sure if this a bug r327206 introduced or an existing bug in ASTImporter
as there are other bits in RecordDecl that are not copied, but I think I should
revert the patch for now.
> On Mar 12, 2018, at 9:57 AM, Eric Liu wrote:
>
> I think it's likely as our tests only fail with module en
I think it's likely as our tests only fail with module enabled (without
module, ASTImporter isn't really used).
On Mon, Mar 12, 2018 at 5:51 PM Akira Hatanaka wrote:
> The patch I committed moved CXXRecordDecl::CanPassInRegisters to
> RecordDecl. It looks like ASTImporter::ImportDefinition no lo
Author: hokein
Date: Mon Mar 12 09:49:24 2018
New Revision: 327293
URL: http://llvm.org/viewvc/llvm-project?rev=327293&view=rev
Log:
[clangd] Fix diagnostic errors in the test code, NFC.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits, ioeric
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327293: [clangd] Fix diagnostic errors in the test code,
NFC. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44294?vs=137712&id=138039#toc
Repository:
rCTE
The patch I committed moved CXXRecordDecl::CanPassInRegisters to RecordDecl. It
looks like ASTImporter::ImportDefinition no longer copies the bit for
CanPassInRegisters after that change. I’m not sure that is what’s causing tests
to fail.
> On Mar 12, 2018, at 9:29 AM, Eric Liu wrote:
>
> I h
hokein added inline comments.
Comment at: clangd/XRefs.cpp:201
std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos();
+ if (!MacroInfos.empty()) {
+for (auto Item : MacroInfos) {
ilya-biryukov wrote:
> I wonder whether we should fix the `DeclrationA
lebedev.ri added a comment.
Since the commit was reverted, did you mean to either recommit it, or reopen
this (with updated diff), so it does not get lost?
Repository:
rL LLVM
https://reviews.llvm.org/D41102
___
cfe-commits mailing list
cfe-comm
I have been trying to reduce a reproducer for this but haven't gotten any
luck yet. The error happens in conversion between different version of STL
containers and is a bit hard to reduce. I'll keep trying to create a
reproducer.
Could you please also take a quick look to see if ASTImporter/Reader
Do you have a reproducer?
> On Mar 12, 2018, at 9:07 AM, Eric Liu wrote:
>
> I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure
> what's the right way to fix it. I'll revert this commit for now to unblock
> integration. Let me know if you need more information from us.
>
I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure
what's the right way to fix it. I'll revert this commit for now to unblock
integration. Let me know if you need more information from us.
Regards,
Eric
On Mon, Mar 12, 2018 at 4:51 PM Eric Liu wrote:
> The tests only fail
The tests only failed with module enabled. FWIW, I think the change in
ASTImporter (https://reviews.llvm.org/rL327206#change-1q8vFFjJ6Cqk) needs
additional changes to make imports work for RecordDecl.
On Mon, Mar 12, 2018 at 3:56 PM Eric Liu wrote:
> Hi Akira,
>
> It seems that this commit also
This revision was automatically updated to reflect the committed changes.
benhamilton marked an inline comment as done.
Closed by commit rC327285: [clang-format] Improve detection of Objective-C
block types (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327284: [clang-format] Don't detect C++11 attribute
specifiers as ObjC (authored by benhamilton, committed by ).
Changed
benhamilton updated this revision to Diff 138024.
benhamilton added a comment.
- Restore short functionn type variable names and add clarifying comment.
Repository:
rC Clang
https://reviews.llvm.org/D43906
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
unittests/F
Author: benhamilton
Date: Mon Mar 12 08:42:38 2018
New Revision: 327284
URL: http://llvm.org/viewvc/llvm-project?rev=327284&view=rev
Log:
[clang-format] Don't detect C++11 attribute specifiers as ObjC
Summary:
Previously, clang-format would detect C++11 and C++17 attribute
specifiers like the fol
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:210
-bool MightBeFunctionType = !Contexts[Contexts.size() - 2].IsExpression;
-bool ProbablyFunctionType = CurrentToken->isOneOf(tok::star, tok::amp
Author: benhamilton
Date: Mon Mar 12 08:42:40 2018
New Revision: 327285
URL: http://llvm.org/viewvc/llvm-project?rev=327285&view=rev
Log:
[clang-format] Improve detection of Objective-C block types
Summary:
Previously, clang-format would detect the following as an
Objective-C block type:
FOO(^
stettberger added inline comments.
Comment at: include/clang/AST/CHashVisitor.h:72-79
+ template
+ void addData(const llvm::iterator_range &x) {
+addData(std::distance(x.begin(), x.end()));
+ }
+ template
+ void addData(const llvm::ArrayRef &x) {
+addData(x.size());
stettberger updated this revision to Diff 138019.
stettberger marked an inline comment as done.
stettberger added a comment.
Addressed comments, for more details, please see the mail on cfe-devel
Repository:
rC Clang
https://reviews.llvm.org/D40731
Files:
include/clang/AST/AttrDataCollecto
djasper accepted this revision.
djasper added a comment.
Ok, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D43902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327282: [clangd] Revamp handling of diagnostics. (authored
by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44142?vs=138004&id=138018#toc
Repository:
rCTE Clang Tool
Author: ibiryukov
Date: Mon Mar 12 08:28:22 2018
New Revision: 327282
URL: http://llvm.org/viewvc/llvm-project?rev=327282&view=rev
Log:
[clangd] Revamp handling of diagnostics.
Summary:
The new implementation attaches notes to diagnostic message and shows
the original diagnostics in the message o
GBuella created this revision.
GBuella added reviewers: craig.topper, zvi.
Herald added subscribers: cfe-commits, mgorny.
Introduce pconfig and SGX related intrinsics.
Repository:
rC Clang
https://reviews.llvm.org/D44387
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Opt
paulsemel added a comment.
Hi,
In https://reviews.llvm.org/D44093#1034610, @lebedev.ri wrote:
> BTW, as far as i can tell this still has zero test coverage (no new tests are
> being added).
> I'd expect to see the tests for the actual output
>
> - one struct per each type it is able to print
>
Hi Akira,
It seems that this commit also changes behavior for compiling C++ code as
we are seeing test failures caused by this change in our internal tests.
I'm still trying to reduce a reproducer for the failure. In the meantime,
could you please double check if this affects C++?
Thanks,
Eric
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327275: [clangd] Collect the number of files referencing a
symbol in the static index. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44315?vs=137790&id=138
Author: sammccall
Date: Mon Mar 12 07:49:09 2018
New Revision: 327275
URL: http://llvm.org/viewvc/llvm-project?rev=327275&view=rev
Log:
[clangd] Collect the number of files referencing a symbol in the static index.
Summary:
This is an important ranking signal.
It's off for the dynamic index for n
ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/XRefsTests.cpp:587
- const char *HeaderContents = R"cpp([[]]int a;)cpp";
+ const char *HeaderContents = R"cpp([[]]#ifndef T
ilya-biryukov updated this revision to Diff 138004.
ilya-biryukov added a comment.
- Replace equality comparison ops with matchers, they were only used in tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44142
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
c
gtbercea updated this revision to Diff 138002.
gtbercea added a comment.
Add input file.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
gtbercea updated this revision to Diff 138001.
gtbercea added a comment.
Fixes.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-g
gtbercea updated this revision to Diff 138000.
gtbercea added a comment.
Rename folder. Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Drive
gtbercea updated this revision to Diff 137999.
gtbercea added a comment.
Herald added a subscriber: jholewinski.
Change name of folder.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGOpenMPRu
lebedev.ri added a comment.
BTW, as far as i can tell this still has zero test coverage (no new tests are
being added).
I'd expect to see the tests for the actual output
- one struct per each type it is able to print
- probably some tests showing error handling,
and possibly the availability of
paulsemel updated this revision to Diff 137998.
paulsemel added a comment.
Applied Francis' suggestions
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
Index: lib/Sema/SemaChecking.cpp
===
yvvan abandoned this revision.
yvvan added a comment.
It was the wrong direction
https://reviews.llvm.org/D35200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chefmax
Date: Mon Mar 12 06:44:19 2018
New Revision: 327270
URL: http://llvm.org/viewvc/llvm-project?rev=327270&view=rev
Log:
[analyzer] Trying to fix Windows buildbots after r327258
Modified:
cfe/trunk/test/Analysis/scopes-cfg-output.cpp
Modified: cfe/trunk/test/Analysis/scopes-cfg-
1 - 100 of 124 matches
Mail list logo
