aaron.ballman added a comment. It seems like there are some other changes than just the serialize and deserialize that I'm not opposed to, but am wondering why they're needed. It seems some functions are now `getFoo()` calls and it seems like some declarations moved around. Are those intended as part of this patch?
================ Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2 +// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse +// it here to check -emit-ast for attributes. + ---------------- Can you move this below the RUN line? ================ Comment at: cfe/trunk/test/Sema/attr-print.cpp:1 +// This file is also used as input for %S/../Frontend/ast-attr.cpp. + ---------------- Can you move this comment below the RUN line? https://reviews.llvm.org/D43248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
