Author: dcoughlin
Date: Sun Feb 25 16:39:25 2018
New Revision: 326062
URL: http://llvm.org/viewvc/llvm-project?rev=326062&view=rev
Log:
[www] Update link to analyzer's "Building a Checker in 24 hours" video
The video is now uploaded to YouTube.
Modified:
cfe/trunk/www/analyzer/alpha_checks.h
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48
+ // memcpy is intercepted by asan which performs checks on src and dst
+ using T = int[1000];
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:384
+KernelAddress | Efficiency),
+ std::make_pair(SafeStack, Address | HWAddr
aaron.ballman added a comment.
(Review is incomplete, but here are some initial comments.)
Comment at: include/clang/AST/Attr.h:210-212
+ unsigned Idx;
+ bool HasThis;
+ bool IsValid;
I think it might be best to mash these together using bit-fields:
```
unsi
aaron.ballman added a comment.
Committed (with whitespace fix for the test case) in r326058, thanks for the
patch!
https://reviews.llvm.org/D43749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: aaronballman
Date: Sun Feb 25 12:40:06 2018
New Revision: 326058
URL: http://llvm.org/viewvc/llvm-project?rev=326058&view=rev
Log:
When diagnosing the arguments to alloc_size, report the failing argument using
a 1-based index instead of a 0-based index for consistency.
Patch by Joel Denn
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r326057.
If you're not already on IRC, I would recommend joining the #llvm channel on
OFTC so that you can watch for build break notifications from the build bots.
https://reviews.llvm.org/D43747
___
Author: aaronballman
Date: Sun Feb 25 12:28:10 2018
New Revision: 326057
URL: http://llvm.org/viewvc/llvm-project?rev=326057&view=rev
Log:
Fix a failing assertion with the pointer_with_type_tag attribute when the
function the attribute appertains to is variadic.
Patch by Joel Denny.
Modified:
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
Calling convention attributes notionally appertain to the function type -- they
modify the mangling of the function, change the behavior of assignment
operations, etc. However, they're not currently allowed to be writte
jdenny added inline comments.
Comment at: test/Misc/ast-print-objectivec.m:52
// CHECK: @class C1;
-// CHECK: struct __attribute__((objc_bridge_related(C1, , ))) S1;
+// CHECK: struct __attribute__((objc_bridge_related(C1))) S1;
aaron.ballman wrote:
> This fix i
aaron.ballman added a comment.
In https://reviews.llvm.org/D43749#1018825, @jdenny wrote:
> In https://reviews.llvm.org/D43749#1018818, @aaron.ballman wrote:
>
> > Aside from a minor testcase nit, this LGTM. Why is this dependent on
> > https://reviews.llvm.org/D43248?
>
>
> The dependency goes
jdenny added a comment.
In https://reviews.llvm.org/D43747#1018824, @aaron.ballman wrote:
> In https://reviews.llvm.org/D43747#1018814, @jdenny wrote:
>
> > Hi Aaron. Thanks for accepting. I do not have commit privileges. Would
> > you please commit this (and any other patches you accept) for me
jdenny added a comment.
In https://reviews.llvm.org/D43749#1018818, @aaron.ballman wrote:
> Aside from a minor testcase nit, this LGTM. Why is this dependent on
> https://reviews.llvm.org/D43248?
The dependency goes the other way. Did I get it wrong?
Comment at: test/Sema/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor testcase nit, this LGTM. Why is this dependent on
https://reviews.llvm.org/D43248?
Comment at: test/Sema/alloc-size.c:3
-void *fail1(int a
aaron.ballman added a comment.
In https://reviews.llvm.org/D43747#1018814, @jdenny wrote:
> Hi Aaron. Thanks for accepting. I do not have commit privileges. Would
> you please commit this (and any other patches you accept) for me?
I'm happy to do so. Just to double-check though, there's nothin
aaron.ballman added a comment.
Why is this dependent on https://reviews.llvm.org/D43248?
https://reviews.llvm.org/D43747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jdenny added a comment.
Hi Aaron. Thanks for accepting. I do not have commit privileges. Would
you please commit this (and any other patches you accept) for me?
https://reviews.llvm.org/D43747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
In general, I think the idea is reasonable, but in practice I'm worried about
the attributes with custom parsing. Sometimes the parsing requires those extra
bits and I'm not certain of how best to address that.
Comment at: test/Misc/ast-print-ob
jdenny updated this revision to Diff 135839.
jdenny retitled this revision from "[Attr] Fix printing of parameter indices in
attributes" to "[Attr] Fix parameter indexing for attributes".
jdenny edited the summary of this revision.
jdenny added a comment.
Herald added a subscriber: kristof.beyls.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the fix!
https://reviews.llvm.org/D43747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
jdenny created this revision.
jdenny added a reviewer: aaron.ballman.
For consistency with other attributes, fix alloc_size's diagnostics to
report the attribute's argument index for a function parameter index
rather than the actual function parameter index specified in the
source.
https://revie
jdenny created this revision.
jdenny added a reviewer: aaron.ballman.
https://reviews.llvm.org/D43747
Files:
lib/Sema/SemaDeclAttr.cpp
test/Sema/warn-type-safety.c
Index: test/Sema/warn-type-safety.c
===
--- test/Sema/warn-type
jdenny created this revision.
jdenny added a reviewer: aaron.ballman.
The first FIXME introduced here will be addressed in another patch
soon.
https://reviews.llvm.org/D43748
Files:
test/Misc/ast-print-objectivec.m
test/Sema/attr-print.c
test/Sema/attr-print.cpp
utils/TableGen/ClangAttr
predator5047 created this revision.
predator5047 added reviewers: alexfh, alexfh_.
predator5047 added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, kbarton, nemanjai.
Fix bug #36489
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43745
Files:
clang-tidy/
CodaFi updated this revision to Diff 135827.
https://reviews.llvm.org/D43737
Files:
lib/Sema/AnalysisBasedWarnings.cpp
test/SemaCXX/warn-infinite-recursion.cpp
Index: test/SemaCXX/warn-infinite-recursion.cpp
===
--- test/SemaCXX
Author: aaronballman
Date: Sun Feb 25 07:34:17 2018
New Revision: 326055
URL: http://llvm.org/viewvc/llvm-project?rev=326055&view=rev
Log:
Switch the default behavior of the Clang<> spelling to opt-in to the C2x
attribute spellings. NFC to the attribute spellings themselves.
The Clang<> spelling
Author: aaronballman
Date: Sun Feb 25 06:54:25 2018
New Revision: 326054
URL: http://llvm.org/viewvc/llvm-project?rev=326054&view=rev
Log:
Document why the consumed attributes (consumable, callable_when, et al) are not
exposed with a C2x spelling. NFC.
Modified:
cfe/trunk/include/clang/Basic
Author: aaronballman
Date: Sun Feb 25 06:43:45 2018
New Revision: 326053
URL: http://llvm.org/viewvc/llvm-project?rev=326053&view=rev
Log:
Add a C2x spelling for the external_source_symbol and internal_linkage
attributes in the clang vendor namespace.
Both of these attributes have existing meani
MTC created this revision.
MTC added reviewers: alexshap, NoQ, dcoughlin.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
There is a problem with analyzer that a wrong value is given when modeling the
increment operator of the operan
Author: aaronballman
Date: Sun Feb 25 06:01:04 2018
New Revision: 326052
URL: http://llvm.org/viewvc/llvm-project?rev=326052&view=rev
Log:
Add a C++11 and C2x spelling for the type safety attribute
(argument_with_type_tag, pointer_with_type_tag, and type_tag_for_datatype) in
the clang vendor nam
lebedev.ri added a comment.
Please upload patches with full diff (-U99)
Repository:
rC Clang
https://reviews.llvm.org/D43737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
Can’t you just change the description to be the LangAS value? I also thought
these happened to be the same already
https://reviews.llvm.org/D43281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
32 matches
Mail list logo
