aaron.ballman added a comment.

In general, I think the idea is reasonable, but in practice I'm worried about 
the attributes with custom parsing. Sometimes the parsing requires those extra 
bits and I'm not certain of how best to address that.



================
Comment at: test/Misc/ast-print-objectivec.m:52
 // CHECK: @class C1;
-// CHECK: struct __attribute__((objc_bridge_related(C1, , ))) S1;
+// CHECK: struct __attribute__((objc_bridge_related(C1))) S1;
----------------
This fix is incorrect in this case -- the attribute doesn't parse without the 
extra commas.

https://godbolt.org/g/Ze69HD


https://reviews.llvm.org/D43748



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to