Author: inouehrs
Date: Wed Feb 21 23:49:13 2018
New Revision: 325753
URL: http://llvm.org/viewvc/llvm-project?rev=325753&view=rev
Log:
[NFC] fix trivial typos in comments
"a a"->"a"
Modified:
cfe/trunk/include/clang/Sema/ScopeInfo.h
cfe/trunk/test/SemaCXX/ms-uuid.cpp
Modified: cfe/trunk
krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-instrument-os.c:2
// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-
// REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64
```
Author: kamil
Date: Wed Feb 21 23:00:29 2018
New Revision: 325749
URL: http://llvm.org/viewvc/llvm-project?rev=325749&view=rev
Log:
Revert part of D43378 in this file
It causes failure on clang-x86_64-debian-fast.
Modified:
cfe/trunk/test/Driver/XRay/xray-instrument-os.c
Modified: cfe/trunk
krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp:11
//
-// REQUIRES: linux, enable_shared
+// REQUIRES: enable_shared
int foo() { return 42; }
```
FAIL: Clang :: Driver/XRay/xray-shared-noxray.cpp (6820 of 38122)
Author: kamil
Date: Wed Feb 21 22:48:34 2018
New Revision: 325748
URL: http://llvm.org/viewvc/llvm-project?rev=325748&view=rev
Log:
Revert part of r. 325746 D43378
test/Driver/XRay/xray-shared-noxray.cpp fails on !Linux hosts.
Modified:
cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325746: FreeBSD driver / Xray flags moving pthread to
compile flags. (authored by kamil, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43378
Author: kamil
Date: Wed Feb 21 22:31:40 2018
New Revision: 325746
URL: http://llvm.org/viewvc/llvm-project?rev=325746&view=rev
Log:
FreeBSD driver / Xray flags moving pthread to compile flags.
Summary:
- Using -lpthread instead, with -pthread the linkage does not work.
-Warning about the -fxray-i
Author: rtrieu
Date: Wed Feb 21 21:50:29 2018
New Revision: 325742
URL: http://llvm.org/viewvc/llvm-project?rev=325742&view=rev
Log:
[ODRHash] Fix hashing for friend functions.
When hashing a templated function, use the hash of the function it was
instantiated from.
Added:
cfe/trunk/test/Mod
Author: rtrieu
Date: Wed Feb 21 21:32:25 2018
New Revision: 325741
URL: http://llvm.org/viewvc/llvm-project?rev=325741&view=rev
Log:
[ODRHash] Handle some template weirdness.
Build the index off of DeclarationName instead of Decl pointers. When finding
an UnresolvedLookupExprClass, hash it as if
Author: marshall
Date: Wed Feb 21 21:14:20 2018
New Revision: 325740
URL: http://llvm.org/viewvc/llvm-project?rev=325740&view=rev
Log:
Add another test case to the deduction guide for basic_string.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
phosek created this revision.
phosek added reviewers: kcc, vitalybuka.
Herald added a subscriber: cfe-commits.
This allows reporting an error when user tries to use SafeStack with
incompatible sanitizers.
Repository:
rC Clang
https://reviews.llvm.org/D43606
Files:
clang/lib/Driver/Sanitize
vsapsai added a comment.
Thanks for response, Richard. I'll look into using `CXXDefaultInitExpr`.
As for
In https://reviews.llvm.org/D42498#1007028, @rsmith wrote:
> […] your approach will still go wrong if the `This` pointer is used in other
> ways, such as an explicit mention of `this` or a
STL_MSFT updated this revision to Diff 135352.
STL_MSFT added a comment.
Update based on code review feedback.
https://reviews.llvm.org/D43273
Files:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass
rnk added a comment.
Can you update the description to clarify that this is fixing a bug in the
indexing library? From the description it sounds like we have a serious bug in
FUNCDNAME codegen, which is not the case. CodeGen does the right thing. The
ASTContext API is just crappy, so the Index
tra added a comment.
In https://reviews.llvm.org/D43602#1015370, @jlebar wrote:
> For my information, how are we verifying that we've caught everything?
for v in 8.0 9.0 9.1 ; do
/usr/local/cuda-$v/bin/nvcc -c -x cu /dev/null -o /tmp/null.o -arch=sm_60
-keep-dir=nvcc-$v -keep -v
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
For my information, how are we verifying that we've caught everything?
https://reviews.llvm.org/D43602
___
cfe-commits mailing list
cfe-commits@l
tra updated this revision to Diff 135348.
tra added a comment.
Added missing __threadfence_system().
https://reviews.llvm.org/D43602
Files:
clang/lib/Headers/__clang_cuda_device_functions.h
Index: clang/lib/Headers/__clang_cuda_device_functions.h
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
Initial commit missed sincos(float), llabs() and few atomics that we
used to pull in from device_functions.hpp, which we no longer include.
https://reviews.llvm.org/D43602
Files:
clang/lib/Headers/__cl
Hi Hans,
If there's still time for rc3, I'd like to get this crash fix in. This
adds a null check to prevent a crash on invalid.
Richard
On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Mon Feb 5 18:58:21 2018
> New Re
jakehehrlich added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
juliehockett wrote:
> jakehehrlich wrote:
> > lebed
juliehockett updated this revision to Diff 135342.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Updating location creation and adding mapping from type to BlockId
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/Bi
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
jakehehrlich wrote:
> lebedev.ri wrote:
> > julieho
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Thank you for doing these follow up changes!
Repository:
rC Clang
https://reviews.llvm.org/D43598
___
cfe-commits mailing list
cfe-commits@l
benhamilton created this revision.
benhamilton added a reviewer: djasper.
Herald added subscribers: cfe-commits, klimek.
This fixes a few issues djasper@ brought up in his review of
https://reviews.llvm.org/D43522.
Test Plan:
make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests
benhamilton added a comment.
Follow-ups (aside from the case, which I already fixed) in
https://reviews.llvm.org/D43598.
Repository:
rL LLVM
https://reviews.llvm.org/D43522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
benhamilton added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2308
+ Guesser.process();
+ if (Guesser.isObjC()) {
+result = FormatStyle::LK_ObjC;
djasper wrote:
> benhamilton wrote:
> > djasper wrote:
> > > In LLVM, we generally
mclow.lists added inline comments.
Comment at: include/math.h:1499
+// has previously been included.
+#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES)
+#include_next
pcc wrote:
> Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.
I
vitalybuka added inline comments.
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6056
SmallPtrSetImpl *LoopHeaders) {
+ const Function *Fn = BB->getParent();
+ if (Fn && Fn->getMetadata("no_simplify_cfg"))
So maybe Attribute::Sani
djasper added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2308
+ Guesser.process();
+ if (Guesser.isObjC()) {
+result = FormatStyle::LK_ObjC;
benhamilton wrote:
> djasper wrote:
> > In LLVM, we generally don't add braces for sin
aaron.ballman added a comment.
In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote:
> In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> >
> > > Is there a way to make clang-apply-replacements smart
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325733: [Driver] Generate .eh_frame_hdr for static
executables too. (authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43203?vs=133907&id=135336#toc
Repository:
Author: danalbert
Date: Wed Feb 21 14:36:51 2018
New Revision: 325733
URL: http://llvm.org/viewvc/llvm-project?rev=325733&view=rev
Log:
[Driver] Generate .eh_frame_hdr for static executables too.
Summary: libgcc won't unwind without an .eh_frame_hdr section.
Reviewers: srhines, chandlerc
Review
jdemeule added a comment.
In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
>
> > Is there a way to make clang-apply-replacements smarter rather than forcing
> > every check to jump through hoops? I'm worried t
eastig added a comment.
Just validated that it has fixed the issue.
Thank you, Peter.
Repository:
rCXX libc++
https://reviews.llvm.org/D42503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
pcc added inline comments.
Comment at: include/math.h:1499
+// has previously been included.
+#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES)
+#include_next
Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.
https://reviews.llvm.
jakehehrlich added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
lebedev.ri wrote:
> juliehockett wrote:
> > lebedev
compnerd closed this revision.
compnerd added a comment.
SVN r325724
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: compnerd
Date: Wed Feb 21 13:47:51 2018
New Revision: 325724
URL: http://llvm.org/viewvc/llvm-project?rev=325724&view=rev
Log:
CodeGen: handle blocks correctly when inalloca'ed
When using blocks with C++ on Windows x86, it is possible to have the
block literal be pushed into the inalloca'
mstorsjo added a comment.
Ping @rnk
Repository:
rC Clang
https://reviews.llvm.org/D43184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX325723: libcxx: Unbreak external thread library
configuration. (authored by pcc, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D42503?vs=131
Author: pcc
Date: Wed Feb 21 13:36:18 2018
New Revision: 325723
URL: http://llvm.org/viewvc/llvm-project?rev=325723&view=rev
Log:
libcxx: Unbreak external thread library configuration.
Differential Revision: https://reviews.llvm.org/D42503
Modified:
libcxx/trunk/include/__threading_support
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I hate `inalloca` so much. Okay.
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
cfe-commits@lists.llvm
Fix landed in r325722.
On Wed, Feb 21, 2018 at 1:53 PM Ben Hamilton wrote:
> Thanks for the report, and sorry for the breakage.
>
> Here's the fix: https://reviews.llvm.org/D43590
>
> Ben
>
> On Wed, Feb 21, 2018 at 1:47 PM wrote:
>
>> Hi Ben,
>>
>> Your change is causing a test failure on one
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325722: [clang-format] Fix regression when getStyle() called
with empty filename (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43590?vs=135314&id=135321#to
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1108
+PCK_ARCStrong, // objc strong pointer.
+PCK_Struct // non-trivial C struct.
+ };
These should all be /// documentation comments, and they mostly shouldn't talk
about fields si
Author: benhamilton
Date: Wed Feb 21 13:27:27 2018
New Revision: 325722
URL: http://llvm.org/viewvc/llvm-project?rev=325722&view=rev
Log:
[clang-format] Fix regression when getStyle() called with empty filename
Summary:
D43522 caused an assertion failure when getStyle() was called with
an empty f
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
I'm not familiar with this code, so post-commit review by someone more
knowledgeable might be a good idea.
Code-wise it looks good. I feel uneasy about using fake file name, but it is
exact
Hi Ben,
Your change is causing a test failure on one of the bots, can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/25515
FAIL: Clang Tools :: clang-apply-replacements/format.cpp (12526 of 38114)
TEST 'Clang Tools :: cla
Thanks for the report, and sorry for the breakage.
Here's the fix: https://reviews.llvm.org/D43590
Ben
On Wed, Feb 21, 2018 at 1:47 PM wrote:
> Hi Ben,
>
> Your change is causing a test failure on one of the bots, can you take a
> look?
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x8
benhamilton created this revision.
benhamilton added reviewers: vsapsai, jolesiak, krasimir.
Herald added subscribers: cfe-commits, klimek.
https://reviews.llvm.org/D43522 caused an assertion failure when getStyle() was
called with
an empty filename:
https://reviews.llvm.org/P8065
This adds a t
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:396
+ProgramStateRef State, const LocationContext *FromLC,
+const LocationContext *ToLC) {
+ const LocationContext *LC = FromLC;
a.sidorin wrote:
> EndLC? (similar to iterators
NoQ updated this revision to Diff 135312.
NoQ marked 4 inline comments as done.
NoQ added a comment.
- Address comments.
- Add a FIXME test case that demonstrates that automatic destructors don't fire
after lifetime extension through a POD field, even though lifetime extension
itself seems to wo
smeenai added a comment.
Patch is missing context.
Comment at: lib/CodeGen/CGDecl.cpp:1851
// The only implicit argument a block has is its literal.
// We assume this is always passed directly.
if (BlockInfo) {
This comment needs to be updated.
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D43570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 135309.
ahatanak marked 14 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D41228
Files:
docs/LanguageExtensions.rst
include/clang/AST/Decl.h
include/clang/AST/Type.h
include/clang/Basic/Diagnost
morehouse added a comment.
In https://reviews.llvm.org/D43423#1011170, @davide wrote:
> Some high level comments:
>
> 1. This is something that GCC does relatively frequently (adding frontend
> options to control optimization passes), but LLVM tends to not expose these
> details. FWIW, I'd very
juliehockett updated this revision to Diff 135305.
juliehockett marked 20 inline comments as done.
juliehockett added a comment.
Cleaning up bitcode writer and fixing pointers for CommentInfos
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/Bitc
compnerd created this revision.
compnerd added a reviewer: rnk.
Herald added a subscriber: cfe-commits.
When using blocks with C++ on Windows x86, it is possible to have the
block literal be pushed into the inalloca'ed parameters. Teach IRGen to
handle the case properly by extracting the block li
ahatanak added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1423
+ if (capturedByInit)
+drillIntoBlockVariable(*this, lvalue, cast(D));
+
rjmccall wrote:
> The "delay" is that we generally handle `__block` captures within
> initializers by de
aaron.ballman added a comment.
In https://reviews.llvm.org/D43581#1014903, @stephanemoore wrote:
> In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote:
>
> > LGTM with a few additional test cases.
> >
> > It'd be nice if the style guide linked actually described what a "good"
> > pr
efriedma added a comment.
> FWIW, I'd very much prefer the details of the optimizer wouldn't be exposed
> as frontend flags.
Yes, definitely this. Frontend flags to control the optimizer should state an
expected result, not just turn off some completely arbitrary set of transforms.
Otherwise
Author: erichkeane
Date: Wed Feb 21 12:29:05 2018
New Revision: 325716
URL: http://llvm.org/viewvc/llvm-project?rev=325716&view=rev
Log:
Replace incorrect usage of isInvalidDecl with intended setInvalidDecl
This typo would cause an attempt to multiversion 'main' to issue an
error, but not mark t
compnerd updated this revision to Diff 135304.
compnerd added a comment.
Update comment
Repository:
rC Clang
https://reviews.llvm.org/D43586
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/block-inalloca.cpp
Index: test/CodeGenCXX/block-inalloca.cpp
==
lebedev.ri added inline comments.
Comment at: clang-doc/Representation.h:79
+ std::string Filename;
+};
+
Hmm, have you tried adding a constructor here?
```
struct Location {
int LineNumber;
std::string Filename;
Location() = default;
Location(int Line
yaxunl updated this revision to Diff 135301.
yaxunl added a comment.
Replace Flag with LValue in CallArg.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/ItaniumCX
bsdjhb created this revision.
bsdjhb added a reviewer: sdardis.
Herald added subscribers: cfe-commits, christof.
Currently this is only planned to be used by libunwind's tests.
Repository:
rCXX libc++
https://reviews.llvm.org/D43584
Files:
utils/libcxx/test/config.py
Index: utils/libcxx/
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3510
+ args.add(RValue::getAggregate(Dest.getAddress()), type, L);
}
return;
Please move all this conditionality to the call-emission code; just check
whether you have a load of an
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote:
> LGTM with a few additional test cases.
>
> It'd be nice if the style guide linked actually described what a "good"
> prefix is rather than make the r
lebedev.ri added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
juliehockett wrote:
> lebedev.ri wrote:
> > Hmm, comm
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
lebedev.ri wrote:
> Hmm, common pattern again
> ```
stephanemoore updated this revision to Diff 135291.
stephanemoore added a comment.
Added excerpts from the Google Objective-C style guide section on constant
naming (http://google.github.io/styleguide/objcguide#constants) as additional
test cases.
Repository:
rCTE Clang Tools Extra
https://
bsdjhb added a comment.
@sdardis requested this functionality in the review of
https://reviews.llvm.org/D39074. Simon, can you confirm that this works for
you in your testing?
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
___
cfe-
bsdjhb updated this revision to Diff 135285.
bsdjhb added a comment.
- Unexpand tabs.
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
Files:
CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
--
bsdjhb created this revision.
bsdjhb added a reviewer: sdardis.
Herald added subscribers: christof, mgorny.
This is done via a new LIBUNWIND_TEST_CFLAGS variable.
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
Files:
CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.
benhamilton added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2298
+FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) {
+ FormatStyle::LanguageKind result = getLanguageByFileName(FileName);
+ if (result == FormatStyle::LK_Cpp) {
--
tmsriram added a comment.
Ping. This patch goes with https://reviews.llvm.org/D42216, Rafael can you
approve this too if you think it is ok? Thanks.
https://reviews.llvm.org/D42217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
djasper added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2298
+FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) {
+ FormatStyle::LanguageKind result = getLanguageByFileName(FileName);
+ if (result == FormatStyle::LK_Cpp) {
--
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3505
+if (AS != LangAS::Default && AS != LangAS::opencl_private &&
+AS != CGM.getASTAllocaAddressSpace())
+ Flag = CallArg::ByValArgNeedsCopy;
rjmccall wrote:
> This is an odd condi
lebedev.ri added a comment.
Nice!
Comment at: clang-doc/BitcodeWriter.cpp:33
+ llvm::IndexedMap BlockIdNameMap;
+ BlockIdNameMap.resize(BI_LAST - BI_FIRST + 1);
+
So here's the thing.
We know how many enumerators we have (`BI_LAST - BI_FIRST + 1`).
An
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few additional test cases.
It'd be nice if the style guide linked actually described what a "good" prefix
is rather than make the reader guess.
Co
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM.
https://reviews.llvm.org/D43579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
stephanemoore created this revision.
Herald added a subscriber: cfe-commits.
The current Objective-C global variable declaration check restricts naming that
is permitted by the Objective-C style guide.
The Objective-C style guide states the following:
"Global and file scope constants should have
Author: ioeric
Date: Wed Feb 21 08:17:25 2018
New Revision: 325694
URL: http://llvm.org/viewvc/llvm-project?rev=325694&view=rev
Log:
[clangd] Update canonical header mapping for STL
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clangd/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325693: [analyzer] Prevent AnalyzerStatsChecker from crash
(authored by szepet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42266?vs=130501&id=135266#toc
Repository:
rC Clang
Author: szepet
Date: Wed Feb 21 08:06:56 2018
New Revision: 325693
URL: http://llvm.org/viewvc/llvm-project?rev=325693&view=rev
Log:
[analyzer] Prevent AnalyzerStatsChecker from crash
The checker marks the locations where the analyzer creates sinks. However, it
can happen that the sink was create
miyuki created this revision.
miyuki added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Certain C libraries require configuration macros defined in __config
to provide the correct functionality for libc++. This patch ensures
that the C header math.h is always included after the __conf
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3505
+if (AS != LangAS::Default && AS != LangAS::opencl_private &&
+AS != CGM.getASTAllocaAddressSpace())
+ Flag = CallArg::ByValArgNeedsCopy;
This is an odd condition. What are
Author: dblaikie
Date: Wed Feb 21 08:00:50 2018
New Revision: 325692
URL: http://llvm.org/viewvc/llvm-project?rev=325692&view=rev
Log:
Remove use of the 'gmlt' term from the -fsplit-dwarf-inlining flag description
to make it more readily legible
Modified:
cfe/trunk/include/clang/Driver/Optio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325691: [clang-format] New API guessLanguage() (authored by
benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43522?vs=135121&id=135261#toc
Repository:
rC Clang
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325691: [clang-format] New API guessLanguage() (authored by
benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43522
Files:
cfe/trunk
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D43570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: benhamilton
Date: Wed Feb 21 07:54:31 2018
New Revision: 325691
URL: http://llvm.org/viewvc/llvm-project?rev=325691&view=rev
Log:
[clang-format] New API guessLanguage()
Summary:
For clients which don't have a filesystem, calling getStyle() doesn't
make much sense (there's no .clang-format
devnexen updated this revision to Diff 135258.
devnexen added a comment.
Rephrasing Checkers.td comment
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
emaste added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until th
rjmccall added a comment.
In https://reviews.llvm.org/D42366#1014157, @kosarev wrote:
> I think zero would serve better as the unknown-size value. People who are not
> aware of TBAA internals would guess that since zero-sized accesses make no
> sense, they are likely to have some special meanin
szepet added a comment.
In https://reviews.llvm.org/D16403#1011218, @NoQ wrote:
> Yeah, i mean, like, if we change the scope markers to also appear even when
> no variables are present in the scope, then it would be possible to replace
> loop markers with some of the scope markers, right?
OK,
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
Author: ioeric
Date: Wed Feb 21 06:22:42 2018
New Revision: 325682
URL: http://llvm.org/viewvc/llvm-project?rev=325682&view=rev
Log:
[ASTMatchers] Regenerate documentation after r325678
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.htm
1 - 100 of 135 matches
Mail list logo
