lebedev.ri added inline comments.
Comment at: clang-doc/ClangDocBinary.cpp:72
+ assert(Abbrevs.find(recordID) == Abbrevs.end() &&
+ "Abbreviation already set.");
+ Abbrevs[recordID] = abbrevID;
juliehockett wrote:
> lebedev.ri wrote:
> > lebedev.ri wrot
jdemeule created this revision.
jdemeule added a reviewer: alexfh.
Herald added subscribers: cfe-commits, mgorny.
'modernize-user-default-member-init' does not automatically ask to remove comma
and colon when replacements are produced.
It seems, when they are apply directly from clang-tidy, the
Author: ctopper
Date: Mon Feb 19 23:28:18 2018
New Revision: 325560
URL: http://llvm.org/viewvc/llvm-project?rev=325560&view=rev
Log:
[X86] Remove mask from 512 bit pmulhrsw/pmulhw/pmulhuw builtins.
We now use a vselect node in IR around an unmasked builtin. This makes it
consistent with the 128
Author: sammccall
Date: Mon Feb 19 23:21:56 2018
New Revision: 325553
URL: http://llvm.org/viewvc/llvm-project?rev=325553&view=rev
Log:
[Sema] Fix -Wunused-variable
Modified:
cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp
Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp
URL:
http://llvm
juliehockett updated this revision to Diff 135009.
juliehockett marked 27 inline comments as done.
juliehockett added a comment.
1. Decoupled the mapper implementation from the main program, exposing only the
function to generate the action factory
2. Implemented the matchers into a RecursiveASTV
juliehockett added inline comments.
Comment at: clang-doc/ClangDoc.cpp:32
+ ECtx.reportResult(
+ Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D)));
+}
lebedev.ri wrote:
> I wonder if `Name` should be `std::move()`'d ? Or not, `reportRes
Quuxplusone updated this revision to Diff 135005.
Quuxplusone added a comment.
Removed a redundant check for LValueReferenceType in the CWG1579 codepath. (In
that branch, we know that standard C++ *did* perform the copy-to-move
transformation, so obviously we can't have had an lvalue reference t
mclow.lists added inline comments.
Comment at:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp:80
{
std::vector v(10);
std::iota(v.begin(), v.end(), 1);
What if we just made the containers `vector` ? (and `triangle`)
https:
NoQ added a comment.
I believe we should relocate this checker into `alpha.security` in order to
indicate that this is still in development, so that you (or anyone else) could
provide auto-detection for the macro values later as an incremental
improvement, and then it will be back in `security`
Author: rsmith
Date: Mon Feb 19 18:32:30 2018
New Revision: 325545
URL: http://llvm.org/viewvc/llvm-project?rev=325545&view=rev
Log:
Fix some -Wexceptions false positives.
Reimplement the "noexcept function actually throws" warning to properly handle
nested try-blocks. In passing, change 'throw;'
Author: eugenezelenko
Date: Mon Feb 19 18:16:28 2018
New Revision: 325544
URL: http://llvm.org/viewvc/llvm-project?rev=325544&view=rev
Log:
[Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Sema/AttributeList.h
vsapsai updated this revision to Diff 135003.
vsapsai added a comment.
Herald added a subscriber: christof.
- Add back existing test but run it only when file system supports min time.
https://reviews.llvm.org/D42755
Files:
libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This patch uses the reference to `MaterializeTemporaryExpr` stored in the
construction context since https://reviews.llvm.org/D43477 in order
Quuxplusone added a comment.
@rsmith and/or @rtrieu, please take another look? All my TODOs are done now:
there are fixits, and the wording of the diagnostic changes if it's a "throw"
instead of a "return", and the wording has been updated per Richard Smith's
suggestions.
I have one very mino
Quuxplusone updated this revision to Diff 134999.
Quuxplusone edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D43322
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaExprC
aprantl added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2969
+if (!DD && RD->isBeingDefined())
+ return nullptr;
Perhaps add a comment explaining what's going on in this early exit?
https://reviews.llvm.org/D43494
compnerd added a comment.
Is there a need for this given the changes for 6.0?
https://reviews.llvm.org/D34365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai created this revision.
vsapsai added reviewers: rsmith, bruno.
Herald added a subscriber: jkorous-apple.
During reading C++ definition data for lambda we can access
CXXRecordDecl representing lambda before we finished reading the
definition data. This can happen by reading a captured varia
EricWF updated this revision to Diff 134989.
EricWF added a comment.
Ping.
https://reviews.llvm.org/D43047
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/Cod
EricWF updated this revision to Diff 134987.
EricWF added a comment.
Ping.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/SourceLocExprScope.h
include/c
EricWF updated this revision to Diff 134986.
EricWF added a comment.
Ping.
https://reviews.llvm.org/D40218
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
test/CodeGen/bui
NoQ updated this revision to Diff 134979.
NoQ added a comment.
Fix the test.
https://reviews.llvm.org/D43483
Files:
lib/Analysis/CFG.cpp
test/Analysis/cfg-rich-constructors.cpp
test/Analysis/temp-obj-dtors-cfg-output.cpp
Index: test/Analysis/temp-obj-dtors-cfg-output.cpp
Fixed in r325540. Sorry about that.
On 19 February 2018 at 14:44, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> One of modified tests broke the next builder:
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-
> expensive-checks-win/builds/8006
>
>
Author: rsmith
Date: Mon Feb 19 14:50:50 2018
New Revision: 325540
URL: http://llvm.org/viewvc/llvm-project?rev=325540&view=rev
Log:
Fix test failure on target where size_t is long long.
Modified:
cfe/trunk/test/CXX/drs/dr6xx.cpp
Modified: cfe/trunk/test/CXX/drs/dr6xx.cpp
URL:
http://llvm.o
sdardis created this revision.
sdardis added a reviewer: atanasyan.
Herald added a subscriber: arichardson.
This patch provides migitation for CVE-2017-5715, Spectre variant two,
which affects the https://reviews.llvm.org/P5600 and
https://reviews.llvm.org/P6600. It provides the option
-mindirect
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
Similarly to https://reviews.llvm.org/D43480 and
https://reviews.llvm.org/D43481, we need to skip the ternary conditional
operator `... ? ..
Hello Richard,
One of modified tests broke the next builder:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/8006
Failing Tests (1):
Clang :: CXX/drs/dr6xx.cpp
Please have a look?
Thanks
Galina
On Mon, Feb 19, 2018 at 1:05 AM, Richard Smith via cfe-commit
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
Because lifetime-extended temporaries are treated as const objects, an implicit
`NoOp` cast to `const` usually surrounds them in the AST, som
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
When a constructor with a single argument is treated as a functional cast
expression, skip the functional cast while finding the construction
Hans,
The reproducer below generates wrong export symbols compared to MSVC but I am
not sure it is related to my change.
Compiling this with MSVC generates these symbols:
ksh-3.2$ dumpbin /directives t3.obj | grep EXPORT
/EXPORT:??4?$d@H@@QEAAAEAV0@AEBV0@@Z
/EXPORT:??4?$d@H@@QEAAAEA
NoQ added a comment.
> eg. `const C &c(123);` or the actual (not the elidable copy) constructor in
> `C foo() { return C(123); }`
Emm, sry, never mind, forget it, i was trying to say that the reason why we
don't have a `CXXBindTemporary` is because we don't have a destructor in class
`C`, not
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm fine with this, but I don't really think it's a good solution (but none of
our LIT config is ideal). In particular for the link flags might not work well,
because the order of linker flags
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
`MaterializeTemporaryExpr` captures lifetime extension information. In the
analyzer it is important to have this information at construction
arichardson added a comment.
Herald added a subscriber: christof.
ping
Repository:
rCXX libc++
https://reviews.llvm.org/D42139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325523: [clangd] Fixes for #include insertion. (authored
by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43462?vs=134947&id=134952#toc
Repository:
rL LLVM
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325523: [clangd] Fixes for #include insertion. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43462
Files:
clang-tools-ex
Author: ioeric
Date: Mon Feb 19 10:48:44 2018
New Revision: 325523
URL: http://llvm.org/viewvc/llvm-project?rev=325523&view=rev
Log:
[clangd] Fixes for #include insertion.
Summary:
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files (by not indexing symbo
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric updated this revision to Diff 134947.
ioeric added a comment.
- assert in the very beginning!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
clangd/index/CanonicalIncludes.cpp
clangd/index
ioeric updated this revision to Diff 134944.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- added a comment about thread safety
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
cl
ioeric marked 5 inline comments as done.
ioeric added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
ilya-biryukov wrote:
> Not related t
ioeric updated this revision to Diff 134943.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- addressed comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
clangd/index/Canon
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325522: [clangd] Do not reuse preamble if compile args
changed (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43454?v
Author: ibiryukov
Date: Mon Feb 19 10:18:49 2018
New Revision: 325522
URL: http://llvm.org/viewvc/llvm-project?rev=325522&view=rev
Log:
[clangd] Do not reuse preamble if compile args changed
Reviewers: hokein, ioeric, sammccall, simark
Reviewed By: simark
Subscribers: klimek, jkorous-apple, cfe
ilya-biryukov added inline comments.
Comment at: clangd/index/CanonicalIncludes.cpp:21
llvm::StringRef CanonicalPath) {
addRegexMapping((llvm::Twine("^") + llvm::Regex::escape(Path) + "$").str(),
CanonicalPath);
--
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
Not related to this patch, but just noticed that we don't call
`FS->s
sammccall added inline comments.
Comment at: clangd/Headers.h:26
///
/// \param Header is an absolute file path.
+/// \return A quoted "path" or . This returns an empty string if:
File also needs to be absolute.
(May want to add asserts for this at the start of
Author: aaronballman
Date: Mon Feb 19 09:32:07 2018
New Revision: 325520
URL: http://llvm.org/viewvc/llvm-project?rev=325520&view=rev
Log:
Add several more attributes to be parsed in C with [[]] when
-fdouble-square-bracket-attributes is specified.
Also flags a few attributes that should not be
tbourvon updated this revision to Diff 134936.
tbourvon added a comment.
This updates the patch to use `clang::tooling::fixit::getText()` instead of the
custom `getStmtText`. This also adds a macro unit test.
https://reviews.llvm.org/D37014
Files:
clang-tidy/readability/CMakeLists.txt
clan
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, but you should wait a few days in case Richard has thoughts or
concerns.
Repository:
rC Clang
https://reviews.llvm.org/D42840
__
sammccall added a comment.
Naming conventions tend to stick around for a while - `clang-doc/ClangDocXYZ.h`
seems a bit unwieldy compared to `clang-doc/XYZ.h` - might be worth considering.
Comment at: clang-doc/ClangDoc.cpp:37
+ Context = Result.Context;
+ if (const auto *M =
ioeric updated this revision to Diff 134932.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Stop indexing main files in dynamic index; addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/H
ioeric added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
ilya-biryukov wrote:
rjmccall added a comment.
Discourse nitpick: I would encourage you to just use the ordinary phrase "null
pointer", or just "null", when referring to a pointer value that happens to be
null and to reserve "nullptr" for *statically* null pointers, especially the
`nullptr` expression.
If the poin
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I'm fine with that plan. LGTM.
https://reviews.llvm.org/D42366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: miyuki
Date: Mon Feb 19 07:41:36 2018
New Revision: 325510
URL: http://llvm.org/viewvc/llvm-project?rev=325510&view=rev
Log:
[libcxx] Improve accuracy of complex asinh and acosh
Summary:
Currently std::asinh and std::acosh use std::pow to compute x^2. This
results in a significant error w
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325513: [clang-format] Fix text proto extension scope
opening detection (authored by krasimir, committed by ).
Herald adde
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325513: [clang-format] Fix text proto extension scope
opening detection (authored by krasimir, committed by ).
Changed pr
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This fixes the detection of scope openers in text proto extensions; previously
they were not detected correctly leading to instances like:
msg {
[aa.bb
] {
key: value
}
}
Repository:
rC Clang
https:/
Author: krasimir
Date: Mon Feb 19 08:00:21 2018
New Revision: 325513
URL: http://llvm.org/viewvc/llvm-project?rev=325513&view=rev
Log:
[clang-format] Fix text proto extension scope opening detection
Summary:
This fixes the detection of scope openers in text proto extensions; previously
they were
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and
acosh (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41629
Files:
include/complex
test/libcxx/numer
sammccall added inline comments.
Comment at: clangd/Headers.cpp:42-43
};
+/// Returns true if \p Path has header extensions like .h and .hpp etc.
+bool hasHeaderExtension(PathRef Path) {
As discussed offline, this seems dubious.
- this is probably the generali
simark added a comment.
In https://reviews.llvm.org/D39571#1011877, @ilya-biryukov wrote:
> > That looks like another preamble-handling bug. It's much easier to fix and
> > it's clangd-specific, so I'll make sure to fix that soon.
> > Thanks for bringing this up, we haven't been testing compile
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
There is anot
simark accepted this revision.
simark added a comment.
This revision is now accepted and ready to land.
I don't have the setup to test at the moment, but the code looks good to me.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43454
__
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325509: [clang-format] Fixup a case of text proto message
attributes (authored by krasimir, committed by ).
Changed prior
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325509: [clang-format] Fixup a case of text proto message
attributes (authored by krasimir, committed by ).
Herald added a
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This patch fixes a case where a proto message attribute is wrongly identified
as an text proto extension.
Repository:
rC Clang
https://reviews.llvm.org/D43465
Files:
lib/Format/TokenAnnotator.cpp
unittests/Fo
Author: krasimir
Date: Mon Feb 19 07:31:25 2018
New Revision: 325509
URL: http://llvm.org/viewvc/llvm-project?rev=325509&view=rev
Log:
[clang-format] Fixup a case of text proto message attributes
Summary: This patch fixes a case where a proto message attribute is wrongly
identified as an text pr
miyuki added a comment.
No, I'll commit it myself. Thank you for the review.
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files.
o Canonicalize include paths for symbols in dynamic index.
Author: hokein
Date: Mon Feb 19 06:26:55 2018
New Revision: 325503
URL: http://llvm.org/viewvc/llvm-project?rev=325503&view=rev
Log:
[clangd] Correct the doc, password => Personal Access Token.
Modified:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md
Modified: clang-tools-ext
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra.
Herald added a subscriber: cfe-commits.
Binaries for multiple architectures are combined by fatbinary,
so the current code was effectively not needed.
Repository:
rC Clang
https://reviews.llvm.org/D43461
Files:
include/
Merged to 6.0 in r325500.
On Fri, Feb 16, 2018 at 8:44 PM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Fri Feb 16 11:44:47 2018
> New Revision: 325375
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325375&view=rev
> Log:
> [MS] Make constexpr static data members implicitly inline
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE325499: [clangd] Add brief instructions on how to make a
release for vscode-clangd… (authored by hokein, committed by ).
Changed prior to commit:
https://revie
Author: hokein
Date: Mon Feb 19 06:01:52 2018
New Revision: 325499
URL: http://llvm.org/viewvc/llvm-project?rev=325499&view=rev
Log:
[clangd] Add brief instructions on how to make a release for vscode-clangd
extension.
Reviewers: sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, ioer
GBuella added a comment.
See also: https://reviews.llvm.org/D43380
Repository:
rC Clang
https://reviews.llvm.org/D43459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella created this revision.
GBuella added reviewers: craig.topper, zvi, echristo.
Herald added a subscriber: cfe-commits.
Cannon Lake does not support CLWB, therefore it
does not include all features listed under SKX.
Repository:
rC Clang
https://reviews.llvm.org/D43459
Files:
lib/Basic
hokein updated this revision to Diff 134900.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43455
Files:
clangd/clients/clangd-vscode/README.md
Index: clangd/clients/clangd-vscode/READ
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/clients/clangd-vscode/README.md:61
+* Make sure install the `vsce` command (`npm install -g vsce`)
+* `llvm-vs-code-extensions` account
+
sammccall wrote:
> increase the ver
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
thanks! couple of nits
Comment at: clangd/clients/clangd-vscode/README.md:55
+
+Everytime you make a change to `clangd-vscode`, you are expected to publish a
+new versi
Author: ibiryukov
Date: Mon Feb 19 05:53:49 2018
New Revision: 325496
URL: http://llvm.org/viewvc/llvm-project?rev=325496&view=rev
Log:
[CodeComplete] Avoid name clashes of 'Kind' inside CodeCompletionContext. NFC
CodeCompletionContext had declarations of field and enum inside, both named
'Kind'
lebedev.ri added a comment.
clang 6.0 defaults to C++14, BTW.
https://reviews.llvm.org/D34365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added inline comments.
Comment at: clang-doc/ClangDocBinary.h:82
+
+static std::map BlockIdNameMap = {
+ {NAMESPACE_BLOCK_ID, "NamespaceBlock"},
lebedev.ri wrote:
> Nice!
> Some thoughts:
> 1. I agree it makes sense to keep it close to the enum defini
Author: sammccall
Date: Mon Feb 19 05:04:41 2018
New Revision: 325493
URL: http://llvm.org/viewvc/llvm-project?rev=325493&view=rev
Log:
[clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)
Have had way too many bugs by converting between "isComplete" and
"isIncomplete". LSP i
mgorny added a comment.
Ping for the third time.
https://reviews.llvm.org/D34365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325492: [ARM] disable FPU features when using soft floating
point. (authored by kwalker, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42569
Author: kwalker
Date: Mon Feb 19 04:40:26 2018
New Revision: 325492
URL: http://llvm.org/viewvc/llvm-project?rev=325492&view=rev
Log:
[ARM] disable FPU features when using soft floating point.
To be compatible with GCC if soft floating point is in effect any FPU
specified is effectively ignored,
Author: ibiryukov
Date: Mon Feb 19 04:35:57 2018
New Revision: 325491
URL: http://llvm.org/viewvc/llvm-project?rev=325491&view=rev
Log:
[clangd] Attach more information about Sema completion to traces
Reviewers: hokein, ioeric, sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325491: [clangd] Attach more information about Sema
completion to traces (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43377?vs=134889&id=134892#toc
Repos
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325490: [CodeComplete] Add a helper to print
CodeCompletionContext::Kind (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43379?vs=134888&id=134891#toc
Reposit
Author: ibiryukov
Date: Mon Feb 19 04:35:33 2018
New Revision: 325490
URL: http://llvm.org/viewvc/llvm-project?rev=325490&view=rev
Log:
[CodeComplete] Add a helper to print CodeCompletionContext::Kind
Summary: Will be used in clangd. See D43377.
Reviewers: sammccall
Reviewed By: sammccall
Subs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325489: clang-format: [JS] fix `of` detection. (authored by
mprobst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43440
Files:
cfe/trunk/lib
Author: mprobst
Date: Mon Feb 19 04:32:13 2018
New Revision: 325489
URL: http://llvm.org/viewvc/llvm-project?rev=325489&view=rev
Log:
clang-format: [JS] fix `of` detection.
Summary:
`of` is only a keyword when after an identifier, but not when after
an actual keyword.
Before:
return of (a, b
ilya-biryukov updated this revision to Diff 134889.
ilya-biryukov added a comment.
- Rename usage of printCompletionKind to getCompletionKindString
- Remove tracing of the filename, TUScheduler now provides those traces
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
Files
ilya-biryukov updated this revision to Diff 134888.
ilya-biryukov added a comment.
- Rename printCompletionKind to getCompletionKindString
Repository:
rC Clang
https://reviews.llvm.org/D43379
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/CodeCompleteConsumer.cpp
Index: lib/
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D43440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
lebedev.ri added a comment.
Great work!
Some more review...
Comment at: clang-doc/ClangDoc.cpp:32
+ ECtx.reportResult(
+ Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D)));
+}
I wonder if `Name` should be `std::move()`'d ? Or not, `rep
sammccall added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:355
+/// \brief Get string representation of \p Kind, useful for for debugging.
+llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind);
+
ilya-biryukov wro
1 - 100 of 131 matches
Mail list logo
