smeenai added a comment.
We've seen lots of spurious warnings from this. Thanks for the fix!
https://reviews.llvm.org/D43110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl added a comment.
In https://reviews.llvm.org/D40045#925400, @t-tye wrote:
> LGTM except for Bonaire.
Done. Also removed gfx800 as per latest docs.
Repository:
rL LLVM
https://reviews.llvm.org/D40045
___
cfe-commits mailing list
cfe-co
This revision was not accepted when it landed; it landed in state "Changes
Planned".
This revision was automatically updated to reflect the committed changes.
kzhuravl marked an inline comment as done.
Closed by commit rL324714: AMDGPU/GCN: Bring processors in sync with
AMDGPUUsage (authored by k
Author: kzhuravl
Date: Thu Feb 8 23:02:28 2018
New Revision: 324714
URL: http://llvm.org/viewvc/llvm-project?rev=324714&view=rev
Log:
AMDGPU/GCN: Bring processors in sync with AMDGPUUsage
- Remove gfx800
- Remove gfx804
- Remove gfx901
- Remove gfx903
Differential Revision: https://reviews.llvm
EricWF added a comment.
This LGTM.
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 133564.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
msearles accepted this revision.
msearles added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
kzhuravl added a comment.
I thought we could override `isPICDefault` in AMDGPUToolChain instead of doing
what is posted. But AMDGPUToolChain is only created for AMDHSA OS.
Do we want to enable PIC by default for all AMDGCNs? Or only for AMDHSA?
https://reviews.llvm.org/D43094
__
Author: compnerd
Date: Thu Feb 8 19:23:54 2018
New Revision: 324701
URL: http://llvm.org/viewvc/llvm-project?rev=324701&view=rev
Log:
AST: support ObjC lifetime qualifiers in MS ABI
Adjust the ObjC protocol conformance workaround to be more extensible.
Use a synthetic type for the protocol (`str
stephanemoore added a comment.
Thanks for the explanation 👌 I'm still learning the inner workings of clang 😅
The change looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
kito-cheng added a comment.
Hi Eli:
We need that because compiler-rt implement 128 bits soft floating point with
int128_t, and RISC-V need that but RV32 doesn't support int128_t, we know it's
can be just return true to support that. but we don't want to bring any ABI
contemptible issue between
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
No worries. LGTM!
https://reviews.llvm.org/D42549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:939
std::make_pair(D.getBindTemporaryExpr(), Pred->getStackFrame()));
+// *MRPtr may still be null when the construction context for the temporary
+// was not implemented.
---
rnk created this revision.
rnk added a reviewer: rsmith.
This fixes a flaw in our AST: PR27098
MSVC always gives plain enums the underlying type 'int'. Clang does this
as well, but we claim the enum is "fixed", as if the user actually wrote
': int'. It means we end up emitting spurious -Wsign-com
efriedma added a comment.
> This flag can then be used to build compiler-rt for RISCV32.
Can you give a little more context for why this is necessary? As far as I
know, compiler-rt generally supports building for targets which don't have
__int128_t. (If all riscv targets are supposed to suppo
nruslan created this revision.
nruslan added a reviewer: clang.
Herald added a subscriber: cfe-commits.
Adds support for this flag. There is also another piece for llvm (separate
review). More info: https://bugs.llvm.org/show_bug.cgi?id=36221
Repository:
rC Clang
https://reviews.llvm.org/D43
mgrang added a comment.
Related compiler-rt patch: https://reviews.llvm.org/D43106
Repository:
rC Clang
https://reviews.llvm.org/D43105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mgrang created this revision.
mgrang added reviewers: asb, kito-cheng, apazos.
Herald added subscribers: cfe-commits, niosHD, sabuasal, jordy.potman.lists,
simoncook, johnrusso, rbar, aheejin, jgravelle-google, sbc100, sdardis,
dschuff, jfb.
If the flag -fuse-int128 is passed, it will enable sup
Author: dergachev
Date: Thu Feb 8 17:43:26 2018
New Revision: 324697
URL: http://llvm.org/viewvc/llvm-project?rev=324697&view=rev
Log:
[CFG] Squash an unused variable introduced in r324668.
Found by -Werror buildbot.
Modified:
cfe/trunk/lib/Analysis/CFG.cpp
Modified: cfe/trunk/lib/Analysis
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:68-71
typedef llvm::ImmutableMap, SVal>
-CXXNewAllocatorValuesMap;
+ const LocationContext *>,
+ SVal>
+CXXNewAllocatorValuesMa
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:68-71
typedef llvm::ImmutableMap, SVal>
-
Author: rsmith
Date: Thu Feb 8 17:15:13 2018
New Revision: 324695
URL: http://llvm.org/viewvc/llvm-project?rev=324695&view=rev
Log:
[modules] Fix incorrect diagnostic mapping computation when a module changes
diagnostic settings using _Pragma within a macro.
The AST writer had previously been as
mattd updated this revision to Diff 133540.
mattd added a comment.
Thanks for the test tips. I realize the original was a bit carried away, my
apologies for that. This updated test visits the same code path that we're
trying to test, and is much more concise.
https://reviews.llvm.org/D42549
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
:-D
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
sammccall added a comment.
Some comments on the insert side, which looks pretty good. I'll take another
look at indexing tomorrow.
Comment at: clangd/ClangdServer.cpp:465
+auto &HeaderSearchInfo = Clang->getPreprocessor().getHeaderSearchInfo();
+std::string Suggested =
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
One down!
I'd like to know what you think about a generic "block the call and capture the
result" mechanism rather than method-specific wrappers.
But if you're not convinced or just want
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324689: [WinEH] Put funclet bundles on inline asm calls
(authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43033?vs=133263&id=1
Author: rnk
Date: Thu Feb 8 16:16:41 2018
New Revision: 324689
URL: http://llvm.org/viewvc/llvm-project?rev=324689&view=rev
Log:
[WinEH] Put funclet bundles on inline asm calls
Summary:
Fixes PR36247, which is where WinEHPrepare replaces inline asm in
funclets with unreachable.
Make getBundlesF
rjmccall added a comment.
Oh. It's not a good idea to try to match exact local IR names like this for
two reasons:
- First, many IR names are different in builds with and without assertions.
- Second, it's pretty susceptible to innocuous changes in output.
You should use FileCheck patterns (`[
Author: erichkeane
Date: Thu Feb 8 16:13:49 2018
New Revision: 324687
URL: http://llvm.org/viewvc/llvm-project?rev=324687&view=rev
Log:
Fix UBSan issue with PPC::isValidCPUName
Apparently storing the pointer to a StringLiteral as
a StringRef caused this section of code to issue a ubsan
warning.
Eugene.Zelenko added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8220
+
+} // End anonymous namespace.
Please change to // namespace
https://reviews.llvm.org/D43089
___
cfe-commits mailing list
Author: erichkeane
Date: Thu Feb 8 15:49:40 2018
New Revision: 324682
URL: http://llvm.org/viewvc/llvm-project?rev=324682&view=rev
Log:
Add size to constexpr Arrays
What seems to be a bug in older versions of MSVC, constexpr
member arrays with a redefinition (to force emission) require
their ini
az updated this revision to Diff 133505.
az added a comment.
> Question about the failures: I am now wondering if this means we were and
> still are missing tests?
Given that this work is fixing https://reviews.llvm.org/D41792 which is mainly
about adding frontend intrinsic support, then there
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324673: Make march/target-cpu print a note with the list of
valid values for ARM (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
kzhuravl created this revision.
kzhuravl added reviewers: nhaehnle, t-tye, timcorringham, tpr, tstellar.
Herald added subscribers: dstuttard, yaxunl, wdng.
https://reviews.llvm.org/D43094
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/amdgcn-toolchain-pic.cl
Index: test/Driver/amdg
NoQ added a comment.
Do you have commit access, or do you want me to commit this for you?
https://reviews.llvm.org/D42745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane updated this revision to Diff 133452.
erichkeane added a comment.
Relaxed the test further.
https://reviews.llvm.org/D42978
Files:
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/AArch64.cpp
lib/Basic/Tar
erichkeane added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:1
+// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s
2>&1 | FileCheck %s --check-prefix ARM
+// ARM: error: unknown target CPU 'not-a-cpu'
erichkeane w
erichkeane added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:1
+// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s
2>&1 | FileCheck %s --check-prefix ARM
+// ARM: error: unknown target CPU 'not-a-cpu'
Hahnfeld wro
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM thanks. Please wait a day or so with committing so others can raise
additional concerns.
Comment at: test/Misc/target-invalid-cpu-note.c:8
+// AARCH64: note: valid target
Hahnfeld added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:1
+// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s
2>&1 | FileCheck %s --check-prefix ARM
+// ARM: error: unknown target CPU 'not-a-cpu'
Is there a rea
erichkeane updated this revision to Diff 133442.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Removed extra newline.
https://reviews.llvm.org/D42978
Files:
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib
erichkeane added a comment.
That makes sense. I changed the ARM one to check ONLY the first one, since in
each case that seems like the oldest anyway. It at least makes sure that the
lists are distinct, and avoids this cross-repo fragility.
https://reviews.llvm.org/D42978
erichkeane updated this revision to Diff 133435.
erichkeane added a comment.
Simplified ARM tests as requested.
https://reviews.llvm.org/D42978
Files:
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/AArch64.cpp
lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324680: [analyzer] MallocChecker: Fix one more bug category.
(authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43074?vs=133423&id=133521#toc
Repository:
rC Cl
EricWF updated this revision to Diff 133517.
EricWF retitled this revision from "[Builtins] Overload
__builtin_operator_new/delete to accept an optional alignment parameter." to
"[Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual
allocation/deallocation functions.".
E
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324680: [analyzer] MallocChecker: Fix one more bug category.
(authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43074?vs=
erichkeane created this revision.
erichkeane added reviewers: echristo, craig.topper, aaron.ballman.
Herald added a subscriber: mgrang.
As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301
The issue is that the 'use' causes the plain declaration to emit
the attributes to LLVM-IR. However,
Author: dergachev
Date: Thu Feb 8 15:28:29 2018
New Revision: 324680
URL: http://llvm.org/viewvc/llvm-project?rev=324680&view=rev
Log:
[analyzer] MallocChecker: Fix one more bug category.
Even though most of the inconsistencies in MallocChecker's bug categories were
fixed in r302016, one more wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324676: Add Rest of Targets Support to ValidCPUList
(enabling march notes) (authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43057?vs=133459&id=133509#toc
Repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324675: Add NVPTX Support to ValidCPUList (enabling march
notes) (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4304
Author: erichkeane
Date: Thu Feb 8 15:16:55 2018
New Revision: 324676
URL: http://llvm.org/viewvc/llvm-project?rev=324676&view=rev
Log:
Add Rest of Targets Support to ValidCPUList (enabling march notes)
A followup to: https://reviews.llvm.org/D42978
Most of the rest of the Targets were pretty r
Author: erichkeane
Date: Thu Feb 8 15:16:00 2018
New Revision: 324675
URL: http://llvm.org/viewvc/llvm-project?rev=324675&view=rev
Log:
Add NVPTX Support to ValidCPUList (enabling march notes)
A followup to: https://reviews.llvm.org/D42978
This patch adds NVPTX support for
enabling the march not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324674: Add X86 Support to ValidCPUList (enabling march
notes) (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43041?
sammccall updated this revision to Diff 133502.
sammccall added a comment.
Revert hack in global-symbol-builder to filter the input files.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42942
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
clangd/index/Index
Author: erichkeane
Date: Thu Feb 8 15:15:02 2018
New Revision: 324674
URL: http://llvm.org/viewvc/llvm-project?rev=324674&view=rev
Log:
Add X86 Support to ValidCPUList (enabling march notes)
A followup to: https://reviews.llvm.org/D42978
This patch adds X86 and X86_64 support for
enabling the ma
Author: erichkeane
Date: Thu Feb 8 15:14:15 2018
New Revision: 324673
URL: http://llvm.org/viewvc/llvm-project?rev=324673&view=rev
Log:
Make march/target-cpu print a note with the list of valid values for ARM
When rejecting a march= or target-cpu command line parameter,
the message is quite lack
sammccall added a comment.
Thanks for the comments!
And sorry for the delay, I was haunted by useless gtest messages, which
https://reviews.llvm.org/D43091 should fix.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:159
+ // Output phase: emit YAML for re
sammccall updated this revision to Diff 133501.
sammccall marked 6 inline comments as done.
sammccall added a comment.
Address review comments.
Make SymbolsToYAML take an ostream instead of returning a string.
Define SymbolSlab::iterator so googletest will print it as a container.
Repository:
NoQ added a comment.
I guess this happened due to a race with https://reviews.llvm.org/rL301913. My
bad anyways^^
Repository:
rC Clang
https://reviews.llvm.org/D43074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324668: [CFG] Add extra context to C++ constructor statement
elements. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42672?vs=133139&id=133500#toc
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324668: [CFG] Add extra context to C++ constructor statement
elements. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: dergachev
Date: Thu Feb 8 14:58:15 2018
New Revision: 324668
URL: http://llvm.org/viewvc/llvm-project?rev=324668&view=rev
Log:
[CFG] Add extra context to C++ constructor statement elements.
This patch adds a new CFGStmt sub-class, CFGConstructor, which replaces
the regular CFGStmt with C
mattd updated this revision to Diff 133497.
mattd added a comment.
Thanks for the look @rjmccall . I tossed in the shortcut as you suggested. I
also had to fix the instruction numbering in the test case.
https://reviews.llvm.org/D42549
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGen/a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324663: [analyzer] Self-debug: Dump the core's internal
state traits to the egraph. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42560
Files:
include/clang/
Author: dergachev
Date: Thu Feb 8 14:32:38 2018
New Revision: 324663
URL: http://llvm.org/viewvc/llvm-project?rev=324663&view=rev
Log:
[analyzer] Self-debug: Dump the core's internal state traits to the egraph.
It is useful for debugging problems with C++ operator new() or temporaries.
Differen
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324660: [analyzer] Self-debug: Dump environment
frame-by-frame. (authored by dergachev, committed by ).
Herald added a sub
Author: dergachev
Date: Thu Feb 8 14:24:38 2018
New Revision: 324660
URL: http://llvm.org/viewvc/llvm-project?rev=324660&view=rev
Log:
[analyzer] Self-debug: Dump environment frame-by-frame.
It makes it easier to discriminate between values of similar expressions
in different stack frames.
It a
simark added inline comments.
Comment at: unittests/clangd/XRefsTests.cpp:231
+TEST(Hover, All) {
+
+ struct OneTest {
ilya-biryukov wrote:
> NIT: remove empty line at the start of the function
Done.
Comment at: unittests/clangd/XRefsTests.cpp
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:325
+void ClangdLSPServer::onHover(TextDocumentPositionParams &Params) {
+
+ llvm::Expected> H =
ilya-biryukov wrote:
> NIT: remove the empty line at the start of function
Done.
=
petecoup created this revision.
petecoup added a reviewer: tatyana-krasnukha.
Herald added subscribers: hintonda, mgorny.
https://reviews.llvm.org/D43089
Files:
clang/lib/Basic/CMakeLists.txt
clang/lib/Basic/Targets.cpp
clang/lib/Basic/Targets/ARC.cpp
clang/lib/Basic/Targets/ARC.h
clang
NoQ accepted this revision.
NoQ added a comment.
Woohoo thanks nice.
Repository:
rC Clang
https://reviews.llvm.org/D43074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
All right, so this change is indeed safe, i.e. no crashes or changes in
analyzer behavior so far on my large codebase run. Will commit now.
https://reviews.llvm.org/D42672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: george.karpenkov
Date: Thu Feb 8 13:22:42 2018
New Revision: 324652
URL: http://llvm.org/viewvc/llvm-project?rev=324652&view=rev
Log:
[analyzer] [tests] Test different projects concurrently
Differential Revision: https://reviews.llvm.org/D43031
Modified:
cfe/trunk/utils/analyzer/SAT
Author: arphaman
Date: Thu Feb 8 13:20:43 2018
New Revision: 324651
URL: http://llvm.org/viewvc/llvm-project?rev=324651&view=rev
Log:
PR36307: Consume the #pragma options align annotation token after
semantic analysis to prevent incorrect -Wpragma-pack warning for an included
file
rdar://3735495
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Tests look good. You can't test deadcode :)
https://reviews.llvm.org/D42745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
NoQ added a comment.
Hmm, maybe it'd also be a good idea to disable the check completely when a
likely-correct value for the macro cannot be determined.
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:74-75
+ mgr.registerChecker();
+ Mwec->ProtExecOv =
+
simark added a comment.
In https://reviews.llvm.org/D35894#1001875, @ilya-biryukov wrote:
> Thanks for picking this up!
> I have just one major comment related to how we generate the hover text.
>
> Current implementation tries to get the actual source code for every
> declaration and then patc
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
All right, i guess we already do have a pair of callbacks for `IntegerLiteral`
and it doesn't hurt, especially because here they'd eventually be actually
useful. I think it should land, just to make
MaskRay updated this revision to Diff 133476.
MaskRay added a comment.
.rst
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/SIMDIntrinsicsCheck.cpp
NoQ updated this revision to Diff 133475.
NoQ added a comment.
Add a simple test for a class with no destructor.
https://reviews.llvm.org/D43062
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/temporaries.cpp
Index: test/Analysis/temporaries.cpp
=
MaskRay updated this revision to Diff 133474.
MaskRay added a comment.
Herald added subscribers: kbarton, nemanjai.
Split test/clang-tidy/readability-simd-intrinsics.cpp to x86 and ppc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLis
MTC added a comment.
@NoQ Sorry to bother you again. It seems that this patch is useless to analyzer
temporarily, if you think so, I will abandon it : ).
Repository:
rC Clang
https://reviews.llvm.org/D42300
___
cfe-commits mailing list
cfe-commi
Author: ctopper
Date: Thu Feb 8 12:16:17 2018
New Revision: 324647
URL: http://llvm.org/viewvc/llvm-project?rev=324647&view=rev
Log:
[X86] Replace kortest intrinsics with native IR.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/tru
Author: erichkeane
Date: Thu Feb 8 12:04:22 2018
New Revision: 324644
URL: http://llvm.org/viewvc/llvm-project?rev=324644&view=rev
Log:
Fix improper indentation issue in CodeGenModule [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
U
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
erichkeane wrote:
> tra wr
erichkeane added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
tra wrote:
> Nit: G
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Fair. Did you want to handle this a different way? I thought the list at
least seemed reasonable for spelling.
On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator <
revi...@reviews.llvm.org> wrote:
> tra added inline comments.
>
>
>
> Comment at: test/Misc/target-invalid
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
Nit: Generally speaking th
arsenm closed this revision.
arsenm added a comment.
r324641
https://reviews.llvm.org/D43078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Thu Feb 8 11:37:09 2018
New Revision: 324641
URL: http://llvm.org/viewvc/llvm-project?rev=324641&view=rev
Log:
Fix crash on array initializer with non-0 alloca addrspace
Modified:
cfe/trunk/lib/CodeGen/CGDecl.cpp
cfe/trunk/test/CodeGenOpenCL/address-space-constant-in
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I've glanced at this and didn't notice anything. I think any problems can be
fixed in post-commit review if necessary.
https://reviews.llvm.org/D43057
_
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM with an inline comment.
Comment at: include/clang/Basic/Cuda.h:49
SM_72,
+ LAST,
};
We have last, invalid, etc... maybe we should pick one amon
Author: marshall
Date: Thu Feb 8 11:33:03 2018
New Revision: 324640
URL: http://llvm.org/viewvc/llvm-project?rev=324640&view=rev
Log:
The apple versions of clang don't support deduction guides yet.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cp
erichkeane updated this revision to Diff 133459.
erichkeane added a comment.
rebased, reflowed tests.
https://reviews.llvm.org/D43057
Files:
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
lib/Basic/Targets/AVR.cpp
lib/Basic/Targets/AVR.h
lib/Basic/Targets/BPF.cpp
lib/Basic/
erichkeane updated this revision to Diff 133458.
erichkeane added a comment.
rebased, reflowed tests.
https://reviews.llvm.org/D43045
Files:
include/clang/Basic/Cuda.h
lib/Basic/Cuda.cpp
lib/Basic/Targets/NVPTX.cpp
lib/Basic/Targets/NVPTX.h
test/Misc/target-invalid-cpu-note.c
Index:
MaskRay updated this revision to Diff 133457.
MaskRay added a comment.
Set `Enabled` to 1 in test/clang-tidy/readability-simd-intrinsics.cpp
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityT
rjmccall added a comment.
I'm somewhat surprised LLVM doesn't already canonicalize this, but ok.
Should we also do this when building a constant struct?
Comment at: lib/CodeGen/CGExprConstant.cpp:873
Elts.push_back(C);
+ if (!C->isNullValue())
+AllNullValue
1 - 100 of 172 matches
Mail list logo
