AlexeySotkin created this revision.
https://reviews.llvm.org/D39936
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Headers/opencl-c.h
test/SemaOpenCL/extension-version.cl
Index: test/SemaOpenCL/extension-version.cl
===
--
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
eric_niebler accepted this revision.
eric_niebler added a comment.
This revision is now accepted and ready to land.
Looks ok to me.
https://reviews.llvm.org/D39768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: jakehehrlich
Date: Fri Nov 10 17:15:41 2017
New Revision: 317960
URL: http://llvm.org/viewvc/llvm-project?rev=317960&view=rev
Log:
Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission
llvm-objcopy is getting to where it can be used in non-trivial ways
(such as fo
arphaman updated this revision to Diff 122565.
arphaman marked 3 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D39706
Files:
lib/Tooling/Refactoring/CMakeLists.txt
lib/Tooling/Refactoring/Extract/CaptureVariables.c
arphaman added inline comments.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.h:36
+ explicit CapturedExtractedEntity(const VarDecl *VD)
+ : Kind(CapturedVarDecl), VD(VD) {}
+
ioeric wrote:
> arphaman wrote:
> > ioeric wrote:
> > > Maybe a `F
akyrtzi added a comment.
Hey Eric,
In https://reviews.llvm.org/D39050#921748, @ioeric wrote:
> >> - I think the implementation of the index output logic (e.g.
> >> `IndexUnitWriter` and bit format file) can be abstracted away (and split
> >> into separate patches) so that you can unit-test the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317962: [CUDA] [test-suite] Test std::min and std::max with
C++11. (authored by jlebar).
Repository:
rL LLVM
https://reviews.llvm.org/D39818
Files:
test-suite/trunk/External/CUDA/algorithm.cu
Inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317961: [CUDA] Fix std::min on device side to return the
min, not the max. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D39817?vs=122151&id=122563#toc
Repository:
rL LLVM
Author: jlebar
Date: Fri Nov 10 17:25:44 2017
New Revision: 317961
URL: http://llvm.org/viewvc/llvm-project?rev=317961&view=rev
Log:
[CUDA] Fix std::min on device side to return the min, not the max.
Summary:
How embarrassing.
This is tested in the test-suite -- fix to come there in a separate
p
mcgrathr added a comment.
In principle this should be OK since we're unconditionally building the
runtimes for `default`.
However, this means that any dynamically-linked host builds will assume our
toolchain-provided shared libraries are available on the runtime host in
standard library places.
Author: tejohnson
Date: Fri Nov 10 17:06:41 2017
New Revision: 317959
URL: http://llvm.org/viewvc/llvm-project?rev=317959&view=rev
Log:
Revert "[ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang"
This reverts commit r317951 and r317952. The new test is aborting on
some bots a
Author: rtrieu
Date: Fri Nov 10 16:54:25 2017
New Revision: 317957
URL: http://llvm.org/viewvc/llvm-project?rev=317957&view=rev
Log:
Handle lambda captures of variable length arrays in profiling and printing.
From http://reviews.llvm.org/D4368 these cases were thought to not be reachable
and the
phosek created this revision.
Herald added subscribers: mgorny, dberris.
Herald added a reviewer: EricWF.
Fuchsia already defaults to libc++ and compiler-rt, but we want to use
these as default runtimes even on the host platform.
Repository:
rL LLVM
https://reviews.llvm.org/D39930
Files:
c
hans updated this revision to Diff 122557.
hans added a comment.
Updating to match the LLVM-side: https://reviews.llvm.org/D39287#inline-348143
https://reviews.llvm.org/D39331
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
Wizard marked 2 inline comments as done.
Wizard added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:27
+FixItHint generateFixItHint(const ObjCPropertyDecl *Decl) {
+ if (isupper(Decl->getName()[0])) {
+auto NewName = Decl->getName().str();
---
Wizard updated this revision to Diff 122552.
Wizard marked 9 inline comments as done.
Wizard added a comment.
add custom options
https://reviews.llvm.org/D39829
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-ti
arphaman added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12853
+ const llvm::Triple &Trip = Context.getTargetInfo().getTriple();
+ if ((Trip.isGNUEnvironment() || Trip.isKnownWindowsMSVCEnvironment()) &&
+ (Name->isStr("fma") || Name->isStr("fmaf") ||
Author: eugenezelenko
Date: Fri Nov 10 16:08:50 2017
New Revision: 317953
URL: http://llvm.org/viewvc/llvm-project?rev=317953&view=rev
Log:
[Serialization] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Serializatio
Author: tejohnson
Date: Fri Nov 10 16:05:39 2017
New Revision: 317952
URL: http://llvm.org/viewvc/llvm-project?rev=317952&view=rev
Log:
Add x86-registered-target to REQUIRES for new test
Should fix test added in r317951.
Modified:
cfe/trunk/test/CodeGen/thinlto-debug-pm.c
Modified: cfe/trun
arphaman added a comment.
ok, sgtm
https://reviews.llvm.org/D39446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:244
+ DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt)
+ DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt)
+
arphaman wrote:
> What about `ObjCAtTryStmt`?
I thought about this, but: we don't place a counter on ObjC a
arphaman added a comment.
Generally it LG
Comment at: lib/CodeGen/CodeGenPGO.cpp:244
+ DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt)
+ DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt)
+
What about `ObjCAtTryStmt`?
Comment at: lib/CodeGen/CodeGenPGO.cpp:321
spatel updated this revision to Diff 122545.
spatel added a comment.
Patch updated:
cbrt() is always const. fma() is always const with GNU or Win+MSVC.
https://reviews.llvm.org/D39641
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaDecl.cpp
test/CodeGen/li
Author: tejohnson
Date: Fri Nov 10 15:37:39 2017
New Revision: 317951
URL: http://llvm.org/viewvc/llvm-project?rev=317951&view=rev
Log:
[ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang
Summary:
The LTO Config field wasn't being set when invoking a ThinLTO backend
via clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317951: [ThinLTO] Handle -fdebug-pass-manager for backend
invocations via clang (authored by tejohnson).
Repository:
rL LLVM
https://reviews.llvm.org/D39923
Files:
cfe/trunk/lib/CodeGen/BackendUtil.
Nebiroth added a comment.
This updated patch still does not handle highlighting macro references
correctly. I will make another patch at a later time for this issue.
In https://reviews.llvm.org/D38425#922408, @ioeric wrote:
> Drive-by comment: in general, have you considered reusing the existin
ioeric added a comment.
Drive-by comment: in general, have you considered reusing the existing
declarations and occurrences finding functionalities in clang-rename? AFAIK, it
deals with templates and macros pretty well.
o
https://github.com/llvm-mirror/clang/blob/master/include/clang/Tooling/R
Author: hans
Date: Fri Nov 10 14:34:23 2017
New Revision: 317944
URL: http://llvm.org/viewvc/llvm-project?rev=317944&view=rev
Log:
Remove declaration of EmitMCountInstrumentation(). NFC
The definition was removed in r280355.
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.h
Modified: cfe/tr
Hello everyone,
We will be installing some network hardware in the Lab today. Most likely
everything will go well, but there is a chance of network outage around
4:00 PM PST. Thanks for your patience and understanding.
Thanks
Galina
___
cfe-commits mai
Author: jvesely
Date: Fri Nov 10 14:16:39 2017
New Revision: 317940
URL: http://llvm.org/viewvc/llvm-project?rev=317940&view=rev
Log:
native_sqrt: Switch implementation to llvm intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_sqrt.cl
Mo
Author: jvesely
Date: Fri Nov 10 14:16:41 2017
New Revision: 317941
URL: http://llvm.org/viewvc/llvm-project?rev=317941&view=rev
Log:
native_exp10: Switch implementation to llvm intrinsic
v2: Use native_log2 instead of wrong constant
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
Nebiroth updated this revision to Diff 122529.
Nebiroth added a comment.
Decls and MacroInfos vectors are now private and passed by reference instead of
copied.
DeclarationLocationsFinder does not store Locations anymore, instead the vector
is filled in their respective methods in ClangdUnit.cpp
Author: jvesely
Date: Fri Nov 10 14:16:31 2017
New Revision: 317937
URL: http://llvm.org/viewvc/llvm-project?rev=317937&view=rev
Log:
native_exp2: Switch implementation to llvm intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_exp2.cl
Mo
Author: jvesely
Date: Fri Nov 10 14:16:33 2017
New Revision: 317938
URL: http://llvm.org/viewvc/llvm-project?rev=317938&view=rev
Log:
native_cos: Switch implementation to llvm intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_cos.cl
Modi
Author: jvesely
Date: Fri Nov 10 14:16:36 2017
New Revision: 317939
URL: http://llvm.org/viewvc/llvm-project?rev=317939&view=rev
Log:
native_sin: Switch implementation to llvm intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_sin.cl
Modi
Author: jvesely
Date: Fri Nov 10 14:16:28 2017
New Revision: 317936
URL: http://llvm.org/viewvc/llvm-project?rev=317936&view=rev
Log:
native_exp: Switch implementation to llvm intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_exp.cl
Modi
Author: jvesely
Date: Fri Nov 10 14:16:25 2017
New Revision: 317935
URL: http://llvm.org/viewvc/llvm-project?rev=317935&view=rev
Log:
amdgpu: Add workaround for unimplemented llvm.exp intrinsic
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/amdgpu/lib/math/native_exp.
Nebiroth updated this revision to Diff 122528.
Nebiroth added a comment.
- Decls and MacroInfos vectors are now private and passed by reference instead
of copied.
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/C
Author: jvesely
Date: Fri Nov 10 14:16:22 2017
New Revision: 317934
URL: http://llvm.org/viewvc/llvm-project?rev=317934&view=rev
Log:
native_log10: Switch to generic native intrinsic inc file
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Removed:
libclc/trunk/generic/lib/math/native_log
Author: jvesely
Date: Fri Nov 10 14:16:20 2017
New Revision: 317933
URL: http://llvm.org/viewvc/llvm-project?rev=317933&view=rev
Log:
native_log: Switch to generic native intrinsic inc file
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Removed:
libclc/trunk/generic/lib/math/native_log.i
Author: jvesely
Date: Fri Nov 10 14:16:15 2017
New Revision: 317932
URL: http://llvm.org/viewvc/llvm-project?rev=317932&view=rev
Log:
native_log2: Switch to generic native intrinsic inc file
v2: Add __CLC_XCONCAT instead of function name redirection
Use __CLC_XCONCAT for intrinsic functions a
danielcdh accepted this revision.
danielcdh added a comment.
This revision is now accepted and ready to land.
Thanks for the fix.
https://reviews.llvm.org/D39923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: zturner
Date: Fri Nov 10 14:12:04 2017
New Revision: 317931
URL: http://llvm.org/viewvc/llvm-project?rev=317931&view=rev
Log:
Fix for skipped CMake configuration on debuginfo-tests.
This should have been part of the change to debuginfo-tests, but
it was left out. This should get the buil
tejohnson created this revision.
Herald added subscribers: eraman, inglorion, mehdi_amini.
The LTO Config field wasn't being set when invoking a ThinLTO backend
via clang (i.e. for distributed builds).
https://reviews.llvm.org/D39923
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/thinlto-d
erik.pilkington added a comment.
Any thoughts on having this for regular functions and C++ member functions?
Seems just as useful there.
Comment at: include/clang/Sema/Sema.h:2406
+ /// This will warn on any missing clauses in the declaration.
+ void checkMissingAvailability
alexshap updated this revision to Diff 122507.
alexshap added a comment.
Address the comments
Repository:
rL LLVM
https://reviews.llvm.org/D39438
Files:
lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
test/Analysis/stack-capture-leak-arc.mm
test/Analysis/stack-capture-leak-no-ar
Author: zturner
Date: Fri Nov 10 12:57:57 2017
New Revision: 317925
URL: http://llvm.org/viewvc/llvm-project?rev=317925&view=rev
Log:
[debuginfo-tests] Make debuginfo-tests work in a standard configuration.
Previously, debuginfo-tests was expected to be checked out into
clang/test and then the te
mstorsjo created this revision.
Herald added a subscriber: aprantl.
If the linker chose to store the full section name instead of truncating it,
this field doesn't contain a truncated name, but an offset into the string
table of the binary. The string table isn't loaded/mapped into memory during
mgrang created this revision.
mgrang added a project: clang.
Herald added a subscriber: jholewinski.
https://reviews.llvm.org/D39915
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Driver/Driver.cpp
lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
Index: lib/StaticAnalyzer/Checkers
efriedma added a comment.
cbrt() can't underflow; that's not how cube roots work. If 0 x.
See also the definition of rootn() in IEEE 754 (which specifies no exceptions
for n=3).
For fma(), sure, I guess we could whitelist glibc and msvcrt, if you're worried
there's some unknown implementatio
arphaman created this revision.
Herald added a subscriber: javed.absar.
This patch extends the -Wavailability warning to warn about cases where a
method declaration is missing an availability attribute clause that's present
in the method's definition. We also warn about missing `deprecated` attr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317917: AMDGPU: Add -mxnack/-mno-xnack options that set
+/-xnack feature (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D39878?vs=122355&id=122489#toc
Repository:
rL LLVM
Author: kzhuravl
Date: Fri Nov 10 11:28:25 2017
New Revision: 317917
URL: http://llvm.org/viewvc/llvm-project?rev=317917&view=rev
Log:
AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature
Differential Revision: https://reviews.llvm.org/D39878
Modified:
cfe/trunk/include/clang/Dri
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
In https://reviews.llvm.org/D38801#910524, @NoQ wrote:
> Also the overload between `getSVal(Ex, LC)` and `getSVal(R, Ty)`, when they
> do completely different things, seem
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317909: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU
toolchain (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D39877?vs=122354&id=122487#toc
Repository:
rL LLVM
http
Author: kzhuravl
Date: Fri Nov 10 11:09:57 2017
New Revision: 317909
URL: http://llvm.org/viewvc/llvm-project?rev=317909&view=rev
Log:
AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain
Differential Revision: https://reviews.llvm.org/D39877
Modified:
cfe/trunk/lib/Driver/ToolChains
spatel added a comment.
Based on the comments in https://reviews.llvm.org/D39611, I think we have to
change this (although I'd be happy to be wrong).
1. cbrt() can underflow and could set errno to ERANGE.
2. fma() can overflow or underflow and set errno to ERANGE.
We could still make an excepti
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM.
I suppose we could move the logic that constructs pointers to members for
fields here (right now that logic is in ExprEngine::VisitUnaryOperator()'s
handling of '&'). However, since the AST's DeclRefExpr for the field is marked
jakehehrlich added a comment.
> Another option would be to restrict `CLANG_DEFAULT_OBJCOPY` to contain
> `objcopy` or even to only allow `objcopy` or `llvm-objcopy`. I don't know if
> that's sensible though...
I think there are some other strip/objcopy like implementations out there but I
thin
spatel updated this revision to Diff 122474.
spatel added a comment.
Patch updated:
Except for cimag, cproj, conj, and creal, everything in is marked 'e'
- the functions are not const if we might set errno.
https://reviews.llvm.org/D39611
Files:
include/clang/Basic/Builtins.def
test/CodeG
Hahnfeld added a comment.
In https://reviews.llvm.org/D39821#922026, @jakehehrlich wrote:
> In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote:
>
> > I think the current tests will only pass iff the executable name ends with
> > `objcopy` - can we make this more reliable?
>
>
> If I read
arphaman added a comment.
Also,
Comment at: lib/Sema/SemaCodeComplete.cpp:980
+ if (isa(R.Declaration)
+ && dyn_cast(CurContext) == nullptr
+ && dyn_cast(CurContext) == nullptr
arphaman wrote:
> You can use `!isa`
Have you checked if this check works
jakehehrlich added a comment.
In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote:
> I think the current tests will only pass iff the executable name ends with
> `objcopy` - can we make this more reliable?
If I read the tests (split-debug.h, split-debug.c, and split-debug.s) correctly
arphaman added a comment.
It doesn't look like this works in the body of the class (at least there's no
test for it). For that you might have to inject these kind results by
performing another lookup when completing inside the body of the class.
Comment at: lib/Sema/SemaCodeC
jkorous-apple updated this revision to Diff 122470.
jkorous-apple added a comment.
I am able to enable ctor completion selectively in translate unit scope and
namespace scope so ctor completion does not appear in dot access context. I
haven't figured out how to explicitly specify that completion
hfinkel added a comment.
In https://reviews.llvm.org/D39611#921923, @spatel wrote:
> Thanks for the clarification!
>
> If I'm reading this properly, we should make the same kind of change as in
> https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the
> standard allows errno
On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits
wrote:
> On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote:
>> Huh, I consider clang not warning on this a feature, not a bug. Why are we
>> trying to match what gcc does here?
> Because i have been bitten by this more than once.
> I
ioeric added inline comments.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.cpp:97
+ }
+ llvm_unreachable("invalid kind!");
+}
A more informative message would be better.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVaria
frutiger added a comment.
Thanks for the note, I'll wait.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel added a comment.
Thanks for the clarification!
If I'm reading this properly, we should make the same kind of change as in
https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the
standard allows errno-setting, and it's (unfortunately for optimization) even
more clearl
djasper closed this revision.
djasper added a comment.
Submitted as r317901.
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Fri Nov 10 09:11:18 2017
New Revision: 317901
URL: http://llvm.org/viewvc/llvm-project?rev=317901&view=rev
Log:
[clang-format] Handle leading comments in using declaration
This fixes clang-format internal assertion for the following code:
/* override */ using std::string;
mgorny added a comment.
I've rewritten the tests to use `unittest`, so this patch needs to be updated
now. However, you may want to wait a while since @compnerd promised to look at
it and he might have a way to get `uniqueExternal()` linkage.
https://reviews.llvm.org/D39161
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Maybe we should further refactor `getRawStringStyle` into
`llvm::Optional> getRawStringStyleAndDelimiter` and
that would nicely take care of the duplicated effort?
https://reviews.llvm.o
Author: cbertol
Date: Fri Nov 10 08:49:09 2017
New Revision: 317898
URL: http://llvm.org/viewvc/llvm-project?rev=317898&view=rev
Log:
[NFC] Pacify bbot for OpenMP 'teams distribute parallel for'
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_messages.cpp
Modified: cfe/trunk/te
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:41
+ objcPropertyDecl(
+ // the property name should be in Lower Camel Case like
+ // 'lowerCamelCase'
benhamilton wrote:
> There are some exception
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:41
+ objcPropertyDecl(
+ // the property name should be in Lower Camel Case like
+ // 'lowerCamelCase'
There are some exceptions we should special c
mgorny added a comment.
Thanks. I'll update it to incorporate the lately committed test fixes, and push
it later today.
Repository:
rL LLVM
https://reviews.llvm.org/D39763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 317893.
Repository:
rL LLVM
https://reviews.llvm.org/D39902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: cbertol
Date: Fri Nov 10 08:05:00 2017
New Revision: 317893
URL: http://llvm.org/viewvc/llvm-project?rev=317893&view=rev
Log:
[OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'
https://reviews.llvm.org/D39902
Simply leverage existing implementation and verify correc
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D39902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
carlo.bertolli created this revision.
Simply leverage existing implementation and verify correct functioning with two
regression tests.
Repository:
rL LLVM
https://reviews.llvm.org/D39902
Files:
include/clang/Basic/OpenMPKinds.def
test/OpenMP/teams_distribute_parallel_for_ast_print.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317891: [OpenMP] diagnose assign to firstprivate const,
patch by Joel E. Denny (authored by ABataev).
Changed prior to commit:
https://reviews.llvm.org/D39859?vs=122329&id=122434#toc
Repository:
rL L
Author: abataev
Date: Fri Nov 10 07:39:50 2017
New Revision: 317891
URL: http://llvm.org/viewvc/llvm-project?rev=317891&view=rev
Log:
[OpenMP] diagnose assign to firstprivate const, patch by Joel E. Denny
Summary:
[OpenMP] diagnose assign to firstprivate const
Clang does not diagnose assignments
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1028
+ unsigned Penalty =
+ handleEndOfLine(Current, State, DryRun, AllowBreak);
krasimir wrote:
> Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of
>
klimek updated this revision to Diff 122433.
klimek marked an inline comment as done.
klimek added a comment.
- Add test.
Updating D39900: Refactor ContinuationIndenter's breakProtrudingToken logic
into slightly more
===
klimek added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:99
/// Changes options inside \p CI to use PCH from this preamble. Also remaps
- /// main file to \p MainFileBuffer.
+ /// main file to \p MainFileBuffer and updates \p VFS to ensure pream
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1028
+ unsigned Penalty =
+ handleEndOfLine(Current, State, DryRun, AllowBreak);
Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of the
line?
==
ABataev added a comment.
In https://reviews.llvm.org/D39859#921780, @jdenny wrote:
> Alexey: Thanks for accepting. I do not have commit privileges. Would you
> please commit for me?
Sure, no problems.
https://reviews.llvm.org/D39859
___
cfe-co
jdenny added a comment.
Alexey: Thanks for accepting. I do not have commit privileges. Would you
please commit for me?
https://reviews.llvm.org/D39859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG.
https://reviews.llvm.org/D37554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek created this revision.
This patch allowed me to experiment with various alternatives to
https://reviews.llvm.org/D33589.
https://reviews.llvm.org/D39900
Files:
lib/Format/BreakableToken.cpp
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
unittests/Format/Fo
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D39859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
>> - I think the implementation of the index output logic (e.g.
>> `IndexUnitWriter` and bit format file) can be abstracted away (and split
>> into separate patches) so that you can unit-test the action with a
>> custom/mock unit writer; this would also make the action r
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I can't really check if all the tests are equivalent to the old ones, but not
having to install nose is a major usability improvement. Let's ship this.
We should totally fix the existing fai
Hahnfeld added a comment.
I think the current tests will only pass iff the executable name ends with
`objcopy` - can we make this more reliable?
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
cfe-commits mailing list
cfe-commits@lists.l
1 - 100 of 109 matches
Mail list logo
