dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!

In https://reviews.llvm.org/D38801#910524, @NoQ wrote:

> Also the overload between `getSVal(Ex, LC)` and `getSVal(R, Ty)`, when they 
> do completely different things, seems confusing.


Yes! I think we should change this (possibly rename them both?). I think it is 
a big barrier to entry -- I certainly found it super confusing when first 
getting started on the analyzer code base.


https://reviews.llvm.org/D38801



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D38801: [analyzer]... Devin Coughlin via Phabricator via cfe-commits

Reply via email to