kimgr added a comment.
Why? It seems easier to me to map back if the diagnostic mirrors the code
as-written.
https://reviews.llvm.org/D39360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Incremental progress is fine :)
On 26 Oct 2017 09:53, "Keane, Erich via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Thanks for the review Richard. Would you like me to revert, or can I just
make these changes in a new patch?
*From:* Richard Smith [mailto:rich...@metafoo.co.uk]
*Sent:*
Rakete created this revision.
Rakete added a project: clang.
This patch removes the empty `""` when using `static_assert(1 + 1 == 3, "");`
in the diagnostic:
main.cpp:1:1: error: static_assert failed
static_assert(1 + 1 == 3, "");
^ ~~
https://reviews.llvm.org
looks good! Feel free to commit whenever, I'd definitely recommend posting
a PSA on cfe-dev@ (after you commit) so that people know about it. You
might also get some useful ideas for improvements that way too.
On Thu, Oct 26, 2017 at 9:52 PM Don Hinton wrote:
> On Thu, Oct 26, 2017 at 5:44 PM,
compnerd added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:231
+ else if (Triple.isWatchABI())
+PtrDiffType = SignedLong;
+
I changed this to:
if (Triple.isOSDarwin() && !Triple.isWatchABI())
PtrDiffType = SignedInt;
Repository:
rL
On Thu, Oct 26, 2017 at 5:44 PM, Zachary Turner wrote:
>
>
> On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote:
>
>> On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner
>> wrote:
>>
>>> Seems fine, it would be nice if the workflow could be improved a little
>>> bit so that all you have to do is say
hintonda updated this revision to Diff 120538.
hintonda added a comment.
- Add ability to add breakpoints matching -W warnings.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev/nul
mstorsjo added a comment.
In https://reviews.llvm.org/D39280#908825, @compnerd wrote:
> I dont think that this is correct. IIRC, the unwind specification expects
> `unw_word_t` to match `uintptr_t` (that is, it should be 32-bits on
> https://reviews.llvm.org/P32 environments).
Ok, well curre
compnerd updated this revision to Diff 120534.
compnerd added a comment.
Catch a couple of missed instances, add more context
Repository:
rL LLVM
https://reviews.llvm.org/D39321
Files:
lib/Basic/Targets/ARM.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
===
compnerd added a comment.
I dont think that this is correct. IIRC, the unwind specification expects
`unw_word_t` to match `uintptr_t` (that is, it should be 32-bits on
https://reviews.llvm.org/P32 environments).
https://reviews.llvm.org/D39280
__
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: src/DwarfInstructions.hpp:170
const int lastReg = R::lastDwarfRegNum();
- assert((int)CFI_Parser::kMaxRegisterNumber > lastReg &&
+ asser
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:706
+
+ // Determine architecture part of the file name, if it presents.
+ size_t ArchPrefixLen = 0;
if it presents. -> if it is present.
Comment at: lib/Driver/Driver.cpp:739
+
sbc100 updated this revision to Diff 120529.
sbc100 added a comment.
- rebase
https://reviews.llvm.org/D39354
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/WebAssembly.cpp
test/Driver/wasm-toolchain.c
Index: test/Driver/wasm-toolchain.c
==
erichkeane added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:1173
.Case("x86", true)
+ .Case("x87", true)
.Case("x86_32", true)
A test also revealed that we forgot this as well. Craig just added sse4, which
was also missing.
http
erichkeane created this revision.
Craig noticed that CodeGen wasn't properly ignoring the
values sent to the target attribute. This patch ignores
them.
This patch also sets the 'default' for this checking to
'supported', since only X86 has implemented the support
for checking valid CPU names an
Author: sbc
Date: Thu Oct 26 18:20:16 2017
New Revision: 316725
URL: http://llvm.org/viewvc/llvm-project?rev=316725&view=rev
Log:
Fix test/Driver/wasm-toolchain.c on windows
Modified:
cfe/trunk/test/Driver/wasm-toolchain.c
Modified: cfe/trunk/test/Driver/wasm-toolchain.c
URL:
http://llvm.or
Author: vsapsai
Date: Thu Oct 26 17:56:23 2017
New Revision: 316723
URL: http://llvm.org/viewvc/llvm-project?rev=316723&view=rev
Log:
[CodeGen] Add support for IncompleteArrayType in Obj-C ivars.
Fixes an assertion failure when ivar is a struct containing incomplete
array. Also completes support
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316723: [CodeGen] Add support for IncompleteArrayType in
Obj-C ivars. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D38774?vs=120337&id=120524#toc
Repository:
rL LLVM
http
On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote:
> On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner
> wrote:
>
>> Seems fine, it would be nice if the workflow could be improved a little
>> bit so that all you have to do is say `clangdiag break
>> —error=“-Wcovered-switch”` or something . I think
hintonda updated this revision to Diff 120518.
hintonda added a comment.
- Maintain process id map for diagtool.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev/null
+++ utils/cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316719: [WebAssembly] Include libclang_rt.builtins in the
standard way (authored by sbc).
Changed prior to commit:
https://reviews.llvm.org/D39218?vs=120111&id=120516#toc
Repository:
rL LLVM
https:/
Author: sbc
Date: Thu Oct 26 17:26:07 2017
New Revision: 316719
URL: http://llvm.org/viewvc/llvm-project?rev=316719&view=rev
Log:
[WebAssembly] Include libclang_rt.builtins in the standard way
Differential Revision: https://reviews.llvm.org/D39218
Modified:
cfe/trunk/lib/Driver/ToolChain.cpp
Author: ctopper
Date: Thu Oct 26 17:18:16 2017
New Revision: 316718
URL: http://llvm.org/viewvc/llvm-project?rev=316718&view=rev
Log:
[X86] Add 'sse4' to X86TargetInfo::isValidFeatureName
sse4 is valid for target attribute and functions as an alias of sse4.2.
Modified:
cfe/trunk/lib/Basic/Ta
erichkeane updated this revision to Diff 120513.
erichkeane added a comment.
Realized I can put variables in an Attribute, so I put MV info in the Attribute
rather than at the FD level.
@AaronBallman and @echristo, if you could take another look, I'd appreciate it.
https://reviews.llvm.org/D38
thakis closed this revision.
thakis added a comment.
r316713, thanks!
https://reviews.llvm.org/D39317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Oct 26 16:26:29 2017
New Revision: 316713
URL: http://llvm.org/viewvc/llvm-project?rev=316713&view=rev
Log:
Use -fuse-init-array if no gcc installation is found.
clang currently uses .init_array instead of .ctors on Linux if it detects gcc
4.7+. Make it so that it also uses
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316712: [X86] Make -march=i686 an alias of -march=pentiumpro
(authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D39349?vs=120503&id=120508#toc
Repository:
rL LLVM
https://revie
chandlerc added a comment.
In https://reviews.llvm.org/D38824#908540, @RKSimon wrote:
> Where is the best place to document this policy so people have a chance of
> understanding it going forward?
Given the (apparent) amount of confusion here, I'd suggest a dedicated document
in Clang's docum
Author: ctopper
Date: Thu Oct 26 16:06:19 2017
New Revision: 316712
URL: http://llvm.org/viewvc/llvm-project?rev=316712&view=rev
Log:
[X86] Make -march=i686 an alias of -march=pentiumpro
I think the only reason they are different is because we don't set tune_i686
for -march=i686 to match GCC. Bu
craig.topper added a comment.
I suspect the gcc behavior changed when this bug was fixed
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59588
https://reviews.llvm.org/D39349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
hfinkel added a comment.
In https://reviews.llvm.org/D39204#905860, @efriedma wrote:
> I think you're understanding the semantics correctly.
>
> For r265521, look again at the implementation of
> llvm::checkUnaryFloatSignature; if "I.onlyReadsMemory()" is true, we somehow
> proved the call does
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, nice.
https://reviews.llvm.org/D39349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
craig.topper created this revision.
I think the only reason they are different is because we don't set
__tune_i686__ for -march=i686 to match GCC. But GCC 4.9.0 seems to have changed
this behavior and they do set it now. So I think they can aliases now.
https://reviews.llvm.org/D39349
Files:
erichkeane added a comment.
Added all of @rsmith's comments here, I believe I have them all and have
properly responded to them.
Comment at: include/clang/AST/ASTContext.h:2115
+ bool hasUniqueObjectRepresentations(QualType Ty) const;
+
//===--
On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner wrote:
> Seems fine, it would be nice if the workflow could be improved a little
> bit so that all you have to do is say `clangdiag break
> —error=“-Wcovered-switch”` or something . I think that gives the most
> intuitive usage for people, even it’s
erichkeane created this revision.
Corrections done for @rsmith 's comments after-commit
on cfe-commits.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/Type.cpp
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/type-t
efriedma added a comment.
I didn't really search for it before, but it looks like LLVM already has a
routine for computing column widths? See llvm::sys::unicode::columnWidthUTF8.
There are some tools which parse clang diagnostic output; we might need a flag
to control this. Not sure who would
On Thu, Oct 26, 2017 at 3:00 PM, Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> Each lldb.SBValue has accessors for the stuff in an execution context:
>
> ``
>
> lldb::SBTarget GetTarget();
> lldb::SBProcess GetProcess();
> lldb::SBThread GetT
clayborg added a comment.
Each lldb.SBValue has accessors for the stuff in an execution context:
``
lldb::SBTarget GetTarget();
lldb::SBProcess GetProcess();
lldb::SBThread GetThread();
lldb::SBFrame GetFrame();
You could keep a global map of process ID to diagtool if you want?
W
Seems fine, it would be nice if the workflow could be improved a little bit
so that all you have to do is say `clangdiag break
—error=“-Wcovered-switch”` or something . I think that gives the most
intuitive usage for people, even it’s a bit harder to implement.
I also think user shouldn’t really h
hfinkel added a comment.
In https://reviews.llvm.org/D39053#906513, @spetrovic wrote:
> Well, basically I'm just expanding the existing algorithm, why should we
> split fields just in case when current field is integer,
> I'm not resolving specific problem with unaligned loads/stores on MIPS.
>
hintonda added a comment.
Is there a way to associate a particular diagtool variable to an exe_ctx?
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 120492.
hintonda added a comment.
- Remove debugging print statement, and enhance help message.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316705: [X86][Driver] Move all of the X86 feature flags to
one spot in the Options.td… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D39341?vs=120468&id=120490#toc
Repository
Author: ctopper
Date: Thu Oct 26 14:28:33 2017
New Revision: 316705
URL: http://llvm.org/viewvc/llvm-project?rev=316705&view=rev
Log:
[X86][Driver] Move all of the X86 feature flags to one spot in the Options.td
file and pair them up with their negations.
It looks like at one time Options.td was
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316704: [CGBlocks] Improve line info in backtraces
containing *_helper_block (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D39310?vs=120461&id=120489#toc
Repository:
rL LLV
Author: vedantk
Date: Thu Oct 26 14:27:24 2017
New Revision: 316704
URL: http://llvm.org/viewvc/llvm-project?rev=316704&view=rev
Log:
[CGBlocks] Improve line info in backtraces containing *_helper_block
Instead of only setting a non-zero debug location on the return
instruction in *_helper_block
RKSimon added a comment.
Where is the best place to document this policy so people have a chance of
understanding it going forward?
https://reviews.llvm.org/D38824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
hfinkel added a comment.
In https://reviews.llvm.org/D38824#908461, @chandlerc wrote:
> So, doing research to understand the impact of this has convinced me we
> *really* need to stop doing this. Multiple libraries are actually trying to
> enumerate every CPU that has feature X for some feature
vsk added a comment.
Thanks!
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
aprantl wrote:
> vsk wrote:
> > aprantl wrote:
> > > aprantl
Nebiroth updated this revision to Diff 120485.
Nebiroth added a comment.
- Fixed adding incorrect test file.
https://reviews.llvm.org/D38639
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/GlobalCompilationDatabase.cpp
clangd/Protocol.h
unittests/clan
Nebiroth updated this revision to Diff 120482.
Nebiroth added a comment.
- Now overriding InclusionDirective as a callback to get proper includes
information.
- Fixed tests.
https://reviews.llvm.org/D38639
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/
chandlerc added a comment.
So, doing research to understand the impact of this has convinced me we
*really* need to stop doing this. Multiple libraries are actually trying to
enumerate every CPU that has feature X for some feature X. =[[[ This, combined
with the fundamental pattern of defining
timshen added a comment.
In https://reviews.llvm.org/D39308#907424, @mclow.lists wrote:
> A couple of notes.
Sorry for the oversights, when a C++11(-only :) contributor doesn't care about
ABI stability, nor exceptions, he contributes naive code. :P I'll fix them.
> - This change means that n
yamaguchi created this revision.
Previously, we passed "#" to --autocomplete to indicate to enable cc1
flags. For example, when -cc1 or -Xclang was passed to bash, bash
executed `clang --autocomplete=#-`.
However, this was not a good implementation because it depends -Xclang
and -cc1 parsing to s
Author: adrian
Date: Thu Oct 26 13:16:03 2017
New Revision: 316695
URL: http://llvm.org/viewvc/llvm-project?rev=316695&view=rev
Log:
Fix C++ testcase I forgot to add to r316689.
Modified:
cfe/trunk/test/CodeGenCXX/blocks.cpp
Modified: cfe/trunk/test/CodeGenCXX/blocks.cpp
URL:
http://llvm.or
danielmarjamaki added a comment.
> Do you mind writing some tests with multidimensional arrays to check what do
> we lose if we remove that code?
I have spent a few hours trying to write a test case that shows there is false
negatives caused by this change. And fail.
I see lots of false negati
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]
rjmccall added a comment.
Sure, that makes sense to me.
John.
Repository:
rL LLVM
https://reviews.llvm.org/D39008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: adrian
Date: Thu Oct 26 13:08:52 2017
New Revision: 316689
URL: http://llvm.org/viewvc/llvm-project?rev=316689&view=rev
Log:
Simplify codegen and debug info generation for block context parameters.
The exisiting code goes out of its way to put block parameters into an
alloca only at -O0,
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D39341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D38774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
craig.topper updated this revision to Diff 120469.
craig.topper added a comment.
Fix Simon's comment
https://reviews.llvm.org/D38824
Files:
lib/Basic/Targets/X86.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-macros.c
===
craig.topper created this revision.
It looks like at one time Options.td was in alphabetical order, but that looks
to have long been broken. The result is that it all the no- x86 options got
separated from their other friends for no good reason.
This patch puts them all together in one place wi
mstorsjo updated this revision to Diff 120467.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Herald added subscribers: JDevlieghere, aprantl.
Adjusted _LIBUNWIND_HIGHEST_DWARF_REGISTER to actually have the value of the
highest register, not highest+1.
https://reviews.l
hintonda added a comment.
In https://reviews.llvm.org/D36347#908186, @zturner wrote:
> Do I understand correctly that this will insert breakpoints on *all* clang
> diagnostics? That's not necessarily bad, but I was under the impression
> originally that it would let you pick the diagnostics yo
Author: george.karpenkov
Date: Thu Oct 26 12:00:22 2017
New Revision: 316687
URL: http://llvm.org/viewvc/llvm-project?rev=316687&view=rev
Log:
[Analyzer] [Tests] Write analyzers crashes to stdout, and not to a separate file
With this change it would be sufficient to look at CI console to see the
arphaman updated this revision to Diff 120466.
arphaman added a comment.
- Use a `RefactoringDescriptor` struct that's accessible from a static function
in an operation class.
- Make `createSourceReplacements` private.
Repository:
rL LLVM
https://reviews.llvm.org/D38985
Files:
include/cla
RKSimon added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:835
defineCPUMacros(Builder, "slm");
+// gcc also defineds 'silvermont', but we never have. See comment below.
break;
defines
https://reviews.llvm.org/D38824
_
clayborg added a comment.
Looks good.
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman marked 5 inline comments as done.
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/Extract/ExtractFunction.h:21
+/// then called from the place where the original code was.
+class ExtractFunction final : public SourceChangeRefactoringRule {
+
vsk added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
aprantl wrote:
> aprantl wrote:
> > vsk wrote:
> > > aprantl wro
vsk updated this revision to Diff 120461.
vsk marked 8 inline comments as done.
vsk added a comment.
- Tighten test case to show the dbg loc on return instructions.
https://reviews.llvm.org/D39310
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/debug-info-blocks.m
Index: test/CodeGenObjC
erichkeane updated this revision to Diff 120460.
https://reviews.llvm.org/D38596
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
include/clang/Sema/Sema.h
lib/Basic/Targets/X86.cpp
lib/Basic/Targ
hintonda updated this revision to Diff 120459.
hintonda added a comment.
- Enhance diagtool option to check, reset, print out current value.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
Author: adrian
Date: Thu Oct 26 11:32:16 2017
New Revision: 316686
URL: http://llvm.org/viewvc/llvm-project?rev=316686&view=rev
Log:
Revert "Simplify codegen and debug info generation for block context
parameters."
This reverts commit r316684 while investigating buildbot breakage.
Added:
cf
efriedma added a comment.
I think you missed a couple other places which still set SizeType and
PtrDiffType?
Repository:
rL LLVM
https://reviews.llvm.org/D39321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316684: Simplify codegen and debug info generation for block
context parameters. (authored by adrian).
Changed prior to commit:
https://reviews.llvm.org/D39305?vs=120312&id=120455#toc
Repository:
rL
Author: adrian
Date: Thu Oct 26 11:16:05 2017
New Revision: 316684
URL: http://llvm.org/viewvc/llvm-project?rev=316684&view=rev
Log:
Simplify codegen and debug info generation for block context parameters.
The exisiting code goes out of its way to put block parameters into an
alloca only at -O0,
aprantl added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
aprantl wrote:
> vsk wrote:
> > aprantl wrote:
> > > What's
erichkeane added a comment.
I note my rebase lost the tests... I'll fix that up soon, sorry guys!
https://reviews.llvm.org/D38596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
vsk wrote:
> aprantl wrote:
> > What's the location used for
hfinkel added a comment.
Quick question: We're talking about a few different variants on this feature
now: Post-inlining instrumentation, only marking function entries, and not
passing the function address. Do you intend to use all of these things
separately? I ask because, taken together, that
aprantl added a comment.
In https://reviews.llvm.org/D39305#908208, @rjmccall wrote:
> The original code doesn't make any sense; it looks like the indirection is
> backwards. We just built a debug variable corresponding to the block
> descriptor pointer parameter, so LocalAddr should be dbg.de
vsk added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:13
-// rdar://problem/14386148
-// Test that we don't emit bogus line numbers for the helper functions.
-// Test that we do emit scope info for the helper functions.
+// rdar://problem/32907581
+// Test
Author: ctopper
Date: Thu Oct 26 10:54:22 2017
New Revision: 316681
URL: http://llvm.org/viewvc/llvm-project?rev=316681&view=rev
Log:
[X86] Add a target attribute test for no-sse4.
Modified:
cfe/trunk/test/CodeGen/attr-target-x86.c
Modified: cfe/trunk/test/CodeGen/attr-target-x86.c
URL:
htt
clayborg accepted this revision.
clayborg added inline comments.
Comment at: utils/clangdiag.py:117
+disable(exe_ctx)
+else:
+getDiagtool(exe_ctx.GetTarget(), args.path[0])
hintonda wrote:
> clayborg wrote:
> > should probably verify that this
rjmccall added a comment.
The original code doesn't make any sense; it looks like the indirection is
backwards. We just built a debug variable corresponding to the block
descriptor pointer parameter, so LocalAddr should be dbg.declare'd to be that
variable and Arg should be dbg.value'd. It lo
zturner added a comment.
Do I understand correctly that this will insert breakpoints on *all* clang
diagnostics? That's not necessarily bad, but I was under the impression
originally that it would let you pick the diagnostics you wanted to insert
breakpoints on.
Also, What is the workflow for
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D37341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
hintonda added a comment.
Thanks for the feedback (addressed below).
btw, where should this module go?
Since it's intended for clang, and clang based tool, developers, I put it in
`clang/utils`, but Zackery suggested `lldb/examples/python` might be a better
place. Please let me know if anyone
Author: rnk
Date: Thu Oct 26 10:07:48 2017
New Revision: 316674
URL: http://llvm.org/viewvc/llvm-project?rev=316674&view=rev
Log:
Move MS inline asm parser methods out of line to reduce indentation, NFC
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close. Thanks for making the changes. Just a few nits.
Comment at: utils/clangdiag.py:66
+def setDiagBreakpoint(frame, bp_loc, dict):
+id = frame.FindV
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I don't think working around an lld bug is a particularly good justification
for this, but I do think it makes sense to switch this from being a
"compatibility with GCC 4.7+" thing to being a
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D38819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks for the review Richard. Would you like me to revert, or can I just make
these changes in a new patch?
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Thursday, October 26, 2017 9:50 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r316518 - mplement __has_unique_object_represe
On 24 Oct 2017 14:32, "Erich Keane via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erichkeane
Date: Tue Oct 24 14:31:50 2017
New Revision: 316518
URL: http://llvm.org/viewvc/llvm-project?rev=316518&view=rev
Log:
mplement __has_unique_object_representations
A helper builtin to facil
I don't know of one. ruiu said he's considering making lld error out on
mixed init_array + ctors instead of having it silently do the same thing.
On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
cfe-commits wrote:
> smeenai added a comment.
>
> > And lld currently silently mis
*the wrong thing
On Thu, Oct 26, 2017 at 12:43 PM, Nico Weber wrote:
> I don't know of one. ruiu said he's considering making lld error out on
> mixed init_array + ctors instead of having it silently do the same thing.
>
> On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
> cfe
1 - 100 of 154 matches
Mail list logo
